yahoo-group-data 1.1.0 → 1.1.1

data/lib/yahoo-group-data.rb

@@ -14,6 +14,7 @@ class YahooGroupData
 		curb.follow_location = true
 		curb.http_get
 		@html = curb.body_str.force_encoding('iso-8859-1').encode("UTF-8")
+		@response_code = curb.response_code
 	end
 
 	def name
@@ -53,7 +54,7 @@ class YahooGroupData
 	end
 
 	def not_found?
-		@not_found ||= (
+		@not_found ||= (response_was_404? ||
 			(
 				doc.xpath('/html/body/div[3]/div/div/div/h3').size > 0 and
 				doc.xpath('/html/body/div[3]/div/div/div/h3').first.content.strip.match(/Group Not Found|Group nicht gefunden/i)
@@ -112,6 +113,12 @@ class YahooGroupData
 
 	private
 
+	attr_reader :response_code
+
+	def response_was_404?
+		response_code == 404
+	end
+
 	def matches_private?
 		@matches_private ||= (
 			doc.xpath('/html/body/div[3]/center/p/big').size > 0 and

data/lib/yahoo-group-data/version.rb

@@ -1,3 +1,3 @@
 class YahooGroupData
-	VERSION = "1.1.0"
+	VERSION = "1.1.1"
 end

data/test/test_yahoo_group_data.rb

@@ -93,4 +93,27 @@ class YahooGroupDataTest < Test::Unit::TestCase
 			assert_equal g_data["category"], group.category
 		end
 	end
-end
+
+	def test_404
+		missing_url = "http://tech.groups.yahoo.com/group/OneStopCOBOL/asdasd"
+		stub_request(:get, missing_url).
+			to_return(:status => 404, :body => "", :headers => {})
+			group = YahooGroupData.new(missing_url)
+			
+			assert_nil group.age_restricted?
+			assert_nil group.private?
+			assert_nil group.name
+			assert_nil group.description
+			assert_nil group.post_email
+			assert_nil group.subscribe_email
+			assert_nil group.owner_email
+			assert_nil group.unsubscribe_email
+			assert_nil group.founded
+			assert_nil group.language
+			assert_nil group.num_members
+			assert_nil group.category
+
+			assert group.not_found?
+			assert group.no_data?
+	end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yahoo-group-data
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-03 00:00:00.000000000 Z
+date: 2012-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70321718153700 !ruby/object:Gem::Requirement
+  requirement: &70212330858720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '1.5'
   type: :runtime
   prerelease: false
-  version_requirements: *70321718153700
+  version_requirements: *70212330858720
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70321718153000 !ruby/object:Gem::Requirement
+  requirement: &70212330858040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '1.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70321718153000
+  version_requirements: *70212330858040
 - !ruby/object:Gem::Dependency
   name: curb
-  requirement: &70321718151980 !ruby/object:Gem::Requirement
+  requirement: &70212330856980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '0.8'
   type: :runtime
   prerelease: false
-  version_requirements: *70321718151980
+  version_requirements: *70212330856980
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70321718151560 !ruby/object:Gem::Requirement
+  requirement: &70212330856580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70321718151560
+  version_requirements: *70212330856580
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70321718151060 !ruby/object:Gem::Requirement
+  requirement: &70212330856100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70321718151060
+  version_requirements: *70212330856100
 description: A lib to fetch public Yahoo group data
 email:
 - will@willj.net