yabeda-resque 1.1.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc64c43baf725df7a5f4691a877bf32907d1b2416bdd6835dbe1c43f002d7a01
-  data.tar.gz: e72afe1ba6efb66cca854f9f093a230e434450afcfa87c230eeee9aba29a046f
+  metadata.gz: f8679f70e3f362a27c2e217852e5e2ca48718ba66cf4bdf929d57252dfb56726
+  data.tar.gz: ce6340bbc3f60d3c20bd6dc23fe09ff43efe44bf71bede21112d6a41905f45d3
 SHA512:
-  metadata.gz: 3acc9b46978e547bf10fbee16bdc0cd5053d9d8bbe710e0c7353ab79a0cfd577eed7547e0e05a6aee9e78040ac85c46fed4fbb4cfca8160e490de1c1d4fece9f
-  data.tar.gz: 85e7422c3cd1ecc4835de4ae1c5ff3438fac117ab22ad873242ee962e8ff42296aacf41ee186c4344e549c1842c4741f15c7e20b1ccb6197f66e261ca0da4423
+  metadata.gz: a38fd70482feffcab13f959625a426424f8b79e45cbdd7ceb2bf78b4d3df567f7ea31dd5c6b9339051cea10b0c53f9f9eaf2ca96f2457feee51a359ef8c63a65
+  data.tar.gz: 70629efcd1073097faee26feb96eb486a6baed2ebae5e41ac3716d2d67ea750abff78632e7f3c1f28f6d8b65d9e401f0dd25522095ea8259ce232c2c011aa32d

data/CHANGELOG.md

@@ -1,14 +1,19 @@
 ## [Unreleased]
 
-## [1.1.0] - 2025-02-4
+## [1.3.0] - 2026-05-11
+- Improve Performance of delayed job counting (#1, by @top-sigrid)
+
+## [1.2.0] - 2025-05-16
+- Add jobs_processing_oldest_age metric with unit as config option
+
+## [1.1.0] - 2025-02-14
 - Fix: queue_sizes metric not being exported
 
-## [1.0.0] - 2025-02-4
+## [1.0.0] - 2025-02-14
 - Add queue_size metric
 - Add jobs_delayed metric for resque-scheduler
 
 ## [0.1.0] - 2025-02-13
-
 - Add jobs_pending metric
 - Add jobs_processed metric
 - Add jobs_failed metric

data/README.md

@@ -22,16 +22,24 @@ Add the following code to your existing Yabeda setup:
 Yabeda::Resque.install!
 ```
 
+## Configuration
+
+Configuration can be passed to the `Yabeda::Resque.install!` method, e.g.: `Yabeda::Resque.install!(option_name: :value)` The following options are available:
+
+* `jobs_processing_oldest_age_unit`:
+    The unit of the `jobs_processing_oldest_age` metric. This can be set to `:seconds`, `:minutes`, `:hours` or `:days`. The default value is nil, which means the metric is turned off and will not collected.
+
 ## Provided metrics
 
-| Metric name       | Type  | Tags         | Description                         |
-|-------------------|-------|--------------|-------------------------------------|
-| `jobs_pending`    | gauge | none         | Number of jobs in all queues        |
-| `jobs_processed`  | gauge | none         | Number of jobs processed            |
-| `jobs_failed`     | gauge | none         | Number of jobs currently failed     |
-| `workers_total`   | gauge | none         | Number of workers                   |
-| `workers_working` | gauge | none         | Number of workers currently working |
-| `queue_sizes`     | gauge | queue (name) | Number of jobs in a specific queue  |
+| Metric name       | Type  | Tags     | Description                                          |
+|-------------------|-------|----------|------------------------------------------------------|
+| `jobs_pending`    | gauge | none     | Number of jobs in all queues                         |
+| `jobs_processed`  | gauge | none     | Number of jobs processed                             |
+| `jobs_failed`     | gauge | none     | Number of jobs currently failed                      |
+| `workers_total`   | gauge | none     | Number of workers                                    |
+| `workers_working` | gauge | none     | Number of workers currently working                  |
+| `queue_sizes`     | gauge | queue (name) | Number of jobs in a specific queue                   |
+| `jobs_processing_oldest_age`     | gauge | none     | Age of the oldest processing job (unit configurable) |
 
 Yabeda::Resque detects if [resque-scheduler](https://github.com/resque/resque-scheduler) is being used and adds the following metrics:
 
@@ -46,7 +54,7 @@ included in the `queue_sizes` metric. Gathering this information can be quite ex
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, commit it, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/lib/yabeda/resque/version.rb

@@ -2,6 +2,6 @@
 
 module Yabeda
   module Resque
-    VERSION = "1.1.0"
+    VERSION = "1.3.0"
   end
 end

data/lib/yabeda/resque.rb

@@ -8,11 +8,52 @@ require "resque"
 module Yabeda
   module Resque
     class << self
+      DEFAULT_CONFIG = {
+        jobs_processing_oldest_age_unit: nil
+      }.freeze
+
       def monitor_delayed?
         defined?(::Resque::Scheduler)
       end
 
-      def install!
+      # Pipelined alternative to Resque.count_all_scheduled_jobs from resque-scheduler.
+      # The original implementation issues a sequential LLEN call per timestamp, resulting in N round-trips to Redis.
+      # This version pipelines LLEN calls in batches to avoid blocking the Redis thread for too long,
+      # which is significantly faster when there are many delayed timestamps.
+      def count_all_scheduled_jobs_pipelined
+        timestamps = ::Resque.redis.zrange(:delayed_queue_schedule, 0, -1)
+        return 0 if timestamps.empty?
+
+        timestamps.each_slice(10_000).sum do |batch|
+          ::Resque.redis.pipelined do |pipeline|
+            batch.each { |ts| pipeline.llen("delayed:#{ts}") }
+          end.sum
+        end
+      end
+
+      def jobs_processing_oldest_age(config)
+        oldest_timestamp = ::Resque.working.map { |worker| worker.job(false)["run_at"] }.min
+        return 0 if oldest_timestamp.nil?
+        age_in_seconds = (Time.now - Time.parse(oldest_timestamp)).to_i
+        return 0 if age_in_seconds < 0
+
+        case config[:jobs_processing_oldest_age_unit]
+        when :seconds
+          age_in_seconds
+        when :minutes
+          age_in_seconds / 60.0
+        when :hours
+          age_in_seconds / 3600.0
+        when :days
+          age_in_seconds / 86_400.0
+        else
+          raise ArgumentError, "Unsupported time unit: #{unit.inspect}"
+        end
+      end
+
+      def install!(**config)
+        config = DEFAULT_CONFIG.merge(config)
+
         Yabeda.configure do
           group :resque do
             default_options = {aggregation: :most_recent}
@@ -20,6 +61,10 @@ module Yabeda
             gauge :jobs_processed, **default_options, comment: "Number of processed jobs"
             gauge :jobs_failed, **default_options, comment: "Number of failed jobs"
 
+            if config[:jobs_processing_oldest_age_unit]
+              gauge :jobs_processing_oldest_age, **default_options, comment: "How long the longest processing job has been running in #{config[:jobs_processing_oldest_age_unit]}"
+            end
+
             gauge :queue_sizes, tags: %i[queue], **default_options, comment: "Number of jobs in a specific queue"
 
             gauge :workers_total, **default_options, comment: "Number of workers"
@@ -37,8 +82,13 @@ module Yabeda
             resque.jobs_pending.set({}, resque_info[:pending])
             resque.jobs_processed.set({}, resque_info[:processed])
 
+            if config[:jobs_processing_oldest_age_unit]
+              value = ::Yabeda::Resque.jobs_processing_oldest_age(config)
+              resque.jobs_processing_oldest_age.set({}, value)
+            end
+
             if ::Yabeda::Resque.monitor_delayed?
-              resque.jobs_delayed.set({}, ::Resque.count_all_scheduled_jobs)
+              resque.jobs_delayed.set({}, ::Yabeda::Resque.count_all_scheduled_jobs_pipelined)
             end
 
             ::Resque.queue_sizes.each do |queue, size|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yabeda-resque
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Josch Bockler
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-02-14 00:00:00.000000000 Z
+date: 2026-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Yabeda plugin to collect basic metrics for Resque backend jobs