yabeda-rack-queue 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21cab04c6429f2f935c1f25dd635a57bef7b6f619775a06ee15c678cad907bc8
-  data.tar.gz: 2b0aedeb8ab33fe5c2380942c71221b64a743c2eb7999ba2ecd153ca4703820f
+  metadata.gz: a2460b8b476ceba45cccd0edd32320f133780bc01681d08bcf5fb162b7dd0cf4
+  data.tar.gz: 3b69c898a813804c2f8194fa9e5a84cf1508c1d3df2eb52096683e1b4612d09d
 SHA512:
-  metadata.gz: 177604e2d5e1fc330c66a074dcae18c33ed42a49afca78755e91f75675b67b04451e1d27813ec3040375f2040e221a1aa20e8348b2b17e3e9e8d70cc71b12acc
-  data.tar.gz: 6a90ef452a54f42dd2e916ca6ef528b24cbe97993bc2dc6f0d19f767aeb1fc54bf942c37a82017d559656c57035c85ca6929107d91898f7759a3a67d6e6b9650
+  metadata.gz: 7b34b7083e9afb7c53825d8fd2645d74d36f4b6e9551885546de59f19d836199eb9cf3abc2a4a504d9844a52b468d157c1e6c1a3b7c1df62436b2286b1199271
+  data.tar.gz: c82d59eb210d12595a0c53a4330d004d0d7d4667fdb71101d0b2c2e4a017bc78b77f91ed312ceb6fae8bc68d2d28fb3ee6c7c761eb5020ffbedfc937af6b9788

data/CHANGELOG.md

@@ -0,0 +1,22 @@
+# Changelog
+
+## 0.2.1 - 2026-06-29
+
+### Fixed
+
+- Keep requests flowing if rack queue metric reporting fails, logging the error instead.
+- Load `yabeda/railtie` when Rails appears after Yabeda was already required.
+
+## 0.2.0 - 2026-03-09
+
+### Changed
+
+- Renamed the histogram metric from `rack_queue_duration` to `duration` inside the `rack_queue` group.
+- The Yabeda accessor is now `Yabeda.rack_queue.duration`.
+- Adapters that prepend the group name, such as Prometheus, now expose the metric as `rack_queue_duration_seconds` instead of `rack_queue_rack_queue_duration_seconds`.
+
+## 0.1.0 - 2026-03-08
+
+### Added
+
+- Initial release.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yabeda-rack-queue (0.1.0)
+    yabeda-rack-queue (0.2.1)
       yabeda (>= 0.14, < 1.0)
 
 GEM
@@ -114,7 +114,7 @@ CHECKSUMS
   unicode-display_width (3.2.0) sha256=0cdd96b5681a5949cdbc2c55e7b420facae74c4aaf9a9815eee1087cb1853c42
   unicode-emoji (4.2.0) sha256=519e69150f75652e40bf736106cfbc8f0f73aa3fb6a65afe62fefa7f80b0f80f
   yabeda (0.14.0) sha256=bc517bf22d692ebd80a29fc9fd2246c257aaf92d10b2735a775e2419351a43bf
-  yabeda-rack-queue (0.1.0)
+  yabeda-rack-queue (0.2.1)
 
 BUNDLED WITH
   4.0.3

data/README.md

@@ -12,7 +12,7 @@ High queue time means your app is too busy. It cannot take new requests. That is
 
 Load balancers can add a header to each request. The header records when the request arrived. Common headers are `X-Request-Start` and `X-Queue-Start`.
 
-This middleware reads that header. It subtracts the header's timestamp from the current time. Then it reports that value as `rack_queue.rack_queue_duration`.
+This middleware reads that header. It subtracts the header's timestamp from the current time. Then it reports that value as `rack_queue.duration`.
 
 > [!NOTE]
 > If neither header is present, no measurement is taken. The request passes through unchanged.
@@ -55,14 +55,16 @@ config.middleware.use Yabeda::Rack::Queue::Middleware
 
 | Name | Group | Type | Unit |
 |------|-------|------|------|
-| `rack_queue_duration` | `rack_queue` | histogram | seconds |
+| `duration` | `rack_queue` | histogram | seconds |
 
 Access it in code:
 
 ```ruby
-Yabeda.rack_queue.rack_queue_duration
+Yabeda.rack_queue.duration
 ```
 
+With adapters that prepend the group name, such as Prometheus, this becomes `rack_queue_duration_seconds`.
+
 Histogram buckets: 1 ms, 5 ms, 10 ms, 25 ms, 50 ms, 100 ms, 250 ms, 500 ms, 1 s, 2.5 s, 5 s, 10 s, 30 s, 60 s.
 
 ## Header formats
@@ -93,7 +95,6 @@ The middleware accepts these keyword arguments:
 | Argument | Default | Purpose |
 |----------|---------|---------|
 | `reporter:` | `YabedaReporter.new` | Writes the value to Yabeda. |
-| `parser:` | `HeaderTimestampParser.new` | Parses the header timestamp. |
 | `logger:` | stderr | Gets warning messages. |
 | `clock:` | `Process.clock_gettime(CLOCK_REALTIME)` | Returns current time in seconds. |
 

data/SPEC.md

@@ -21,7 +21,7 @@ Linting uses standardrb.
 
 | Name | Type | Group | Unit | Description |
 |------|------|-------|------|-------------|
-| `rack_queue_duration` | histogram | `rack_queue` | seconds | Time a request waited in the upstream queue before reaching the application |
+| `duration` | histogram | `rack_queue` | seconds | Time a request waited in the upstream queue before reaching the application |
 
 ### Histogram Buckets
 

data/lib/yabeda/rack/queue/metric.rb

@@ -2,9 +2,13 @@
 
 require "yabeda"
 
+# Yabeda only loads its Railtie if Rails exists when Yabeda is first required.
+# Puma plugins can require Yabeda before Rails, so retry when this gem loads.
+require "yabeda/railtie" if defined?(::Rails::Railtie)
+
 Yabeda.configure do
   group :rack_queue do
-    histogram :rack_queue_duration,
+    histogram :duration,
       comment: "Time a request waited in the upstream queue before reaching the application",
       unit: :seconds,
       buckets: [0.001, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10, 30, 60]

data/lib/yabeda/rack/queue/middleware.rb

@@ -9,7 +9,7 @@ module Yabeda
         end
 
         class YabedaReporter
-          def observe(value) = Yabeda.rack_queue.rack_queue_duration.measure({}, value)
+          def observe(value) = Yabeda.rack_queue.duration.measure({}, value)
         end
 
         def initialize(app, reporter: YabedaReporter.new, logger: nil, clock: nil)
@@ -32,6 +32,8 @@ module Yabeda
           start = @parser.parse(env["HTTP_X_REQUEST_START"], now: now) ||
             @parser.parse(env["HTTP_X_QUEUE_START"], now: now)
           report_queue_time(env, now, start) if start
+        rescue => error
+          @logger.warn("rack queue metric failed: #{error.class}: #{error.message}")
         end
 
         def report_queue_time(env, now, request_start)

data/lib/yabeda/rack/queue/version.rb

@@ -3,7 +3,7 @@
 module Yabeda
   module Rack
     module Queue
-      VERSION = "0.1.0"
+      VERSION = "0.2.1"
     end
   end
 end

data/test/e2e/puma_integration_test.rb

@@ -55,7 +55,7 @@ class PumaIntegrationTest < Minitest::Test
     super
   end
 
-  def test_records_rack_queue_duration_histogram_via_yabeda_on_real_http_request
+  def test_records_duration_histogram_via_yabeda_on_real_http_request
     requested_queue_time_seconds = 0.12
     request_start_ms = ((Time.now.to_f - requested_queue_time_seconds) * 1_000).to_i
     uri = URI("http://127.0.0.1:#{@server.port}/")
@@ -66,7 +66,7 @@ class PumaIntegrationTest < Minitest::Test
 
     assert_equal "200", response.code
 
-    metric = Yabeda.rack_queue.rack_queue_duration
+    metric = Yabeda.rack_queue.duration
     measured = Yabeda::TestAdapter.instance.histograms.fetch(metric).fetch({})
 
     assert_kind_of Float, measured

data/test/yabeda/rack/queue/metric_test.rb

@@ -3,10 +3,11 @@
 require "test_helper"
 
 class MetricTest < Minitest::Test
-  def test_registers_rack_queue_duration_histogram_with_required_metadata
-    metric = Yabeda.rack_queue.rack_queue_duration
+  def test_registers_duration_histogram_with_required_metadata
+    metric = Yabeda.rack_queue.duration
 
     assert_instance_of Yabeda::Histogram, metric
+    assert_equal :duration, metric.name
     assert_equal :rack_queue, metric.group
     assert_equal :seconds, metric.unit
     assert_equal "Time a request waited in the upstream queue before reaching the application", metric.comment

data/test/yabeda/rack/queue/middleware_test.rb

@@ -14,6 +14,12 @@ class CapturingReporter
   end
 end
 
+class FailingReporter
+  def observe(_value)
+    raise NoMethodError, "undefined method `rack_queue' for Yabeda:Module"
+  end
+end
+
 class CapturingLogger
   attr_reader :warnings
 
@@ -144,6 +150,21 @@ class MiddlewareTest < Minitest::Test
     assert_empty @reporter.values
   end
 
+  def test_metric_reporting_errors_are_logged_and_do_not_break_request
+    middleware = Yabeda::Rack::Queue::Middleware.new(
+      @app,
+      reporter: FailingReporter.new,
+      clock: @clock,
+      logger: @logger
+    )
+
+    result = middleware.call("HTTP_X_REQUEST_START" => "t=1699999999.9")
+
+    assert_same @response, result
+    assert_equal 1, @app.called_count
+    assert_includes @logger.warnings.join("\n"), "rack queue metric failed: NoMethodError"
+  end
+
   def test_drops_negative_queue_times_and_logs_warning
     @middleware.call("HTTP_X_REQUEST_START" => "t=1700000000.1")
 

data/test/yabeda/rack/queue/railtie_test.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "open3"
+require "rbconfig"
+
+class RailtieTest < Minitest::Test
+  def test_loads_yabeda_railtie_when_rails_appears_after_yabeda
+    script = <<~RUBY
+      require "bundler/setup"
+      require "yabeda"
+
+      module Rails
+        class Railtie
+          def self.config
+            @config ||= Config.new
+          end
+
+          class Config
+            def after_initialize
+            end
+          end
+        end
+      end
+
+      require "yabeda/rack/queue"
+
+      abort "Yabeda::Rails::Railtie was not loaded" unless defined?(Yabeda::Rails::Railtie)
+    RUBY
+
+    stdout, stderr, status = Open3.capture3("bundle", "exec", RbConfig.ruby, "-Ilib", "-e", script)
+
+    assert status.success?, [stdout, stderr].join("\n")
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yabeda-rack-queue
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Nate Berkopec
@@ -147,6 +147,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -166,6 +167,7 @@ files:
 - test/yabeda/rack/queue/metric_test.rb
 - test/yabeda/rack/queue/middleware_performance_test.rb
 - test/yabeda/rack/queue/middleware_test.rb
+- test/yabeda/rack/queue/railtie_test.rb
 - yabeda-rack-queue.gemspec
 homepage: https://github.com/speedshop/yabeda-rack-queue
 licenses:
@@ -190,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Yabeda middleware for HTTP request queue duration
 test_files: []