yabeda-latency 0.1.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7129185f3b35549c6d47c870f34f802b761d1c50d69576d4cbe7741f03681408
-  data.tar.gz: 351cc540bfd2dd6b9e154f7e59f6bcd9ce44990c041475426f6dded4c86a3725
+  metadata.gz: 46a9033d5d31b43832cbe2a31fb0c9cb7ecc902ad3491b395bfdcdc5236992f1
+  data.tar.gz: cf505472b9c141f73b2a62f37e212e22574ece21878c9645fdf48a0fdb8ee436
 SHA512:
-  metadata.gz: 7769f03056bf2172b72168908ce4399eeac3d41d97fc0b744a8a3d9ea9184f61f0cdd7ec22bfc80e7c405f731684e5aa8d7b589d91e2a1d4e53c1b933cf8c575
-  data.tar.gz: 8cfdfd3687096f837d7f49d9f8cedee8e91c2d36fe8bc50d50fde3b29f72c1ae67efff8dfece3596aac3b30ac7ad24b05dc304391b1dc7b75a4901d1d1942ff9
+  metadata.gz: 9f7c53fda1382f3e19cd9f9d4680e6686759e399bec66a5135f6434593df6894a5ddd54b4a20b49bff16fa18830e30e31a4a73f3f8efc9ba4daf1529fa34e318
+  data.tar.gz: 92e3d71a789e64944846d9ae217fd1891c7f5c888e0ccc63c13b18d936dc9013eda3f795ae8bca61dcf1d9d4c8bf0c2215ad452cee3b77900d8850b646f73a5c

data/lib/yabeda/latency/collector.rb

@@ -2,7 +2,7 @@
 
 module Yabeda
   module Latency
-    LATENCY_BUCKETS = [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10].freeze
+    LATENCY_BUCKETS = [0.0025, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5].freeze
     EMPTY_HASH = {}.freeze
     REQUEST_START_HEADER = 'HTTP_X_REQUEST_START'
 
@@ -14,14 +14,17 @@ module Yabeda
     class Collector
       attr_reader :app, :registry
 
-      def initialize(app, metrics_prefix: :http_server)
+      def initialize(app, metrics_prefix: :http_server, debug: false)
         @app = app
         @metrics_prefix = metrics_prefix
+        @debug = debug
 
         init_request_metrics
       end
 
       def call(env) # :nodoc:
+        return @app.call(env) if env['rack.warming_up']
+
         now = Time.now
         observe(env, now)
         @app.call(env)
@@ -32,8 +35,8 @@ module Yabeda
       def observe(env, now)
         latency_seconds = calculate_latency_seconds(env, now)
         measure(latency_seconds) unless latency_seconds.nil?
-      rescue StandardError
-        # ok
+      rescue StandardError => e
+        warn "Could not observe latency (#{e.message})" if @debug
       end
 
       # rubocop:disable Metrics/MethodLength
@@ -43,7 +46,7 @@ module Yabeda
         Yabeda.configure do
           group prefix do
             histogram(
-              :request_latency_seconds,
+              :request_latency,
               comment: 'The time for the HTTP request to reach Rack application',
               unit: :seconds,
               per: :field,
@@ -56,7 +59,7 @@ module Yabeda
       # rubocop:enable Metrics/MethodLength
 
       def metric
-        @metric ||= Yabeda.__send__(@metrics_prefix).request_latency_seconds
+        @metric ||= Yabeda.__send__(@metrics_prefix).request_latency
       end
 
       def measure(latency_seconds)
@@ -67,11 +70,13 @@ module Yabeda
 
       def calculate_latency_seconds(env, now)
         raw_header_value = env[REQUEST_START_HEADER]
-        request_start_timestamp_ms = extract_timestamp_from_header_value(raw_header_value)
+        request_start_timestamp_s = extract_timestamp_from_header_value(raw_header_value)
+
+        puts "X-Request-Start: #{raw_header_value}, Now: #{now.to_f}" if @debug
 
-        return unless request_start_timestamp_ms
+        return unless request_start_timestamp_s
 
-        now.to_f - (request_start_timestamp_ms / 1000)
+        now.to_f - request_start_timestamp_s
       end
 
       def extract_timestamp_from_header_value(value)
@@ -86,7 +91,7 @@ module Yabeda
 
         return unless str
 
-        str.to_i
+        str.to_f
       end
     end
   end

data/lib/yabeda/latency/version.rb

@@ -2,6 +2,6 @@
 
 module Yabeda
   module Latency
-    VERSION = '0.1.2'
+    VERSION = '1.0.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yabeda-latency
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Ian Ker-Seymer
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-12 00:00:00.000000000 Z
+date: 2021-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yabeda
@@ -67,7 +67,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key:
 specification_version: 4
 summary: Collects metrics to monitor latency of HTTP requests