yabeda-latency 0.1.1 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8208b03d0db33e5175d7937a429a432a468f7c6485589b5251978743dc73948d
-  data.tar.gz: f79c2d9904a8c1834b8d206b1af0fdde1dc9604cd9df541e2d59dc614a10114e
+  metadata.gz: 17004f75788a8617c66c902ac6960642f6602c6b86c1669bc5d60977144fefaf
+  data.tar.gz: 86d188ae431880ef8c669513c24ae4ca2b468901fa5ea8af349b66c1b5bbba76
 SHA512:
-  metadata.gz: e8690d781117bfaf3083d51a3d435077f75ed87263760dd73a9fd2bdddb1549f14fc9692e544744339c48a4b37fb359a1555b18764208758c0efd0e355005ee9
-  data.tar.gz: de420dbbc06356d8b44b50e361fb5e0f2e4b14dc7e69f26a1ab1e0b4f5a803bdc7b63ec509c0c9d345679564bbc73da21df6e26c915b5c3b2c52f980d83cb26c
+  metadata.gz: 9effa468a27201895c214a411e9ce27e9886d7b7381784cf695a9a1d429d1dbb1d70e8a287dce39c218acfb7c35a81a253bcb7b2f0bcd8642160948603edc7b3
+  data.tar.gz: 874332278744061281ec5206f710eec5884998c1fa4e262b929f938fab47255296db0fa6944f41010335fc735dccab741d2db79ef1d498abd75a488e6f5e3aac

data/.gitignore

@@ -9,3 +9,4 @@
 
 # rspec failure tracking
 .rspec_status
+Gemfile.lock

data/lib/yabeda/latency/collector.rb

@@ -2,7 +2,7 @@
 
 module Yabeda
   module Latency
-    LATENCY_BUCKETS = [0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10].freeze
+    LATENCY_BUCKETS = [0.0025, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5].freeze
     EMPTY_HASH = {}.freeze
     REQUEST_START_HEADER = 'HTTP_X_REQUEST_START'
 
@@ -14,23 +14,29 @@ module Yabeda
     class Collector
       attr_reader :app, :registry
 
-      def initialize(app, metrics_prefix: :http_server)
+      def initialize(app, metrics_prefix: :http_server, debug: false)
         @app = app
         @metrics_prefix = metrics_prefix
+        @debug = debug
 
         init_request_metrics
       end
 
       def call(env) # :nodoc:
         now = Time.now
-        latency_seconds = calculate_latency_seconds(env, now)
-        measure(latency_seconds) unless latency_seconds.nil?
-      ensure
+        observe(env, now)
         @app.call(env)
       end
 
       protected
 
+      def observe(env, now)
+        latency_seconds = calculate_latency_seconds(env, now)
+        measure(latency_seconds) unless latency_seconds.nil?
+      rescue StandardError => e
+        warn "Could not observe latency (#{e.message})" if @debug
+      end
+
       # rubocop:disable Metrics/MethodLength
       def init_request_metrics
         prefix = @metrics_prefix
@@ -38,7 +44,7 @@ module Yabeda
         Yabeda.configure do
           group prefix do
             histogram(
-              :request_latency_seconds,
+              :request_latency,
               comment: 'The time for the HTTP request to reach Rack application',
               unit: :seconds,
               per: :field,
@@ -51,7 +57,7 @@ module Yabeda
       # rubocop:enable Metrics/MethodLength
 
       def metric
-        @metric ||= Yabeda.__send__(@metrics_prefix).request_latency_seconds
+        @metric ||= Yabeda.__send__(@metrics_prefix).request_latency
       end
 
       def measure(latency_seconds)
@@ -62,11 +68,13 @@ module Yabeda
 
       def calculate_latency_seconds(env, now)
         raw_header_value = env[REQUEST_START_HEADER]
-        request_start_timestamp_ms = extract_timestamp_from_header_value(raw_header_value)
+        request_start_timestamp_s = extract_timestamp_from_header_value(raw_header_value)
+
+        puts "X-Request-Start: #{raw_header_value}, Now: #{now.to_f}" if @debug
 
-        return unless request_start_timestamp_ms
+        return unless request_start_timestamp_s
 
-        now.to_f - (request_start_timestamp_ms / 1000)
+        now.to_f - request_start_timestamp_s
       end
 
       def extract_timestamp_from_header_value(value)
@@ -81,7 +89,7 @@ module Yabeda
 
         return unless str
 
-        str.to_i
+        str.to_f
       end
     end
   end

data/lib/yabeda/latency/version.rb

@@ -2,6 +2,6 @@
 
 module Yabeda
   module Latency
-    VERSION = '0.1.1'
+    VERSION = '0.1.6'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yabeda-latency
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.6
 platform: ruby
 authors:
 - Ian Ker-Seymer
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-12 00:00:00.000000000 Z
+date: 2021-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yabeda
@@ -38,7 +38,6 @@ files:
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile

data/Gemfile.lock

@@ -1,68 +0,0 @@
-PATH
-  remote: .
-  specs:
-    yabeda-latency (0.1.1)
-      yabeda (~> 0.2)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    ast (2.4.2)
-    coderay (1.1.3)
-    concurrent-ruby (1.1.8)
-    diff-lcs (1.4.4)
-    dry-initializer (3.0.3)
-    method_source (1.0.0)
-    parallel (1.20.1)
-    parser (3.0.0.0)
-      ast (~> 2.4.1)
-    pry (0.13.1)
-      coderay (~> 1.1)
-      method_source (~> 1.0)
-    rainbow (3.0.0)
-    rake (12.3.3)
-    regexp_parser (2.0.3)
-    rexml (3.2.4)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.1)
-    rubocop (1.9.1)
-      parallel (~> 1.10)
-      parser (>= 3.0.0.0)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
-    ruby-progressbar (1.11.0)
-    unicode-display_width (2.0.0)
-    yabeda (0.7.0)
-      concurrent-ruby
-      dry-initializer
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  pry
-  rake (~> 12.0)
-  rspec (~> 3.0)
-  rubocop
-  yabeda
-  yabeda-latency!
-
-BUNDLED WITH
-   2.1.1