yabeda-hotcell 1.0.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13da0c8b82abc4ab6de8f7f414c7ed7d2824ca1786756d154b41392f5b679c62
-  data.tar.gz: 9358d4158f3278723029974bd87527a3a458ac8ec31f8b046f9ea0e55f45fb26
+  metadata.gz: '08e37bf27a67e99b44e883564b88243aaf6d37acc6fae614a917a118c88dbc9e'
+  data.tar.gz: 635a1704ac76d9e59005da3457ab42347e34f2ee1ea5877f4c73ff5805510c29
 SHA512:
-  metadata.gz: f941a9b9c570ac6ac9741eec3d59405afa9cbd07df29c695e440fc41bba37258fd929180d30e82d5a174b2be7bd5b3d12001f1bd7b2a361908531d8d39e92b9d
-  data.tar.gz: b8b45065d3357bb52e0588d105149792333c319ee3e460b3192f498693dc8993997b496474e030d2e616cf732de344f82178f05a4d98e4fc9aa5b2213379e214
+  metadata.gz: 45edbd08373a6ad31d2c943f462f80030a566cb16f88e87297df1f52ce83c19e22819b692b7aa026174e1e1ec1f06ef2f7aa413a35a968302e1aaa663fe7fd4f
+  data.tar.gz: 410bbadf75e14d945fb8d2bb5d34bff87d8ac54c45b1337aab6badbf6254347ed0c260a9cb6a6cbd3ddc519ead8b1e9991e36d3f7c3e65ae94d9ded718e44c98

data/README.md

@@ -1,3 +1,3 @@
 # yabeda-hotcell
 
-Part of [HotCell](https://github.com/basecamp/hotcell). See the repository README.
+Part of [Hot Cell](https://github.com/basecamp/hotcell). See the repository README.

data/lib/yabeda/hot_cell/version.rb

@@ -2,6 +2,6 @@
 
 module Yabeda
   module HotCell
-    VERSION = "1.0.0"
+    VERSION = "1.2.0"
   end
 end

data/lib/yabeda/hot_cell.rb

@@ -18,7 +18,7 @@ module Yabeda
       Yabeda.configure do
         group :hotcell
 
-        counter :requests, comment: "Calls through perform_in_hotcell, by outcome",
+        counter :requests, comment: "Calls through perform_in_hotcell, by code",
           tags: %i[ cell operation code cause ]
         histogram :perform, comment: "Time the cell spent performing", unit: :seconds,
           tags: %i[ cell operation ], buckets: [ 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10, 30, 120 ]
@@ -33,7 +33,9 @@ module Yabeda
           tags: %i[ cell ], aggregation: :most_recent
         gauge :killed, comment: "Workers killed since boot, by cause",
           tags: %i[ cell cause ], aggregation: :most_recent
-        gauge :uptime_seconds, comment: "Seconds since the supervisor booted",
+        gauge :uptime_seconds, comment: "Seconds since the supervisor booted. Deprecated: use start_time_seconds",
+          tags: %i[ cell ], aggregation: :most_recent
+        gauge :start_time_seconds, comment: "When the supervisor booted, in seconds since the Unix epoch",
           tags: %i[ cell ], aggregation: :most_recent
 
         collect { Yabeda::HotCell.collect_stats }
@@ -70,12 +72,17 @@ module Yabeda
     # A failed call is not reported from here: the raise the caller sees already reaches the error reporter.
     def self.record_perform(event)
       labels = { cell: event.payload[:cell], operation: event.payload[:operation] }
+      code = event.payload[:code]
 
       # Empty rather than absent, because a label that is sometimes missing is a separate series in Prometheus
       # and a query by code would silently split.
-      Yabeda.hotcell.requests.increment(labels.merge(code: event.payload[:code] || "ok",
-                                                     cause: event.payload[:cause].to_s))
-      Yabeda.hotcell.perform.measure(labels, (event.payload[:perform_ms] || 0) / 1000.0)
+      Yabeda.hotcell.requests.increment(labels.merge(code: code, cause: event.payload[:cause].to_s))
+
+      # The event has no perform_ms when the cell refuses the call with `capacity`, when the client fails the
+      # call itself with `unavailable` or `timeout`, or when an exception interrupts the call. Recording 0
+      # would pull down the low percentiles.
+      perform_ms = event.payload[:perform_ms]
+      Yabeda.hotcell.perform.measure(labels, perform_ms / 1000.0) if perform_ms
     end
 
     private_class_method def self.set_counters(cell, counters)
@@ -86,6 +93,7 @@ module Yabeda
       Yabeda.hotcell.queue_high_water.set(tags, counters[:queue_high_water])
       Yabeda.hotcell.cancelled.set(tags, counters[:cancelled])
       Yabeda.hotcell.uptime_seconds.set(tags, counters[:uptime_s])
+      Yabeda.hotcell.start_time_seconds.set(tags, counters[:start_time_s]) if counters[:start_time_s]
       ::HotCell::Codes::PERMANENT_BY_CAUSE.each_key do |cause|
         Yabeda.hotcell.killed.set(tags.merge(cause: cause), counters[:killed_by].fetch(cause.to_sym, 0))
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yabeda-hotcell
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Mike Dalessio
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: yabeda
   requirement: !ruby/object:Gem::Requirement
@@ -38,7 +38,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.12'
 description: |
-  Yabeda metrics for an application that calls HotCell cells: a counter and a histogram for every call,
+  Yabeda metrics for an application that calls Hot Cell cells: a counter and a histogram for every call,
   and gauges polled from each local cell's control socket.
 email:
 - mike@37signals.com
@@ -56,8 +56,8 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/basecamp/hotcell
-  source_code_uri: https://github.com/basecamp/hotcell/tree/v1.0.0/yabeda-hotcell
-  changelog_uri: https://github.com/basecamp/hotcell/blob/v1.0.0/CHANGELOG.md
+  source_code_uri: https://github.com/basecamp/hotcell/tree/v1.2.0/yabeda-hotcell
+  changelog_uri: https://github.com/basecamp/hotcell/blob/v1.2.0/CHANGELOG.md
   documentation_uri: https://basecamp.github.io/hotcell/
   bug_tracker_uri: https://github.com/basecamp/hotcell/issues
   rubygems_mfa_required: 'true'
@@ -77,5 +77,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 4.0.6
 specification_version: 4
-summary: Yabeda metrics for HotCell.
+summary: Yabeda metrics for Hot Cell.
 test_files: []