yabeda-datadog 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d32a548b326cf89723f3edb5c9fec66a67dc81b095a6dca76820debe7028bfb
-  data.tar.gz: eb01206ff99ab8eb4c47832cb19efd1e1552354a3628706c2e56df375a4d01e5
+  metadata.gz: 651b614460ad3fbb136abd049623f7d7fc66a853c0a0ea28ceb0b0e0d996c453
+  data.tar.gz: c36b5413fb880de21b89b9ff7f22c63a1500e8a834f47fa24a4b8f2ce1158964
 SHA512:
-  metadata.gz: 78c79e937c0d597e02bbff887bca4a461368ff02f279b21bac8045478586965552778939c93fa21f569ad6a379efa34b058d95f45af05aee46b728c834b87c5c
-  data.tar.gz: 8fab8b91c53cdb21d49a1e78e7a82f5b06508de6dfe3a418259451e9bcd80d8503aa75983b9ead17dea54230893ce9c9f4d285de224091b4e57ceed9849c7ffd
+  metadata.gz: 19fe55d75d1ab7f3dabe2b2f410c1dd8b0e36eab05edf9289ed7c51c123b424e22cb6920b53ed721826c6b90fe0a303f9ac95ee97e3839d4ef3d57ec009a79b5
+  data.tar.gz: 7b527fe8982935d83f2023b8408bc0564673726e35c074b8749b6392bb6be82c77f25941cfb5f6ba71f6088b1eeba71b23a3a31b45c31e569306703875c08006

data/.rubocop.yml

@@ -3,7 +3,7 @@ require:
 - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: "2.5.3"
+  TargetRubyVersion: 2.3
 
 Metrics/BlockLength:
   Exclude:

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 2.6.0
+  - 2.5.3
+  - 2.4.2
+  - 2.3.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yabeda-datadog (0.3.0)
+    yabeda-datadog (0.3.1)
       anyway_config (~> 1.0)
       dogapi
       dogstatsd-ruby

data/README.md

@@ -38,7 +38,7 @@ Rails 5.1 users able to use encrypted rails secrets `Rails.application.secrets.y
 Example of `yabeda_datadog.yml` file:
 
 ```yaml
-# required
+# required (if missing adapter is no-op)
 api_key: <your Datadog API key>
 app_key: <your Datadog App key>
 
@@ -60,7 +60,7 @@ log_level: 1
 Example of environment variables:
 
 ```shell
-# required
+# required (if missing adapter is no-op)
 YABEDA_DATADOG_API_KEY=<your Datadog API key>
 YABEDA_DATADOG_APP_KEY=<your Datadog App key>
 
@@ -93,6 +93,8 @@ To start collecting and sending your metrics to Datadog agent run:
 Yabeda::Datadog.start
 ```
 
+**NOTE**: if you're using Ruby <2.5.2 you might encounter [a bug related to the process forking](https://bugs.ruby-lang.org/issues/14634) (e.g. when using Puma web server). The workaround is to start `Yabeda::Datadog` after the `fork` (e.g. when using Puma, put `Yabeda::Datadog.start` inside the `on_worker_boot` callback).
+
 To star collecting Yabeda collect blocks (aka collectors) run the command:
 
 ```ruby

data/lib/yabeda/datadog/exceptions.rb

@@ -2,16 +2,17 @@
 
 module Yabeda
   module Datadog
+    class ConfigError < StandardError; end
     # = This error raised when no Datadog API key provided
-    class ApiKeyError < StandardError
-      def initialize(msg = "Datadog API key doesn't set")
+    class ApiKeyError < ConfigError
+      def initialize(msg = "Datadog API key is missing")
         super
       end
     end
 
     # = This error raised when no Datadog application key provided
-    class AppKeyError < StandardError
-      def initialize(msg = "Datadog application key doesn't set")
+    class AppKeyError < ConfigError
+      def initialize(msg = "Datadog application key is missing")
         super
       end
     end

data/lib/yabeda/datadog/version.rb

@@ -2,6 +2,6 @@
 
 module Yabeda
   module Datadog
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/lib/yabeda/datadog.rb

@@ -14,36 +14,40 @@ module Yabeda
     SECOND = 1
     COLLECT_INTERVAL = 60 * SECOND
 
-    # Gem configuration object
-    def self.config
-      @config ||= Config.new
-    end
-
-    # Check the gem configuration has valid state
-    def self.ensure_configured
-      raise ApiKeyError unless config.api_key
-      raise AppKeyError unless config.app_key
-    end
+    class << self
+      # Gem configuration object
+      def config
+        @config ||= Config.new
+      end
 
-    # Prepare the adapter to work
-    def self.start
-      ensure_configured
+      # Check the gem configuration has valid state
+      def ensure_configured
+        raise ApiKeyError unless config.api_key
+        raise AppKeyError unless config.app_key
+      end
 
-      worker = Yabeda::Datadog::Worker.start(config)
-      adapter = Yabeda::Datadog::Adapter.new(worker: worker)
-      Yabeda.register_adapter(:datadog, adapter)
-      adapter
-    end
+      # Prepare the adapter to work
+      def start
+        ensure_configured
+        worker = Yabeda::Datadog::Worker.start(config)
+        adapter = Yabeda::Datadog::Adapter.new(worker: worker)
+        Yabeda.register_adapter(:datadog, adapter)
+        adapter
+      rescue ConfigError => e
+        Logging.instance.warn e.message
+        nil
+      end
 
-    # Start collection metrics from Yabeda collectors
-    def self.start_exporter(collect_interval: COLLECT_INTERVAL)
-      Thread.new do
-        Logging.instance.debug("initilize collectors harvest")
-        loop do
-          Logging.instance.debug("start collectors harvest")
-          Yabeda.collectors.each(&:call)
-          Logging.instance.debug("end collectors harvest")
-          sleep(collect_interval)
+      # Start collection metrics from Yabeda collectors
+      def start_exporter(collect_interval: COLLECT_INTERVAL)
+        Thread.new do
+          Logging.instance.debug("initilize collectors harvest")
+          loop do
+            Logging.instance.debug("start collectors harvest")
+            Yabeda.collectors.each(&:call)
+            Logging.instance.debug("end collectors harvest")
+            sleep(collect_interval)
+          end
         end
       end
     end

data/yabeda-datadog.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.5.3"
+  spec.required_ruby_version = ">= 2.3.0"
 
   spec.add_dependency "anyway_config", "~> 1.0"
   spec.add_dependency "dogapi"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yabeda-datadog
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Dmitry Shvetsov <@shvetsovdm>
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-11 00:00:00.000000000 Z
+date: 2019-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anyway_config
@@ -134,6 +134,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
 - Gemfile.lock
@@ -172,7 +173,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.3
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="