y-rb 0.4.2 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93340a5c97501c667f0b3f690727d3794310d665678398175cac1e2a09cd768f
-  data.tar.gz: e5dead42fdd8eff21b4a149acd9495a17b5e9a1925bb1aa5d2d90af5673735f2
+  metadata.gz: dc0dfc4d5578e2f6abca4c9224b9d84723371adb5be4b9c44ecf0dc99f70bf6a
+  data.tar.gz: b8e6e6c7c1e9552d4866e52813c43f67763d4a9ed7d114df33a769818e895ccd
 SHA512:
-  metadata.gz: ddfb247b3a58bd677b22f2ede93df1bb2ff8f12d14dc0b9a0030adafdb582ba74149b3aa85ac33a7fe725417d4a5cdbfd3f10a59dec65028c570a3853e0de173
-  data.tar.gz: fa37a398266e02dd3b0473d319ae87d9915a77885597f845f79c78e6a78d1aa33a7c5620389546ba033c1181331ce6b94cde53520fb73201b98679b601083d71
+  metadata.gz: d8270d7099b047a39c1ad2fd9c579d87ebd6a1fcecbc1a421a4119a7019270567a14fc1b320ae6ab7d7134e19e796a1702feb7690986f39a521b418f5489b426
+  data.tar.gz: 906a236b4b56954dfcd23837fd4b2beaf1a14b8390776433376e4fe9ba0e8e8e414c5bcdf5cc52d9b275bee1f80af3025d6b91dccf87e2346e87adbbf2339479

data/ext/yrb/Cargo.toml

@@ -1,19 +1,19 @@
 [package]
 name = "yrb"
-version = "0.4.2"
+version = "0.4.4"
 authors = ["Hannes Moser <box@hannesmoser.at>", "Hannes Moser <hmoser@gitlab.com>"]
 edition = "2021"
 homepage = "https://github.com/y-crdt/yrb"
 repository = "https://github.com/y-crdt/yrb"
 
 [dependencies]
-lib0 = "0.14.1" # must match yrs version
-magnus = { git = "https://github.com/matsadler/magnus", rev = "a51ccaf01d82e9e1a981e4f3fbaca35100513b08" }
+lib0 = "0.16.0" # must match yrs version
+magnus = { git = "https://github.com/matsadler/magnus", rev = "ab982c3643421b38f3293f1fe014aa373abfd6dc" }
 thiserror = "1.0.38"
-yrs = "0.14.1"
+yrs = "0.16.0"
 
 [dev-dependencies]
-magnus = { git = "https://github.com/matsadler/magnus", rev = "a51ccaf01d82e9e1a981e4f3fbaca35100513b08", features = ["embed"] }
+magnus = { git = "https://github.com/matsadler/magnus", rev = "ab982c3643421b38f3293f1fe014aa373abfd6dc", features = ["embed"] }
 
 [lib]
 name = "yrb"

data/ext/yrb/src/yany.rs

@@ -1,4 +1,5 @@
 use lib0::any::Any;
+use magnus::r_string::IntoRString;
 use magnus::{RArray, RHash, RString, Value, QNIL};
 use std::borrow::Borrow;
 use std::ops::{Deref, DerefMut};
@@ -37,7 +38,7 @@ impl TryInto<Value> for YAny {
             Any::Bool(v) => Ok(Value::from(v)),
             Any::Number(v) => Ok(Value::from(v)),
             Any::BigInt(v) => Ok(Value::from(v)),
-            Any::String(v) => Ok(Value::from(RString::from(v.borrow()))),
+            Any::String(v) => Ok(Value::from(RString::from(v.into_r_string()))),
             Any::Buffer(v) => Ok(Value::from(RString::from_slice(v.borrow()))),
         };
     }

data/ext/yrb/src/yarray.rs

@@ -4,6 +4,7 @@ use lib0::any::Any;
 use magnus::block::Proc;
 use magnus::value::Qnil;
 use magnus::{Error, RArray, RHash, Symbol, Value};
+use std::borrow::Borrow;
 use std::cell::RefCell;
 use yrs::types::Change;
 use yrs::{Array, ArrayRef, Observable};
@@ -112,9 +113,15 @@ impl YArray {
                     .partition(Result::is_ok);
 
                 if errors.is_empty() {
-                    let args = (RArray::from_vec(
-                        changes.into_iter().map(Result::unwrap).collect(),
-                    ),);
+                    let args_changes = RArray::new();
+                    for change in changes.iter() {
+                        let c = *change.borrow().as_ref().unwrap();
+                        args_changes
+                            .push(c)
+                            .expect("cannot push change event to args");
+                    }
+
+                    let args = (args_changes,);
                     let _ = block.call::<(RArray,), Qnil>(args);
                     // todo: make sure we respect the result and bubble up the
                     //  error so that we can return as part of the Result
@@ -143,7 +150,7 @@ impl YArray {
         let tx = tx.as_mut().unwrap();
 
         let arr = self.0.borrow_mut();
-        arr.push_front(tx, avalue)
+        arr.push_front(tx, avalue);
     }
     pub(crate) fn yarray_remove(&self, transaction: &YTransaction, index: u32) {
         let mut tx = transaction.transaction();
@@ -164,12 +171,13 @@ impl YArray {
         let tx = transaction.transaction();
         let tx = tx.as_ref().unwrap();
 
-        let arr = arr
-            .iter(tx)
-            .map(|v| YValue::from(v).into())
-            .collect::<Vec<Value>>();
-
-        RArray::from_vec(arr)
+        let r_arr = RArray::new();
+        for item in arr.iter(tx) {
+            let r_val = YValue::from(item);
+            let r_val = r_val.0.borrow().clone();
+            r_arr.push(r_val).expect("cannot push item event to array");
+        }
+        r_arr
     }
     pub(crate) fn yarray_unobserve(&self, subscription_id: u32) {
         self.0.borrow_mut().unobserve(subscription_id);

data/ext/yrb/src/ymap.rs

@@ -27,7 +27,7 @@ impl YMap {
 
         match indifferent_hash_key(key) {
             None => false,
-            Some(k) => self.0.borrow().contains(tx, k.as_str()),
+            Some(k) => self.0.borrow().contains_key(tx, k.as_str()),
         }
     }
     pub(crate) fn ymap_each(&self, transaction: &YTransaction, proc: Proc) {

data/ext/yrb/src/ytext.rs

@@ -48,7 +48,7 @@ impl YText {
         let yvalue = YValue::from(content);
         let avalue = Any::from(yvalue);
 
-        self.0.borrow_mut().insert_embed(tx, index, avalue)
+        self.0.borrow_mut().insert_embed(tx, index, avalue);
     }
     pub(crate) fn ytext_insert_embed_with_attributes(
         &self,
@@ -67,7 +67,7 @@ impl YText {
 
         self.0
             .borrow_mut()
-            .insert_embed_with_attributes(tx, index, avalue, a.0)
+            .insert_embed_with_attributes(tx, index, avalue, a.0);
     }
     pub(crate) fn ytext_insert_with_attributes(
         &self,

data/ext/yrb/src/yvalue.rs

@@ -116,12 +116,13 @@ impl From<Any> for YValue {
             Any::String(v) => YValue::from(v.into_string()),
             Any::Buffer(v) => YValue::from(Value::from(v.into_vec())),
             Any::Array(v) => {
-                let arr = v
-                    .iter()
-                    .map(|i| YValue::from(i.clone()))
-                    .map(|value| *value.0.borrow())
-                    .collect::<Vec<Value>>();
-                YValue::from(RArray::from_vec(arr))
+                let arr = RArray::new();
+                for item in v.iter() {
+                    let val = YValue::from(item.clone());
+                    let val = val.0.borrow().clone();
+                    arr.push(val).expect("cannot push item event to array");
+                }
+                YValue::from(arr)
             }
             Any::Map(v) => {
                 let map = v
@@ -146,14 +147,12 @@ impl From<YrsValue> for YValue {
             YrsValue::YXmlText(text) => YValue::from(text),
             YrsValue::YArray(val) => {
                 let tx = val.transact();
-                let arr = RArray::from_vec(
-                    val.iter(&tx)
-                        .map(|item| {
-                            let yvalue = YValue::from(item);
-                            yvalue.0.into_inner()
-                        })
-                        .collect(),
-                );
+                let arr = RArray::new();
+                for item in val.iter(&tx) {
+                    let val = YValue::from(item.clone());
+                    let val = val.0.borrow().clone();
+                    arr.push(val).expect("cannot push item event to array");
+                }
                 YValue::from(arr)
             }
             YrsValue::YMap(val) => {

data/ext/yrb/src/yxml_element.rs

@@ -76,7 +76,7 @@ impl YXmlElement {
         index: u32,
         content: String,
     ) -> YXmlText {
-        let text = XmlTextPrelim(content.as_str());
+        let text = XmlTextPrelim::new(content.as_str());
         let mut tx = transaction.transaction();
         let tx = tx.as_mut().unwrap();
 
@@ -107,15 +107,16 @@ impl YXmlElement {
                 for change in delta {
                     match change {
                         Change::Added(v) => {
-                            let values = v
-                                .iter()
-                                .map(|o| YValue::from(o.clone()))
-                                .map(|o| *o.0.borrow())
-                                .collect::<Vec<_>>();
+                            let values = RArray::new();
+                            for value in v.iter() {
+                                let value = YValue::from(value.clone());
+                                let value = value.0.borrow().clone();
+                                values.push(value).expect("cannot push value to array");
+                            }
 
                             let payload = RHash::new();
                             payload
-                                .aset(change_added, RArray::from_vec(values))
+                                .aset(change_added, values)
                                 .expect("cannot create change::added payload");
 
                             changes
@@ -203,7 +204,7 @@ impl YXmlElement {
         let mut tx = transaction.transaction();
         let tx = tx.as_mut().unwrap();
 
-        let text = XmlTextPrelim(content.as_str());
+        let text = XmlTextPrelim::new(content.as_str());
         YXmlText::from(self.0.borrow_mut().push_back(tx, text))
     }
     pub(crate) fn yxml_element_push_text_front(
@@ -214,7 +215,7 @@ impl YXmlElement {
         let mut tx = transaction.transaction();
         let tx = tx.as_mut().unwrap();
 
-        let text = XmlTextPrelim(content.as_str());
+        let text = XmlTextPrelim::new(content.as_str());
         YXmlText::from(self.0.borrow_mut().push_front(tx, text))
     }
     pub(crate) fn yxml_element_remove_attribute(&self, transaction: &YTransaction, name: String) {

data/ext/yrb/src/yxml_text.rs

@@ -72,11 +72,13 @@ impl YXmlText {
         let yvalue = YValue::from(content);
         let avalue = Any::from(yvalue);
 
-        map_rhash_to_attrs(attrs).map(|a| {
-            self.0
-                .borrow_mut()
-                .insert_embed_with_attributes(tx, index, avalue, a)
-        })
+        map_rhash_to_attrs(attrs)
+            .map(|a| {
+                self.0
+                    .borrow_mut()
+                    .insert_embed_with_attributes(tx, index, avalue, a)
+            })
+            .map(|_| ())
     }
     pub(crate) fn yxml_text_insert_embed(
         &self,
@@ -89,7 +91,7 @@ impl YXmlText {
 
         self.0
             .borrow_mut()
-            .insert_embed(tx, index, Any::from(YValue::from(embed)))
+            .insert_embed(tx, index, Any::from(YValue::from(embed)));
     }
     pub(crate) fn yxml_text_insert_with_attributes(
         &self,

data/lib/y/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Y
-  VERSION = "0.4.2"
+  VERSION = "0.4.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: y-rb
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.4
 platform: ruby
 authors:
 - Hannes Moser
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-18 00:00:00.000000000 Z
+date: 2023-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.53
+        version: 0.9.56
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.53
+        version: 0.9.56
 - !ruby/object:Gem::Dependency
   name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.2.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.2.1
 - !ruby/object:Gem::Dependency
   name: rake-compiler-dock
   requirement: !ruby/object:Gem::Requirement
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 3.3.21
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.5
 signing_key:
 specification_version: 4
 summary: Ruby bindings for yrs