xrechnung 0.6.1 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 847d896fa56b4d05bf9569e5875df86fdbc1590d6b333b665ae7e118e7c82629
-  data.tar.gz: 1e7d94940bcfd954e550a10a88b0c2c3bdf12b15a525c520cfd4f7cd6bed01c3
+  metadata.gz: 06252face0554e39218ad09f6de658da8ceefab529414974c3cbea5066c03f94
+  data.tar.gz: 37fdbaf09d8b6506f9c49bbb9951aba92fb0d640a11a235b2c4838ca9c6f7ec8
 SHA512:
-  metadata.gz: 15120534576d4080c46eab699327bed3f1b86f1c349d5f02f8a7fb20d02028abe8d0a30bfbd78a03c43e5769dae386f2507040014022835553ec4c01f39a6a4a
-  data.tar.gz: 48443809916284be1acb86213f609d02c6699c50560236091c5116b4661a48b3765a63ca8af771d2ad6159ab4b18568da643aa77bff595a93691f4e177a12bb4
+  metadata.gz: c039758300cab1eb0bfabd785a3c4efc9eba14f0c94f6f72741c0fbb922e3bc0eeab612b3a9842f66244666f230d918a226fc41741eba86005347bff8c4b1c73
+  data.tar.gz: '038c45111d8b65bc6290b78048a30aae81ff04283784efd335c73a34eede869dd9aa5adb33a9a736763065bed4345054cb614e1e23b662510d34edeb9ee3ac24'

data/.github/workflows/rspec.yml

@@ -8,10 +8,10 @@ jobs:
     name: Ruby ${{ matrix.ruby }}
     strategy:
       matrix:
-        ruby:  ['3.0', '3.2', '3.3']
+        ruby:  ['3.2', '3.3', '3.4']
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
 
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1

data/.github/workflows/validate-fixtures.yml

@@ -7,16 +7,16 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
 
-    - uses: actions/setup-java@v2
+    - uses: actions/setup-java@v5
       with:
         distribution: "adopt"
-        java-version: "11" # LTS
+        java-version: "17"
 
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version:  "3.2"
+        ruby-version:  "3.4"
         bundler-cache: true
 
     - name: Prepare validator
@@ -25,7 +25,7 @@ jobs:
     - name: Run validator
       run: bundle exec rake validator:run
 
-    - uses: actions/upload-artifact@v4
+    - uses: actions/upload-artifact@v6
       if: failure()
       with:
         name: validation-results

data/.rubocop

@@ -0,0 +1 @@
+--safe

data/.rubocop.yml

@@ -1,4 +1,6 @@
-# REQUIRES RUBOCOP 1.8.X
+plugins:
+  - rubocop-rspec
+  - rubocop-rake
 
 AllCops:
   Exclude:
@@ -13,6 +15,7 @@ AllCops:
   DisplayCopNames: true
   StyleGuideCopsOnly: false
   TargetRubyVersion: 3.0
+  NewCops: enable
 
 ## Layout Cops - https://docs.rubocop.org/rubocop/cops_layout.html
 
@@ -344,9 +347,6 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: comma
 
-require:
-  - rubocop-rspec
-
 RSpec/AnyInstance:
   Enabled: false
 

data/Gemfile

@@ -3,6 +3,9 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in xrechnung.gemspec
 gemspec
 
-gem "rake", "~> 13.0"
-gem "rspec", "~> 3.0"
-gem "rubocop-rspec", "~> 2.1"
+gem "rake"
+gem "rspec"
+gem "rubocop-rspec"
+gem "rubocop-rake"
+gem "httparty"
+gem "rubyzip"

data/Gemfile.lock

@@ -1,84 +1,115 @@
 PATH
   remote: .
   specs:
-    xrechnung (0.6.1)
+    xrechnung (0.6.3)
+      activesupport
+      base64
+      bigdecimal
       builder (~> 3.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.2)
+    activesupport (8.1.2)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      json
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    ast (2.4.3)
+    base64 (0.3.0)
+    bigdecimal (4.0.1)
     builder (3.3.0)
-    csv (3.3.0)
-    diff-lcs (1.5.1)
-    httparty (0.22.0)
+    concurrent-ruby (1.3.6)
+    connection_pool (3.0.2)
+    csv (3.3.5)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    httparty (0.24.2)
       csv
       mini_mime (>= 1.0.0)
       multi_xml (>= 0.5.2)
-    json (2.9.0)
-    language_server-protocol (3.17.0.3)
+    i18n (1.14.8)
+      concurrent-ruby (~> 1.0)
+    json (2.18.0)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    logger (1.7.0)
     mini_mime (1.1.5)
-    multi_xml (0.6.0)
-    parallel (1.26.3)
-    parser (3.3.6.0)
+    minitest (6.0.1)
+      prism (~> 1.5)
+    multi_xml (0.8.1)
+      bigdecimal (>= 3.1, < 5)
+    parallel (1.27.0)
+    parser (3.3.10.1)
       ast (~> 2.4.1)
       racc
+    prism (1.9.0)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.2.1)
-    regexp_parser (2.9.3)
-    rspec (3.13.0)
+    rake (13.3.1)
+    regexp_parser (2.11.3)
+    rspec (3.13.2)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.2)
+    rspec-core (3.13.6)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.3)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.2)
+    rspec-mocks (3.13.7)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.2)
-    rubocop (1.69.1)
+    rspec-support (3.13.7)
+    rubocop (1.84.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.36.2, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.36.2)
-      parser (>= 3.3.1.0)
-    rubocop-capybara (2.21.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.26.1)
-      rubocop (~> 1.61)
-    rubocop-rspec (2.31.0)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.29.1)
-      rubocop (~> 1.61)
+    rubocop-ast (1.49.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.9.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.81)
     ruby-progressbar (1.13.0)
-    rubyzip (2.3.2)
-    unicode-display_width (3.1.2)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    rubyzip (3.2.2)
+    securerandom (0.4.1)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  httparty (~> 0.22)
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  rubocop-rspec (~> 2.1)
-  rubyzip (~> 2.0)
+  httparty
+  rake
+  rspec
+  rubocop-rake
+  rubocop-rspec
+  rubyzip
   xrechnung!
 
 BUNDLED WITH
-   2.4.19
+  4.0.5

data/Rakefile

@@ -1,41 +1,40 @@
 require "pathname"
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "httparty"
+require "zip"
 
+Zip.on_exists_proc = true
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
 
+VALIDATOR_SOURCES = {
+  tool:      {
+    filename:    "validator/validator-1.6.0-standalone.jar",
+    release_url: "https://github.com/itplr-kosit/validator/releases/download/v1.6.0/validator-1.6.0.zip",
+  },
+  scenarios: {
+    filename:    "validator/scenarios.xml",
+    release_url: "https://github.com/itplr-kosit/validator-configuration-xrechnung/releases/download/release-2025-07-10/validator-configuration-xrechnung_3.0.2_2025-07-10.zip",
+  },
+}.freeze
+
 namespace :validator do
-  VALIDATOR_SOURCES = {
-    tool:      {
-      filename:    "validator/validationtool-1.5.0-standalone.jar",
-      release_url: "https://github.com/itplr-kosit/validator/releases/download/v1.5.0/validator-1.5.0-distribution.zip",
-    },
-    scenarios: {
-      filename:    "validator/scenarios.xml",
-      release_url: "https://github.com/itplr-kosit/validator-configuration-xrechnung/releases/download/release-2024-10-31/validator-configuration-xrechnung_3.0.2_2024-10-31.zip",
-    },
-  }.freeze
-
-  VALIDATOR_SOURCES.each do |_, v|
+  VALIDATOR_SOURCES.each_value do |v|
     base    = Pathname.new(__dir__).join("validator")
     zipfile = base.join(File.basename(v[:release_url]))
 
     file zipfile do
-      require "httparty"
-
       base.mkpath unless base.exist?
 
       res = HTTParty.get(v[:release_url], follow_redirects: true)
-      File.open(zipfile, "wb") { |f| f.write res.body }
+      File.binwrite(zipfile, res.body)
     end
 
     file v[:filename] => zipfile do
-      require "zip"
-
       Zip::File.foreach(zipfile) do |entry|
-        entry.extract base.join(entry.name)
+        entry.extract destination_directory: base
       end
     end
   end

data/lib/xrechnung/contact.rb

@@ -18,8 +18,8 @@ module Xrechnung
     def to_xml(xml)
       xml.cac :Contact do
         xml.cbc :Name, name
-        xml.cbc :Telephone, telephone
-        xml.cbc :ElectronicMail, electronic_mail
+        xml.cbc :Telephone, telephone if telephone.present?
+        xml.cbc :ElectronicMail, electronic_mail if electronic_mail.present?
       end
     end
   end

data/lib/xrechnung/party_legal_entity.rb

@@ -14,7 +14,7 @@ module Xrechnung
     def to_xml(xml)
       xml.cac :PartyLegalEntity do
         xml.cbc :RegistrationName, registration_name
-        xml.cbc(:CompanyID, company_id) unless company_id.nil?
+        xml.cbc(:CompanyID, company_id) if company_id.present?
       end
     end
   end

data/lib/xrechnung/party_tax_scheme.rb

@@ -13,7 +13,7 @@ module Xrechnung
     # noinspection RubyResolve
     def to_xml(xml)
       xml.cac :PartyTaxScheme do
-        xml.cbc :CompanyID, company_id
+        xml.cbc(:CompanyID, company_id) if company_id.present?
         xml.cac :TaxScheme do
           xml.cbc :ID, tax_scheme_id
         end

data/lib/xrechnung/payment_means.rb

@@ -1,6 +1,8 @@
 module Xrechnung
   # <cac:PaymentMeans>
   #   <cbc:PaymentMeansCode>30</cbc:PaymentMeansCode>
+  #   <cbc:InstructionNote>Textvermerk der Zahlung</cbc:InstructionNote>
+  #   <cbc:PaymentID>Verwendungszweck</cbc:PaymentID>
   #   <cac:PayeeFinancialAccount>
   #     <cbc:ID>DE12500105170648489890</cbc:ID>
   #     <cbc:Name>Harry Hirsch</cbc:Name>
@@ -12,14 +14,32 @@ module Xrechnung
   class PaymentMeans
     include MemberContainer
 
+    # Payment means type code BT-81
+    #
     # @!attribute payment_means_code
     #   @return [Integer]
     member :payment_means_code, type: Integer
 
+    # Payment means text BT-82
+    #
+    # @!attribute payment_means_code
+    #   @return [String]
+    member :instruction_note, type: String, optional: true
+
+    # Remittance information BT-83
+    #
+    # @!attribute payment_means_code
+    #   @return [String]
+    member :payment_id, type: String, optional: true
+
+    # Credit transfer BG-17
+    #
     # @!attribute payee_financial_account
     #   @return [Xrechnung::PayeeFinancialAccount]
     member :payee_financial_account, type: Xrechnung::PayeeFinancialAccount
 
+    # Direct debit BG-19
+    #
     # @!attribute payment_mandate
     #   @return [Xrechnung::PaymentMandate]
     member :payment_mandate, type: Xrechnung::PaymentMandate, optional: true
@@ -27,6 +47,8 @@ module Xrechnung
     # noinspection RubyResolve
     def to_xml(xml)
       xml.cbc :PaymentMeansCode, payment_means_code
+      xml.cbc :InstructionNote, instruction_note if instruction_note
+      xml.cbc :PaymentID, payment_id if payment_id
       payee_financial_account&.to_xml(xml)
       payment_mandate&.to_xml(xml)
       xml.target!

data/lib/xrechnung/tax_category.rb

@@ -17,6 +17,11 @@ module Xrechnung
     # • O (Services outside scope of tax)
     # • L (Canary Islands general indirect tax)
     # • M (Tax for production, services and importation in Ceuta and Melilla)
+    #
+    # Note: S, Z, E, AE, K, G, L and M require either a seller VAT identifier (BT-31),
+    # a seller tax registration identifier (BT-32), or a seller tax representative
+    # party (BG-11). Xrechnung::Document currently only supports the VAT identifier.
+    #
     # @!attribute id
     #   @return [String]
     member :id, type: String

data/lib/xrechnung/version.rb

@@ -1,3 +1,3 @@
 module Xrechnung
-  VERSION = "0.6.1".freeze
+  VERSION = "0.6.3".freeze
 end

data/lib/xrechnung.rb

@@ -1,5 +1,9 @@
-require "xrechnung/version"
 require "date"
+require "builder"
+
+require "active_support/core_ext/object/blank"
+
+require "xrechnung/version"
 require "xrechnung/currency"
 require "xrechnung/quantity"
 require "xrechnung/id"
@@ -25,7 +29,6 @@ require "xrechnung/price"
 require "xrechnung/invoice_line"
 require "xrechnung/invoice_document_reference"
 require "xrechnung/invoice_period"
-require "builder"
 
 module Xrechnung
   class Error < StandardError; end
@@ -120,7 +123,7 @@ module Xrechnung
     #
     # @!attribute purchase_order_reference
     #   @return [String]
-    member :purchase_order_reference, type: String, optional: true
+    member :purchase_order_reference, type: String
 
     # Sales order reference BT-14
     #
@@ -289,16 +292,19 @@ module Xrechnung
     #   @return [Array]
     member :allowance_charges, type: Array, default: []
 
+    COMMON_NAMESPACES = {
+      "xmlns:ubl"          => "urn:oasis:names:specification:ubl:schema:xsd:Invoice-2",
+      "xmlns:cac"          => "urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2",
+      "xmlns:cbc"          => "urn:oasis:names:specification:ubl:schema:xsd:CommonBasicComponents-2",
+      "xmlns:xsi"          => "http://www.w3.org/2001/XMLSchema-instance",
+      "xsi:schemaLocation" => "urn:oasis:names:specification:ubl:schema:xsd:Invoice-2 http://docs.oasis-open.org/ubl/os-UBL-2.1/xsd/maindoc/UBL-Invoice-2.1.xsd",
+    }.freeze
+
     def to_xml(indent: 2, target: "")
       xml = Builder::XmlMarkup.new(indent: indent, target: target)
       xml.instruct! :xml, version: "1.0", encoding: "UTF-8"
 
-      xml.ubl :Invoice, \
-        "xmlns:ubl"          => "urn:oasis:names:specification:ubl:schema:xsd:Invoice-2",
-        "xmlns:cac"          => "urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2",
-        "xmlns:cbc"          => "urn:oasis:names:specification:ubl:schema:xsd:CommonBasicComponents-2",
-        "xmlns:xsi"          => "http://www.w3.org/2001/XMLSchema-instance",
-        "xsi:schemaLocation" => "urn:oasis:names:specification:ubl:schema:xsd:Invoice-2 http://docs.oasis-open.org/ubl/os-UBL-2.1/xsd/maindoc/UBL-Invoice-2.1.xsd" do
+      xml.ubl :Invoice, COMMON_NAMESPACES do
         xml.cbc :CustomizationID, customization_id
         xml.cbc :ProfileID, profile_id
         xml.cbc :ID, id
@@ -317,14 +323,12 @@ module Xrechnung
 
         invoice_period&.to_xml(xml) unless self.class.members[:invoice_period].optional && invoice_period.nil?
 
-        unless self.class.members[:purchase_order_reference].optional && purchase_order_reference.nil? &&
+        unless purchase_order_reference.nil? &&
                self.class.members[:sales_order_reference].optional && sales_order_reference.nil?
           xml.cac :OrderReference do
-            unless self.class.members[:purchase_order_reference].optional && purchase_order_reference.nil?
-              xml.cbc :ID, purchase_order_reference
-            end
+            xml.cbc :ID, purchase_order_reference
             unless self.class.members[:sales_order_reference].optional && sales_order_reference.nil?
-              xml.cbc :ID, sales_order_reference
+              xml.cbc :SalesOrderID, sales_order_reference
             end
           end
         end

data/xrechnung.gemspec

@@ -11,8 +11,9 @@ Gem::Specification.new do |spec|
   spec.license               = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 3.0.0")
 
-  spec.metadata["homepage_uri"]    = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/digineo/xrechnung"
+  spec.metadata["homepage_uri"]          = spec.homepage
+  spec.metadata["source_code_uri"]       = "https://github.com/digineo/xrechnung"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -22,8 +23,8 @@ Gem::Specification.new do |spec|
 
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "activesupport" # for String#blank? and #present?
+  spec.add_dependency "base64"
+  spec.add_dependency "bigdecimal"
   spec.add_dependency "builder", "~> 3.2"
-
-  spec.add_development_dependency "httparty", "~> 0.22"
-  spec.add_development_dependency "rubyzip", "~> 2.0"
 end

metadata

@@ -1,58 +1,70 @@
 --- !ruby/object:Gem::Specification
 name: xrechnung
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.3
 platform: ruby
 authors:
 - Julian Kornberger
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: builder
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: base64
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.22'
-  type: :development
+        version: '0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.22'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubyzip
+  name: bigdecimal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: builder
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
+        version: '3.2'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-description:
+        version: '3.2'
 email:
 - jk+github@digineo.de
 executables: []
@@ -63,6 +75,7 @@ files:
 - ".github/workflows/validate-fixtures.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop"
 - ".rubocop.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -107,7 +120,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/digineo/xrechnung
   source_code_uri: https://github.com/digineo/xrechnung
-post_install_message:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -122,8 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.19
-signing_key:
+rubygems_version: 4.0.5
 specification_version: 4
 summary: Library to create invoices in the XRechnung format.
 test_files: []