xre 0.5.2-x86_64-linux → 0.5.4-x86_64-linux

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ac57c45b6f672b820a2d0978eb531ac6645b8e9118071d80bc4712215bdf14e
-  data.tar.gz: 47e4b60e7a4e9e33492ab085b20e0c6490442193127dd009e067223828fe8407
+  metadata.gz: 3a2279f75a1ab8f8b604416ebaa8c098dde5ae31821413f8c4f15b30cb7d4258
+  data.tar.gz: 70e153012f2725a6de187ca19aa647e9cdcfb1d590a94666bcf956ec4526a273
 SHA512:
-  metadata.gz: b2fc3cbd0550016ea572ee6ec4bae957dad1796c9c6d4ac5babfa46d873f4b5651cad291696612feb947d77fed54e68e6bb956dd6fc0e38f952b1b0a4de64737
-  data.tar.gz: dc2ab19b9debc49cb75722e87b907ba8172800d7c15c1baec0912e391050760aae2782c9621216aa3fd82db461229b1c91dd20e54d9c1171e8e6694faa818793
+  metadata.gz: 873c8c81e6da7d3f81527391adfbec0ced5f2a0b3bde884c4bab8c04e4b0e75b33ff4dd0894b650fe5fcf2388ee330080c9d7e5855cfcdc9425a762d7270db14
+  data.tar.gz: 32332349b596c445a867756799ca86f37270c900f0d6f5ea5fa95f465cd863f032be17b8b2db6fa86d483431e67e8ae2279f416b6585651798430e67a3e0c102

data/README.md

@@ -3,18 +3,57 @@
 This is a rust extension for finding all the matches in a text.
 It's a simple extension that is used in one part of our codebase and this extension makes it substantially faster.
 
-The following text assumes you're in the `xre` directory inside `clearscope` project.
+## Why?
 
-## How to build rust code localy:
+The main reason for this extension is that we have a unique use case where we need to find all captures
+with their respectful offsets in a large text and we need to do this for a huge number of regexes and texts.
+This is a slow operation in ruby since the regular `scan` does not provide the actual captures,
+but only the offsets. This extension provides the captures and offsets in a single call for a
+list of regexes to avoid the overhead of calling the regex engine multiple times.
+
+Moreover, another part of the problem is that we also require the surrounding text of the capture
+with some radius, which is also not possible with the regular `scan` method without resorting to iterating
+the whole text multiple times.
+
+> 🤓
+> Another a bit more technical reason for why the rust extension is faster is that ruby strings are
+> indexed in characters(`O(n)`), but rust strings are indexed in bytes(`O(1)`). And with a careful
+> iteration over the characters on the rust side(see `regex_list.rs#captures_with_context` and `utils.rs#find_char_index`) as we go through the text we can avoid multiple(`n`)
+> `O(n)` operations that ruby would have to do, reducing the algorithmic complexity from
+> `O(n^2)` to `O(n)` for one regex, and from `O(m * n^2)` to `O(m * n)`(where `m` and `n` are the number
+> of regexes and the number of texts respectfuly) for multiple regexes.
+
+## Developing:
+
+The simplest way to develop the gem locally without reinstalling the gem is to just:
+
+1. change the
+   `gem "xre"` in the `Gemfile` to `gem "xre", path: "xre"`
+2. run `bundle install`
+
+and you're good to go. Just change the code(then compile the rust code if you changed it, more on that below),
+go into `rails c` and hack away.
+
+Another simple way is to:
+
+1. change the gem code(then, once again, compile the rust code if you changed it)
+2. go into `rails c` or the console of your choosing
+3. run `require_relative "xre/lib/xre"`
+
+all done.
+
+> 💡Note: _The following part of the readme assumes that you're in the `xre` directory inside `clearscope` project._
+
+### How to build rust code locally:
 
 ```bash
-rake compile
+rake compile # or just rake
 ```
 
 sometimes you might need to clean the build:
 
 ```bash
-rake clean
+rake clean && rake compile
 ```
 
 you might need to install rust toolchain for that:
@@ -23,32 +62,34 @@ you might need to install rust toolchain for that:
 curl https://sh.rustup.rs -sSf | sh
 ```
 
-## How to run tests:
-
-### Ruby tests:
+### How to run tests:
 
-Our ruby tests live in the regular `spec` directory of the project, so inside `clearscope` run:
+**Ruby tests:**
 
 ```bash
-bundle exec rspec spec/xre
+bundle exec rake spec
 ```
 
-### Rust tests:
+**Rust tests:**
 
 ```bash
-cargo test
+cargo test # you will need rust toolchain for that
 ```
 
-## How to publish the gem:
+**Rust linting:**
 
-First, increment the version in the `lib/xre/version.rb` file according to the semantic versioning rules.
+````bash
+# you will need rust toolchain for that
+cargo fmt # will format the code
+cargo clippy # will suggest improvements, not only style ones
+```
 
-Then build the gem and push it to rubygems:
+## Publishing:
 
-```bash
-rake build
-gem push pkg/xre-<version>-gem
-```
+The codebase includes `xre/Rakefile` which in turn defines a `gem:native`
+task that compiles the extension for the `x86_64-linux`, `x86_64-darwin`, and `arm64-darwin`
+and puts the compiled gems into `xre/pkg/` directory, from where one should
+`gem push xre-<version>-x86_64-linux.gem` to publish the gem.
 
-> Note, currently only [`barseek`](https://github.com/Vagab) has access to the rubygems account, so you might need to ask him to publish the gem.
-> As soon as this changes and we get a team rubygems account the README will be updated.
+> Note: You will need a docker installed on your machine for that
+````

data/lib/xre/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Xre
-  VERSION = "0.5.2"
+  VERSION = "0.5.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: xre
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.4
 platform: x86_64-linux
 authors:
 - barseek
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-04-19 00:00:00.000000000 Z
+date: 2024-04-29 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -27,7 +27,6 @@ licenses:
 metadata:
   homepage_uri: https://github.com/vagab/xre
   source_code_uri: https://github.com/vagab/xre
-  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths: