xmldsig 0.0.1 → 0.0.2

data/README.md

@@ -58,11 +58,11 @@ end
 # Validation
 
 signed_document = Xmldsig::SignedDocument.new(signed_xml)
-document.verify(certificate)
+signed_document.verify(certificate)
 
 # With block
 signed_document = Xmldsig::SignedDocument.new(signed_xml)
-document.verify do |signature_value, data|
+signed_document.verify do |signature_value, data|
   certificate.public_key.verify(OpenSSL::Digest::SHA256.new, signature_value, data)
 end
 ```

data/lib/xmldsig/signature.rb

@@ -19,7 +19,7 @@ module Xmldsig
       if reference_uri && reference_uri != ""
         document.dup.at_xpath("//*[@ID='#{reference_uri[1..-1]}']")
       else
-        document.dup.at_xpath(signature.parent.path)
+        document.root
       end
     end
 
@@ -81,7 +81,7 @@ module Xmldsig
     end
 
     def digest_value=(digest_value)
-      signed_info.at_xpath("descendant::ds:DigestValue").content =
+      signed_info.at_xpath("descendant::ds:DigestValue", NAMESPACES).content =
           Base64.encode64(digest_value).chomp
     end
 
@@ -97,7 +97,7 @@ module Xmldsig
     end
 
     def signature_value=(signature_value)
-      signature.at_xpath("descendant::ds:SignatureValue").content =
+      signature.at_xpath("descendant::ds:SignatureValue", NAMESPACES).content =
           Base64.encode64(signature_value).chomp
     end
 

data/lib/xmldsig/version.rb

@@ -1,3 +1,3 @@
 module Xmldsig
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/fixtures/unsigned/with_soap_envelope.xml

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Body>
+    <samlp:ArtifactResponse xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:ec="http://www.w3.org/2001/10/xml-exc-c14n#" ID="_91e79cb2e8cded9a7fd4d68dc480b49d2d1adf88" Version="2.0" IssueInstant="2013-01-17T09:02:44Z">
+      <ds:Signature>
+        <ds:SignedInfo>
+          <ds:CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
+          <ds:SignatureMethod Algorithm="http://www.w3.org/2001/04/xmldsig-more#rsa-sha256"/>
+          <ds:Reference>
+            <ds:Transforms>
+              <ds:Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/>
+              <ds:Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#">
+                <ec:InclusiveNamespaces PrefixList="ds saml samlp xs"/>
+              </ds:Transform>
+            </ds:Transforms>
+            <ds:DigestMethod Algorithm="http://www.w3.org/2001/04/xmlenc#sha256"/>
+            <ds:DigestValue></ds:DigestValue>
+          </ds:Reference>
+        </ds:SignedInfo>
+        <ds:SignatureValue></ds:SignatureValue>
+        <ds:KeyInfo/>
+      </ds:Signature>
+      <samlp:Status>
+        <samlp:StatusCode/>
+      </samlp:Status>
+      <samlp:Response ID="_5a88b4aeb1d290c86073874278e5ef302da66739" Version="2.0" IssueInstant="2013-01-17T09:02:44Z">
+        <samlp:Status>
+          <samlp:StatusCode/>
+        </samlp:Status>
+      </samlp:Response>
+    </samlp:ArtifactResponse>
+  </soapenv:Body>
+</soapenv:Envelope>

data/spec/lib/xmldsig/signature_spec.rb

@@ -29,7 +29,7 @@ describe Xmldsig::Signature do
     it "returns the referenced node by parent" do
       signature.stub(:reference_uri).and_return("")
       signature.referenced_node.to_s.should ==
-          document.at_xpath("//*[@ID='foo']").to_s
+          document.root.to_s
     end
   end
 

data/spec/lib/xmldsig_spec.rb

@@ -5,17 +5,9 @@ describe Xmldsig do
   let(:certificate) { OpenSSL::X509::Certificate.new(File.read("spec/fixtures/certificate.cer")) }
 
   describe "Sign unsigned documents" do
-
-    %w(
-      canonicalizer_1_0
-      canonicalizer_1_1
-      canonicalizer_exc
-      digest_sha1
-      without_namespace_prefix
-      without_reference_uri
-    ).each do |document|
+    Dir["spec/fixtures/unsigned/*.xml"].each do |document|
       describe "#{document}" do
-        let(:unsigned_xml) { File.read("spec/fixtures/unsigned/#{document}.xml") }
+        let(:unsigned_xml) { File.read(document) }
         let(:unsigned_document) { Xmldsig::SignedDocument.new(unsigned_xml) }
 
         it "should be signable an validateable" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: xmldsig
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-13 00:00:00.000000000 Z
+date: 2013-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -60,6 +60,7 @@ files:
 - spec/fixtures/unsigned/canonicalizer_1_1.xml
 - spec/fixtures/unsigned/canonicalizer_exc.xml
 - spec/fixtures/unsigned/digest_sha1.xml
+- spec/fixtures/unsigned/with_soap_envelope.xml
 - spec/fixtures/unsigned/without_namespace_prefix.xml
 - spec/fixtures/unsigned/without_reference_uri.xml
 - spec/fixtures/unsigned_nested_signature.xml
@@ -68,7 +69,7 @@ files:
 - spec/lib/xmldsig/transforms/transform_spec.rb
 - spec/lib/xmldsig_spec.rb
 - spec/spec_helper.rb
-- xmlsec.gemspec
+- xmldsig.gemspec
 homepage: https://github.com/benoist/xmldsig
 licenses: []
 post_install_message: 
@@ -103,6 +104,7 @@ test_files:
 - spec/fixtures/unsigned/canonicalizer_1_1.xml
 - spec/fixtures/unsigned/canonicalizer_exc.xml
 - spec/fixtures/unsigned/digest_sha1.xml
+- spec/fixtures/unsigned/with_soap_envelope.xml
 - spec/fixtures/unsigned/without_namespace_prefix.xml
 - spec/fixtures/unsigned/without_reference_uri.xml
 - spec/fixtures/unsigned_nested_signature.xml