xliffer 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f2c02d93b1d9d6bab91e7f11acc68b009627647a
-  data.tar.gz: 47287acd5be0ca4262a2bdcfaf6e10f48ec0ce70
+  metadata.gz: 3c29a80258b1cfcf31ced1de9bd964236291e258
+  data.tar.gz: acea02334221f81e6aaf5f269991ca321ffc8261
 SHA512:
-  metadata.gz: f877905bc87525bd2771c8bd9f68ebfdf893147e73813ee8999f0c73636456d38e51aadca814874adf22bb5a34708600642e9e02e511ad4173f9cad28ea6040c
-  data.tar.gz: 3679c4fd443dd9c93788f758f55b09988ea31c252ff3a3dc75ad0e88676b59ab95575221ffca152fe95b3333cea82e9304bf19cb435bb164a59b7b848c1f21a4
+  metadata.gz: dab58fa8560313c44d35fd14c1959038c88668672331ca9617ed2039d008307ce97de5416fe1400557f6a608df78e9696f11d5ddab724793eeaf252daaa70ab4
+  data.tar.gz: 4b5567873006d671eaefb09e5a81efda623585754a21c67fed484068bd78ac6b03809435ce90ebacb66f93cb95e493b76b0e10e08bf3206443fa58da33d8947a

data/.rubocop.yml

@@ -0,0 +1,13 @@
+# This will acuse `expect {` from being bad style
+Style/BlockDelimiters:
+  Enabled: false
+
+# We support ruby 1.8
+Style/HashSyntax:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/ModuleLength:
+   Max: 250

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - "2.3.0"
   - "2.2.2"
   - "2.1.6"
   - "2.0.0"

data/Gemfile

@@ -1,11 +1,11 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
 
 gem 'nokogiri', '~> 1.5.10'
 gem 'equivalent-xml'
 
 group :test do
   unless RUBY_VERSION.match(/\A1\.8/)
-    gem "codeclimate-test-reporter", :require => false
+    gem 'codeclimate-test-reporter', :require => false
   end
 end
 

data/lib/xliffer/version.rb

@@ -1,3 +1,3 @@
 module XLIFFer
-  VERSION = "1.0.2"
+  VERSION = '1.0.3'
 end

data/lib/xliffer/xliff.rb

@@ -8,7 +8,7 @@ module XLIFFer
       text = case xliff
              when ::IO then xliff.read
              when ::String then xliff
-             else fail ArgumentError, "Expects an IO or String"
+             else fail ArgumentError, 'Expects an IO or String'
              end
 
       parse(text)
@@ -19,12 +19,13 @@ module XLIFFer
     end
 
     private
+
     def parse(text)
       @xml = Nokogiri::XML(text)
 
       @xml.remove_namespaces!
       root = @xml.xpath('/xliff')
-      raise FormatError, "Not a XLIFF file" unless root.any?
+      fail FormatError, 'Not a XLIFF file' unless root.any?
 
       @version = get_version(root)
       @files = parse_files(root)
@@ -36,12 +37,11 @@ module XLIFFer
     end
 
     def parse_files(root)
-      root.xpath('//file').map{|f| File.new(f)}
+      root.xpath('//file').map { |f| File.new(f) }
     end
 
     def self.xml_element?(xml)
-      xml.kind_of? Nokogiri::XML::Element
+      xml.is_a? Nokogiri::XML::Element
     end
-
   end
 end

data/lib/xliffer/xliff/file.rb

@@ -1,4 +1,3 @@
-require 'xliffer/xliff'
 require 'nokogiri'
 
 module XLIFFer
@@ -7,16 +6,16 @@ module XLIFFer
       attr_reader :source_language, :target_language, :original, :strings
       alias_method :file_name, :original
       def initialize(xml)
-        unless XLIFF::xml_element?(xml) and file?(xml)
-          raise ArgumentError, "can't create a File without a file subtree"
+        unless XLIFF.xml_element?(xml) && file?(xml)
+          fail ArgumentError, "can't create a File without a file subtree"
         end
 
         @xml = xml
 
-        @original = @xml.attr("original")
-        @source_language = @xml.attr("source-language")
-        @target_language = @xml.attr("target-language")
-        @strings = @xml.xpath('.//trans-unit').map{|tu| String.new(tu) }
+        @original = @xml.attr('original')
+        @source_language = @xml.attr('source-language')
+        @target_language = @xml.attr('target-language')
+        @strings = @xml.xpath('.//trans-unit').map { |tu| String.new(tu) }
       end
 
       def [](id)
@@ -36,10 +35,11 @@ module XLIFFer
         @target_language = val
         @xml['target-language'] = val
       end
+
       private
 
       def file?(xml)
-        xml.name.downcase == "file"
+        xml.name.downcase == 'file'
       end
     end
   end

data/lib/xliffer/xliff/string.rb

@@ -3,15 +3,16 @@ module XLIFFer
     class String
       attr_reader :id, :source, :target, :note
       def initialize(trans_unit_xml)
-        unless XLIFF::xml_element?(trans_unit_xml) and trans_unit?(trans_unit_xml)
-          raise ArgumentError, "can't create a String without a trans-unit subtree"
+        unless XLIFF.xml_element?(trans_unit_xml) && trans_unit?(trans_unit_xml)
+          error_message = "can't create a String without a trans-unit subtree"
+          fail ArgumentError, error_message
         end
 
         @xml = trans_unit_xml
         @id = @xml.attr('id')
-        @source = get_source
-        @target = get_target
-        @note   = get_note
+        @source = find_source
+        @target = find_target
+        @note   = find_note
       end
 
       def target=(val)
@@ -29,19 +30,25 @@ module XLIFFer
       private
 
       def trans_unit?(xml)
-        xml.name.downcase == "trans-unit"
+        xml.name.downcase == 'trans-unit'
       end
 
-      def get_source
-        sources = @xml.xpath("./source")
-        raise MultipleElement, "Should have only one source tag" if sources.size > 1
-        raise NoElement, "Should have one source tag" unless sources.size == 1
+      def find_source
+        sources = @xml.xpath('./source')
+        error_message = 'Should have only one source tag'
+        fail MultipleElement, error_message if sources.size > 1
+
+        error_message = 'Should have one source tag'
+        fail NoElement, error_message unless sources.size == 1
         sources.first.text
       end
 
-      def get_target
-        targets = @xml.xpath("./target")
-        raise MultipleElement, "Should have only one target tag" if targets.size > 1
+      def find_target
+        targets = @xml.xpath('./target')
+
+        error_message = 'Should have only one target tag'
+        fail MultipleElement, error_message if targets.size > 1
+
         if targets.empty?
           targets << Nokogiri::XML::Node.new('target', @xml)
           @xml.add_child(targets.first)
@@ -49,9 +56,10 @@ module XLIFFer
         targets.first.text
       end
 
-      def get_note
-        notes = @xml.xpath("./note")
-        raise MultipleElement, "Should have only one target tag" if notes.size > 1
+      def find_note
+        notes = @xml.xpath('./note')
+        error_message = 'Should have only one target tag'
+        fail MultipleElement, error_message if notes.size > 1
         notes.first ? notes.first.text : ''
       end
     end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 unless RUBY_VERSION.match(/\A1\.8/)
-  require "codeclimate-test-reporter"
+  require 'codeclimate-test-reporter'
   require 'simplecov'
   CodeClimate::TestReporter.start
   SimpleCov.start

data/spec/xliffer/file_spec.rb

@@ -3,78 +3,78 @@ require 'nokogiri'
 
 module XLIFFer
   describe XLIFF::File do
-    describe "#new" do
-      it "is created with a nokogiri file node" do
-        file_node = Nokogiri::XML.parse("<file></file>").xpath("/file").first
+    describe '#new' do
+      it 'is created with a nokogiri file node' do
+        file_node = Nokogiri::XML.parse('<file></file>').xpath('/file').first
         expect(XLIFF::File.new(file_node)).to be
       end
 
       it "can't be created with a string" do
-        expect{XLIFF::File.new("<file></file>")}.to raise_error ArgumentError
+        expect { XLIFF::File.new('<file></file>') }.to raise_error ArgumentError
       end
 
       it "can't be created with a node that is not a file node" do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("/xliff").first
-        expect{XLIFF::File.new(file_node)}.to raise_error ArgumentError
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        file_node = xml.xpath('/xliff').first
+        expect { XLIFF::File.new(file_node) }.to raise_error ArgumentError
       end
     end
 
-    describe "#original" do
-      it "is nil if not defined" do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
+    describe '#original' do
+      it 'is nil if not defined' do
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).original).to be nil
       end
 
-      it "is the original attribute on file tag" do
-        file_node = Nokogiri::XML.parse('<xliff><file original="neat file.c"></file></xliff>').xpath("//file").first
-        expect(XLIFF::File.new(file_node).original).to eql("neat file.c")
+      it 'is the original attribute on file tag' do
+        xml_text = '<xliff><file original="neat file.c"></file></xliff>'
+        xml = Nokogiri::XML.parse(xml_text)
+        file_node = xml.xpath('//file').first
+        expect(XLIFF::File.new(file_node).original).to eql('neat file.c')
       end
     end
 
-    describe "#original" do
-      it "is nil if not defined" do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
-        expect(XLIFF::File.new(file_node).original).to be nil
-      end
-
-      it "is the original attribute on file tag" do
-        file_node = Nokogiri::XML.parse('<xliff><file original="neat file.c"></file></xliff>').xpath("//file").first
-        expect(XLIFF::File.new(file_node).original).to eql("neat file.c")
-      end
-    end
-
-    describe "#source_language" do
-      it "is nil if not defined" do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
+    describe '#source_language' do
+      it 'is nil if not defined' do
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).source_language).to be nil
       end
 
-      it "is the original attribute on file tag" do
-        file_node = Nokogiri::XML.parse('<xliff><file source-language="en"></file></xliff>').xpath("//file").first
-        expect(XLIFF::File.new(file_node).source_language).to eql("en")
+      it 'is the original attribute on file tag' do
+        xml_text = '<xliff><file source-language="en"></file></xliff>'
+        xml = Nokogiri::XML.parse(xml_text)
+        file_node = xml.xpath('//file').first
+        expect(XLIFF::File.new(file_node).source_language).to eql('en')
       end
     end
 
-    describe "#target_language" do
-      it "is nil if not defined" do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
+    describe '#target_language' do
+      it 'is nil if not defined' do
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).target_language).to be nil
       end
 
-      it "is the original attribute on file tag" do
-        file_node = Nokogiri::XML.parse('<xliff><file target-language="fr"></file></xliff>').xpath("//file").first
-        expect(XLIFF::File.new(file_node).target_language).to eql("fr")
+      it 'is the original attribute on file tag' do
+        xml_text = '<xliff><file target-language="fr"></file></xliff>'
+        xml = Nokogiri::XML.parse(xml_text)
+        file_node = xml.xpath('//file').first
+        expect(XLIFF::File.new(file_node).target_language).to eql('fr')
       end
     end
 
-    describe "attribute accessors" do
+    describe 'attribute accessors' do
       let(:subject) do
-        XLIFF::File.new Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        XLIFF::File.new xml.xpath('//file').first
       end
 
-      describe "source_language=" do
-        it "changes the source language" do
-          file_node = Nokogiri::XML.parse('<xliff><file source-language="fr"></file></xliff>').xpath("//file").first
+      describe 'source_language=' do
+        it 'changes the source language' do
+          xml_text = '<xliff><file source-language="fr"></file></xliff>'
+          file_node = Nokogiri::XML.parse(xml_text).xpath('//file').first
           subject = XLIFF::File.new file_node
           subject.source_language = 'en'
           expect(subject.source_language).to eq('en')
@@ -86,9 +86,10 @@ module XLIFFer
         end
       end
 
-      describe "target_language=" do
-        it "changes the target language" do
-          file_node = Nokogiri::XML.parse('<xliff><file target-language="fr"></file></xliff>').xpath("//file").first
+      describe 'target_language=' do
+        it 'changes the target language' do
+          xml_text = '<xliff><file target-language="fr"></file></xliff>'
+          file_node = Nokogiri::XML.parse(xml_text).xpath('//file').first
           subject = XLIFF::File.new file_node
           subject.target_language = 'en'
           expect(subject.target_language).to eq('en')
@@ -101,7 +102,7 @@ module XLIFFer
       end
     end
 
-    describe "string accessors" do
+    describe 'string accessors' do
       let(:xml) do
         <<-EOF
         <file>
@@ -121,21 +122,21 @@ module XLIFFer
       end
 
       let(:subject) do
-        XLIFF::File.new(Nokogiri::XML.parse(xml).xpath("//file").first)
+        XLIFF::File.new(Nokogiri::XML.parse(xml).xpath('//file').first)
       end
 
-      describe "[]" do
-        it "gets the string with this id" do
-          expect(subject['hello'].target).to eq("Bonjour le monde")
+      describe '[]' do
+        it 'gets the string with this id' do
+          expect(subject['hello'].target).to eq('Bonjour le monde')
         end
 
-        it "returns nil if no string found" do
+        it 'returns nil if no string found' do
           expect(subject['non-existent id']).to be_nil
         end
       end
 
-      describe "[]=" do
-        it "changes the string target" do
+      describe '[]=' do
+        it 'changes the string target' do
           subject['hello'] = 'changed text'
           expect(subject['hello'].target).to eq('changed text')
         end
@@ -147,7 +148,7 @@ module XLIFFer
       end
     end
 
-    describe "#strings" do
+    describe '#strings' do
       let(:trans_unit) do
         <<-EOF
         <trans-unit id="my id">
@@ -156,23 +157,28 @@ module XLIFFer
         </trans-unit>
         EOF
       end
-      it "is an array " do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
+      it 'is an array ' do
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).strings).to be_kind_of(Array)
       end
 
-      it "can be empty" do
-        file_node = Nokogiri::XML.parse("<xliff><file></file></xliff>").xpath("//file").first
+      it 'can be empty' do
+        xml = Nokogiri::XML.parse('<xliff><file></file></xliff>')
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).strings).to be_empty
       end
 
-      it "should have a string" do
-        file_node = Nokogiri::XML.parse("<xliff><file>#{trans_unit}</file></xliff>").xpath("//file").first
+      it 'should have a string' do
+        xml = Nokogiri::XML.parse("<xliff><file>#{trans_unit}</file></xliff>")
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).strings.size).to eql(1)
       end
 
-      it "should have multiple strings" do
-        file_node = Nokogiri::XML.parse("<xliff><file>#{trans_unit * 10}</file></xliff>").xpath("//file").first
+      it 'should have multiple strings' do
+        xml_text = "<xliff><file>#{trans_unit * 10}</file></xliff>"
+        xml = Nokogiri::XML.parse(xml_text)
+        file_node = xml.xpath('//file').first
         expect(XLIFF::File.new(file_node).strings.size).to eql(10)
       end
     end

data/spec/xliffer/string_spec.rb

@@ -12,57 +12,76 @@ module XLIFFer
       EOF
     end
 
-    describe "#new" do
-      it "is created with a nokogiri trans-unit node" do
-        trans_unit_node = Nokogiri::XML.parse(trans_unit).xpath("//trans-unit").first
+    let(:xml) do
+      Nokogiri::XML.parse(trans_unit)
+    end
+
+    describe '#new' do
+      it 'is created with a nokogiri trans-unit node' do
+        trans_unit_node = xml.xpath('//trans-unit').first
         expect(XLIFF::String.new(trans_unit_node)).to be
       end
 
       it "can't be created with a string" do
-        expect{XLIFF::String.new("<file></file>")}.to raise_error ArgumentError
+        expect {
+          XLIFF::String.new('<file></file>')
+        }.to raise_error ArgumentError
       end
 
       it "can't be created with a node that is not a file node" do
-        trans_unit_node = Nokogiri::XML.parse("<xliff></xliff>").xpath("/xliff").first
-        expect{XLIFF::String.new(trans_unit_node)}.to raise_error ArgumentError
+        xml = Nokogiri::XML.parse('<xliff></xliff>')
+        trans_unit_node = xml.xpath('/xliff').first
+        expect {
+          XLIFF::String.new(trans_unit_node)
+        }.to raise_error ArgumentError
       end
 
-      it "have one source" do
-        xml = "<trans-unit><target></target></trans-unit>"
-        trans_unit_node = Nokogiri::XML.parse(xml).xpath("//trans-unit").first
-        expect{XLIFF::String.new(trans_unit_node)}.to raise_error NoElement
+      it 'have one source' do
+        xml = '<trans-unit><target></target></trans-unit>'
+        trans_unit_node = Nokogiri::XML.parse(xml).xpath('//trans-unit').first
+        expect { XLIFF::String.new(trans_unit_node) }.to raise_error NoElement
       end
 
       it "don't have multiple sources tag" do
-        xml = "<trans-unit>#{"<source></source>"*2}<target></target></trans-unit>"
-        trans_unit_node = Nokogiri::XML.parse(xml).xpath("//trans-unit").first
-        expect{XLIFF::String.new(trans_unit_node)}.to raise_error MultipleElement
+        xml = '<trans-unit>'
+        xml += "#{'<source></source>' * 2}<target></target>"
+        xml += '</trans-unit>'
+        trans_unit_node = Nokogiri::XML.parse(xml).xpath('//trans-unit').first
+        expect {
+          XLIFF::String.new(trans_unit_node)
+        }.to raise_error MultipleElement
       end
 
       it "don't have multiple targets tag" do
-        xml = "<trans-unit><source></source>#{"<target></target>"*2}</trans-unit>"
-        trans_unit_node = Nokogiri::XML.parse(xml).xpath("//trans-unit").first
-        expect{XLIFF::String.new(trans_unit_node)}.to raise_error MultipleElement
+        xml = '<trans-unit>'
+        xml += "<source></source>#{'<target></target>' * 2}"
+        xml += '</trans-unit>'
+        trans_unit_node = Nokogiri::XML.parse(xml).xpath('//trans-unit').first
+        expect {
+          XLIFF::String.new(trans_unit_node)
+        }.to raise_error MultipleElement
       end
     end
 
-    describe "#id" do
-      it "is nil if not defined" do
-        xml = "<trans-unit><source></source><target></target></trans-unit>"
-        trans_unit_node = Nokogiri::XML.parse(xml).xpath("//trans-unit").first
+    describe '#id' do
+      it 'is nil if not defined' do
+        xml = '<trans-unit><source></source><target></target></trans-unit>'
+        trans_unit_node = Nokogiri::XML.parse(xml).xpath('//trans-unit').first
         expect(XLIFF::String.new(trans_unit_node).id).to be nil
       end
 
-      it "is the id attribute on trans-unit tag" do
-        xml = "<trans-unit id='my id'><source></source><target></target></trans-unit>"
-        trans_unit_node = Nokogiri::XML.parse(xml).xpath("//trans-unit").first
-        expect(XLIFF::String.new(trans_unit_node).id).to eql("my id")
+      it 'is the id attribute on trans-unit tag' do
+        xml = "<trans-unit id='my id'>"
+        xml += '<source></source><target></target>'
+        xml += '</trans-unit>'
+        trans_unit_node = Nokogiri::XML.parse(xml).xpath('//trans-unit').first
+        expect(XLIFF::String.new(trans_unit_node).id).to eql('my id')
       end
     end
 
-    describe "#target=" do
+    describe '#target=' do
       it 'Modify target' do
-        trans_unit_node = Nokogiri::XML.parse(trans_unit).xpath("//trans-unit").first
+        trans_unit_node = xml.xpath('//trans-unit').first
         string = XLIFF::String.new(trans_unit_node)
         string.target = 'Hola Mundo'
         expect(string.target).to eq 'Hola Mundo'
@@ -71,7 +90,7 @@ module XLIFFer
       context 'when target do not exist' do
         it 'add a new target' do
           xml = "<trans-unit id='my id'><source>Value</source></trans-unit>"
-          trans_unit_node = Nokogiri::XML.parse(xml).xpath("//trans-unit").first
+          trans_unit_node = Nokogiri::XML.parse(xml).xpath('//trans-unit').first
           string = XLIFF::String.new(trans_unit_node)
           string.target = 'Hola Mundo'
           expect(string.target).to eq 'Hola Mundo'
@@ -79,9 +98,9 @@ module XLIFFer
       end
     end
 
-    describe "#source=" do
+    describe '#source=' do
       it 'Modify source' do
-        trans_unit_node = Nokogiri::XML.parse(trans_unit).xpath("//trans-unit").first
+        trans_unit_node = xml.xpath('//trans-unit').first
         string = XLIFF::String.new(trans_unit_node)
         string.source = 'Hola Mundo'
         expect(string.source).to eq 'Hola Mundo'

data/spec/xliffer/xliff_spec.rb

@@ -2,70 +2,82 @@ require 'spec_helper'
 
 module XLIFFer
   describe XLIFF do
-    describe "#new" do
-      it "accepts a xliff file" do
-        expect(XLIFF.new(::File.open("spec/files/empty.xliff"))).to be
+    describe '#new' do
+      it 'accepts a xliff file' do
+        expect(XLIFF.new(::File.open('spec/files/empty.xliff'))).to be
       end
 
-      it "accepts a xliff string" do
-        expect(XLIFF.new(::File.open("spec/files/empty.xliff").read)).to be
+      it 'accepts a xliff string' do
+        expect(XLIFF.new(::File.open('spec/files/empty.xliff').read)).to be
       end
 
       it "doesn't accept a number" do
-        expect{XLIFF.new(123)}.to raise_error ArgumentError
+        expect { XLIFF.new(123) }.to raise_error ArgumentError
       end
 
       it "doesn't accept a random string" do
-        expect{XLIFF.new("foobar")}.to raise_error FormatError
+        expect { XLIFF.new('foobar') }.to raise_error FormatError
       end
 
       it "doesn't accept a random file" do
-        expect{XLIFF.new(::File.new("spec/files/file.foobar"))}.to raise_error FormatError
+        expect {
+          XLIFF.new(::File.new('spec/files/file.foobar'))
+        }.to raise_error FormatError
       end
     end
 
-    describe "#version" do
-      it "is the xliff version" do
-        expect(XLIFF.new('<xliff version="9.8"></xliff>').version).to eql("9.8")
+    describe '#version' do
+      it 'is the xliff version' do
+        expect(
+          XLIFF.new('<xliff version="9.8"></xliff>').version
+        ).to eql('9.8')
       end
 
-      it "is nil when it is not present" do
+      it 'is nil when it is not present' do
         expect(XLIFF.new('<xliff></xliff>').version).to be_nil
       end
 
-      it "is a string when there is a xliff version" do
-        expect(XLIFF.new('<xliff version="9.8"></xliff>').version).to be_kind_of(String)
+      it 'is a string when there is a xliff version' do
+        expect(
+          XLIFF.new('<xliff version="9.8"></xliff>').version
+        ).to be_kind_of(String)
       end
     end
 
-    describe "#files" do
-      it "is an array " do
-        expect(XLIFF.new('<xliff></xliff>').files).to be_kind_of(Array)
+    describe '#files' do
+      it 'is an array ' do
+        expect(
+          XLIFF.new('<xliff></xliff>').files
+        ).to be_kind_of(Array)
       end
 
-      it "can be empty" do
+      it 'can be empty' do
         expect(XLIFF.new('<xliff></xliff>').files).to be_empty
       end
 
-      it "should have a file" do
-        expect(XLIFF.new('<xliff><file></file></xliff>').files.first).to be_kind_of(XLIFF::File)
+      it 'should have a file' do
+        expect(
+          XLIFF.new('<xliff><file></file></xliff>').files.first
+        ).to be_kind_of(XLIFF::File)
       end
 
-      it "should have multiple files" do
-        expect(XLIFF.new('<xliff><file></file><file></file></xliff>').files.size).to eql(2)
+      it 'should have multiple files' do
+        expect(
+          XLIFF.new('<xliff><file></file><file></file></xliff>').files.size
+        ).to eql(2)
       end
     end
 
-    describe "#to_s" do
+    describe '#to_s' do
       it 'outputs a xml' do
-        xml = ::File.open("spec/files/simple.xliff").read
+        xml = ::File.open('spec/files/simple.xliff').read
         xliff = XLIFF.new(xml)
         expect(Nokogiri::XML(xliff.to_s)).to be
       end
 
       context 'when xml is not changed' do
         it 'outputs the same xml' do
-          xml = ::File.open("spec/files/simple.xliff").read
+          xml = ::File.open('spec/files/simple.xliff').read
           xliff = XLIFF.new(xml)
           expect(xliff.to_s).to be_equivalent_to(xml)
         end
@@ -73,9 +85,9 @@ module XLIFFer
 
       context 'when xml is changed' do
         it 'outputs a different xml' do
-          xml = ::File.open("spec/files/simple.xliff").read
+          xml = ::File.open('spec/files/simple.xliff').read
           xliff = XLIFF.new(xml)
-          xliff.files.first.strings.first.target = "My brand new target"
+          xliff.files.first.strings.first.target = 'My brand new target'
           expect(xliff.to_s).not_to be_equivalent_to(xml)
         end
       end

data/xliffer.gemspec

@@ -1,27 +1,29 @@
-$:.push File.expand_path("../lib", __FILE__)
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
 require 'xliffer/version'
 
 Gem::Specification.new do |s|
   s.name        = 'xliffer'
   s.version     = XLIFFer::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.licenses   = ["MIT"]
+  s.licenses = ['MIT']
   s.date        = '2012-01-01'
-  s.summary     = "A XLIFF parser"
-  s.description = "A parser for XLIFF files"
-  s.authors     = ["Felipe Tanus"]
+  s.summary     = 'A XLIFF parser'
+  s.description = 'A parser for XLIFF files'
+  s.authors     = ['Felipe Tanus']
   s.email       = 'fotanus@gmail.com'
   s.homepage    = 'http://github.com/fotanus/xliff'
 
-  s.add_dependency "nokogiri", "~> 1.5"
+  s.add_dependency 'nokogiri', '~> 1.5'
 
-  s.add_development_dependency "rspec", "~> 2"
-  s.add_development_dependency "simplecov", "~> 0.10"
+  s.add_development_dependency 'rspec', '~> 2'
+  s.add_development_dependency 'simplecov', '~> 0.10'
 
-  s.rubyforge_project = "xliffer"
+  s.rubyforge_project = 'xliffer'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.executables   = `git ls-files -- bin/*`.split("\n").map do |f|
+    File.basename(f)
+  end
+  s.require_paths = ['lib']
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: xliffer
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Felipe Tanus
@@ -60,6 +60,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.md
@@ -102,8 +103,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: xliffer
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A XLIFF parser
 test_files: []
+has_rdoc: