xing-backend 0.0.16 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5e09d2b2bea8388051e9e89f57f8288e5781434
-  data.tar.gz: 44cc296801fd1915cdf22f3a747569f24b29ff97
+  metadata.gz: 13ae26abbc1ee9f7bd2d9afae55849632ec9ffa1
+  data.tar.gz: 0df9f7c564139946b873e56001df974a965882e1
 SHA512:
-  metadata.gz: 856cd6bfe88478f7cdf77396e0062d4ab0d78f0b526ec0394f91e5c27611113477eba27e4cbc99b4e2f7489a7553b68dfbc22fd4624bb28695da3387d8356c2d
-  data.tar.gz: 82d3a6b115af69c879839592f40f3d7941b47553fb29f3cfe482fe5d531c421fc9fffe27b71a1339c756f457fe640107701b4ecd85add6f9e6250c807f881b0f
+  metadata.gz: afc9e88098caf477eb19c55272412bad43f175f17bd28cd37c8d665662463db8d88a040076899dc45cc129159e34d7fd37804a8dc9e307e158dd526ea2a4422a
+  data.tar.gz: 018e22b3a6705f22c97949ef6bdfeb1c1812fe3b5384061fb21a66c0cd819a72149e4c5eaeeea465366e72d93e5d039acf9d8723ecc8271735636482aa1928eb

data/lib/deprecated_classes.rb

@@ -8,8 +8,7 @@ module Xing
     :ResourcesSerializer       => Xing::Serializers::RootResources,
     :JsonTreeLister            => Xing::Services::JsonTreeLister,
     :ActiveModelErrorConverter => Xing::Services::ErrorConverter,
-    :RemoteSnapshotFetcher     => Xing::Services::SnapshotFetcher,
-    :ListDifferenceBuilder     => Xing::Builders::OrderedListDifferenceBuilder
+    :RemoteSnapshotFetcher     => Xing::Services::SnapshotFetcher
   }
 end
 

data/lib/xing/builders.rb

@@ -3,5 +3,5 @@ module Xing
   end
 end
 
-require 'xing/builders/list_difference_builder'
-require 'xing/builders/ordered_list_difference_builder'
+require 'xing/builders/list_builder'
+require 'xing/builders/ordered_list_builder'

data/lib/xing/builders/list_builder.rb

@@ -0,0 +1,42 @@
+require 'xing/services/locator'
+
+module Xing
+  module Builders
+    class ListBuilder
+      include Services::Locator
+
+      # list_data is is an array of JSON objects passed in by the mapper (the new list of records)
+      def initialize(list_data, mapper_class)
+        @list_data = list_data
+        @mapper_class = mapper_class
+
+        @errors = Hash.new { |hash, key| hash[key] = {} }
+      end
+
+      attr_reader :errors
+
+      def locator_for(data)
+        route_to(data[:links][:self])[:id].to_i unless (data[:links] || {})[:self].blank?
+      end
+
+      def build
+        @new_list = []
+        @list_data.each_with_index do |data, index|
+
+          mapper = @mapper_class.new(data, locator_for(data))
+
+          mapper.perform_mapping
+          set_position(mapper.record, index)
+
+          @new_list << mapper.record
+          @errors[index] = mapper.errors[:data] unless mapper.errors[:data].blank?
+        end
+        @new_list
+      end
+
+      def set_position(record, index)
+        # position is not set in list builder
+      end
+    end
+  end
+end

data/lib/xing/builders/ordered_list_builder.rb

@@ -0,0 +1,9 @@
+module Xing
+  module Builders
+    class OrderedListBuilder < ListBuilder
+      def set_position(record, index)
+        record.position = index if record.has_attribute?(:position)
+      end
+    end
+  end
+end

data/spec/xing/builders/list_builder_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe Xing::Builders::ListBuilder do
+
+  let :builder do
+    Xing::Builders::ListBuilder.new(list_data, mapper_class)
+  end
+
+  let :mapper_class do
+    double("ItemMapper")
+  end
+
+  let :mapper_instance do
+    double("mapper")
+  end
+
+  let :new_ar_object do
+    double("New Relation AR Object")
+  end
+
+  let :updated_ar_object do
+    double("Updated AR Object")
+  end
+
+  let :list_data do
+    [
+      {
+        links: {
+          self: "/somethings/1"
+        },
+        data: {
+          stuff: "some updated stuff"
+        }
+      },
+      {
+        links: {
+          self: ""
+        },
+        data: {
+          stuff: "some new stuff"
+        }
+      }
+    ]
+  end
+
+  it "initialize" do
+    expect(builder.instance_variable_get('@list_data')).to eq(list_data)
+    expect(builder.instance_variable_get('@mapper_class')).to eq(mapper_class)
+    expect(builder.instance_variable_get('@errors')).to eq({})
+  end
+
+  describe "#build" do
+    before :each do
+      allow(builder).to receive(:locator_for).and_return(1)
+      allow(mapper_class).to receive(:new).with(list_data[0], 1).and_return(mapper_instance)
+      allow(mapper_class).to receive(:new).with(list_data[1], 1).and_return(mapper_instance)
+      allow(mapper_instance).to receive(:record).and_return(new_ar_object, new_ar_object, updated_ar_object, updated_ar_object)
+      allow(mapper_instance).to receive(:perform_mapping)
+      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
+      allow(updated_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
+    end
+
+    context "successful" do
+      before :each do
+        allow(mapper_instance).to receive(:errors).and_return({})
+      end
+
+      it "should return array of AR records" do
+        expect(builder.build).to match_array([new_ar_object, updated_ar_object])
+      end
+    end
+
+    context "with errors" do
+      before :each do
+        allow(mapper_instance).to receive(:errors).and_return({data: {type: "I would do anything for love", message: "but I won't do that"}}, {data: {type: "I would do anything for love", message: "but I won't do that"}}, {})
+        builder.build
+      end
+
+      it "should return errors" do
+        expect(builder.errors).to eq({0=>{:type=>"I would do anything for love", :message=>"but I won't do that"}})
+      end
+    end
+  end
+end

data/spec/xing/builders/ordered_list_builder_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe Xing::Builders::OrderedListBuilder do
+
+  let :builder do
+    Xing::Builders::OrderedListBuilder.new(list_data, mapper_class)
+  end
+
+  let :mapper_class do
+    double("ItemMapper")
+  end
+
+  let :mapper_instance do
+    double("mapper")
+  end
+
+  let :new_ar_object do
+    double("New Relation AR Object")
+  end
+
+  let :updated_ar_object do
+    double("Updated AR Object")
+  end
+
+  let :list_data do
+    [
+      {
+        links: {
+          self: "/somethings/1"
+        },
+        data: {
+          stuff: "some updated stuff"
+        }
+      },
+      {
+        links: {
+          self: ""
+        },
+        data: {
+          stuff: "some new stuff"
+        }
+      }
+    ]
+  end
+
+  it "initialize" do
+    expect(builder.instance_variable_get('@list_data')).to eq(list_data)
+    expect(builder.instance_variable_get('@mapper_class')).to eq(mapper_class)
+    expect(builder.instance_variable_get('@errors')).to eq({})
+  end
+
+  describe "#set_position" do
+
+    it "should update the position if the record has a position attribute" do
+      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(true)
+      expect(new_ar_object).to receive(:position=).with(1)
+
+      builder.set_position(new_ar_object, 1)
+    end
+
+    it "should not blow up if the record does not have a position attribute" do
+      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
+      expect(new_ar_object).to_not receive(:position=)
+
+      builder.set_position(new_ar_object, 1)
+    end
+  end
+
+  describe "#build" do
+    before :each do
+      allow(builder).to receive(:locator_for).and_return(1)
+      allow(mapper_class).to receive(:new).with(list_data[0], 1).and_return(mapper_instance)
+      allow(mapper_class).to receive(:new).with(list_data[1], 1).and_return(mapper_instance)
+      allow(mapper_instance).to receive(:record).and_return(new_ar_object, new_ar_object, updated_ar_object, updated_ar_object)
+      allow(mapper_instance).to receive(:perform_mapping)
+      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
+      allow(updated_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
+    end
+
+    context "successful" do
+      before :each do
+        allow(mapper_instance).to receive(:errors).and_return({})
+      end
+
+      it "should return array of AR records" do
+        expect(builder.build).to match_array([new_ar_object, updated_ar_object])
+      end
+    end
+
+    context "with errors" do
+      before :each do
+        allow(mapper_instance).to receive(:errors).and_return({data: {type: "I would do anything for love", message: "but I won't do that"}}, {data: {type: "I would do anything for love", message: "but I won't do that"}}, {})
+        builder.build
+      end
+
+      it "should return errors" do
+        expect(builder.errors).to eq({0=>{:type=>"I would do anything for love", :message=>"but I won't do that"}})
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: xing-backend
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.17
 platform: ruby
 authors:
 - Evan Dorn
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-29 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -126,8 +126,8 @@ files:
 - lib/deprecated_classes.rb
 - lib/xing-backend.rb
 - lib/xing/builders.rb
-- lib/xing/builders/list_difference_builder.rb
-- lib/xing/builders/ordered_list_difference_builder.rb
+- lib/xing/builders/list_builder.rb
+- lib/xing/builders/ordered_list_builder.rb
 - lib/xing/controllers/base.rb
 - lib/xing/controllers/root_resources_controller.rb
 - lib/xing/engine.rb
@@ -148,11 +148,10 @@ files:
 - spec/deprecated_classes/base_serializer_spec.rb
 - spec/deprecated_classes/hypermedia_json_mapper_spec.rb
 - spec/deprecated_classes/json_tree_lister_spec.rb
-- spec/deprecated_classes/list_difference_builder_spec.rb
 - spec/deprecated_classes/remote_snapshot_fetcher_spec.rb
 - spec/deprecated_classes/resources_serializer_spec.rb
-- spec/xing/builders/list_difference_builder_spec.rb
-- spec/xing/builders/ordered_list_difference_builder_spec.rb
+- spec/xing/builders/list_builder_spec.rb
+- spec/xing/builders/ordered_list_builder_spec.rb
 - spec/xing/controllers/base_spec.rb
 - spec/xing/controllers/root_resources_controller_spec.rb
 - spec/xing/mappers/base_spec.rb
@@ -208,7 +207,7 @@ rdoc_options:
 - "--main"
 - doc/README
 - "--title"
-- xing-backend-0.0.16 Documentation
+- xing-backend-0.0.17 Documentation
 require_paths:
 - lib/
 required_ruby_version: !ruby/object:Gem::Requirement

data/lib/xing/builders/list_difference_builder.rb

@@ -1,61 +0,0 @@
-require 'xing/services/locator'
-
-module Xing
-  module Builders
-    class ListDifferenceBuilder
-      include Services::Locator
-
-      # list_data is is an array of JSON objects passed in by the mapper (the new list of records)
-      # collection is the ActiveRecord collection of existing records (i.e. person.pets, rainbow.colors, book.chapters)
-      def initialize(list_data, collection, mapper_class)
-        @list_data = list_data
-        @collection = collection
-        @mapper_class = mapper_class
-
-        @errors = Hash.new { |hash, key| hash[key] = {} }
-      end
-
-      attr_reader :errors
-
-      def build
-        sort_json_items
-        map_items
-
-        { save: @new_list, delete: @delete_ids }
-      end
-
-      def sort_json_items
-        @existing_ids = @collection.map{|item| item.send(@mapper_class.locator_attribute_name)}
-
-        @list_data = @list_data.map do |data|
-          { :locator => set_locator(data), :incoming => data}
-        end
-
-        @delete_ids = @existing_ids - @list_data.map { |item| item[:locator] }
-      end
-
-      def set_locator(data)
-        locator_for(data) unless (data[:links] || {})[:self].blank?
-      end
-
-      def locator_for(data)
-       route_to(data[:links][:self])[:id].to_i
-      end
-
-      def map_items
-        @new_list = []
-        @list_data.each_with_index do |item, index|
-
-          mapper = @mapper_class.new(item[:incoming], item[:locator])
-
-          # Sets association, attributes
-          @collection << mapper.record
-          mapper.perform_mapping
-
-          @new_list << mapper
-          @errors[index] = mapper.errors[:data] unless mapper.errors[:data].blank?
-        end
-      end
-    end
-  end
-end

data/lib/xing/builders/ordered_list_difference_builder.rb

@@ -1,25 +0,0 @@
-module Xing
-  module Builders
-    class OrderedListDifferenceBuilder < ListDifferenceBuilder
-      def map_items
-        @new_list = []
-        @list_data.each_with_index do |item, index|
-
-          mapper = @mapper_class.new(item[:incoming], item[:locator])
-
-          # Sets association, attributes and position
-          @collection << mapper.record
-          mapper.perform_mapping
-          set_position(mapper.record, index)
-
-          @new_list << mapper
-          @errors[index] = mapper.errors[:data] unless mapper.errors[:data].blank?
-        end
-      end
-
-      def set_position(record, index)
-         record.position = index if record.has_attribute?(:position)
-      end
-    end
-  end
-end

data/spec/deprecated_classes/list_difference_builder_spec.rb

@@ -1,19 +0,0 @@
-require 'deprecated_classes'
-
-describe ListDifferenceBuilder, :type => :deprecation do
-  let :list_data do
-    double('list_data')
-  end
-
-  let :collection do
-    double('many.things')
-  end
-
-  let :mapper do
-    double('ThingMapper')
-  end
-
-  it "should be the correct class" do
-    expect(ListDifferenceBuilder.new(list_data, collection, mapper)).to be_a(Xing::Builders::OrderedListDifferenceBuilder)
-  end
-end

data/spec/xing/builders/list_difference_builder_spec.rb

@@ -1,193 +0,0 @@
-require 'spec_helper'
-
-describe Xing::Builders::ListDifferenceBuilder do
-
-  let :builder do
-    Xing::Builders::ListDifferenceBuilder.new(list_data, collection, mapper_class)
-  end
-
-  let :mapper_class do
-    double("ItemMapper")
-  end
-
-  let :mapper_instance do
-    double("mapper")
-  end
-
-  let :collection do
-    [double("Relation AR Object id: 1"), double("Relation AR Object id: 2"), double("Relation AR Object id: 3")]
-  end
-
-  let :new_ar_object do
-    double("New Relation AR Object")
-  end
-
-  let :updated_ar_object do
-    double("Updated AR Object")
-  end
-
-  let :existing_ids do
-    [1,2,3]
-  end
-
-  let :list_data do
-    [
-      {
-        links: {
-          self: "/somethings/1"
-        },
-        data: {
-          stuff: "some updated stuff"
-        }
-      },
-      {
-        links: {
-          self: ""
-        },
-        data: {
-          stuff: "some new stuff"
-        }
-      }
-    ]
-  end
-
-  let :new_list_data do
-    [
-      {
-        locator: 1,
-        incoming: {
-          links: {
-            self: "/somethings/1"
-          },
-          data: {
-            stuff: "some updated stuff"
-          }
-        }
-      },
-      {
-        locator: nil,
-        incoming: {
-          links: {
-            self: ""
-          },
-          data: {
-            stuff: "some new stuff"
-          }
-        }
-      }
-    ]
-  end
-
-  it "should initialize and assign list_data, collection, mapper class and errors" do
-    expect(builder.instance_variable_get('@list_data')).to eq(list_data)
-    expect(builder.instance_variable_get('@collection')).to eq(collection)
-    expect(builder.instance_variable_get('@mapper_class')).to eq(mapper_class)
-    expect(builder.instance_variable_get('@errors')).to eq({})
-  end
-
-  describe "#sort_json_items" do
-    before :each do
-      allow(collection).to receive(:map).and_return(existing_ids)
-      allow(builder).to receive(:locator_for).and_return(1)
-      builder.sort_json_items
-    end
-
-    it "should create a list of existing ids" do
-      expect(builder.instance_variable_get('@existing_ids')).to eq(existing_ids)
-    end
-
-    it "should insert index and locator into the item data" do
-      expect(builder.instance_variable_get('@list_data')).to eq(new_list_data)
-    end
-
-    it "should find the ids to delete" do
-      expect(builder.instance_variable_get('@delete_ids')).to eq([2,3])
-    end
-  end
-
-  describe "#set_locator" do
-
-    it "should be nil if links is empty" do
-      data = { links: {}, data: { text:"bs" } }
-      expect(builder.set_locator(data)).to be_nil
-    end
-
-    it "should be nil if links/self is empty" do
-      data = { links: {self: ""}}
-      expect(builder.set_locator(data)).to be_nil
-    end
-
-    it "should set locator if links/self is present" do
-      data = { links: {self: "some_link/1/something"}}
-      allow(builder).to receive(:locator_for).and_return(1)
-
-      expect(builder.set_locator(data)).to eq(1)
-    end
-  end
-
-  describe "#map_items" do
-    before :each do
-      builder.instance_variable_set('@list_data', new_list_data)
-      allow(mapper_class).to receive(:new).and_return(mapper_instance)
-      allow(mapper_instance).to receive(:record).and_return(new_ar_object, new_ar_object, updated_ar_object, updated_ar_object)
-      allow(mapper_instance).to receive(:perform_mapping)
-      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-      allow(updated_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-    end
-
-    context "successful" do
-      it "should create a new ar list" do
-        allow(mapper_instance).to receive(:errors).and_return({})
-        builder.map_items
-
-        expect(builder.instance_variable_get('@new_list')).to match_array([mapper_instance, mapper_instance])
-      end
-    end
-
-    context "with errors" do
-      it "should add to the error hash with the correct index" do
-        allow(mapper_instance).to receive(:errors).and_return({}, {data: {type: "I would do anything for love", message: "but I won't do that"}}, {data: {type: "I would do anything for love", message: "but I won't do that"}})
-        builder.map_items
-
-        expect(builder.instance_variable_get('@errors')).to eq({1=>{:type=>"I would do anything for love", :message=>"but I won't do that"}})
-      end
-    end
-  end
-
-  describe "#build" do
-    before :each do
-      allow(collection).to receive(:map).and_return(existing_ids)
-      allow(builder).to receive(:locator_for).and_return(1)
-      allow(mapper_class).to receive(:new).and_return(mapper_instance)
-      allow(mapper_instance).to receive(:record).and_return(new_ar_object, new_ar_object, updated_ar_object, updated_ar_object)
-      allow(mapper_instance).to receive(:perform_mapping)
-      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-      allow(updated_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-    end
-
-    context "successful" do
-      before :each do
-        allow(mapper_instance).to receive(:errors).and_return({})
-      end
-
-      it "should return a hash with save keys" do
-        expect(builder.build[:save]).to match_array([mapper_instance, mapper_instance])
-      end
-
-      it "should return a hash with delete keys" do
-        expect(builder.build[:delete]).to match_array([2,3])
-      end
-    end
-
-    context "with errors" do
-      before :each do
-        allow(mapper_instance).to receive(:errors).and_return({data: {type: "I would do anything for love", message: "but I won't do that"}}, {data: {type: "I would do anything for love", message: "but I won't do that"}}, {})
-        builder.build
-      end
-
-      it "should return errors" do
-        expect(builder.errors).to eq({0=>{:type=>"I would do anything for love", :message=>"but I won't do that"}})
-      end
-    end
-  end
-end

data/spec/xing/builders/ordered_list_difference_builder_spec.rb

@@ -1,210 +0,0 @@
-require 'spec_helper'
-
-describe Xing::Builders::OrderedListDifferenceBuilder do
-
-  let :builder do
-    Xing::Builders::OrderedListDifferenceBuilder.new(list_data, collection, mapper_class)
-  end
-
-  let :mapper_class do
-    double("ItemMapper")
-  end
-
-  let :mapper_instance do
-    double("mapper")
-  end
-
-  let :collection do
-    [double("Relation AR Object id: 1"), double("Relation AR Object id: 2"), double("Relation AR Object id: 3")]
-  end
-
-  let :new_ar_object do
-    double("New Relation AR Object")
-  end
-
-  let :updated_ar_object do
-    double("Updated AR Object")
-  end
-
-  let :existing_ids do
-    [1,2,3]
-  end
-
-  let :list_data do
-    [
-      {
-        links: {
-          self: "/somethings/1"
-        },
-        data: {
-          stuff: "some updated stuff"
-        }
-      },
-      {
-        links: {
-          self: ""
-        },
-        data: {
-          stuff: "some new stuff"
-        }
-      }
-    ]
-  end
-
-  let :new_list_data do
-    [
-      {
-        locator: 1,
-        incoming: {
-          links: {
-            self: "/somethings/1"
-          },
-          data: {
-            stuff: "some updated stuff"
-          }
-        }
-      },
-      {
-        locator: nil,
-        incoming: {
-          links: {
-            self: ""
-          },
-          data: {
-            stuff: "some new stuff"
-          }
-        }
-      }
-    ]
-  end
-
-  it "should initialize and assign list_data, collection, mapper class and errors" do
-    expect(builder.instance_variable_get('@list_data')).to eq(list_data)
-    expect(builder.instance_variable_get('@collection')).to eq(collection)
-    expect(builder.instance_variable_get('@mapper_class')).to eq(mapper_class)
-    expect(builder.instance_variable_get('@errors')).to eq({})
-  end
-
-  describe "#sort_json_items" do
-    before :each do
-      allow(collection).to receive(:map).and_return(existing_ids)
-      allow(builder).to receive(:locator_for).and_return(1)
-      builder.sort_json_items
-    end
-
-    it "should create a list of existing ids" do
-      expect(builder.instance_variable_get('@existing_ids')).to eq(existing_ids)
-    end
-
-    it "should insert index and locator into the item data" do
-      expect(builder.instance_variable_get('@list_data')).to eq(new_list_data)
-    end
-
-    it "should find the ids to delete" do
-      expect(builder.instance_variable_get('@delete_ids')).to eq([2,3])
-    end
-  end
-
-  describe "#set_locator" do
-
-    it "should be nil if links is empty" do
-      data = { links: {}, data: { text:"bs" } }
-      expect(builder.set_locator(data)).to be_nil
-    end
-
-    it "should be nil if links/self is empty" do
-      data = { links: {self: ""}}
-      expect(builder.set_locator(data)).to be_nil
-    end
-
-    it "should set locator if links/self is present" do
-      data = { links: {self: "some_link/1/something"}}
-      allow(builder).to receive(:locator_for).and_return(1)
-
-      expect(builder.set_locator(data)).to eq(1)
-    end
-  end
-
-  describe "#map_items" do
-    before :each do
-      builder.instance_variable_set('@list_data', new_list_data)
-      allow(mapper_class).to receive(:new).and_return(mapper_instance)
-      allow(mapper_instance).to receive(:record).and_return(new_ar_object, new_ar_object, updated_ar_object, updated_ar_object)
-      allow(mapper_instance).to receive(:perform_mapping)
-      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-      allow(updated_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-    end
-
-    context "successful" do
-      it "should create a new ar list" do
-        allow(mapper_instance).to receive(:errors).and_return({})
-        builder.map_items
-
-        expect(builder.instance_variable_get('@new_list')).to match_array([mapper_instance, mapper_instance])
-      end
-    end
-
-    context "with errors" do
-      it "should add to the error hash with the correct index" do
-        allow(mapper_instance).to receive(:errors).and_return({}, {data: {type: "I would do anything for love", message: "but I won't do that"}}, {data: {type: "I would do anything for love", message: "but I won't do that"}})
-        builder.map_items
-
-        expect(builder.instance_variable_get('@errors')).to eq({1=>{:type=>"I would do anything for love", :message=>"but I won't do that"}})
-      end
-    end
-  end
-
-  describe "#set_position" do
-
-    it "should update the position if the record has a position attribute" do
-      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(true)
-      expect(new_ar_object).to receive(:position=).with(1)
-
-      builder.set_position(new_ar_object, 1)
-    end
-
-    it "should not blow up if the record does not have a position attribute" do
-      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-      expect(new_ar_object).to_not receive(:position=)
-
-      builder.set_position(new_ar_object, 1)
-    end
-  end
-
-  describe "#build" do
-    before :each do
-      allow(collection).to receive(:map).and_return(existing_ids)
-      allow(builder).to receive(:locator_for).and_return(1)
-      allow(mapper_class).to receive(:new).and_return(mapper_instance)
-      allow(mapper_instance).to receive(:record).and_return(new_ar_object, new_ar_object, updated_ar_object, updated_ar_object)
-      allow(mapper_instance).to receive(:perform_mapping)
-      allow(new_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-      allow(updated_ar_object).to receive(:has_attribute?).with(:position).and_return(false)
-    end
-
-    context "successful" do
-      before :each do
-        allow(mapper_instance).to receive(:errors).and_return({})
-      end
-
-      it "should return a hash with save keys" do
-        expect(builder.build[:save]).to match_array([mapper_instance, mapper_instance])
-      end
-
-      it "should return a hash with delete keys" do
-        expect(builder.build[:delete]).to match_array([2,3])
-      end
-    end
-
-    context "with errors" do
-      before :each do
-        allow(mapper_instance).to receive(:errors).and_return({data: {type: "I would do anything for love", message: "but I won't do that"}}, {data: {type: "I would do anything for love", message: "but I won't do that"}}, {})
-        builder.build
-      end
-
-      it "should return errors" do
-        expect(builder.errors).to eq({0=>{:type=>"I would do anything for love", :message=>"but I won't do that"}})
-      end
-    end
-  end
-end