xeroizer 2.17.1 → 3.0.0

data/test/unit/models/line_item_test.rb

@@ -1,11 +1,11 @@
-require "test_helper"
+require 'unit_test_helper'
 
 class LineItemTest < Test::Unit::TestCase
   include TestHelper
   include Xeroizer::Record
 
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
   end
 
   it "line_item tracking specified correctly" do
@@ -24,61 +24,53 @@ class LineItemTest < Test::Unit::TestCase
 
     line_item.quantity = 1
     line_item.unit_amount = BigDecimal("1337.00")
-    line_item.tax_amount = BigDecimal("0.15")
 
-    expected = BigDecimal((line_item.quantity * (line_item.unit_amount)).to_s).round(2)
-
-    assert_equal expected.to_s, line_item.line_amount.to_s,
-      "expected line_amount to equal unit_amount times quantity"
+    assert_equal "1337.0", line_item.line_amount.to_s,
+                 "expected line_amount to equal unit_amount times quantity"
   end
 
   it "line_amount equals unit_amount times quantity minus the discount if there is a discount_rate" do
     line_item = LineItem.new(nil)
     line_item.quantity = 1
     line_item.unit_amount = BigDecimal("1337.00")
-    line_item.tax_amount = BigDecimal("0.15")
-    line_item.discount_rate = BigDecimal("10.0")
+    line_item.discount_rate = BigDecimal("12.34")
 
-    discount = (100 - line_item.discount_rate) / 100
-    expected = BigDecimal(((line_item.quantity * line_item.unit_amount) * discount).to_s).round(2)
-    assert_equal expected.to_s, line_item.line_amount.to_s,
-      "expected line_amount to equal unit_amount times quantity minus the discount"
+    assert_equal "1172.01", line_item.line_amount.to_s,
+                 "expected line_amount to equal unit_amount times quantity minus the discount"
   end
 
-  it "line_amount is zero when quantity is nil or zero" do
+  it "line_amount equals unit_amount times quantity minus the discount if there is a discount_amount" do
     line_item = LineItem.new(nil)
+    line_item.quantity = 1
+    line_item.unit_amount = BigDecimal("1337.00")
+    line_item.discount_amount = BigDecimal("164.99")
 
-    line_item.quantity = nil
-    line_item.unit_amount = BigDecimal("1.00")
-    line_item.tax_amount = BigDecimal("0.15")
-
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when quantity is nil"
-
-    line_item.quantity = 0
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when quantity is zero"
+    assert_equal "1172.01", line_item.line_amount.to_s,
+                 "expected line_amount to equal unit_amount times quantity minus the discount amount"
   end
 
-  it "is not possible to set unit_amount to zero" do
+  it "coerces decimals when calculating line amount" do
     line_item = LineItem.new(nil)
+    line_item.quantity = "1"
+    line_item.unit_amount = 50
+    assert_equal 50, line_item.line_amount,
+                 "expected line amount to be calculated from coerced values"
+  end
 
-    line_item.quantity = 1
-    line_item.unit_amount = nil
-    line_item.tax_amount = BigDecimal("0.15")
+  context "line_item validations" do
 
-    assert_equal 0.0, line_item.unit_amount,
-      "Expected setting unit_amount to nil to be ignored, i.e., it should remain zero"
-  end
+    it "is an invalid line_item if there is no description" do
+      line_item = LineItem.new(nil)
 
-  it "line_amount is zero when unit_amount is nil or zero" do
-    line_item = LineItem.new(nil)
+      assert_equal(false, line_item.valid?)
+    end
 
-    line_item.quantity = 1
-    line_item.unit_amount = nil
-    line_item.tax_amount = BigDecimal("0.15")
+    it "is a valid line_item with minimal attributes" do
+      line_item = LineItem.new(nil)
+      line_item.description = "Test Description"
 
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when unit_amount is nil"
+      assert_equal(true, line_item.valid?)
+    end
 
-    line_item.unit_amount = BigDecimal("0.00")
-    assert_equal "0.0", line_item.line_amount.to_s, "expected line amount zero when unit_amount is zero"
   end
 end

data/test/unit/models/manual_journal_test.rb

@@ -1,10 +1,10 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class ManualJournalTest < Test::Unit::TestCase
   include TestHelper
 
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
     mock_api('ManualJournals')
   end
 
@@ -22,4 +22,4 @@ class ManualJournalTest < Test::Unit::TestCase
       end
     end
   end
-end
+end

data/test/unit/models/organisation_test.rb

@@ -1,10 +1,10 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class OrganisationTest < Test::Unit::TestCase
   include TestHelper
 
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
   end
 
   context "sales_tax_basis_validations" do
@@ -35,4 +35,18 @@ class OrganisationTest < Test::Unit::TestCase
     end
   end
 
+  context "parse response" do
+    it "includes payment_terms" do
+      @instance = Xeroizer::Record::OrganisationModel.new(nil, "Organisation")
+      some_xml = get_record_xml("organisations")
+
+      result = @instance.parse_response(some_xml)
+      organisation = result.response_items.first
+
+      assert_equal(organisation.payment_terms.bills.day, "4")
+      assert_equal(organisation.payment_terms.bills.type, "OFFOLLOWINGMONTH")
+      assert_equal(organisation.payment_terms.sales.day, "2")
+      assert_equal(organisation.payment_terms.sales.type, "OFFOLLOWINGMONTH")
+    end
+  end
 end

data/test/unit/models/payment_service_test.rb

@@ -0,0 +1,29 @@
+require 'unit_test_helper'
+
+class PaymentServiceTest < Test::Unit::TestCase
+  include TestHelper
+
+  def setup
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
+  end
+
+  context "response parsing" do
+    it "parses default attributes" do
+      @instance = Xeroizer::Record::PaymentServiceModel.new(nil, "PaymentService")
+
+      some_xml = get_record_xml("payment_service")
+
+      result = @instance.parse_response(some_xml)
+      payment_service = result.response_items.first
+
+      keys = [:payment_service_id,
+              :payment_service_name,
+              :payment_service_type,
+              :payment_service_url,
+              :pay_now_text
+      ]
+
+      assert_equal(payment_service.attributes.keys, keys)
+    end
+  end
+end

data/test/unit/models/phone_test.rb

@@ -1,23 +1,23 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class PhoneTest < Test::Unit::TestCase
   include TestHelper
-  
+
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
     @contact = @client.Contact.build
 
   end
-  
+
   context "validators" do
-    
+
     should "not allow long phone numbers" do
       @phone = @contact.add_phone(phone_number: "1234567890123456789012345678901234567890123456789012345678901234567890")
       assert_equal(false, @phone.valid?)
       blank_error = @phone.errors_for(:phone_number).first
       assert_not_nil(blank_error)
       assert_equal("must be shorter than 50 characters", blank_error)
-      
+
     end
 
     should "allow phone numbers" do
@@ -27,5 +27,5 @@ class PhoneTest < Test::Unit::TestCase
       assert_equal(0, @phone.errors.size)
     end
   end
-  
+
 end

data/test/unit/models/prepayment_test.rb

@@ -1,14 +1,14 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class PrepaymentTest < Test::Unit::TestCase
   include TestHelper
-  
+
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)    
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
     mock_api("Prepayments")
     @prepayment = @client.Prepayment.first
   end
-  
+
   context "prepayment attributes" do
     should "large-scale testing from API XML" do
       prepayments = @client.Prepayment.all

data/test/unit/models/repeating_invoice_test.rb

@@ -1,10 +1,10 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class RepeatingInvoiceTest < Test::Unit::TestCase
   include TestHelper
 
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
     mock_api('RepeatingInvoices')
   end
 
@@ -18,7 +18,7 @@ class RepeatingInvoiceTest < Test::Unit::TestCase
       repeating_invoice = repeating_invoices.first
 
       assert_equal "PowerDirect", repeating_invoice.contact_name
-      assert_equal BigDecimal.new(90), repeating_invoice.total
+      assert_equal BigDecimal(90), repeating_invoice.total
       assert_equal true, repeating_invoice.accounts_payable?
 
       schedule = repeating_invoice.schedule

data/test/unit/models/tax_rate_test.rb

@@ -1,11 +1,11 @@
-require 'test_helper'
+require 'unit_test_helper'
 require 'mocha/test_unit'
 
 class TaxRateTest < Test::Unit::TestCase
   include TestHelper
 
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
   end
 
   should "have a primary key value of :name" do

data/test/unit/oauth2_test.rb

@@ -0,0 +1,171 @@
+require 'unit_test_helper'
+
+class OAuth2Test < UnitTestCase
+  include TestHelper
+
+  setup do
+    @client_id = 'client_id'
+    @client_secret = 'client_secret'
+    @access_token = 'access_token'
+    @site = 'https://example.com'
+    @content_type = 'application/xml'
+    @path = '/path'
+    @uri = "#{@site}#{@path}"
+    @response_body = '{"test": true}'
+    @status_code = 200
+    @additional_headers = {foo: 'bar'}
+    @request_body = "xml"
+    @request_headers = { 'Content-Type' => @content_type }
+    @tenant_id = "tenant"
+  end
+
+  def instance
+    Xeroizer::OAuth2.new(@client_id, @client_secret, {
+        site: @site
+    }).tap do |oauth2|
+      oauth2.authorize_from_access(@access_token)
+    end
+  end
+
+  context "get" do
+    setup do
+      stub_request(:get, @uri).
+          with(
+              headers: {
+                  'Authorization' => "Bearer #{@access_token}",
+              }
+          ).to_return(status: @status_code, body: @response_body, headers: {})
+    end
+
+    context "when tenant_id is not present" do
+      should "make a get request" do
+        result = instance.get(@path)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_requested :get, @uri
+        assert_not_requested :get, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+
+    context "when tenant_id is present" do
+      setup do
+        @client = instance
+        @client.tenant_id = @tenant_id
+      end
+
+      should "make a get request with the tenant_id" do
+        result = @client.get(@path)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_requested :get, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+  end
+
+  context "delete" do
+    setup do
+      stub_request(:delete, @uri).
+          with(
+              headers: {
+                  'Authorization' => "Bearer #{@access_token}",
+              }
+          ).to_return(status: @status_code, body: @response_body, headers: {})
+    end
+
+    context "when tenant_id is not present" do
+      should "make a delete request" do
+        result = instance.delete(@path)
+        assert_equal(result.code, @status_code)
+        assert_not_requested :delete, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+
+
+    context "when tenant_id is present" do
+      setup do
+        @client = instance
+        @client.tenant_id = @tenant_id
+      end
+
+      should "make a delete request with the tenant_id" do
+        result = @client.delete(@path)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_requested :delete, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+  end
+
+  context "post" do
+    setup do
+      stub_request(:post, @uri).
+          with(
+              body: @request_body,
+              headers: {
+                  'Authorization' => "Bearer #{@access_token}",
+                  'Content-Type' => @content_type,
+              }).
+          to_return(status: @status_code, body: @response_body, headers: @request_headers)
+
+    end
+
+    context "when tenant_id is not present" do
+      should "make a post request" do
+        result = instance.post(@path, @request_body, @request_headers)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_not_requested :post, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+
+    context "when tenant_id is present" do
+      setup do
+        @client = instance
+        @client.tenant_id = @tenant_id
+      end
+
+      should "make a post request with the tenant_id" do
+        result = @client.post(@path, @request_body, @request_headers)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_requested :post, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+  end
+
+  context "put" do
+    setup do
+      stub_request(:put, @uri).
+          with(
+              body: @request_body,
+              headers: {
+                  'Authorization' => "Bearer #{@access_token}",
+                  'Content-Type' => @content_type,
+              }).
+          to_return(status: @status_code, body: @response_body, headers: @request_headers)
+    end
+
+    context "when tenant_id is not present" do
+      should "make a put request" do
+        result = instance.put(@path, @request_body, @request_headers)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_not_requested :put, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+
+    context "when tenant_id is present" do
+      setup do
+        @client = instance
+        @client.tenant_id = @tenant_id
+      end
+
+      should "make a put request" do
+        result = @client.put(@path, @request_body, @request_headers)
+        assert_equal(result.code, @status_code)
+        assert_equal(result.plain_body, @response_body)
+        assert_requested :put, @uri, headers: { "Xero-tenant-id" => @tenant_id }
+      end
+    end
+  end
+end

data/test/unit/oauth_config_test.rb

@@ -1,4 +1,4 @@
-require "test_helper"
+require 'unit_test_helper'
 
 class OAuthConfigTest < Test::Unit::TestCase
   include Xeroizer

data/test/unit/record/base_model_test.rb

@@ -1,50 +1,50 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class RecordBaseModelTest < Test::Unit::TestCase
   include TestHelper
-  
+
   class AppleModel < Xeroizer::Record::BaseModel
     set_api_controller_name 'AppleController'
     set_permissions :read, :write
   end
-  
+
   class PearModel < Xeroizer::Record::BaseModel
     set_api_controller_name 'PearController'
     set_permissions :read
   end
-  
+
   class OrangeModel < Xeroizer::Record::BaseModel
     set_permissions :read, :write, :update
   end
-  
+
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET)
     @apple_model = AppleModel.new(@client, 'Apple')
     @pear_model = PearModel.new(@client, 'Pear')
     @orange_model = OrangeModel.new(@client, 'Orange')
   end
-  
+
   context "RecordModel.api_controller_name" do
-    
+
     should "api_controller_name should default to pluralized model name" do
       assert_equal('Oranges', @orange_model.api_controller_name)
     end
-    
+
     should "set_api_controller_name should set the base controller name used by Xero" do
       assert_equal('AppleController', @apple_model.api_controller_name)
      assert_equal('PearController', @pear_model.api_controller_name)
     end
-    
+
   end
-  
+
   context "model permssions" do
-    
+
     should "save permissions correctly" do
       assert_equal(%w(read write), @apple_model.class.permissions.keys.map(&:to_s).sort)
       assert_equal(%w(read), @pear_model.class.permissions.keys.map(&:to_s).sort)
       assert_equal(%w(read update write), @orange_model.class.permissions.keys.map(&:to_s).sort)
     end
-    
+
   end
 
   context "InvalidPermissionError" do

data/test/unit/record/base_test.rb

@@ -1,10 +1,11 @@
-require 'test_helper'
+require 'unit_test_helper'
 
 class RecordBaseTest < Test::Unit::TestCase
   include TestHelper
 
   def setup
-    @client = Xeroizer::PublicApplication.new(CONSUMER_KEY, CONSUMER_SECRET)
+    @client = Xeroizer::OAuth2Application.new(CLIENT_ID, CLIENT_SECRET, tenant_id: TENANT_ID)
+    @client.authorize_from_access(ACCESS_TOKEN)
     @contact = @client.Contact.build(:name => 'Test Contact Name ABC')
   end
 
@@ -26,14 +27,14 @@ class RecordBaseTest < Test::Unit::TestCase
   context "new_record? states" do
 
     should "new_record? should be false when loading data" do
-      Xeroizer::OAuth.any_instance.stubs(:get).returns(stub(:plain_body => get_record_xml(:contact), :code => '200'))
+      Xeroizer::OAuth2.any_instance.stubs(:get).returns(stub(:plain_body => get_record_xml(:contact), :code => '200'))
       contact = @client.Contact.find('TESTID')
       assert_kind_of(Xeroizer::Record::Contact, contact)
       assert_equal(false, contact.new_record?)
     end
 
     should "new_record? should be false after successfully creating a record" do
-      Xeroizer::OAuth.any_instance.stubs(:put).returns(stub(:plain_body => get_record_xml(:contact), :code => '200'))
+      Xeroizer::OAuth2.any_instance.stubs(:put).returns(stub(:plain_body => get_record_xml(:contact), :code => '200'))
       assert_equal(true, @contact.new_record?)
       assert_nil(@contact.contact_id)
       assert_equal(true, @contact.save, "Error saving contact: #{@contact.errors.inspect}")
@@ -103,4 +104,72 @@ class RecordBaseTest < Test::Unit::TestCase
       an_example_instance.save
     end
   end
+
+  context 'build' do
+
+    should "raise an undefined method error with useful message" do
+      assert_raise_message("undefined method `this_method_does_not_exist=' for #<Xeroizer::Record::Contact >") do
+        @client.Contact.build(:this_method_does_not_exist =>  true)
+      end
+    end
+
+  end
+
+  context 'saving' do
+    context 'invalid record' do
+      setup do
+        @contact.stubs(:valid?).returns(false)
+      end
+
+      must 'raise an exception saving with #save!' do
+        assert_raise(Xeroizer::RecordInvalid) do
+          @contact.save!
+        end
+      end
+
+      must 'return false saving with #save' do
+        assert_equal(false, @contact.save)
+      end
+    end
+
+    context 'api error received' do
+      setup do
+        response = get_file_as_string('api_exception.xml')
+        doc = Nokogiri::XML(response)
+        exception = Xeroizer::ApiException.new(doc.root.xpath("Type").text,
+                                               doc.root.xpath("Message").text,
+                                               response,
+                                               doc,
+                                               '<FakeRequest />')
+
+        @contact.stubs(:valid?).returns(true)
+        @contact.stubs(:create).raises(exception)
+        @contact.stubs(:update).raises(exception)
+      end
+
+      must 'raise an exception creating records with #save!' do
+        @contact.stubs(:new_record?).returns(true)
+        assert_raise(Xeroizer::ApiException) do
+          @contact.save!
+        end
+      end
+
+      must 'raise an exception updating records with #save!' do
+        @contact.stubs(:new_record?).returns(false)
+        assert_raise(Xeroizer::ApiException) do
+          @contact.save!
+        end
+      end
+
+      must 'return false creating records with #save' do
+        @contact.stubs(:new_record?).returns(true)
+        assert_equal(false, @contact.save)
+      end
+
+      must 'return false updating records with #save' do
+        @contact.stubs(:new_record?).returns(false)
+        assert_equal(false, @contact.save)
+      end
+    end
+  end
 end

data/test/unit/record/block_validator_test.rb

@@ -1,4 +1,4 @@
-require "test_helper"
+require 'unit_test_helper'
 
 class BlockValidatorTest < Test::Unit::TestCase
   def setup