xero_gateway 2.0.4 → 2.0.5

data/lib/xero_gateway/tracking_category.rb

@@ -18,7 +18,7 @@
 #
 module XeroGateway
   class TrackingCategory
-    attr_accessor :name, :options
+    attr_accessor :tracking_category_id, :name, :options
     
     def initialize(params = {})
       @options = []
@@ -33,6 +33,7 @@ module XeroGateway
         
     def to_xml(b = Builder::XmlMarkup.new)
       b.TrackingCategory {
+        b.TrackingCategoryID self.tracking_category_id
         b.Name self.name
         b.Options {
           if self.options.is_a?(Array)
@@ -54,6 +55,7 @@ module XeroGateway
     # option, and the Options tag is omitted
     def to_xml_for_invoice_messages(b = Builder::XmlMarkup.new)
       b.TrackingCategory {
+        b.TrackingCategoryID self.tracking_category_id
         b.Name self.name
         b.Option self.options.is_a?(Array) ? self.options.first : self.options.to_s 
       }      
@@ -63,6 +65,7 @@ module XeroGateway
       tracking_category = TrackingCategory.new
       tracking_category_element.children.each do |element|
         case(element.name)
+          when "TrackingCategoryID" then tracking_category.tracking_category_id = element.text
           when "Name" then tracking_category.name = element.text
           when "Options" then
             element.children.each do |option_child|
@@ -74,7 +77,7 @@ module XeroGateway
     end  
     
     def ==(other)
-      [:name, :options].each do |field|
+      [:tracking_category_id, :name, :options].each do |field|
         return false if send(field) != other.send(field)
       end
       return true

data/lib/xero_gateway.rb

@@ -21,6 +21,7 @@ require File.join(File.dirname(__FILE__), 'xero_gateway', 'contact')
 require File.join(File.dirname(__FILE__), 'xero_gateway', 'line_item')
 require File.join(File.dirname(__FILE__), 'xero_gateway', 'payment')
 require File.join(File.dirname(__FILE__), 'xero_gateway', 'invoice')
+require File.join(File.dirname(__FILE__), 'xero_gateway', 'credit_note')
 require File.join(File.dirname(__FILE__), 'xero_gateway', 'address')
 require File.join(File.dirname(__FILE__), 'xero_gateway', 'phone')
 require File.join(File.dirname(__FILE__), 'xero_gateway', 'organisation')

data/test/integration/create_credit_note_test.rb

@@ -0,0 +1,49 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class CreateCreditNoteTest < Test::Unit::TestCase
+  include TestHelper
+  
+  def setup
+    @gateway = XeroGateway::Gateway.new(CONSUMER_KEY, CONSUMER_SECRET)
+    
+    if STUB_XERO_CALLS
+      @gateway.xero_url = "DUMMY_URL"
+      
+      @gateway.stubs(:http_put).with {|client, url, body, params| url =~ /CreditNotes$/ }.returns(get_file_as_string("create_credit_note.xml"))          
+      @gateway.stubs(:http_post).with {|client, url, body, params| url =~ /CreditNotes$/ }.returns(get_file_as_string("credit_note.xml"))          
+    end
+  end
+  
+  def test_create_credit_note
+    example_credit_note = dummy_credit_note.dup
+    
+    result = @gateway.create_credit_note(example_credit_note)
+    assert_valid_credit_note_save_response(result, example_credit_note)
+  end
+  
+  def test_create_from_credit_note
+    example_credit_note = dummy_credit_note.dup
+    
+    credit_note = @gateway.build_credit_note(example_credit_note)
+    result = credit_note.create
+    assert_valid_credit_note_save_response(result, example_credit_note)
+  end
+  
+  def test_create_credit_note_valid
+    example_credit_note = dummy_credit_note.dup
+    assert_equal true, example_credit_note.valid?, "credit_note is invalid - errors:\n\t#{example_credit_note.errors.map { | error | "#{error[0]} #{error[1]}"}.join("\n\t")}"
+  end
+  
+  private
+  
+    def assert_valid_credit_note_save_response(result, example_credit_note)
+      assert_kind_of XeroGateway::Response, result
+      assert result.success?
+      assert !result.request_xml.nil?
+      assert !result.response_xml.nil?
+      assert !result.credit_note.credit_note_id.nil?
+      assert result.credit_note.credit_note_number == example_credit_note.credit_note_number
+      assert result.credit_note.credit_note_id =~ GUID_REGEX
+    end
+    
+end

data/test/integration/get_credit_note_test.rb

@@ -0,0 +1,48 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class GetCreditNoteTest < Test::Unit::TestCase
+  include TestHelper
+  
+  def setup
+    @gateway = XeroGateway::Gateway.new(CONSUMER_KEY, CONSUMER_SECRET)
+    
+    if STUB_XERO_CALLS
+      @gateway.xero_url = "DUMMY_URL"
+      
+      @gateway.stubs(:http_get).with {|client, url, params| url =~ /CreditNotes(\/[0-9a-z\-]+)?$/i }.returns(get_file_as_string("credit_note.xml"))              
+      @gateway.stubs(:http_put).with {|client, url, body, params| url =~ /CreditNotes$/ }.returns(get_file_as_string("create_credit_note.xml"))          
+    end
+  end
+  
+  def test_get_credit_note
+    # Make sure there is an credit_note in Xero to retrieve
+    credit_note = @gateway.create_credit_note(dummy_credit_note).credit_note
+
+    result = @gateway.get_credit_note(credit_note.credit_note_id)
+    assert result.success?
+    assert !result.request_params.nil?
+    assert !result.response_xml.nil?    
+    assert_equal result.credit_note.credit_note_number, credit_note.credit_note_number
+
+    result = @gateway.get_credit_note(credit_note.credit_note_number)
+    assert result.success?
+    assert !result.request_params.nil?
+    assert !result.response_xml.nil?    
+    assert_equal result.credit_note.credit_note_id, credit_note.credit_note_id
+  end
+  
+  def test_line_items_downloaded_set_correctly
+    # Make sure there is an credit_note in Xero to retrieve.
+    example_credit_note = @gateway.create_credit_note(dummy_credit_note).credit_note
+    
+    # No line items.
+    response = @gateway.get_credit_note(example_credit_note.credit_note_id)
+    assert_equal(true, response.success?)
+    
+    credit_note = response.credit_note
+    assert_kind_of(XeroGateway::LineItem, credit_note.line_items.first)
+    assert_kind_of(XeroGateway::CreditNote, credit_note)
+    assert_equal(true, credit_note.line_items_downloaded?)
+  end
+  
+end

data/test/integration/get_credit_notes_test.rb

@@ -0,0 +1,90 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class GetCreditNotesTest < Test::Unit::TestCase
+  include TestHelper
+  
+  INVALID_CREDIT_NOTE_ID = "99999999-9999-9999-9999-999999999999" unless defined?(INVALID_CREDIT_NOTE_ID)
+  
+  def setup
+    @gateway = XeroGateway::Gateway.new(CONSUMER_KEY, CONSUMER_SECRET)
+    
+    if STUB_XERO_CALLS
+      @gateway.xero_url = "DUMMY_URL"
+      
+      @gateway.stubs(:http_get).with {|client, url, params| url =~ /CreditNotes/ }.returns(get_file_as_string("credit_notes.xml"))
+      @gateway.stubs(:http_put).with {|client, url, body, params| url =~ /CreditNotes$/ }.returns(get_file_as_string("create_credit_note.xml"))
+
+      # Get an credit_note with an invalid ID number.
+      @gateway.stubs(:http_get).with {|client, url, params| url =~ Regexp.new("CreditNotes/#{INVALID_CREDIT_NOTE_ID}") }.returns(get_file_as_string("credit_note_not_found_error.xml"))
+    end
+  end
+  
+  def test_get_credit_notes
+    # Make sure there is an credit_note in Xero to retrieve
+    credit_note = @gateway.create_credit_note(dummy_credit_note).credit_note
+    
+    result = @gateway.get_credit_notes
+    assert result.success?
+    assert !result.request_params.nil?
+    assert !result.response_xml.nil?  
+    assert result.credit_notes.collect {|i| i.credit_note_number}.include?(credit_note.credit_note_number)
+  end
+  
+  def test_get_credit_notes_with_modified_since_date
+    # Create a test credit_note
+    credit_note = dummy_credit_note
+    @gateway.create_credit_note(credit_note)
+    
+    # Check that it is returned
+    result = @gateway.get_credit_notes(:modified_since => Date.today - 1)
+    assert result.success?
+    assert !result.request_params.nil?
+    assert !result.response_xml.nil?    
+    assert result.request_params.keys.include?(:ModifiedAfter) # make sure the flag was sent
+    assert result.credit_notes.collect {|response_credit_note| response_credit_note.credit_note_number}.include?(credit_note.credit_note_number)
+  end
+  
+  def test_line_items_downloaded_set_correctly
+    # No line items.
+    response = @gateway.get_credit_notes
+    assert_equal(true, response.success?)
+    
+    credit_note = response.credit_notes.first
+    assert_kind_of(XeroGateway::CreditNote, credit_note)
+    assert_equal(false, credit_note.line_items_downloaded?)
+  end
+  
+  # Make sure that a reference to gateway is passed when the get_credit_notes response is parsed.
+  def test_get_contacts_gateway_reference
+    result = @gateway.get_credit_notes
+    assert(result.success?)
+    assert_not_equal(0, result.credit_notes.size)
+    
+    result.credit_notes.each do | credit_note |
+      assert(credit_note.gateway === @gateway)
+    end
+  end
+  
+  # Test to make sure that we correctly error when an credit_note doesn't have an ID.
+  # This should usually never be ecountered, but might if a draft credit_note is deleted from Xero.
+  def test_to_ensure_that_an_credit_note_with_invalid_id_errors
+    # Make sure there is an credit_note to retrieve, even though we will mangle it later.
+    credit_note = @gateway.create_credit_note(dummy_credit_note).credit_note
+    
+    result = @gateway.get_credit_notes
+    assert_equal(true, result.success?)
+    
+    credit_note = result.credit_notes.first
+    assert_equal(false, credit_note.line_items_downloaded?)
+    
+    # Mangle credit_note_id to invalid one.
+    credit_note.credit_note_id = INVALID_CREDIT_NOTE_ID
+    
+    # Make sure we fail here.
+    line_items = nil
+    assert_raise(XeroGateway::CreditNoteNotFoundError) { line_items = credit_note.line_items }
+    assert_nil(line_items)
+    
+  end
+  
+end

data/test/integration/get_tracking_categories_test.rb

@@ -20,7 +20,8 @@ class GetTrackingCategoriesTest < Test::Unit::TestCase
     if STUB_XERO_CALLS
       # When operating against the Xero test environment, there may not be any tracking categories present,
       # so this assertion can only be done when operating against stub responses
-      assert result.tracking_categories.size == 2
+      assert_equal 1, result.tracking_categories.size
+      assert_equal 4, result.tracking_categories.first.options.size
     end
   end
-end
+end

data/test/test_helper.rb

@@ -51,6 +51,29 @@ module TestHelper
      invoice
   end
       
+  def dummy_credit_note(with_line_items = true)
+     credit_note = XeroGateway::CreditNote.new({
+       :type => "ACCRECCREDIT",
+       :date => Time.now,
+       :credit_note_number => STUB_XERO_CALLS ? "CN-0153" : "#{Time.now.to_f}",
+       :reference => "YOUR REFERENCE (NOT NECESSARILY UNIQUE!)",
+       :line_items_downloaded => with_line_items
+     })
+     credit_note.contact = dummy_contact
+     if with_line_items
+       credit_note.line_items << XeroGateway::LineItem.new(
+         :description => "THE DESCRIPTION OF THE LINE ITEM",
+         :unit_amount => 1000,
+         :tax_amount => 125,
+         :tracking => [
+            XeroGateway::TrackingCategory.new(:name => "THE FIRST  TRACKING CATEGORY FOR THE LINE ITEM", :options => ["a", "b"]),
+            XeroGateway::TrackingCategory.new(:name => "THE SECOND TRACKING CATEGORY FOR THE LINE ITEM", :options => "c")
+         ]
+       )
+     end
+     credit_note
+  end
+      
   def dummy_contact
     unique_id = Time.now.to_f
     contact = XeroGateway::Contact.new(:name => STUB_XERO_CALLS ? "CONTACT NAME" : "THE NAME OF THE CONTACT #{unique_id}")
@@ -78,4 +101,4 @@ module TestHelper
     return data
   end
   
-end
+end

data/test/unit/account_test.rb

@@ -22,13 +22,14 @@ class AccountTest < Test::Unit::TestCase
   private
   
   def create_test_account
-    account = XeroGateway::Account.new
+    account = XeroGateway::Account.new(:account_id => "57cedda9")
     account.code = "200"
     account.name = "Sales"
     account.type = "REVENUE"
     account.tax_type = "OUTPUT"
     account.description = "Income from any normal business activity"
+    account.enable_payments_to_account = false
     
     account
   end
-end
+end

data/test/unit/credit_note_test.rb

@@ -0,0 +1,284 @@
+require File.join(File.dirname(__FILE__), '../test_helper.rb')
+
+class CreditNoteTest < Test::Unit::TestCase
+  
+  # Tests that a credit note can be converted into XML that Xero can understand, and then converted back to a credit note
+  def test_build_and_parse_xml
+    credit_note = create_test_credit_note
+    
+    # Generate the XML message
+    credit_note_as_xml = credit_note.to_xml
+
+    # Parse the XML message and retrieve the credit_note element
+    credit_note_element = REXML::XPath.first(REXML::Document.new(credit_note_as_xml), "/CreditNote")
+
+    # Build a new credit_note from the XML
+    result_credit_note = XeroGateway::CreditNote.from_xml(credit_note_element)
+
+    assert_equal(credit_note, result_credit_note)
+  end
+  
+  # Tests the sub_total calculation and that setting it manually doesn't modify the data.
+  def test_credit_note_sub_total_calculation
+    credit_note = create_test_credit_note
+    line_item = credit_note.line_items.first
+    
+    # Make sure that everything adds up to begin with.
+    expected_sub_total = credit_note.line_items.inject(BigDecimal.new('0')) { | sum, line_item | line_item.line_amount }
+    assert_equal(expected_sub_total, credit_note.sub_total)
+    
+    # Change the sub_total and check that it doesn't modify anything.
+    credit_note.sub_total = expected_sub_total * 10
+    assert_equal(expected_sub_total, credit_note.sub_total)
+    
+    # Change the amount of the first line item and make sure that 
+    # everything still continues to add up.
+    line_item.unit_amount = line_item.unit_amount + 10
+    assert_not_equal(expected_sub_total, credit_note.sub_total)
+    expected_sub_total = credit_note.line_items.inject(BigDecimal.new('0')) { | sum, line_item | line_item.line_amount }
+    assert_equal(expected_sub_total, credit_note.sub_total)
+  end
+  
+  # Tests the total_tax calculation and that setting it manually doesn't modify the data.
+  def test_credit_note_sub_total_calculation
+    credit_note = create_test_credit_note
+    line_item = credit_note.line_items.first
+    
+    # Make sure that everything adds up to begin with.
+    expected_total_tax = credit_note.line_items.inject(BigDecimal.new('0')) { | sum, line_item | line_item.tax_amount }
+    assert_equal(expected_total_tax, credit_note.total_tax)
+    
+    # Change the total_tax and check that it doesn't modify anything.
+    credit_note.total_tax = expected_total_tax * 10
+    assert_equal(expected_total_tax, credit_note.total_tax)
+    
+    # Change the tax_amount of the first line item and make sure that 
+    # everything still continues to add up.
+    line_item.tax_amount = line_item.tax_amount + 10
+    assert_not_equal(expected_total_tax, credit_note.total_tax)
+    expected_total_tax = credit_note.line_items.inject(BigDecimal.new('0')) { | sum, line_item | line_item.tax_amount }
+    assert_equal(expected_total_tax, credit_note.total_tax)
+  end
+
+  # Tests the total calculation and that setting it manually doesn't modify the data.
+  def test_credit_note_sub_total_calculation
+    credit_note = create_test_credit_note
+    line_item = credit_note.line_items.first
+    
+    # Make sure that everything adds up to begin with.
+    expected_total = credit_note.sub_total + credit_note.total_tax
+    assert_equal(expected_total, credit_note.total)
+    
+    # Change the total and check that it doesn't modify anything.
+    credit_note.total = expected_total * 10
+    assert_equal(expected_total, credit_note.total)
+    
+    # Change the quantity of the first line item and make sure that 
+    # everything still continues to add up.
+    line_item.quantity = line_item.quantity + 5
+    assert_not_equal(expected_total, credit_note.total)
+    expected_total = credit_note.sub_total + credit_note.total_tax
+    assert_equal(expected_total, credit_note.total)
+  end
+
+  # Tests that the LineItem#line_amount calculation is working correctly.
+  def test_line_amount_calculation
+    credit_note = create_test_credit_note
+    line_item = credit_note.line_items.first
+    
+    # Make sure that everything adds up to begin with.
+    expected_amount = line_item.quantity * line_item.unit_amount
+    assert_equal(expected_amount, line_item.line_amount)
+    
+    # Change the line_amount and check that it doesn't modify anything.
+    line_item.line_amount = expected_amount * 10
+    assert_equal(expected_amount, line_item.line_amount)
+    
+    # Change the quantity and check that the line_amount has been updated.
+    quantity = line_item.quantity + 2
+    line_item.quantity = quantity
+    assert_not_equal(expected_amount, line_item.line_amount)
+    assert_equal(quantity * line_item.unit_amount, line_item.line_amount)
+  end
+  
+  # Ensure that the totalling methods don't raise exceptions, even when
+  # credit_note.line_items is empty.
+  def test_totalling_methods_when_line_items_empty
+    credit_note = create_test_credit_note
+    credit_note.line_items = []
+    
+    assert_nothing_raised(Exception) {
+      assert_equal(BigDecimal.new('0'), credit_note.sub_total)
+      assert_equal(BigDecimal.new('0'), credit_note.total_tax)
+      assert_equal(BigDecimal.new('0'), credit_note.total)
+    }
+  end
+  
+  def test_type_helper_methods
+    # Test accounts receivable credit_notes.
+    credit_note = create_test_credit_note({:type => 'ACCRECCREDIT'})
+    assert_equal(true,  credit_note.accounts_receivable?, "Accounts RECEIVABLE credit_note doesn't think it is.")
+    assert_equal(false, credit_note.accounts_payable?,    "Accounts RECEIVABLE credit_note thinks it's payable.")
+    
+    # Test accounts payable credit_notes.
+    credit_note = create_test_credit_note({:type => 'ACCPAYCREDIT'})
+    assert_equal(false, credit_note.accounts_receivable?, "Accounts PAYABLE credit_note doesn't think it is.")
+    assert_equal(true,  credit_note.accounts_payable?,    "Accounts PAYABLE credit_note thinks it's receivable.")
+  end
+  
+  
+  # Make sure that the create_test_credit_note method is working correctly
+  # with all the defaults and overrides.
+  def test_create_test_credit_note_defaults_working
+    credit_note = create_test_credit_note
+    
+    # Test credit_note defaults.
+    assert_equal('ACCRECCREDIT', credit_note.type)
+    assert_kind_of(Date, credit_note.date)
+    assert_equal('12345', credit_note.credit_note_number)
+    assert_equal('MY REFERENCE FOR THIS CREDIT NOTE', credit_note.reference)
+    assert_equal("Exclusive", credit_note.line_amount_types)
+    
+    # Test the contact defaults.
+    assert_equal('00000000-0000-0000-0000-000000000000', credit_note.contact.contact_id)
+    assert_equal('CONTACT NAME', credit_note.contact.name)
+    
+    # Test address defaults.
+    assert_equal('DEFAULT', credit_note.contact.address.address_type)
+    assert_equal('LINE 1 OF THE ADDRESS', credit_note.contact.address.line_1)
+    
+    # Test phone defaults.
+    assert_equal('DEFAULT', credit_note.contact.phone.phone_type)
+    assert_equal('12345678', credit_note.contact.phone.number)
+    
+    # Test the line_item defaults.
+    assert_equal('A LINE ITEM', credit_note.line_items.first.description)
+    assert_equal('200', credit_note.line_items.first.account_code)
+    assert_equal(BigDecimal.new('100'), credit_note.line_items.first.unit_amount)
+    assert_equal(BigDecimal.new('12.5'), credit_note.line_items.first.tax_amount)
+
+    # Test overriding an credit_note parameter (assume works for all).
+    credit_note = create_test_credit_note({:type => 'ACCPAYCREDIT'})
+    assert_equal('ACCPAYCREDIT', credit_note.type)
+    
+    # Test overriding a contact/address/phone parameter (assume works for all).
+    credit_note = create_test_credit_note({}, {:name => 'OVERRIDDEN NAME', :address => {:line_1 => 'OVERRIDDEN LINE 1'}, :phone => {:number => '999'}})
+    assert_equal('OVERRIDDEN NAME', credit_note.contact.name)
+    assert_equal('OVERRIDDEN LINE 1', credit_note.contact.address.line_1)
+    assert_equal('999', credit_note.contact.phone.number)
+    
+    # Test overriding line_items with hash.
+    credit_note = create_test_credit_note({}, {}, {:description => 'OVERRIDDEN LINE ITEM'})
+    assert_equal(1, credit_note.line_items.size)
+    assert_equal('OVERRIDDEN LINE ITEM', credit_note.line_items.first.description)
+    assert_equal(BigDecimal.new('100'), credit_note.line_items.first.unit_amount)
+    
+    # Test overriding line_items with array of 2 line_items.
+    credit_note = create_test_credit_note({}, {}, [
+      {:description => 'OVERRIDDEN ITEM 1'},
+      {:description => 'OVERRIDDEN ITEM 2', :account_code => '200', :unit_amount => BigDecimal.new('200'), :tax_amount => '25.0'}
+    ])
+    assert_equal(2, credit_note.line_items.size)
+    assert_equal('OVERRIDDEN ITEM 1', credit_note.line_items[0].description)
+    assert_equal(BigDecimal.new('100'), credit_note.line_items[0].unit_amount)
+    assert_equal('OVERRIDDEN ITEM 2', credit_note.line_items[1].description)
+    assert_equal(BigDecimal.new('200'), credit_note.line_items[1].unit_amount)
+  end
+  
+  def test_auto_creation_of_associated_contact
+    credit_note = create_test_credit_note({}, nil) # no contact
+    assert_nil(credit_note.instance_variable_get("@contact"))
+    
+    new_contact = credit_note.contact
+    assert_kind_of(XeroGateway::Contact, new_contact)
+  end
+  
+  def test_add_line_item
+    credit_note = create_test_credit_note({}, {}, nil) # no line_items
+    assert_equal(0, credit_note.line_items.size)
+    
+    line_item_params = {:description => "Test Item 1", :unit_amount => 100}
+    
+    # Test adding line item by hash
+    line_item = credit_note.add_line_item(line_item_params)
+    assert_kind_of(XeroGateway::LineItem, line_item)
+    assert_equal(line_item_params[:description], line_item.description)
+    assert_equal(line_item_params[:unit_amount], line_item.unit_amount)
+    assert_equal(1, credit_note.line_items.size)
+    
+    # Test adding line item by XeroGateway::LineItem
+    line_item = credit_note.add_line_item(line_item_params)
+    assert_kind_of(XeroGateway::LineItem, line_item)
+    assert_equal(line_item_params[:description], line_item.description)
+    assert_equal(line_item_params[:unit_amount], line_item.unit_amount)
+    assert_equal(2, credit_note.line_items.size)
+
+    # Test that pushing anything else into add_line_item fails.
+    ["invalid", 100, nil, []].each do | invalid_object |
+      assert_raise(XeroGateway::CreditNote::InvalidLineItemError) { credit_note.add_line_item(invalid_object) }
+      assert_equal(2, credit_note.line_items.size)
+    end
+  end
+  
+  private
+    
+  def create_test_credit_note(credit_note_params = {}, contact_params = {}, line_item_params = [])
+    unless credit_note_params.nil?
+      credit_note_params = {
+        :type => 'ACCRECCREDIT',
+        :date => Date.today,
+        :credit_note_number => '12345',
+        :reference => "MY REFERENCE FOR THIS CREDIT NOTE",
+        :line_amount_types => "Exclusive"
+      }.merge(credit_note_params)
+    end
+    credit_note = XeroGateway::CreditNote.new(credit_note_params || {})
+    
+    unless contact_params.nil?
+      # Strip out :address key from contact_params to use as the default address.
+      stripped_address = {
+        :address_type => 'DEFAULT',
+        :line_1 => 'LINE 1 OF THE ADDRESS'
+      }.merge(contact_params.delete(:address) || {})
+    
+      # Strip out :phone key from contact_params to use at the default phone.
+      stripped_phone = {
+        :phone_type => 'DEFAULT',
+        :number => '12345678'
+      }.merge(contact_params.delete(:phone) || {})
+    
+      contact_params = {
+        :contact_id => '00000000-0000-0000-0000-000000000000', # Just any valid GUID
+        :name => "CONTACT NAME",
+        :first_name => "Bob",
+        :last_name => "Builder"
+      }.merge(contact_params)
+    
+      # Create credit_note.contact from contact_params.
+      credit_note.contact = XeroGateway::Contact.new(contact_params)
+      credit_note.contact.address = XeroGateway::Address.new(stripped_address)
+      credit_note.contact.phone = XeroGateway::Phone.new(stripped_phone)
+    end
+    
+    unless line_item_params.nil?
+      line_item_params = [line_item_params].flatten # always use an array, even if only a single hash passed in
+    
+      # At least one line item, make first have some defaults.
+      line_item_params << {} if line_item_params.size == 0
+      line_item_params[0] = {
+        :description => "A LINE ITEM",
+        :account_code => "200",
+        :unit_amount => BigDecimal.new("100"),
+        :tax_amount => BigDecimal.new("12.5"),
+        :tracking => XeroGateway::TrackingCategory.new(:name => "blah", :options => "hello")
+      }.merge(line_item_params[0])
+    
+      # Create credit_note.line_items from line_item_params
+      line_item_params.each do | line_item |
+        credit_note.add_line_item(line_item)
+      end
+    end
+    
+    credit_note
+  end
+end

data/test/unit/gateway_test.rb

@@ -32,6 +32,22 @@ class GatewayTest < Test::Unit::TestCase
         @gateway.get_accounts
       end
     end
+
+    should "handle rate limit exceeded" do
+      XeroGateway::OAuth.any_instance.stubs(:get).returns(stub(:plain_body => get_file_as_string("rate_limit_exceeded"), :code => "401"))
+
+      assert_raises XeroGateway::OAuth::RateLimitExceeded do
+        @gateway.get_accounts
+      end
+    end
+
+    should "handle unknown errors" do
+      XeroGateway::OAuth.any_instance.stubs(:get).returns(stub(:plain_body => get_file_as_string("bogus_oauth_error"), :code => "401"))
+
+      assert_raises XeroGateway::OAuth::UnknownError do
+        @gateway.get_accounts
+      end
+    end
     
     should "handle ApiExceptions" do
       XeroGateway::OAuth.any_instance.stubs(:put).returns(stub(:plain_body => get_file_as_string("api_exception.xml"), :code => "400"))
@@ -76,4 +92,4 @@ class GatewayTest < Test::Unit::TestCase
     assert_equal "Xero.API.Library.Exceptions.ObjectDoesNotExistException", result.errors.first.type
     assert !result.errors.first.description.nil?
   end
-end
+end