wvanbergen-request-log-analyzer 1.1.2 → 1.1.3

data/spec/unit/tracker/duration_tracker_spec.rb

@@ -0,0 +1,90 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe RequestLogAnalyzer::Tracker::Duration, 'static category' do
+  
+  include RequestLogAnalyzer::Spec::Helper
+
+  before(:each) do
+    @tracker = RequestLogAnalyzer::Tracker::Duration.new(:duration => :duration, :category => :category)
+    @tracker.prepare
+  end
+
+  it "should register a request in the right category" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.categories.keys.should include('a')
+  end
+ 
+  it "should register a hit in the right category" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.update(request(:category => 'b', :duration => 0.3))
+    @tracker.update(request(:category => 'b', :duration => 0.4))
+    
+    @tracker.hits('a').should == 1
+    @tracker.hits('b').should == 2
+  end
+  
+  it "should sum the durations of the same category as cumulative duration" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.update(request(:category => 'b', :duration => 0.3))
+    @tracker.update(request(:category => 'b', :duration => 0.4))      
+    
+    @tracker.cumulative_duration('a').should == 0.2
+    @tracker.cumulative_duration('b').should == 0.7
+  end
+  
+  it "should calculate the average duration correctly" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.update(request(:category => 'b', :duration => 0.3))
+    @tracker.update(request(:category => 'b', :duration => 0.4))      
+    
+    @tracker.average_duration('a').should == 0.2
+    @tracker.average_duration('b').should == 0.35
+  end
+  
+end
+
+describe RequestLogAnalyzer::Tracker::Duration, 'dynamic category' do
+  
+  include RequestLogAnalyzer::Spec::Helper
+  
+  before(:each) do
+    @categorizer = Proc.new { |request| request[:duration] > 0.2 ? 'slow' : 'fast' }
+    @tracker = RequestLogAnalyzer::Tracker::Duration.new(:duration => :duration, :category => @categorizer)
+    @tracker.prepare
+  end
+  
+  it "should use the categorizer to determine the right category" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.update(request(:category => 'b', :duration => 0.3))
+    @tracker.update(request(:category => 'b', :duration => 0.4)) 
+    
+    @tracker.cumulative_duration('fast').should == 0.2
+    @tracker.cumulative_duration('slow').should == 0.7     
+  end
+  
+end
+
+describe RequestLogAnalyzer::Tracker::Duration, 'reporting' do
+ 
+  include RequestLogAnalyzer::Spec::Helper
+ 
+  before(:each) do
+    @tracker = RequestLogAnalyzer::Tracker::Duration.new(:category => :category, :duration => :duration)
+    @tracker.prepare
+  end
+  
+  it "should generate a report without errors when one category is present" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+
+  it "should generate a report without errors when no category is present" do
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+
+  it "should generate a report without errors when multiple categories are present" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.update(request(:category => 'b', :duration => 0.2))    
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+end

data/spec/unit/tracker/frequency_tracker_spec.rb

@@ -0,0 +1,83 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe RequestLogAnalyzer::Tracker::Frequency, 'static category' do
+  
+  include RequestLogAnalyzer::Spec::Helper
+
+  before(:each) do
+    @tracker = RequestLogAnalyzer::Tracker::Frequency.new(:category => :category)
+    @tracker.prepare
+  end
+  
+  
+  it "should register a request in the right category" do
+    @tracker.update(request(:category => 'a', :blah => 0.2))
+    @tracker.frequencies.keys.should include('a')
+  end
+  
+  it "should register a request in the right category" do
+    @tracker.update(request(:category => 'a', :blah => 0.2))
+    @tracker.update(request(:category => 'b', :blah => 0.2))
+    @tracker.update(request(:category => 'b', :blah => 0.2))
+    
+    @tracker.frequency('a').should == 1
+    @tracker.frequency('b').should == 2
+    @tracker.overall_frequency.should == 3
+  end
+
+  it "should sort correctly by frequency" do
+    @tracker.update(request(:category => 'a', :blah => 0.2))
+    @tracker.update(request(:category => 'b', :blah => 0.2))
+    @tracker.update(request(:category => 'b', :blah => 0.2))
+
+    @tracker.sorted_by_frequency.should == [['b', 2], ['a', 1]]
+  end
+end
+
+describe RequestLogAnalyzer::Tracker::Frequency, 'dynamic category' do
+  
+  include RequestLogAnalyzer::Spec::Helper
+  
+  before(:each) do
+    @categorizer = Proc.new { |request| request[:duration] > 0.2 ? 'slow' : 'fast' }
+    @tracker = RequestLogAnalyzer::Tracker::Frequency.new(:category => @categorizer)
+    @tracker.prepare
+  end
+  
+  it "should use the categorizer to determine the right category" do
+    @tracker.update(request(:category => 'a', :duration => 0.2))
+    @tracker.update(request(:category => 'b', :duration => 0.3))
+    @tracker.update(request(:category => 'b', :duration => 0.4)) 
+    
+    @tracker.frequency('fast').should == 1
+    @tracker.frequency('slow').should == 2
+    @tracker.frequency('moderate').should == 0
+  end
+  
+end
+
+
+describe RequestLogAnalyzer::Tracker::Frequency, 'reporting' do
+ 
+  include RequestLogAnalyzer::Spec::Helper
+ 
+  before(:each) do
+    @tracker = RequestLogAnalyzer::Tracker::Frequency.new(:category => :category)
+    @tracker.prepare
+  end
+  
+  it "should generate a report without errors when one category is present" do
+    @tracker.update(request(:category => 'a', :blah => 0.2))
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+
+  it "should generate a report without errors when no category is present" do
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+
+  it "should generate a report without errors when multiple categories are present" do
+    @tracker.update(request(:category => 'a', :blah => 0.2))
+    @tracker.update(request(:category => 'b', :blah => 0.2))    
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+end

data/spec/unit/tracker/timespan_tracker_spec.rb

@@ -0,0 +1,64 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe RequestLogAnalyzer::Tracker::Timespan do
+
+  include RequestLogAnalyzer::Spec::Helper
+
+  before(:each) do
+    @tracker = RequestLogAnalyzer::Tracker::Timespan.new
+    @tracker.prepare
+  end
+
+  it "should set the first request timestamp correctly" do
+    @tracker.update(request(:timestamp => 20090102000000))
+    @tracker.update(request(:timestamp => 20090101000000))    
+    @tracker.update(request(:timestamp => 20090103000000))        
+    
+    @tracker.first_timestamp.should == DateTime.parse('Januari 1, 2009 00:00:00')
+  end
+
+  it "should set the last request timestamp correctly" do
+    @tracker.update(request(:timestamp => 20090102000000))
+    @tracker.update(request(:timestamp => 20090101000000))    
+    @tracker.update(request(:timestamp => 20090103000000))        
+
+    @tracker.last_timestamp.should == DateTime.parse('Januari 3, 2009 00:00:00')
+  end
+  
+  it "should return the correct timespan in days when multiple requests are given" do
+    @tracker.update(request(:timestamp => 20090102000000))
+    @tracker.update(request(:timestamp => 20090101000000))    
+    @tracker.update(request(:timestamp => 20090103000000))  
+    
+    @tracker.timespan.should == 2          
+  end
+
+  it "should return a timespan of 0 days when only one timestamp is set" do
+    @tracker.update(request(:timestamp => 20090103000000))  
+    @tracker.timespan.should == 0
+  end
+
+  it "should raise an error when no timestamp is set" do
+    lambda { @tracker.timespan }.should raise_error
+  end
+end
+
+describe RequestLogAnalyzer::Tracker::Timespan, 'reporting' do
+ 
+  include RequestLogAnalyzer::Spec::Helper
+ 
+  before(:each) do
+    @tracker = RequestLogAnalyzer::Tracker::Timespan.new
+    @tracker.prepare
+  end
+
+  it "should generate a report without errors when no request was tracked" do
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+
+  it "should generate a report without errors when multiple requests were tracked" do
+    @tracker.update(request(:category => 'a', :timestamp => 20090102000000))
+    @tracker.update(request(:category => 'a', :timestamp => 20090101000000))
+    lambda { @tracker.report(mock_output) }.should_not raise_error
+  end
+end

data/spec/unit/tracker/tracker_api_test.rb

@@ -0,0 +1,45 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe RequestLogAnalyzer::Tracker::Base, "API test" do
+
+  include RequestLogAnalyzer::Spec::Helper
+  
+  before(:each) do
+    @tracker    = Class.new(RequestLogAnalyzer::Tracker::Base).new
+    
+    @summarizer = RequestLogAnalyzer::Aggregator::Summarizer.new(mock_source)
+    @summarizer.trackers << @tracker
+  end
+  
+  it "should receive :prepare when the summarizer is preparing" do
+    @tracker.should_receive(:prepare).once    
+    @summarizer.prepare
+  end
+  
+  it "should receieve :finalize when the summarizer is finalizing" do
+    @tracker.should_receive(:finalize).once    
+    @summarizer.finalize    
+  end
+  
+  it "should receive :update for every request for which should_update? returns true" do
+    @tracker.should_receive(:should_update?).twice.and_return(true)
+    @tracker.should_receive(:update).twice
+    
+    @summarizer.aggregate(testing_format.request(:field => 'value1'))
+    @summarizer.aggregate(testing_format.request(:field => 'value2'))    
+  end
+  
+  it "should not :update for every request for which should_update? returns false" do
+    @tracker.should_receive(:should_update?).twice.and_return(false)
+    @tracker.should_not_receive(:update)
+    
+    @summarizer.aggregate(testing_format.request(:field => 'value1'))
+    @summarizer.aggregate(testing_format.request(:field => 'value2'))    
+  end
+  
+  it "should receive :report when the summary report is being built" do
+    @tracker.should_receive(:report).with(anything).once   
+    @summarizer.report(mock_output) 
+  end
+  
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: wvanbergen-request-log-analyzer
 version: !ruby/object:Gem::Version 
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors: 
 - Willem van Bergen
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-24 00:00:00 -08:00
+date: 2009-01-29 00:00:00 -08:00
 default_executable: request-log-analyzer
 dependencies: []
 
@@ -34,6 +34,7 @@ files:
 - lib/cli
 - lib/cli/command_line_arguments.rb
 - lib/cli/progressbar.rb
+- lib/cli/tools.rb
 - lib/request_log_analyzer
 - lib/request_log_analyzer.rb
 - lib/request_log_analyzer/aggregator
@@ -69,12 +70,6 @@ files:
 - lib/request_log_analyzer/tracker/hourly_spread.rb
 - lib/request_log_analyzer/tracker/timespan.rb
 - spec
-- spec/controller_spec.rb
-- spec/database_inserter_spec.rb
-- spec/file_format_spec.rb
-- spec/file_formats
-- spec/file_formats/spec_format.rb
-- spec/filter_spec.rb
 - spec/fixtures
 - spec/fixtures/merb.log
 - spec/fixtures/multiple_files_1.log
@@ -87,14 +82,37 @@ files:
 - spec/fixtures/test_file_format.log
 - spec/fixtures/test_language_combined.log
 - spec/fixtures/test_order.log
-- spec/line_definition_spec.rb
-- spec/log_parser_spec.rb
-- spec/log_processor_spec.rb
-- spec/merb_format_spec.rb
-- spec/rails_format_spec.rb
-- spec/request_spec.rb
+- spec/integration
+- spec/integration/command_line_usage_spec.rb
+- spec/lib
+- spec/lib/helper.rb
+- spec/lib/mocks.rb
+- spec/lib/testing_format.rb
 - spec/spec_helper.rb
-- spec/summarizer_spec.rb
+- spec/unit
+- spec/unit/aggregator
+- spec/unit/aggregator/database_inserter_spec.rb
+- spec/unit/aggregator/summarizer_spec.rb
+- spec/unit/controller
+- spec/unit/controller/controller_spec.rb
+- spec/unit/controller/log_processor_spec.rb
+- spec/unit/file_format
+- spec/unit/file_format/file_format_api_spec.rb
+- spec/unit/file_format/line_definition_spec.rb
+- spec/unit/file_format/merb_format_spec.rb
+- spec/unit/file_format/rails_format_spec.rb
+- spec/unit/filter
+- spec/unit/filter/anonymize_filter_spec.rb
+- spec/unit/filter/field_filter_spec.rb
+- spec/unit/filter/timespan_filter_spec.rb
+- spec/unit/source
+- spec/unit/source/log_parser_spec.rb
+- spec/unit/source/request_spec.rb
+- spec/unit/tracker
+- spec/unit/tracker/duration_tracker_spec.rb
+- spec/unit/tracker/frequency_tracker_spec.rb
+- spec/unit/tracker/timespan_tracker_spec.rb
+- spec/unit/tracker/tracker_api_test.rb
 - tasks
 - tasks/github-gem.rake
 - tasks/request_log_analyzer.rake
@@ -130,14 +148,20 @@ signing_key:
 specification_version: 2
 summary: A command line tool to analyze Rails logs
 test_files: 
-- spec/controller_spec.rb
-- spec/database_inserter_spec.rb
-- spec/file_format_spec.rb
-- spec/filter_spec.rb
-- spec/line_definition_spec.rb
-- spec/log_parser_spec.rb
-- spec/log_processor_spec.rb
-- spec/merb_format_spec.rb
-- spec/rails_format_spec.rb
-- spec/request_spec.rb
-- spec/summarizer_spec.rb
+- spec/integration/command_line_usage_spec.rb
+- spec/unit/aggregator/database_inserter_spec.rb
+- spec/unit/aggregator/summarizer_spec.rb
+- spec/unit/controller/controller_spec.rb
+- spec/unit/controller/log_processor_spec.rb
+- spec/unit/file_format/file_format_api_spec.rb
+- spec/unit/file_format/line_definition_spec.rb
+- spec/unit/file_format/merb_format_spec.rb
+- spec/unit/file_format/rails_format_spec.rb
+- spec/unit/filter/anonymize_filter_spec.rb
+- spec/unit/filter/field_filter_spec.rb
+- spec/unit/filter/timespan_filter_spec.rb
+- spec/unit/source/log_parser_spec.rb
+- spec/unit/source/request_spec.rb
+- spec/unit/tracker/duration_tracker_spec.rb
+- spec/unit/tracker/frequency_tracker_spec.rb
+- spec/unit/tracker/timespan_tracker_spec.rb

data/spec/controller_spec.rb

@@ -1,64 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
-describe RequestLogAnalyzer::Controller do
-
-  include RequestLogAnalyzerSpecHelper
-
-  it "should use a custom output generator correctly" do
-    
-    mock_output = mock('RequestLogAnalyzer::Output::Base')
-    mock_output.stub!(:io).and_return(mock_io)
-    mock_output.should_receive(:header)
-    mock_output.should_receive(:footer)
-
-    file_format = RequestLogAnalyzer::FileFormat.load(:rails)
-    source      = RequestLogAnalyzer::Source::LogParser.new(file_format, :source_files => log_fixture(:rails_1x))  
-    controller  = RequestLogAnalyzer::Controller.new(source, :output => mock_output)
-
-    controller.run!
-  end
-
-  it "should call aggregators correctly when run" do
-    
-    file_format = RequestLogAnalyzer::FileFormat.load(:rails)
-    source      = RequestLogAnalyzer::Source::LogParser.new(file_format, :source_files => log_fixture(:rails_1x))  
-    controller  = RequestLogAnalyzer::Controller.new(source, :output => mock_output)
-    
-    mock_aggregator = mock('RequestLogAnalyzer::Aggregator::Base')
-    mock_aggregator.should_receive(:prepare).once.ordered
-    mock_aggregator.should_receive(:aggregate).with(an_instance_of(file_format.class::Request)).at_least(:twice).ordered
-    mock_aggregator.should_receive(:finalize).once.ordered
-    mock_aggregator.should_receive(:report).once.ordered
-  
-    controller.aggregators << mock_aggregator
-    controller.run!
-  end
-  
-  it "should call filters when run" do
-    file_format = RequestLogAnalyzer::FileFormat.load(:rails)
-    source      = RequestLogAnalyzer::Source::LogParser.new(file_format, :source_files => log_fixture(:rails_1x))  
-    controller  = RequestLogAnalyzer::Controller.new(source, :output => mock_output)
-    
-    mock_filter = mock('RequestLogAnalyzer::Filter::Base')
-    mock_filter.should_receive(:prepare).once.ordered
-    mock_filter.should_receive(:filter).at_least(:twice)
-    
-    controller.should_not_receive(:aggregate_request)
-    
-    controller.filters << mock_filter
-    controller.run!
-  end
-  
-  it "should run well from the command line with the most important features" do
-    
-    temp_file = "#{File.dirname(__FILE__)}/fixtures/report.txt"
-    temp_db   = "#{File.dirname(__FILE__)}/fixtures/output.db"
-    binary = "#{File.dirname(__FILE__)}/../bin/request-log-analyzer"
-  
-    system("#{binary} #{log_fixture(:rails_1x)} --database #{temp_db} --select Controller PeopleController --file #{temp_file} > /dev/null").should be_true
-  
-    File.unlink(temp_file)
-    File.unlink(temp_db)    
-  end
-  
-end

data/spec/filter_spec.rb

@@ -1,157 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper'
-
-describe RequestLogAnalyzer::Filter::Timespan, 'both before and after'  do
-  include RequestLogAnalyzerSpecHelper
-
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Timespan.new(spec_format, :after => DateTime.parse('2009-01-01'), :before => DateTime.parse('2009-02-02'))
-    @filter.prepare
-  end
-  
-  it "should reject a request before the after date" do
-    @filter.filter(request(:timestamp => 20081212000000)).should be_nil
-  end
-  
-  it "should reject a request after the before date" do
-    @filter.filter(request(:timestamp => 20090303000000)).should be_nil
-  end
-  
-  it "should accept a request between the after and before dates" do
-    @filter.filter(request(:timestamp => 20090102000000)).should_not be_nil
-  end
-end
-
-describe RequestLogAnalyzer::Filter::Timespan, 'only before'  do
-  include RequestLogAnalyzerSpecHelper
-  
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Timespan.new(spec_format, :before => DateTime.parse('2009-02-02'))    
-    @filter.prepare
-  end
-  
-  it "should accept a request before the after date" do
-    @filter.filter(request(:timestamp => 20081212000000)).should_not be_nil
-  end
-  
-  it "should reject a request after the before date" do
-    @filter.filter(request(:timestamp => 20090303000000)).should be_nil
-  end
-  
-  it "should accept a request between the after and before dates" do
-    @filter.filter(request(:timestamp => 20090102000000)).should_not be_nil
-  end   
-end
-
-describe RequestLogAnalyzer::Filter::Timespan, 'only after'  do  
-  include RequestLogAnalyzerSpecHelper 
-  
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Timespan.new(spec_format, :after => DateTime.parse('2009-01-01'))
-    @filter.prepare
-  end
-  
-  it "should reject a request before the after date" do
-    @filter.filter(request(:timestamp => 20081212000000)).should be_nil
-  end
-  
-  it "should accept a request after the before date" do
-    @filter.filter(request(:timestamp => 20090303000000)).should_not be_nil
-  end
-  
-  it "should accept a request between the after and before dates" do
-    @filter.filter(request(:timestamp => 20090102000000)).should_not be_nil
-  end  
-end
-
-describe RequestLogAnalyzer::Filter::Field, 'string in accept mode' do
-  include RequestLogAnalyzerSpecHelper
-
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Field.new(spec_format, :field => :test, :value => 'test', :mode => :select)
-    @filter.prepare
-  end
-  
-  it "should reject a request if the field value does not match" do
-    @filter.filter(request(:test => 'not test')).should be_nil
-  end
-  
-  it "should reject a request if the field name does not match" do
-    @filter.filter(request(:testing => 'test')).should be_nil
-  end
-
-  it "should accept a request if the both name and value match" do
-    @filter.filter(request(:test => 'test')).should_not be_nil
-  end 
-    
-  it "should accept a request if the value is not the first value" do
-    @filter.filter(request([{:test => 'ignore'}, {:test => 'test'}])).should_not be_nil
-  end  
-end
-
-describe RequestLogAnalyzer::Filter::Field, 'string in reject mode' do
-  include RequestLogAnalyzerSpecHelper
-
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Field.new(spec_format, :field => :test, :value => 'test', :mode => :reject)
-    @filter.prepare
-  end
-  
-  it "should accept a request if the field value does not match" do
-    @filter.filter(request(:test => 'not test')).should_not be_nil
-  end
-  
-  it "should accept a request if the field name does not match" do
-    @filter.filter(request(:testing => 'test')).should_not be_nil
-  end
-
-  it "should reject a request if the both name and value match" do
-    @filter.filter(request(:test => 'test')).should be_nil
-  end 
-    
-  it "should reject a request if the value is not the first value" do
-    @filter.filter(request([{:test => 'ignore'}, {:test => 'test'}])).should be_nil
-  end  
-end
-
-describe RequestLogAnalyzer::Filter::Field, 'regexp in accept mode' do
-  include RequestLogAnalyzerSpecHelper
-
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Field.new(spec_format, :field => :test, :value => '/test/', :mode => :select)
-    @filter.prepare
-  end
-  
-  it "should reject a request if the field value does not match" do
-    @filter.filter(request(:test => 'a working test')).should_not be_nil
-  end
-  
-  it "should reject a request if the field name does not match" do
-    @filter.filter(request(:testing => 'test')).should be_nil
-  end
-
-  it "should accept a request if the value is not the first value" do
-    @filter.filter(request([{:test => 'ignore'}, {:test => 'testing 123'}])).should_not be_nil
-  end  
-end
-
-describe RequestLogAnalyzer::Filter::Anonymize, 'anonymize request' do
-  include RequestLogAnalyzerSpecHelper
-
-  before(:each) do
-    @filter = RequestLogAnalyzer::Filter::Anonymize.new(spec_format)
-    @filter.prepare
-  end
-  
-  it "should anonimize ip" do
-    @filter.filter(request(:ip => '123.123.123.123'))[:ip].should_not eql('123.123.123.123')
-  end
-
-  it "should anonimize url" do
-    @filter.filter(request(:url => 'https://test.mysite.com/employees'))[:url].should eql('http://example.com/employees')
-  end
-
-  it "should fuzz durations" do
-    @filter.filter(request(:duration => 100))[:duration].should_not eql(100)
-  end
-  
-end

data/spec/summarizer_spec.rb

@@ -1,9 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper'
-require 'request_log_analyzer/aggregator/summarizer'
-
-describe RequestLogAnalyzer::Aggregator::Summarizer do
-  
-  before(:each) do
-  end
-
-end