wvanbergen-request-log-analyzer 0.2.2 → 0.3.0

data/output/blockers.rb

@@ -1,11 +1,9 @@
 # Print requests that took more than a second to complete, sorted by their frequency.
-amount = $arguments[:amount] || 10
-
 puts
-puts "Mongrel process blockers (> #{$summarizer.blocker_duration} seconds)"
+puts "Mongrel process blockers (> #{@summarizer.blocker_duration} seconds)"
 puts green("========================================================================")
 
-$summarizer.sort_blockers_by(:count).reverse[0, amount.to_i].each do |a|
+@summarizer.sort_blockers_by(:count).reverse[0, @amount].each do |a|
  puts "%-50s: %10.03fs [#{green("%d requests")}]" % [a[0], a[1][:total_time], a[1][:count]]
 end
 

data/output/errors.rb

@@ -1,9 +1,8 @@
 # Print errors that occured often
-amount = $arguments[:amount] || 10
 puts
 puts "Errors"
 puts green("========================================================================")
-$summarizer.sort_errors_by(:count).reverse[0, amount.to_i].each do |a|
+@summarizer.sort_errors_by(:count).reverse[0, @amount].each do |a|
   puts "%s: [#{green("%d requests")}]" % [a[0] + 'Error', a[1][:count]]
   puts blue(' -> ' + (a[1][:exception_strings].invert[ a[1][:exception_strings].values.max ])[0..79])
 end

data/output/hourly_spread.rb

@@ -1,7 +1,7 @@
 # Draws a graph containing the average amound of requests per hour per day
-if $summarizer.request_time_graph?
+if @summarizer.request_time_graph?
 
-  max_request_graph = $summarizer.request_time_graph.max / $summarizer.duration
+  max_request_graph = @summarizer.request_time_graph.max / @summarizer.duration
   deviation         = max_request_graph / 20
   deviation         = 1 if deviation == 0
   color_cutoff      = 15
@@ -11,7 +11,7 @@ if $summarizer.request_time_graph?
   puts green("========================================================================")
   
   (0..23).each do |a|
-    requests      = $summarizer.request_time_graph[a] / $summarizer.duration
+    requests      = @summarizer.request_time_graph[a] / @summarizer.duration
     display_chars = requests / deviation
     
     if display_chars >= color_cutoff

data/output/mean_db_time.rb

@@ -1,7 +1,6 @@
 # Prints a table sorted by the highest database times.
-amount = $arguments[:amount] || 10
 puts
 puts "Top #{amount} worst DB offenders - mean time"
 puts green("========================================================================")
-print_table($summarizer, :mean_db_time, amount)
+print_table(@summarizer, :mean_db_time, @amount)
 

data/output/mean_rendering_time.rb

@@ -1,7 +1,6 @@
 # Prints a table showing the slowest renderes
-amount = $arguments[:amount] || 10
 puts
-puts "Top #{amount} slow renderers - mean time"
+puts "Top #{@amount} slow renderers - mean time"
 puts green("========================================================================")
-print_table($summarizer, :mean_rendering_time, amount)
+print_table(@summarizer, :mean_rendering_time, @amount)
 

data/output/mean_time.rb

@@ -1,7 +1,6 @@
 # Prints  table sorted by the duration of the requests
-amount = $arguments[:amount] || 10
 puts
-puts "Top #{amount} actions by time - per request mean"
+puts "Top #{@amount} actions by time - per request mean"
 puts green("========================================================================")
 
-print_table($summarizer, :mean_time, amount)
+print_table(@summarizer, :mean_time, @amount)

data/output/most_requested.rb

@@ -1,6 +1,5 @@
 # Prints a table sorted by the most frequently requested actions
-amount = $arguments[:amount] || 10
 puts
 puts "Top #{amount} most requested actions"
 puts green("========================================================================")
-print_table($summarizer, :count, amount)
+print_table(@summarizer, :count, @amount)

data/output/timespan.rb

@@ -2,15 +2,17 @@
 puts
 puts green("========================================================================")
 
-if $summarizer.has_timestamps?
-  puts "Timestamp first request: #{$summarizer.first_request_at}"
-  puts "Timestamp last request:  #{$summarizer.last_request_at}" 
-  puts "Total time analyzed: #{$summarizer.duration} days"
+if @summarizer.has_timestamps?
+  puts "Timestamp first request: #{@summarizer.first_request_at}"
+  puts "Timestamp last request:  #{@summarizer.last_request_at}" 
+  puts "Total time analyzed:     #{@summarizer.duration} days"
+  puts ""
+  puts "Total requests analyzed: #{@summarizer.request_count}"
 end
 
 methods_print_array = []
-methods_request_count = $summarizer.methods.inject(0) { |subtotal, (k, v)| subtotal + v }
-$summarizer.methods.each do |key, value|
-  methods_print_array << "%s (%0.01f%%)" % [key, green((value * 100) / methods_request_count.to_f)]
+methods_request_count = @summarizer.methods.inject(0) { |subtotal, (k, v)| subtotal + v }
+@summarizer.methods.each do |key, value|
+  methods_print_array << green("%s (%0.01f%%)") % [key, (value * 100) / methods_request_count.to_f]
 end
-puts 'Methods: ' + methods_print_array.join(', ') + '.'
+puts 'Methods: ' + methods_print_array.join(', ') + '.'

data/output/total_db_time.rb

@@ -1,6 +1,5 @@
 # Prints a list of the actions that spend most of their time waiting for database results.
-amount = $arguments[:amount] || 10
 puts
-puts "Top #{amount} worst DB offenders - cumulative time"
+puts "Top #{@amount} worst DB offenders - cumulative time"
 puts green("========================================================================")
-print_table($summarizer, :total_db_time, amount)
+print_table(@summarizer, :total_db_time, @amount)

data/output/total_time.rb

@@ -1,6 +1,5 @@
 # Prints a list ordered by the requests that took the most time in total.
-amount = $arguments[:amount] || 10
 puts
-puts "Top #{amount} actions by time - cumulative"
+puts "Top #{@amount} actions by time - cumulative"
 puts green("========================================================================")
-print_table($summarizer, :total_time, amount)
+print_table(@summarizer, :total_time, @amount)

data/output/usage.rb

@@ -2,14 +2,15 @@
 puts "Usage: request-log-analyzer [LOGFILES*] <OPTIONS>"
 puts
 puts "Options:"
-puts "  --fast, -t:                 Only use completed requests"
+puts "  --fast, -f:                 Only use completed requests"
 puts "  --guess-database-time, -g:  Guesses the database duration of requests" 
 puts "  --output, -o:               Comma-separated list of reports to show"     
 puts "  --amount, -c:               Displays the top <amount> elements in the reports"     
 puts "  --colorize, -z:             Fancy bash coloring"
 puts "  --merb, -m:                 Parse merb logfiles"
+puts "  --install rails, -i rails   Install Rails task rake log:analyze"
 puts 
 puts "Examples:"
 puts "  request-log-analyzer development.log"
 puts "  request-log-analyzer mongrel.0.log mongrel.1.log mongrel.2.log -g -f -o mean_time,most_requested,blockers -c 20 -z"
-puts
+puts "  request-log-analyzer --install rails"

data/spec/controller_spec.rb

@@ -0,0 +1,33 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe RequestLogAnalyzer::Controller do
+
+  include RequestLogAnalyzerSpecHelper
+
+  it "should include the file format module" do
+    controller = RequestLogAnalyzer::Controller.new(:rails)
+    (class << controller; self; end).ancestors.include?(RequestLogAnalyzer::FileFormat::Rails)
+  end
+
+  it "should call the aggregators when run" do
+    controller = RequestLogAnalyzer::Controller.new(:rails)
+    controller << log_fixture(:rails_1x)
+    
+    mock_aggregator = mock('aggregator')
+    mock_aggregator.should_receive(:prepare).once.ordered
+    mock_aggregator.should_receive(:aggregate).with(an_instance_of(RequestLogAnalyzer::Request)).at_least(:twice).ordered
+    mock_aggregator.should_receive(:finalize).once.ordered
+    mock_aggregator.should_receive(:report).once.ordered
+    
+    another_mock_aggregator = mock('another aggregator')
+    another_mock_aggregator.should_receive(:prepare).once.ordered
+    another_mock_aggregator.should_receive(:aggregate).with(an_instance_of(RequestLogAnalyzer::Request)).at_least(:twice).ordered
+    another_mock_aggregator.should_receive(:finalize).once.ordered  
+    another_mock_aggregator.should_receive(:report).once.ordered  
+
+    
+    controller.aggregators << mock_aggregator << another_mock_aggregator
+    controller.run!
+  end
+  
+end

data/spec/database_inserter_spec.rb

@@ -0,0 +1,81 @@
+require File.dirname(__FILE__) + '/spec_helper'
+require 'request_log_analyzer/aggregator/database'
+
+
+describe RequestLogAnalyzer::Aggregator::Database, "schema creation" do
+
+  TEST_DATABASE_FILE = File.dirname(__FILE__) + "/fixtures/requests.db"
+  include RequestLogAnalyzerSpecHelper
+  
+  before(:each) do
+    @database_inserter = RequestLogAnalyzer::Aggregator::Database.new(TestFileFormat, :database => TEST_DATABASE_FILE)
+  end
+  
+  after(:each) do
+    File.unlink(TEST_DATABASE_FILE) if File.exist?(TEST_DATABASE_FILE)
+  end
+  
+  it "should create the correct tables" do
+    ActiveRecord::Migration.should_receive(:create_table).with("warnings")    
+    ActiveRecord::Migration.should_receive(:create_table).with("first_lines")
+    ActiveRecord::Migration.should_receive(:create_table).with("test_lines")        
+    ActiveRecord::Migration.should_receive(:create_table).with("last_lines")    
+    @database_inserter.prepare
+  end
+  
+  it "should create the default table names" do
+    @database_inserter.prepare
+    @database_inserter.file_format.line_definitions.each do |name, definition|
+      klass = TestFileFormat.const_get("#{name}_line".camelize)
+      klass.column_names.should include('id')
+      klass.column_names.should include('lineno')      
+      klass.column_names.should include('request_id')      
+    end
+  end
+  
+  it "should create the correct fields in the table" do
+    @database_inserter.prepare
+    
+    TestFileFormat::FirstLine.column_names.should include('request_no')
+    TestFileFormat::LastLine.column_names.should include('request_no')
+    TestFileFormat::TestLine.column_names.should include('test_capture')    
+  end
+  
+end
+
+describe RequestLogAnalyzer::Aggregator::Database, "record insertion" do
+
+  before(:each) do
+    @database_inserter = RequestLogAnalyzer::Aggregator::Database.new(TestFileFormat, :database => TEST_DATABASE_FILE)
+    @database_inserter.prepare
+        
+    @single = RequestLogAnalyzer::Request.create(TestFileFormat, {:line_type => :first, :request_no => 564})
+    @combined = RequestLogAnalyzer::Request.create(TestFileFormat, 
+                          {:line_type => :first, :request_no  => 564},
+                          {:line_type => :test, :test_capture => "awesome"},
+                          {:line_type => :test, :test_capture => "indeed"},                                                    
+                          {:line_type => :last, :request_no   => 564})    
+  end
+  
+  after(:each) do
+    File.unlink(TEST_DATABASE_FILE) if File.exist?(TEST_DATABASE_FILE)
+  end 
+  
+  it "should insert a record in the relevant table" do
+    TestFileFormat::FirstLine.should_receive(:create!).with(hash_including(:request_no => 564))
+    @database_inserter.aggregate(@single)
+  end
+  
+  it "should insert records in all relevant tables" do
+    TestFileFormat::FirstLine.should_receive(:create!).with(hash_including(:request_no => 564)).once
+    TestFileFormat::TestLine.should_receive(:create!).twice
+    TestFileFormat::LastLine.should_receive(:create!).with(hash_including(:request_no => 564)).once
+    @database_inserter.aggregate(@combined)
+  end
+  
+  it "should log a warning in the warnings table" do
+    TestFileFormat::Warning.should_receive(:create!).with(hash_including(:warning_type => 'test_warning'))
+    @database_inserter.warning(:test_warning, "Testing the warning system", 12)
+  end
+  
+end

data/spec/fixtures/multiple_files_1.log

@@ -0,0 +1,5 @@
+initializing
+
+processing request 1
+
+testing is amazing

data/spec/fixtures/multiple_files_2.log

@@ -0,0 +1,2 @@
+testing is cool
+finishing request 1

data/{test/log_fragments/fragment_1.log → spec/fixtures/rails_1x.log}

@@ -1,4 +1,4 @@
-Processing DashboardController#index (for 130.89.162.199 at 2008-08-14 21:16:25) [GET]
+Processing DashboardController#index (for 1.1.1.1 at 2008-08-14 21:16:25) [GET]
   Session ID: BAh7CToMcmVmZXJlciIbL3ByaXNjaWxsYS9wZW9wbGUvMjM1MCIKZmxhc2hJ
 QzonQWN0aW9uQ29udHJvbGxlcjo6Rmxhc2g6OkZsYXNoSGFzaHsABjoKQHVz
 ZWR7ADoNbGFuZ3VhZ2VvOhNMb2NhbGU6Ok9iamVjdBI6CUB3aW4wOg1AY291
@@ -13,7 +13,7 @@ Rendering dashboard/index
 Completed in 0.22699 (4 reqs/sec) | Rendering: 0.02667 (11%) | DB: 0.03057 (13%) | 200 OK [https://www.example.com/]
 
 
-Processing PeopleController#index (for 130.89.162.199 at 2008-08-14 21:16:30) [GET]
+Processing PeopleController#index (for 1.1.1.1 at 2008-08-14 21:16:30) [GET]
   Session ID: BAh7CSIKZmxhc2hJQzonQWN0aW9uQ29udHJvbGxlcjo6Rmxhc2g6OkZsYXNo
 SGFzaHsABjoKQHVzZWR7ADoMcmVmZXJlciIQL3ByaXNjaWxsYS86DnBlcnNv
 bl9pZGkCMgc6DWxhbmd1YWdlbzoTTG9jYWxlOjpPYmplY3QSOg1AY291bnRy
@@ -27,7 +27,7 @@ Redirected to https://www.example.com/people/2545
 Completed in 0.04759 (21 reqs/sec) | DB: 0.03719 (78%) | 302 Found [https://www.example.com/people?q=gaby&commit=Zoek]
 
 
-Processing PeopleController#show (for 130.89.162.199 at 2008-08-14 21:16:30) [GET]
+Processing PeopleController#show (for 1.1.1.1 at 2008-08-14 21:16:30) [GET]
   Session ID: BAh7CToMcmVmZXJlciIpL3ByaXNjaWxsYS9wZW9wbGU/cT1nYWJ5JmNvbW1p
 dD1ab2VrIgpmbGFzaElDOidBY3Rpb25Db250cm9sbGVyOjpGbGFzaDo6Rmxh
 c2hIYXNoewAGOgpAdXNlZHsAOg1sYW5ndWFnZW86E0xvY2FsZTo6T2JqZWN0
@@ -40,11 +40,11 @@ X2lkaQIyBw==--3ad1948559448522a49d289a2a89dc7ccbe8847a
 Set language to: nl_NL
 Rendering template within layouts/priscilla
 Rendering people/show
-person: Gaby Somers, study_year: 2008/2009
+person: John Doe, study_year: 2008/2009
 Completed in 0.29077 (3 reqs/sec) | Rendering: 0.24187 (83%) | DB: 0.04030 (13%) | 200 OK [https://www.example.com/people/2545]
 
 
-Processing PeopleController#picture (for 130.89.162.199 at 2008-08-14 21:16:35) [GET]
+Processing PeopleController#picture (for 1.1.1.1 at 2008-08-14 21:16:35) [GET]
   Session ID: BAh7CSIKZmxhc2hJQzonQWN0aW9uQ29udHJvbGxlcjo6Rmxhc2g6OkZsYXNo
 SGFzaHsABjoKQHVzZWR7ADoMcmVmZXJlciIbL3ByaXNjaWxsYS9wZW9wbGUv
 MjU0NToOcGVyc29uX2lkaQIyBzoNbGFuZ3VhZ2VvOhNMb2NhbGU6Ok9iamVj

data/{test/log_fragments/fragment_3.log → spec/fixtures/rails_22.log}

@@ -1,7 +1,7 @@
 Processing PageController#demo (for 127.0.0.1 at 2008-12-10 16:28:09) [GET]
   Parameters: {"action"=>"demo", "controller"=>"page"}
 Logging in from session data...
-Logged in as willem@depillem.com
+Logged in as test@example.com
 Using locale: en-US, http-accept: ["en-US"], session: , det browser: en-US, det domain: 
 Rendering template within layouts/demo
 Rendering page/demo
@@ -9,4 +9,4 @@ Rendered shared/_analytics (0.2ms)
 Rendered layouts/_actions (0.6ms)
 Rendered layouts/_menu (2.2ms)
 Rendered layouts/_tabbar (0.5ms)
-Completed in 614ms (View: 120, DB: 31) | 200 OK [http://floorplanner.local/demo]
+Completed in 614ms (View: 120, DB: 31) | 200 OK [http://www.example.coml/demo]

data/spec/fixtures/rails_22_cached.log

@@ -0,0 +1,10 @@
+Processing CachedController#cached (for 1.1.1.1 at 2008-12-24 07:36:53) [GET]
+  Parameters: {"action"=>"cached", "controller"=>"cached"}
+Logging in from session data...
+Logging in using cookie...
+Using locale: zh-Hans, http-accept: ["zh-CN", "zh-HK", "zh-TW", "en-US"], session: , det browser: zh-Hans, det domain: , user pref locale: 
+Referer: http://www.example.com/referer
+Cached fragment hit: views/zh-Hans-www-cached-cached-all-CN--- (0.0ms)
+Filter chain halted as [#<ActionController::Caching::Actions::ActionCacheFilter:0x2a999ad620 @check=nil, @options={:store_options=>{}, :layout=>nil, :cache_path=>#<Proc:0x0000002a999b8890@/app/controllers/cached_controller.rb:8>}>] rendered_or_redirected.
+Filter chain halted as [#<ActionController::Filters::AroundFilter:0x2a999ad120 @identifier=nil, @kind=:filter, @options={:only=>#<Set: {"cached"}>, :if=>:not_logged_in?, :unless=>nil}, @method=#<ActionController::Caching::Actions::ActionCacheFilter:0x2a999ad620 @check=nil, @options={:store_options=>{}, :layout=>nil, :cache_path=>#<Proc:0x0000002a999b8890@/app/controllers/cached_controller.rb:8>}>>] did_not_yield.
+Completed in 3ms (View: 0, DB: 0) | 200 OK [http://www.example.com/cached/cached/]

data/spec/fixtures/rails_unordered.log

@@ -0,0 +1,24 @@
+Processing AccountController#dashboard (for 1.1.1.1 at 2008-12-24 07:36:49) [GET]
+  Parameters: {"action"=>"dashboard", "controller"=>"account", "first_use"=>"true"}
+Logging in from session data...
+
+
+Processing ProjectsController#new (for 1.1.1.1 at 2008-12-24 07:36:49) [GET]
+  Parameters: {"action"=>"new", "controller"=>"projects"}
+Rendering template within layouts/default
+Rendering account/dashboard
+Logging in from session data...
+Logging in using cookie...
+Using locale: en-US, http-accept: [], session: , det browser: , det domain: , user pref locale: 
+Rendered shared/_maintenance (0.6ms)
+Rendering template within layouts/templates/general_default/index.html.erb
+Rendered projects/_recent_designs (4.3ms)
+Rendered projects/_project (13.6ms)
+Rendered projects/_projects (18.7ms)
+Rendered layouts/_menu (1.4ms)
+Completed in 36ms (View: 30, DB: 3) | 200 OK [http://www.example.com/projects/new]
+Rendered layouts/_actions (0.3ms)
+Rendered layouts/_menu (1.6ms)
+Rendered layouts/_tabbar (1.9ms)
+Rendered layouts/_footer (3.2ms)
+Completed in 50ms (View: 41, DB: 4) | 200 OK [http://www.example.com/dashboard?first_use=true]

data/spec/fixtures/test_file_format.log

@@ -0,0 +1,11 @@
+testing
+testing methods
+testing is cool
+testing fixtures
+testing is amazing
+testing can be cumbersome
+testing 
+nonsense
+testing is
+
+more nonsense

data/spec/fixtures/test_language_combined.log

@@ -0,0 +1,14 @@
+initializing
+
+processing request 1
+
+testing is amazing
+testing is cool
+
+finishing request 1
+
+asdfad # garbage
+dsaads # garbage
+
+processing request 1
+finishing request 1

data/spec/fixtures/test_order.log

@@ -0,0 +1,16 @@
+initializing
+
+processing request 1
+
+testing is amazing
+testing is cool
+
+processing request 1
+testing is cool
+finishing request 1
+
+asdfad # garbage
+dsaads # garbage
+
+
+finishing request 1

data/spec/line_definition_spec.rb

@@ -0,0 +1,34 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe RequestLogAnalyzer::FileFormat::LineDefinition do
+  
+  before(:each) do
+    @line_definition = RequestLogAnalyzer::FileFormat::LineDefinition.new(:test, {
+      :teaser   => /Testing /,
+      :regexp   => /Testing (\w+), tries\: (\d+)/,
+      :captures => [{:what => :string}, {:tries => :integer}]
+    })
+  end
+  
+  it "should return false on an unmatching line" do
+    (@line_definition =~ "nonmatching").should be_false
+  end
+  
+  it "should return false when only the teaser matches" do
+    (@line_definition =~ "Testing LineDefinition").should be_false  
+  end
+  
+  it "should return a hash if the line matches" do
+    (@line_definition =~ "Testing LineDefinition, tries: 123").should be_kind_of(Hash)
+  end
+  
+  it "should return a hash with all captures set" do
+    hash = @line_definition.matches("Testing LineDefinition, tries: 123")
+    hash[:what].should == "LineDefinition"
+    hash[:tries].should == 123
+  end
+  
+  it "should return a hash with :line_type set" do
+     @line_definition.matches("Testing LineDefinition, tries: 123")[:line_type].should == :test
+   end
+end

data/spec/log_parser_spec.rb

@@ -0,0 +1,92 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe RequestLogAnalyzer::LogParser, :single_line_requests do
+  
+  include RequestLogAnalyzerSpecHelper
+  
+  before(:each) do
+    @log_parser = RequestLogAnalyzer::LogParser.new(TestFileFormat)
+  end
+  
+  it "should have line definitions" do
+    @log_parser.file_format.line_definitions.should_not be_empty
+  end
+  
+  it "should have include the language specific hooks in the instance, not in the class" do
+    metaclass = (class << @log_parser; self; end)
+    metaclass.ancestors.should include(TestFileFormat::LogParser)
+    @log_parser.class.ancestors.should_not include(TestFileFormat::LogParser)
+  end
+  
+  it "should parse a stream and find valid requests" do
+    io = File.new(log_fixture(:test_file_format), 'r')
+    @log_parser.parse_io(io, :line_types => [:test]) do |request| 
+      request.should be_kind_of(RequestLogAnalyzer::Request)
+      request.should =~ :test
+      request[:test_capture].should_not be_nil      
+    end
+    io.close
+  end
+  
+  it "should find as many lines as request" do
+    @log_parser.parse_file(log_fixture(:test_file_format)) { |request| request.should be_single_line }
+    @log_parser.parsed_lines.should eql(@log_parser.parsed_requests)
+  end
+end
+
+describe RequestLogAnalyzer::LogParser, :combined_requests do
+  include RequestLogAnalyzerSpecHelper
+  
+  before(:each) do
+    @log_parser = RequestLogAnalyzer::LogParser.new(TestFileFormat, :combined_requests => true)
+  end
+  
+  it "should have multiple line definitions" do
+    @log_parser.file_format.line_definitions.length.should >= 2
+  end  
+  
+  it "should have a valid language" do
+    @log_parser.file_format.should be_valid
+  end
+  
+  it "should parse more lines than requests" do
+    @log_parser.should_receive(:handle_request).with(an_instance_of(RequestLogAnalyzer::Request)).twice
+    @log_parser.parse_file(log_fixture(:test_language_combined)) { |request| request.should be_combined }  
+    @log_parser.parsed_lines.should > 2    
+  end
+  
+  it "should parse requests spanned over multiple files" do
+    @log_parser.should_receive(:handle_request).with(an_instance_of(RequestLogAnalyzer::Request)).once
+    @log_parser.parse_files([log_fixture(:multiple_files_1), log_fixture(:multiple_files_2)])
+  end
+  
+  it "should parse all request values when spanned over multiple files" do
+    @log_parser.parse_files([log_fixture(:multiple_files_1), log_fixture(:multiple_files_2)]) do |request|
+      request.lines.should have(4).items
+      
+      request[:request_no].should == 1
+      request[:test_capture].should == "amazing"      
+    end
+  end  
+end
+
+describe RequestLogAnalyzer::LogParser, :warnings do
+  include RequestLogAnalyzerSpecHelper
+    
+  it "should warn about teaser matching problems" do
+    @log_parser = RequestLogAnalyzer::LogParser.new(TestFileFormat)
+    @log_parser.should_receive(:warn).with(:teaser_check_failed, anything).exactly(5).times
+    @log_parser.parse_file(log_fixture(:test_file_format))
+  end
+  
+  it "should warn about unmatching request headers and footers" do
+    @log_parser = RequestLogAnalyzer::LogParser.new(TestFileFormat, :combined_requests => true)
+    
+    @log_parser.should_receive(:warn).with(:unclosed_request, anything).at_least(1).times    
+    @log_parser.should_receive(:warn).with(:no_current_request, anything).at_least(1).times    
+    @log_parser.should_not_receive(:handle_request)    
+    @log_parser.parse_file(log_fixture(:test_order))    
+
+  end  
+  
+end

data/spec/merb_format_spec.rb

@@ -0,0 +1,58 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe RequestLogAnalyzer::LogParser, "Merb without combined requests" do
+  include RequestLogAnalyzerSpecHelper
+  
+  before(:each) do
+    @log_parser = RequestLogAnalyzer::LogParser.new(:merb, :combined_requests => false)
+  end
+  
+  it "should parse a stream and find valid requests" do
+    File.open(log_fixture(:merb), 'r') do |io|
+      @log_parser.parse_io(io) do |request| 
+        request.should be_kind_of(RequestLogAnalyzer::Request)
+        request.should be_single_line
+      end
+    end
+  end
+
+  it "should find 33 request lines when lines are not linked" do
+    @log_parser.should_receive(:handle_request).exactly(33).times
+    @log_parser.parse_file(log_fixture(:merb))
+  end  
+  
+  it "should find 11 request start lines when lines are not linked" do
+    @log_parser.should_receive(:handle_request).exactly(11).times
+    @log_parser.parse_file(log_fixture(:merb), :line_types => [:started])
+  end  
+end
+
+
+describe RequestLogAnalyzer::LogParser, "Merb with combined requests" do
+  include RequestLogAnalyzerSpecHelper
+  
+  before(:each) do
+    @log_parser = RequestLogAnalyzer::LogParser.new(:merb, :combined_requests => true)
+  end
+  
+  it "should have a valid language definitions" do
+    @log_parser.file_format.should be_valid
+  end
+  
+  it "should find 11 completed requests when lines are linked" do
+    @log_parser.should_receive(:handle_request).exactly(11).times
+    @log_parser.parse_file(log_fixture(:merb))
+  end
+  
+  it "should parse all details from a request correctly" do
+    request = nil
+    @log_parser.parse_file(log_fixture(:merb)) { |found_request| request ||= found_request }
+    
+    request.should be_completed
+    request[:timestamp].should == 'Fri Aug 29 11:10:23 +0200 2008'
+    request[:dispatch_time].should == 0.243424
+    request[:after_filters_time].should == 6.9e-05
+    request[:before_filters_time].should == 0.213213
+    request[:action_time].should == 0.241652
+  end
+end