wupee 1.0.4 → 1.1.2

data/spec/models/notification_type_spec.rb

@@ -0,0 +1,42 @@
+require 'rails_helper'
+
+RSpec.describe Wupee::NotificationType, type: :model do
+  let!(:receiver) { create :user }
+  let!(:notification_type_name) { 'notify_new_message' }
+  let!(:notification_type) { create :notification_type, name: notification_type_name }
+  let!(:notification) { create :notification, notification_type: notification_type, receiver: receiver }
+
+  context "validations" do
+    it "validates presence of name" do
+      notification_type = Wupee::NotificationType.new
+      notification_type.valid?
+      expect(notification_type.errors).to have_key :name
+    end
+
+    it "validates presence of uniqueness of name" do
+      notification_type = Wupee::NotificationType.new(name: notification_type_name)
+      notification_type.valid?
+      expect(notification_type.errors).to have_key :name
+    end
+  end
+
+  context "methods" do
+    it "responds to notification_type_configurations" do
+      expect(notification_type).to respond_to(:notification_type_configurations)
+    end
+
+    it "responds to notifications" do
+      expect(notification_type).to respond_to(:notifications)
+    end
+  end
+
+  context "associations" do
+    it "destroys notification_type_configurations on destroy" do
+      expect { notification_type.destroy! }.to change { Wupee::Notification.count }.by(-1)
+    end
+
+    it "destroys notifications on destroy" do
+      expect { notification_type.destroy! }.to change { Wupee::NotificationTypeConfiguration.count }.by(-1)
+    end
+  end
+end

data/spec/models/notifier_spec.rb

@@ -1,6 +1,9 @@
 require 'rails_helper'
+require_relative '../../lib/wupee/notifier'
 
 RSpec.describe Wupee::Notifier, type: :model do
+  let!(:notif_type) { Wupee::NotificationType.create!(name: "notify_new_message") }
+  let!(:user) { create :user }
 
   context "methods defined" do
     it { expect(subject).to respond_to(:notif_type) }
@@ -12,7 +15,6 @@ RSpec.describe Wupee::Notifier, type: :model do
   end
 
   it "has a method notif_type that can take Wupee::NotificationType instance or string/symbol as argument" do
-    notif_type = create :notification_type
     wupee_notifier = Wupee::Notifier.new
     wupee_notifier.notif_type(notif_type.name)
     expect(wupee_notifier.notification_type).to eq notif_type
@@ -22,8 +24,6 @@ RSpec.describe Wupee::Notifier, type: :model do
   end
 
   it "has a method execute to send notifications and mails depending on notification_type_configurations of the users" do
-    notif_type = Wupee::NotificationType.create!(name: "notify_new_message")
-
     user_1 = create :user
     user_2 = create :user
     user_3 = create :user
@@ -39,4 +39,21 @@ RSpec.describe Wupee::Notifier, type: :model do
     expect { wupee_notifier.execute }.to change { Wupee::Notification.where(is_read: true).count }.by(2)
     expect { wupee_notifier.execute }.to change { Wupee::Notification.count }.by(4)
   end
+
+  it "raises ArgumentError if receiver or receivers is missing" do
+    expect { Wupee::Notifier.new(notif_type: notif_type).execute }.to raise_error(ArgumentError)
+  end
+
+  it "doesn't raise ArgumentError if receiver or receivers is present" do
+    expect { Wupee::Notifier.new(notif_type: notif_type, receiver: user).execute }.not_to raise_error
+    expect { Wupee::Notifier.new(notif_type: notif_type, receivers: user).execute }.not_to raise_error
+  end
+
+  it "doesn't raise ArgumentError if receivers is an empty array" do
+    expect { Wupee::Notifier.new(notif_type: notif_type, receivers: []).execute }.not_to raise_error
+  end
+
+  it "raises ArgumentError if notif_type is missing" do
+    expect { Wupee::Notifier.new(receiver: user).execute }.to raise_error(ArgumentError)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wupee
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.2
 platform: ruby
 authors:
 - Peng DU
@@ -9,15 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-24 00:00:00.000000000 Z
+date: 2016-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.0
@@ -25,9 +22,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.0
@@ -105,7 +99,6 @@ files:
 - app/models/wupee/notification.rb
 - app/models/wupee/notification_type.rb
 - app/models/wupee/notification_type_configuration.rb
-- app/models/wupee/notifier.rb
 - app/views/wupee/api/notifications/_notification.json.jbuilder
 - app/views/wupee/api/notifications/index.json.jbuilder
 - app/views/wupee/api/notifications/show.json.jbuilder
@@ -118,9 +111,10 @@ files:
 - lib/generators/wupee/install/templates/wupee.rb
 - lib/generators/wupee/notification_type/USAGE
 - lib/generators/wupee/notification_type/notification_type_generator.rb
-- lib/tasks/wupee_tasks.rake
+- lib/tasks/wupee.rake
 - lib/wupee.rb
 - lib/wupee/engine.rb
+- lib/wupee/notifier.rb
 - lib/wupee/version.rb
 - spec/controllers/notifications_controller_spec.rb
 - spec/dummy/README.rdoc
@@ -188,6 +182,7 @@ files:
 - spec/models/message_spec.rb
 - spec/models/notification_spec.rb
 - spec/models/notification_type_configuration_spec.rb
+- spec/models/notification_type_spec.rb
 - spec/models/notifier_spec.rb
 - spec/models/user_spec.rb
 - spec/rails_helper.rb
@@ -285,9 +280,11 @@ test_files:
 - spec/models/message_spec.rb
 - spec/models/notification_spec.rb
 - spec/models/notification_type_configuration_spec.rb
+- spec/models/notification_type_spec.rb
 - spec/models/notifier_spec.rb
 - spec/models/user_spec.rb
 - spec/rails_helper.rb
 - spec/spec_helper.rb
 - spec/support/factory_girl.rb
 - spec/wupee_spec.rb
+has_rdoc: 

data/lib/tasks/wupee_tasks.rake

@@ -1,4 +0,0 @@
-# desc "Explaining what the task does"
-# task :wupee do
-#   # Task goes here
-# end