wt_activerecord_index_spy 0.3.0 → 0.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (8) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +3 -0
  3. data/CHANGELOG.md +4 -0
  4. data/Gemfile +1 -1
  5. data/lib/wt_activerecord_index_spy/notification_listener.rb +3 -3
  6. data/lib/wt_activerecord_index_spy/query_analyser/mysql.rb +1 -1
  7. data/lib/wt_activerecord_index_spy/version.rb +1 -1
  8. metadata +6 -6
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 11d05e2c0947b38147e7410caf7659d87ecf28e07f684f075eb77034d0b01025
4
- data.tar.gz: 17d2229914f89671fbd811a4e5dc5851354190d7e1eb90ec7444f1449731c4eb
3
+ metadata.gz: 139af66e444d627962e5c1012c22bb950aaf2e4f5ca4626068174beb75664bb6
4
+ data.tar.gz: 5f0d2385cf19cee78366660c2d647dbe468a86f189589a4c745c91df18d84bf9
5
5
  SHA512:
6
- metadata.gz: 8bf3bb1095e3b9ba88d69fdbd0dd00da66135308b4a2f2931abda47f225609aa8eef07f029b70a936087181d92b36832441c429d37b6b67ae076671236de847e
7
- data.tar.gz: 7216232729e5f15769f2da26abb2d9e8922cb1411f67843cd2f64e2e08a3fe2b50045ea0481fac74b338dc941d5fad23e8763d6c8eeae11240a0359f17d957cc
6
+ metadata.gz: 0f211a9e65df94123ce1404e35a13c615eafe0a9fe5189ccf0397d64fc357dba80e099e7f08c6c4f28c738e1dc10fa52f41bfab3e3f0579cf751768684ea37fb
7
+ data.tar.gz: f753b9c6c7362464de58317d0bfcadd9fdf1ce587468568a07524fe9fecbb371460c1604b2a800563ae2bbacd705ffa1c1542519361f6aae4278151289df6998
data/.rubocop.yml CHANGED
@@ -26,3 +26,6 @@ Metrics/MethodLength:
26
26
 
27
27
  Style/ModuleFunction:
28
28
  EnforcedStyle: extend_self
29
+
30
+ Style/TrailingCommaInArrayLiteral:
31
+ EnforcedStyleForMultiline: consistent_comma
data/CHANGELOG.md CHANGED
@@ -1,3 +1,7 @@
1
+ ## 0.4.0
2
+ * change `NotificationListener` to ignore queries to INFORMATION_SCHEMA
3
+ * change `NotificationListener` to not ignore queries with an empty identifier, for example, when running with `ActiveRecord::Base.connection.execute`
4
+
1
5
  ## 0.3.0
2
6
  * add support for PostgreSQL (unfortunately all results are uncertain)
3
7
  * add support for Ruby >= 2.5 and Activerecord >= 4
data/Gemfile CHANGED
@@ -11,7 +11,7 @@ gem "rspec", "~> 3.0"
11
11
 
12
12
  gem "rubocop", "~> 1.7"
13
13
 
14
- active_record_version = ENV.fetch("ACTIVE_RECORD_VERSION", "~> 4")
14
+ active_record_version = ENV.fetch("ACTIVE_RECORD_VERSION", "~> 6")
15
15
 
16
16
  gem "activerecord", active_record_version
17
17
  gem "activesupport", active_record_version
data/lib/wt_activerecord_index_spy/notification_listener.rb CHANGED
@@ -21,7 +21,8 @@ module WtActiverecordIndexSpy
21
21
  /^SELECT @@FOREIGN_KEY_CHECKS/,
22
22
  /^SET FOREIGN_KEY_CHECKS/,
23
23
  /^TRUNCATE TABLE/,
24
- /^EXPLAIN/
24
+ /^EXPLAIN/,
25
+ /FROM INFORMATION_SCHEMA/,
25
26
  ].freeze
26
27
 
27
28
  attr_reader :queries_missing_index
@@ -44,7 +45,7 @@ module WtActiverecordIndexSpy
44
45
  identifier = values[:name]
45
46
 
46
47
  if ignore_query?(query: query, name: identifier)
47
- logger.debug "query type ignored"
48
+ logger.debug "query type ignored, name: #{identifier}, query: #{query}"
48
49
  return
49
50
  end
50
51
  logger.debug "query type accepted"
@@ -88,7 +89,6 @@ module WtActiverecordIndexSpy
88
89
  # the query was cached
89
90
  name == "CACHE" ||
90
91
  name == "SCHEMA" ||
91
- !name ||
92
92
  !query.downcase.include?("where") ||
93
93
  IGNORED_SQL.any? { |r| query =~ r }
94
94
  end
data/lib/wt_activerecord_index_spy/query_analyser/mysql.rb CHANGED
@@ -9,7 +9,7 @@ module WtActiverecordIndexSpy
9
9
  ALLOWED_EXTRA_VALUES = [
10
10
  # https://bugs.mysql.com/bug.php?id=64197
11
11
  "Impossible WHERE noticed after reading const tables",
12
- "no matching row"
12
+ "no matching row",
13
13
  ].freeze
14
14
 
15
15
  def analyse(results)
data/lib/wt_activerecord_index_spy/version.rb CHANGED
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module WtActiverecordIndexSpy
4
- VERSION = "0.3.0"
4
+ VERSION = "0.4.0"
5
5
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: wt_activerecord_index_spy
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.3.0
4
+ version: 0.4.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Fabio Perrella
8
- autorequire:
8
+ autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2021-04-16 00:00:00.000000000 Z
11
+ date: 2021-05-17 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activerecord
@@ -165,7 +165,7 @@ metadata:
165
165
  homepage_uri: https://github.com/fabioperrella/wt_activerecord_index_spy
166
166
  source_code_uri: https://github.com/fabioperrella/wt_activerecord_index_spy
167
167
  changelog_uri: https://github.com/fabioperrella/wt_activerecord_index_spy/blob/main/CHANGELOG.md
168
- post_install_message:
168
+ post_install_message:
169
169
  rdoc_options: []
170
170
  require_paths:
171
171
  - lib
@@ -180,8 +180,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
180
180
  - !ruby/object:Gem::Version
181
181
  version: '0'
182
182
  requirements: []
183
- rubygems_version: 3.0.3
184
- signing_key:
183
+ rubygems_version: 3.1.6
184
+ signing_key:
185
185
  specification_version: 4
186
186
  summary: It checks if queries use an index
187
187
  test_files: []