ws-style 6.1.1 → 6.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: a655c650097aee04578896ec65002116b0b0b19e78663024fa732825fe2ca175
4
- data.tar.gz: ae259d51706c8191e2651c1292163625a1bcddd50a2edda2bd29a02ed6134d18
3
+ metadata.gz: 4a605b5e2240f475f0d822ece0003a3b28c824d6778bbae60dc0be53225d31cf
4
+ data.tar.gz: f75e46a2c110efbadf47c9b4f3fb544c2477c3940bbb67b031455ce9bc94ca33
5
5
  SHA512:
6
- metadata.gz: 63ac417ec06ba2ad39b5286f4b1f4946612a60be8fdf55a0c27d6ad0e89cbc3b75e3f018ebc750ab3da8500a4916151ea1ba9cf681c4dabfc45d1ed54383507e
7
- data.tar.gz: 9829019947308da98658521fffe595a1a17a4fd46267b1fc4e1e1cc9ade58df4d041025a2206a41cb7a5070eb452ed018e2a919ce8e26b423e6f7361cb1bdd84
6
+ metadata.gz: 9101a95f343a4ec65a25b14ac79f455ed8c10297d4343db28b91edaef5455ede575141cdb894967e597054eea34f31dd02d6e8270e87992c8c6e27cb80628230
7
+ data.tar.gz: e2383ed5c76230f7a3d045463378e5832707c77ca45d6f5fb6c60d867e5f413d8c8b984f90c0799f46c8a5c6ab4ddd02d9fa9ac0ad84a8641c80ab11e32e3ada
@@ -73,12 +73,15 @@ workflows:
73
73
  - checkout_and_bundle:
74
74
  context: wealthsimple
75
75
  - rspec:
76
+ context: wealthsimple
76
77
  requires:
77
78
  - checkout_and_bundle
78
79
  - lint_check:
80
+ context: wealthsimple
79
81
  requires:
80
82
  - checkout_and_bundle
81
83
  - vulnerability_check:
84
+ context: wealthsimple
82
85
  requires:
83
86
  - checkout_and_bundle
84
87
  - release:
@@ -87,9 +90,9 @@ workflows:
87
90
  branches:
88
91
  only: master
89
92
  requires:
90
- - rspec
91
- - lint_check
92
- - vulnerability_check
93
+ - rspec
94
+ - lint_check
95
+ - vulnerability_check
93
96
 
94
97
  security-audit:
95
98
  triggers:
@@ -103,5 +106,6 @@ workflows:
103
106
  - checkout_and_bundle:
104
107
  context: wealthsimple
105
108
  - vulnerability_check:
109
+ context: wealthsimple
106
110
  requires:
107
111
  - checkout_and_bundle
@@ -1 +1 @@
1
- 2.5.7
1
+ 2.5.8
@@ -4,6 +4,18 @@ All notable changes to this project will be documented in this file.
4
4
  The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
5
5
  and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
6
6
 
7
+ ## 6.5.0 - 2020-10-26
8
+ - Upgrade RuboCop and RuboCop RSpec
9
+
10
+ ## 6.4.0 - 2020-10-07
11
+ - Upgrade RuboCop
12
+
13
+ ## 6.3.0 - 2020-10-06
14
+ - Upgrade RuboCop and enable cops that were voted in
15
+
16
+ ## 6.2.0 - 2020-09-04
17
+ - Disable Cops enabled in 6.1.0 until we can confirm we want them
18
+
7
19
  ## 6.1.1 - 2020-09-04
8
20
  - Disable RSpec/MultipleMemoizedHelpers cop
9
21
 
data/Rakefile CHANGED
@@ -1,6 +1,31 @@
1
1
  require "bundler/gem_tasks"
2
2
  require "rspec/core/rake_task"
3
+ require "rubocop"
4
+ require "rubocop-performance"
5
+ require "rubocop-rails"
6
+ require "rubocop-rspec"
3
7
 
4
8
  RSpec::Core::RakeTask.new(:spec)
5
9
 
6
10
  task default: :spec
11
+
12
+ desc 'Print out comments that can be used for a GitHub cop election'
13
+ task :election do # rubocop:disable Rails/RakeEnvironment
14
+ configuration_path = File.expand_path('default.yml', File.dirname(__FILE__))
15
+ RuboCop::ConfigLoader.load_file(configuration_path).pending_cops.each do |pending_cop|
16
+ base_urls = {
17
+ 'layout' => 'https://docs.rubocop.org/rubocop/cops_layout.html#layout',
18
+ 'lint' => 'https://docs.rubocop.org/rubocop/cops_lint.html#lint',
19
+ 'style' => 'https://docs.rubocop.org/rubocop/cops_style.html#style',
20
+ 'performance' => 'https://docs.rubocop.org/rubocop-performance/cops_performance.html#performance',
21
+ 'rails' => 'https://docs.rubocop.org/rubocop-rails/cops_rails.html#rails',
22
+ 'rspec' => 'https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspec',
23
+ }
24
+ department, anchor = pending_cop.name.downcase.split('/')
25
+ puts <<~COMMENT
26
+ [**#{pending_cop.name}**](#{base_urls.fetch(department)}#{anchor})
27
+ #{pending_cop.metadata.fetch('Description')}
28
+
29
+ COMMENT
30
+ end
31
+ end
data/core.yml CHANGED
@@ -48,6 +48,9 @@ Layout/CaseIndentation:
48
48
  Layout/ElseAlignment:
49
49
  Enabled: false
50
50
 
51
+ Layout/EmptyLineBetweenDefs:
52
+ AllowAdjacentOneLineDefs: true
53
+
51
54
  Layout/EndAlignment:
52
55
  Enabled: false
53
56
 
@@ -279,7 +282,7 @@ Style/ExplicitBlockArgument:
279
282
  Enabled: True
280
283
 
281
284
  Style/GlobalStdStream:
282
- Enabled: True
285
+ Enabled: False
283
286
 
284
287
  Style/OptionalBooleanParameter:
285
288
  Enabled: True
@@ -314,3 +317,32 @@ Performance/Squeeze:
314
317
 
315
318
  Performance/StringInclude:
316
319
  Enabled: True
320
+
321
+ # 0.90
322
+ Lint/DuplicateRequire:
323
+ Enabled: True
324
+
325
+ Lint/EmptyFile:
326
+ Enabled: True
327
+
328
+ Lint/TrailingCommaInAttributeDeclaration:
329
+ Enabled: True
330
+
331
+ Lint/UselessMethodDefinition:
332
+ Enabled: True
333
+
334
+ Style/CombinableLoops:
335
+ Enabled: True
336
+
337
+ Style/KeywordParametersOrder:
338
+ Enabled: True
339
+
340
+ Style/RedundantSelfAssignment:
341
+ Enabled: True
342
+
343
+ Style/SoleNestedConditional:
344
+ Enabled: True
345
+
346
+ # rubocop-performance 1.7
347
+ Performance/Sum:
348
+ Enabled: True
@@ -1,5 +1,5 @@
1
1
  module Ws
2
2
  module Style
3
- VERSION = '6.1.1'.freeze
3
+ VERSION = '6.5.1'.freeze
4
4
  end
5
5
  end
data/rails.yml CHANGED
@@ -45,8 +45,17 @@ Rails/RenderPlainText:
45
45
  Enabled: True
46
46
 
47
47
  Rails/ShortI18n:
48
- Enabled: True
48
+ Enabled: False
49
49
 
50
50
  Rails/WhereExists:
51
51
  Enabled: True
52
52
 
53
+ # rubocop-rails 2.8
54
+ Rails/AfterCommitOverride:
55
+ Enabled: True
56
+
57
+ Rails/SquishedSQLHeredocs:
58
+ Enabled: False
59
+
60
+ Rails/WhereNot:
61
+ Enabled: True
@@ -22,15 +22,15 @@ Gem::Specification.new do |s|
22
22
  s.require_paths = ['lib']
23
23
  s.required_ruby_version = '>= 2.5.7'
24
24
 
25
- s.add_dependency 'rubocop', '>= 0.89'
26
- s.add_dependency 'rubocop-performance', '>= 1.7'
27
- s.add_dependency 'rubocop-rails', '>= 2.7'
28
- s.add_dependency 'rubocop-rspec', '~> 1.32'
25
+ s.add_dependency 'rubocop', '>= 1.0.0'
26
+ s.add_dependency 'rubocop-performance', '>= 1.8.1'
27
+ s.add_dependency 'rubocop-rails', '>= 2.8.1'
28
+ s.add_dependency 'rubocop-rspec', '>= 1.44.1'
29
29
  s.add_dependency 'rubocop-vendor', '~> 0'
30
30
 
31
31
  s.add_development_dependency 'bundler'
32
32
  s.add_development_dependency 'bundler-audit'
33
33
  s.add_development_dependency 'git'
34
34
  s.add_development_dependency 'rake'
35
- s.add_development_dependency 'rspec', '~> 3.0'
35
+ s.add_development_dependency 'rspec', '~> 3.9.0'
36
36
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: ws-style
3
3
  version: !ruby/object:Gem::Version
4
- version: 6.1.1
4
+ version: 6.5.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Peter Graham
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2020-09-04 00:00:00.000000000 Z
11
+ date: 2020-11-30 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,56 +16,56 @@ dependencies:
16
16
  requirements:
17
17
  - - ">="
18
18
  - !ruby/object:Gem::Version
19
- version: '0.89'
19
+ version: 1.0.0
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - ">="
25
25
  - !ruby/object:Gem::Version
26
- version: '0.89'
26
+ version: 1.0.0
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rubocop-performance
29
29
  requirement: !ruby/object:Gem::Requirement
30
30
  requirements:
31
31
  - - ">="
32
32
  - !ruby/object:Gem::Version
33
- version: '1.7'
33
+ version: 1.8.1
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - ">="
39
39
  - !ruby/object:Gem::Version
40
- version: '1.7'
40
+ version: 1.8.1
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: rubocop-rails
43
43
  requirement: !ruby/object:Gem::Requirement
44
44
  requirements:
45
45
  - - ">="
46
46
  - !ruby/object:Gem::Version
47
- version: '2.7'
47
+ version: 2.8.1
48
48
  type: :runtime
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - ">="
53
53
  - !ruby/object:Gem::Version
54
- version: '2.7'
54
+ version: 2.8.1
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: rubocop-rspec
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
- - - "~>"
59
+ - - ">="
60
60
  - !ruby/object:Gem::Version
61
- version: '1.32'
61
+ version: 1.44.1
62
62
  type: :runtime
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
- - - "~>"
66
+ - - ">="
67
67
  - !ruby/object:Gem::Version
68
- version: '1.32'
68
+ version: 1.44.1
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: rubocop-vendor
71
71
  requirement: !ruby/object:Gem::Requirement
@@ -142,14 +142,14 @@ dependencies:
142
142
  requirements:
143
143
  - - "~>"
144
144
  - !ruby/object:Gem::Version
145
- version: '3.0'
145
+ version: 3.9.0
146
146
  type: :development
147
147
  prerelease: false
148
148
  version_requirements: !ruby/object:Gem::Requirement
149
149
  requirements:
150
150
  - - "~>"
151
151
  - !ruby/object:Gem::Version
152
- version: '3.0'
152
+ version: 3.9.0
153
153
  description: Shared config to enforce Ruby style consistently across Wealthsimple
154
154
  services.
155
155
  email: