ws-style 6.1.0 → 6.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5210fc8649116d987ca8139168c9962a38ff06c0e5fb1e345c2c131f7884842
-  data.tar.gz: d10be9d6f856a40b4f2217c5497fccea304a96238af6ad2039bfacd8c9caf408
+  metadata.gz: c2c80e18e9cafebd36956f127091b925cc33246ce4294515643283cdf76c90ea
+  data.tar.gz: ca2d889d8b8254fa537fe3eb893511033f6873cd20f84483510fef1503aae96c
 SHA512:
-  metadata.gz: 1db89b905a23779cfd611eb18eb10655308cde5a9fd2745f278bfcec9f3a6b04bb7bbcf7f0ad3079c7735ca5138b8d47c712e07fef738563173b3fddaa37ed62
-  data.tar.gz: d6797dd1e5014b482d3d9da9cabf3fb3197fd525d915f1dc1337138c291fdb5be6806710a4a1bbb5ad1c6a558c3d1b7093ab9b5e3ed9da01aa5381db9a4825eb
+  metadata.gz: a3fb2387578095dfe4b4db4dd78cb2327b1f5a3be125e2720b06fe2c9d21b54855d39240fd0910258b2bed23ac54082bb5bf82de191b58b284e2bf23237895b5
+  data.tar.gz: 3e973a4d4bdf5d28a2ddbefa1d110fe40b6c1201d1fabd709476b9ca3dce86cb29b8095df17e17c70278b18a5d5e1f4f7a1d18308a5a277f99821e47ddeff64a

data/CHANGELOG.md

@@ -4,6 +4,21 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 6.5.0 - 2020-10-26
+- Upgrade RuboCop and RuboCop RSpec
+
+## 6.4.0 - 2020-10-07
+- Upgrade RuboCop
+
+## 6.3.0 - 2020-10-06
+- Upgrade RuboCop and enable cops that were voted in
+
+## 6.2.0 - 2020-09-04
+- Disable Cops enabled in 6.1.0 until we can confirm we want them
+
+## 6.1.1 - 2020-09-04
+- Disable RSpec/MultipleMemoizedHelpers cop
+
 ## 6.1.0 - 2020-08-27
 - Upgraded rubocop to 0.89
 - Upgraded rubocop-performance to 1.7

data/Rakefile

@@ -1,6 +1,31 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop"
+require "rubocop-performance"
+require "rubocop-rails"
+require "rubocop-rspec"
 
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
+
+desc 'Print out comments that can be used for a GitHub cop election'
+task :election do # rubocop:disable Rails/RakeEnvironment
+  configuration_path = File.expand_path('default.yml', File.dirname(__FILE__))
+  RuboCop::ConfigLoader.load_file(configuration_path).pending_cops.each do |pending_cop|
+    base_urls = {
+      'layout' => 'https://docs.rubocop.org/rubocop/cops_layout.html#layout',
+      'lint' => 'https://docs.rubocop.org/rubocop/cops_lint.html#lint',
+      'style' => 'https://docs.rubocop.org/rubocop/cops_style.html#style',
+      'performance' => 'https://docs.rubocop.org/rubocop-performance/cops_performance.html#performance',
+      'rails' => 'https://docs.rubocop.org/rubocop-rails/cops_rails.html#rails',
+      'rspec' => 'https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspec',
+    }
+    department, anchor = pending_cop.name.downcase.split('/')
+    puts <<~COMMENT
+      [**#{pending_cop.name}**](#{base_urls.fetch(department)}#{anchor})
+      #{pending_cop.metadata.fetch('Description')}
+
+    COMMENT
+  end
+end

data/core.yml

@@ -157,6 +157,9 @@ RSpec/MessageChain:
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NamedSubject:
   Enabled: false
 
@@ -276,7 +279,7 @@ Style/ExplicitBlockArgument:
   Enabled: True
 
 Style/GlobalStdStream:
-  Enabled: True
+  Enabled: False
 
 Style/OptionalBooleanParameter:
   Enabled: True
@@ -311,3 +314,32 @@ Performance/Squeeze:
 
 Performance/StringInclude:
   Enabled: True
+
+# 0.90
+Lint/DuplicateRequire:
+  Enabled: True
+
+Lint/EmptyFile:
+  Enabled: True
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: True
+
+Lint/UselessMethodDefinition:
+  Enabled: True
+
+Style/CombinableLoops:
+  Enabled: True
+
+Style/KeywordParametersOrder:
+  Enabled: True
+
+Style/RedundantSelfAssignment:
+  Enabled: True
+
+Style/SoleNestedConditional:
+  Enabled: True
+
+# rubocop-performance 1.7
+Performance/Sum:
+  Enabled: True

data/lib/ws/style/version.rb

@@ -1,5 +1,5 @@
 module Ws
   module Style
-    VERSION = '6.1.0'.freeze
+    VERSION = '6.5.0'.freeze
   end
 end

data/rails.yml

@@ -45,8 +45,17 @@ Rails/RenderPlainText:
   Enabled: True
 
 Rails/ShortI18n:
-  Enabled: True
+  Enabled: False
 
 Rails/WhereExists:
   Enabled: True
 
+# rubocop-rails 2.8
+Rails/AfterCommitOverride:
+  Enabled: True
+
+Rails/SquishedSQLHeredocs:
+  Enabled: False
+
+Rails/WhereNot:
+  Enabled: True

data/ws-style.gemspec

@@ -22,15 +22,15 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
   s.required_ruby_version = '>= 2.5.7'
 
-  s.add_dependency 'rubocop', '>= 0.89'
-  s.add_dependency 'rubocop-performance', '>= 1.7'
-  s.add_dependency 'rubocop-rails', '>= 2.7'
-  s.add_dependency 'rubocop-rspec', '~> 1.32'
+  s.add_dependency 'rubocop', '>= 1.0.0'
+  s.add_dependency 'rubocop-performance', '>= 1.8.1'
+  s.add_dependency 'rubocop-rails', '>= 2.8.1'
+  s.add_dependency 'rubocop-rspec', '>= 1.44.1'
   s.add_dependency 'rubocop-vendor', '~> 0'
 
   s.add_development_dependency 'bundler'
   s.add_development_dependency 'bundler-audit'
   s.add_development_dependency 'git'
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec', '~> 3.0'
+  s.add_development_dependency 'rspec', '~> 3.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ws-style
 version: !ruby/object:Gem::Version
-  version: 6.1.0
+  version: 6.5.0
 platform: ruby
 authors:
 - Peter Graham
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-27 00:00:00.000000000 Z
+date: 2020-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.89'
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.89'
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: 2.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: 2.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: 1.44.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: 1.44.1
 - !ruby/object:Gem::Dependency
   name: rubocop-vendor
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.9.0
 description: Shared config to enforce Ruby style consistently across Wealthsimple
   services.
 email: