ws-style 0.4.7 → 1.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (7) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +2 -0
  3. data/README.md +4 -0
  4. data/default.yml +44 -42
  5. data/lib/ws/style/version.rb +1 -1
  6. data/ws-style.gemspec +2 -2
  7. metadata +6 -5
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: fff4eb25316111ef85c4bc14e63ab473a9dc07b679917f77725ff83499b89019
4
- data.tar.gz: 70e74b6e67a8343a8d6e8d224feab8af61bfb813b4fde8d212a9b1a68e3eb5fc
3
+ metadata.gz: 34863280aa54bba02c70201cfa2be8501891e20c58e790a96248a06dfc983317
4
+ data.tar.gz: a504675010cf1fc4bf7e762686c0e52f9e3ee009bd97f763a134ba953c231dc9
5
5
  SHA512:
6
- metadata.gz: d066af3761e9d7749a3de8768b63d4003e99f375a553a933bf0581b874a594f244bdb6d29555999922c53b22711b23ccfb7b70633035fe7909c2be9dc8b24693
7
- data.tar.gz: 8128c35e873d096828c392403b0f865359892710cece0ab48f09c7d9d3a00eaa7328ea405e41643840cb7b4da3014e4a45a26110b08f52979d71bfd5419f1e18
6
+ metadata.gz: 52197ba848b4aaf6e4d9df9f93aebd7d18f2436ebb3d0b74488a1d48ad37663019190ce5a71d2dea1b76098f046f8101e751c875d1deba81168813bf440a2704
7
+ data.tar.gz: f346639de4f3654730d2d5aeabb42e3e38e67bb93b20b58b53a31b5ccee2b3315eae0d982ee90617d290b7790299cfa22ed53e526dd29e33b380daf41316509a
data/.rubocop.yml ADDED
@@ -0,0 +1,2 @@
1
+ inherit_from:
2
+ - default.yml
data/README.md CHANGED
@@ -2,6 +2,10 @@
2
2
 
3
3
  Shared [rubocop](https://github.com/bbatsov/rubocop) config to enforce Ruby style consistently across Wealthsimple libraries and services.
4
4
 
5
+ # Upgrading to 1.x
6
+
7
+ 1.x adds a number of Cops to our default.yml. See the relevant Quip for more information on how to upgrade.
8
+
5
9
  ## Installation
6
10
 
7
11
  Add this line to your application's Gemfile and execute `bundle`:
data/default.yml CHANGED
@@ -2,108 +2,95 @@
2
2
  # https://rubocop.readthedocs.io
3
3
 
4
4
  AllCops:
5
- DisplayCopNames: true
6
5
  Exclude:
7
- - '*.gemspec'
8
6
  - 'bin/**/*'
9
7
  - 'data/**/*'
10
- - 'db/schema.rb'
11
- - 'db/data_schema.rb'
8
+ - 'db/**/*'
12
9
  - 'gemfiles/**/*'
13
- - 'lib/tasks/circle_0.rake' # Ignore circleci code
10
+ - 'lib/tasks/circle_0.rake'
14
11
  - 'log/**/*'
12
+ - 'node_modules/**/*'
15
13
  - 'public/**/*'
16
14
  - 'tmp/**/*'
17
15
  - 'vendor/**/*'
18
16
 
19
- Layout/DotPosition:
20
- Enabled: false
17
+ Layout/AlignHash:
18
+ EnforcedLastArgumentHashStyle: ignore_implicit
21
19
 
22
- Layout/ExtraSpacing:
20
+ Layout/AlignParameters:
23
21
  Enabled: false
24
22
 
25
- Layout/IndentHash:
26
- Enabled: false
23
+ Lint/AmbiguousBlockAssociation:
24
+ Exclude:
25
+ - 'spec/**/*'
27
26
 
28
27
  Layout/IndentArray:
29
28
  EnforcedStyle: consistent
30
29
 
31
- Layout/MultilineMethodCallIndentation:
30
+ Layout/CaseIndentation:
32
31
  Enabled: false
33
32
 
34
- Layout/SpaceBeforeBlockBraces:
33
+ Layout/ElseAlignment:
35
34
  Enabled: false
36
35
 
37
- Layout/SpaceBeforeFirstArg:
36
+ Layout/EndAlignment:
38
37
  Enabled: false
39
38
 
40
- Lint/AmbiguousBlockAssociation:
39
+ Layout/IndentationWidth:
41
40
  Enabled: false
42
41
 
42
+ Layout/IndentHash:
43
+ EnforcedStyle: consistent
44
+
45
+ Layout/MultilineMethodCallIndentation:
46
+ EnforcedStyle: indented
47
+
43
48
  Metrics/AbcSize:
44
- Enabled: false
49
+ Max: 18
45
50
 
46
51
  Metrics/BlockLength:
47
52
  Enabled: false
48
53
 
49
54
  Metrics/ClassLength:
50
- Enabled: false
55
+ Max: 150
51
56
 
52
57
  Metrics/CyclomaticComplexity:
53
- Enabled: false
58
+ Max: 7
54
59
 
55
60
  Metrics/LineLength:
56
- Enabled: false
61
+ IgnoredPatterns: ['(\A|\s)#']
62
+ Max: 100
57
63
 
58
64
  Metrics/MethodLength:
59
- Enabled: false
60
-
61
- Metrics/ModuleLength:
62
- Enabled: false
65
+ Max: 12
63
66
 
64
67
  Metrics/ParameterLists:
65
68
  Enabled: false
66
69
 
67
70
  Metrics/PerceivedComplexity:
68
- Enabled: false
69
-
70
- Style/Alias:
71
- Enabled: false
71
+ Max: 8
72
72
 
73
73
  Style/AndOr:
74
74
  EnforcedStyle: conditionals
75
75
 
76
- Style/BracesAroundHashParameters:
76
+ Style/BlockDelimiters:
77
77
  Enabled: false
78
78
 
79
- Style/ClassVars:
79
+ Style/BracesAroundHashParameters:
80
80
  Enabled: false
81
81
 
82
- Style/CommentAnnotation:
82
+ Style/ClassAndModuleChildren:
83
83
  Enabled: false
84
84
 
85
85
  Style/Documentation:
86
86
  Enabled: false
87
87
 
88
- Style/FormatString:
89
- Enabled: false
90
-
91
88
  Style/FrozenStringLiteralComment:
92
89
  Enabled: false
93
90
 
94
- Style/GuardClause:
95
- Enabled: false
96
-
97
- Style/Lambda:
98
- Enabled: false
99
-
100
91
  Style/NumericPredicate:
101
92
  Enabled: false
102
93
 
103
- Style/PercentLiteralDelimiters:
104
- Enabled: false
105
-
106
- # Allow use of both single and double quotes for strings.
107
94
  Style/StringLiterals:
108
95
  Enabled: false
109
96
 
@@ -121,3 +108,18 @@ Style/TrailingCommaInHashLiteral:
121
108
 
122
109
  Style/WordArray:
123
110
  Enabled: false
111
+
112
+ Rails:
113
+ Enabled: true
114
+
115
+ Rails/Date:
116
+ Enabled: false
117
+
118
+ Rails/Delegate:
119
+ Enabled: false
120
+
121
+ Rails/SkipsModelValidations:
122
+ Enabled: false
123
+
124
+ Rails/TimeZone:
125
+ Enabled: false
data/lib/ws/style/version.rb CHANGED
@@ -1,5 +1,5 @@
1
1
  module Ws
2
2
  module Style
3
- VERSION = '0.4.7'.freeze
3
+ VERSION = '1.0.0'.freeze
4
4
  end
5
5
  end
data/ws-style.gemspec CHANGED
@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
11
11
  s.email = ['peterghm@gmail.com']
12
12
 
13
13
  s.summary = 'Shared rubocop config'
14
- s.description = 'Shared rubocop config to enforce Ruby style consistently across Wealthsimple services.'
14
+ s.description = 'Shared config to enforce Ruby style consistently across Wealthsimple services.'
15
15
  s.homepage = 'https://github.com/wealthsimple/ws-style'
16
16
 
17
17
  s.files = `git ls-files -z`.split("\x0").reject do |f|
@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
21
21
  s.executables = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
22
22
  s.require_paths = ['lib']
23
23
 
24
- s.add_dependency 'rubocop', '~> 0.62'
24
+ s.add_dependency 'rubocop', '~> 0.64'
25
25
 
26
26
  s.add_development_dependency 'bundler'
27
27
  s.add_development_dependency 'bundler-audit'
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: ws-style
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.4.7
4
+ version: 1.0.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Peter Graham
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2019-01-07 00:00:00.000000000 Z
11
+ date: 2019-02-11 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - "~>"
18
18
  - !ruby/object:Gem::Version
19
- version: '0.62'
19
+ version: '0.64'
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - "~>"
25
25
  - !ruby/object:Gem::Version
26
- version: '0.62'
26
+ version: '0.64'
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: bundler
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -94,7 +94,7 @@ dependencies:
94
94
  - - "~>"
95
95
  - !ruby/object:Gem::Version
96
96
  version: '3.0'
97
- description: Shared rubocop config to enforce Ruby style consistently across Wealthsimple
97
+ description: Shared config to enforce Ruby style consistently across Wealthsimple
98
98
  services.
99
99
  email:
100
100
  - peterghm@gmail.com
@@ -107,6 +107,7 @@ files:
107
107
  - ".github/PULL_REQUEST_TEMPLATE.md"
108
108
  - ".gitignore"
109
109
  - ".rspec"
110
+ - ".rubocop.yml"
110
111
  - ".ruby-version"
111
112
  - CHANGELOG.md
112
113
  - Gemfile