writeexcel 1.0.5 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e036ee78c56e41a25c0c346a2cbc93b579e4f54d
-  data.tar.gz: 20f79a79efa1699803e993ee52aa70665baabcea
+SHA256:
+  metadata.gz: 210718d145e6c74ec1b4ff8242a80937d3fe3de27815decd8a79856fa2f6ae73
+  data.tar.gz: 3ba1e17f91c2093e715cdb14964814cf67adad44890dd8286aac3e1568a09a6b
 SHA512:
-  metadata.gz: 1bb714fcc9f5a3ce118732cce6e4b21623237831ee25d5ab90970320140bc716cb88907ef3326f758f2a909fbdee8f45f1b9d926a72081361cd57d5fc11333a5
-  data.tar.gz: 8b89087c85738f136750da5673e3e0fb4bf95158053dbb9d8d00345715c30d22d8372e68d7c1efddc6674a6a9537ed89b46c9d37ca0d4ca0e15e8a188b2b900a
+  metadata.gz: 28357fc96e5c28bf45924743c758111deb2e8ca5386dcd8efcbd1fdabcae277a8d3756c21d2e9b6b454f10558f9615d28c1b77ef25c8cda3d9335bd24d027c9a
+  data.tar.gz: 36c16f58a152fbfd64d1cd4af38bbdf5a9bccf77962da6cc5436fb70a080bc164e1178ebf0a70296c96232c3143ce775cb74ed31698e4ca2f49d8fc4e884335d

data/.github/workflows/test-suite.yml

@@ -0,0 +1,26 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: test-suite
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [3.3, 3.2, 3.1, '3.0', 2.7, 2.6, 2.5, 2.4]
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - run: bundle exec rake

data/README.rdoc

@@ -3,6 +3,7 @@
 Write to a cross-platform Excel binary file.
 
 {<img src="https://badge.fury.io/rb/writeexcel.png" alt="Gem Version" />}[http://badge.fury.io/rb/writeexcel]
+{<img src="https://travis-ci.org/cxn03651/writeexcel.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/cxn03651/writeexcel]
 
 == Description
 
@@ -84,6 +85,14 @@ Example Code:
 * and ......
 
 == Recent Change
+v1.0.7
+* support Ruby 3.3
+* support Ruby 2.4 or later
+
+v1.0.6
+* support Ruby 3.2
+* use minitest gem instead of test-unit.
+
 v1.0.5
 * use test-unit gem instead of test/unit.
 
@@ -107,8 +116,8 @@ v1.0.0
 
 Original was written in Perl by John McNamara (jmcnamara@cpan.org).
 
-Convert to ruby by Hideo Nakamura (cxn03651@msj.biglobe.ne.jp)
-Copyright (c) 2009-2014 Hideo NAKAMURA. See LICENSE.txt for details.
+Convert to ruby by Hideo Nakamura (nakamura.hideo@gmail.com)
+Copyright (c) 2009-2024 Hideo NAKAMURA. See LICENSE.txt for details.
 
 == License
 

data/lib/writeexcel/biffwriter.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 #
 # BIFFwriter - An abstract base class for Excel workbooks and worksheets.
 #
@@ -187,7 +188,7 @@ class BIFFWriter < WriteFile       #:nodoc:
     # The header contains version and instance info packed into 2 bytes.
     header  = version | (instance << 4)
 
-    record  = [header, type, length].pack('vvV') + data
+    [header, type, length].pack('vvV') + data
   end
 
   def not_using_tmpfile

data/lib/writeexcel/cell_range.rb

@@ -6,6 +6,7 @@ class Worksheet < BIFFWriter
 
     def initialize(worksheet)
       @worksheet = worksheet
+      @row_min = @row_max = @col_min = @col_max = nil
     end
 
     def increment_row_max

data/lib/writeexcel/chart.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 ###############################################################################
 #
 # Chart - A writer class for Excel Charts.
@@ -649,8 +650,6 @@ class Chart < Worksheet
   # information required for _store_series() and the SERIES record.
   #
   def parse_series_formula(formula)  # :nodoc:
-    encoding = 0
-    length   = 0
     count    = 0
     tokens = []
 
@@ -677,7 +676,7 @@ class Chart < Worksheet
 
     # Extract the range from the parse formula.
     if formula.ord == 0x3B
-        ptg, ext_ref, row_1, row_2, col_1, col_2 = formula.unpack('Cv5')
+        row_1, row_2 = formula.unpack('Cv5')[2, 2]
 
         # TODO. Remove high bit on relative references.
         count = row_2 - row_1 + 1

data/lib/writeexcel/charts/area.rb

@@ -13,7 +13,7 @@
 # converted to Ruby by Hideo Nakamura, cxn03651@msj.biglobe.ne.jp
 #
 
-require 'writeexcel'
+require 'writeexcel/chart'
 
 module Writeexcel
 

data/lib/writeexcel/charts/pie.rb

@@ -13,7 +13,7 @@
 # converted to Ruby by Hideo Nakamura, cxn03651@msj.biglobe.ne.jp
 #
 
-require 'writeexcel'
+require 'writeexcel/chart'
 
 module Writeexcel
 

data/lib/writeexcel/charts/scatter.rb

@@ -13,7 +13,7 @@
 # converted to Ruby by Hideo Nakamura, cxn03651@msj.biglobe.ne.jp
 #
 
-require 'writeexcel'
+require 'writeexcel/chart'
 
 module Writeexcel
 

data/lib/writeexcel/charts/stock.rb

@@ -13,7 +13,7 @@
 # converted to Ruby by Hideo Nakamura, cxn03651@msj.biglobe.ne.jp
 #
 
-require 'writeexcel'
+require 'writeexcel/chart'
 
 module Writeexcel
 

data/lib/writeexcel/col_info.rb

@@ -54,9 +54,9 @@ class Worksheet < BIFFWriter
 
     def ixfe
       if @format && @format.respond_to?(:xf_index)
-        ixfe = @format.xf_index
+        @format.xf_index
       else
-        ixfe = 0x0F
+        0x0F
       end
     end
 

data/lib/writeexcel/comments.rb

@@ -6,6 +6,7 @@ class Worksheet < BIFFWriter
   class Collection
     def initialize
       @items = {}
+      @array = nil
     end
 
     def <<(item)
@@ -252,7 +253,7 @@ class Worksheet < BIFFWriter
       when 65533 then 65529
       when 65534 then 65530
       when 65535 then 65531
-      else            @row -1
+      else            @row - 1
       end
     end
 

data/lib/writeexcel/convert_date_time.rb

@@ -81,7 +81,7 @@ module ConvertDateTime
     epoch   = date_1904 ? 1904 : 1900
     offset  = date_1904 ?    4 :    0
     norm    = 300
-    range   = year -epoch
+    range   = year - epoch
 
     # Set month days and check for leap year.
     mdays   = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]
@@ -92,15 +92,15 @@ module ConvertDateTime
     # Some boundary checks
     return nil if year  < epoch or year  > 9999
     return nil if month < 1     or month > 12
-    return nil if day   < 1     or day   > mdays[month -1]
+    return nil if day   < 1     or day   > mdays[month - 1]
 
     # Accumulate the number of days since the epoch.
     days = mdays[0, month - 1].inject(day) {|result, mday| result + mday} # days from 1, Jan
-    days += range *365                       # Add days for past years
-    days += ((range)                /  4)    # Add leapdays
-    days -= ((range + offset)       /100)    # Subtract 100 year leapdays
-    days += ((range + offset + norm)/400)    # Add 400 year leapdays
-    days -= leap                             # Already counted above
+    days += range * 365                        # Add days for past years
+    days += ((range)                 /   4)    # Add leapdays
+    days -= ((range + offset)        / 100)    # Subtract 100 year leapdays
+    days += ((range + offset + norm) / 400)    # Add 400 year leapdays
+    days -= leap                               # Already counted above
 
     # Adjust for Excel erroneously treating 1900 as a leap year.
     days += 1 if !date_1904 and days > 59

data/lib/writeexcel/excelformulaparser.rb

@@ -1,11 +1,12 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 #
 # DO NOT MODIFY!!!!
 # This file is automatically generated by Racc 1.4.11
 # from Racc grammer file "".
 #
 
-require 'racc/parser.rb'
+require 'racc/parser'
 class ExcelFormulaParser < Racc::Parser  # :nodoc:
 ##### State transition tables begin ###
 
@@ -293,14 +294,14 @@ Racc_debug_parser = false
 
 module_eval(<<'.,.,', 'excelformula.y', 20)
   def _reduce_2(val, _values, result)
-     result = [] 
+     result = []
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 21)
   def _reduce_3(val, _values, result)
-     result.push val[1], '_arg', '1' 
+     result.push val[1], '_arg', '1'
     result
   end
 .,.,
@@ -309,84 +310,84 @@ module_eval(<<'.,.,', 'excelformula.y', 21)
 
 module_eval(<<'.,.,', 'excelformula.y', 24)
   def _reduce_5(val, _values, result)
-     result = [ val[0], val[2], 'ptgAdd' ] 
+     result = [ val[0], val[2], 'ptgAdd' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 25)
   def _reduce_6(val, _values, result)
-     result = [ val[0], val[2], 'ptgSub' ] 
+     result = [ val[0], val[2], 'ptgSub' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 26)
   def _reduce_7(val, _values, result)
-     result = [ val[0], val[2], 'ptgMul' ] 
+     result = [ val[0], val[2], 'ptgMul' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 27)
   def _reduce_8(val, _values, result)
-     result = [ val[0], val[2], 'ptgDiv' ] 
+     result = [ val[0], val[2], 'ptgDiv' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 28)
   def _reduce_9(val, _values, result)
-     result = [ val[0], val[2], 'ptgPower' ] 
+     result = [ val[0], val[2], 'ptgPower' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 29)
   def _reduce_10(val, _values, result)
-     result = [ val[0], val[2], 'ptgConcat' ] 
+     result = [ val[0], val[2], 'ptgConcat' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 30)
   def _reduce_11(val, _values, result)
-     result = [ val[0], val[2], 'ptgLT' ] 
+     result = [ val[0], val[2], 'ptgLT' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 31)
   def _reduce_12(val, _values, result)
-     result = [ val[0], val[2], 'ptgGT' ] 
+     result = [ val[0], val[2], 'ptgGT' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 32)
   def _reduce_13(val, _values, result)
-     result = [ val[0], val[2], 'ptgLE' ] 
+     result = [ val[0], val[2], 'ptgLE' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 33)
   def _reduce_14(val, _values, result)
-     result = [ val[0], val[2], 'ptgGE' ] 
+     result = [ val[0], val[2], 'ptgGE' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 34)
   def _reduce_15(val, _values, result)
-     result = [ val[0], val[2], 'ptgNE' ] 
+     result = [ val[0], val[2], 'ptgNE' ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 35)
   def _reduce_16(val, _values, result)
-     result = [ val[0], val[2], 'ptgEQ' ] 
+     result = [ val[0], val[2], 'ptgEQ' ]
     result
   end
 .,.,
@@ -395,14 +396,14 @@ module_eval(<<'.,.,', 'excelformula.y', 35)
 
 module_eval(<<'.,.,', 'excelformula.y', 38)
   def _reduce_18(val, _values, result)
-     result = [ val[1], '_arg', '1', 'ptgParen'] 
+     result = [ val[1], '_arg', '1', 'ptgParen']
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 39)
   def _reduce_19(val, _values, result)
-     result = [ '_num', '-1', val[1], 'ptgMul' ] 
+     result = [ '_num', '-1', val[1], 'ptgMul' ]
     result
   end
 .,.,
@@ -411,63 +412,63 @@ module_eval(<<'.,.,', 'excelformula.y', 39)
 
 module_eval(<<'.,.,', 'excelformula.y', 41)
   def _reduce_21(val, _values, result)
-     result = [ '_num',     val[0] ] 
+     result = [ '_num',     val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 42)
   def _reduce_22(val, _values, result)
-     result = [ '_str',     val[0] ] 
+     result = [ '_str',     val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 43)
   def _reduce_23(val, _values, result)
-     result = [ '_ref2d',   val[0] ] 
+     result = [ '_ref2d',   val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 44)
   def _reduce_24(val, _values, result)
-     result = [ '_ref3d',   val[0] ] 
+     result = [ '_ref3d',   val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 45)
   def _reduce_25(val, _values, result)
-     result = [ '_range2d', val[0] ] 
+     result = [ '_range2d', val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 46)
   def _reduce_26(val, _values, result)
-     result = [ '_range3d', val[0] ] 
+     result = [ '_range3d', val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 47)
   def _reduce_27(val, _values, result)
-     result = [ '_name',    val[0] ] 
+     result = [ '_name',    val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 48)
   def _reduce_28(val, _values, result)
-     result = [ 'ptgBool',  '1'    ] 
+     result = [ 'ptgBool',  '1'    ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 49)
   def _reduce_29(val, _values, result)
-     result = [ 'ptgBool',  '0'    ] 
+     result = [ 'ptgBool',  '0'    ]
     result
   end
 .,.,
@@ -476,28 +477,28 @@ module_eval(<<'.,.,', 'excelformula.y', 49)
 
 module_eval(<<'.,.,', 'excelformula.y', 52)
   def _reduce_31(val, _values, result)
-     result = [ '_class', val[0], val[2], '_arg', val[2].size.to_s, '_func', val[0] ] 
+     result = [ '_class', val[0], val[2], '_arg', val[2].size.to_s, '_func', val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 53)
   def _reduce_32(val, _values, result)
-     result = [ '_func', val[0] ] 
+     result = [ '_func', val[0] ]
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 55)
   def _reduce_33(val, _values, result)
-     result = val 
+     result = val
     result
   end
 .,.,
 
 module_eval(<<'.,.,', 'excelformula.y', 56)
   def _reduce_34(val, _values, result)
-     result.push val[2] 
+     result.push val[2]
     result
   end
 .,.,
@@ -515,70 +516,69 @@ end
 module Writeexcel
 
    class Node  # :nodoc:
-   
+
       def exec_list(nodes)
          v = nil
          nodes.each { |i| v = i.evaluate }
          v
       end
-   
+
       def excelformulaparser_error(msg)
          raise ExcelFormulaParserError,
                   "in #{fname}:#{lineno}: #{msg}"
       end
-   
+
    end
-   
+
    class RootNode < Node  # :nodoc:
-   
+
       def initialize(tree)
          @tree = tree
       end
-   
+
       def evaluate
          exec_list @tree
       end
-   
+
    end
-   
-   
+
+
    class FuncallNode < Node  # :nodoc:
-   
+
       def initialize(func, args)
          @func = func
          @args = args
       end
-   
+
       def evaluate
          arg = @args.collect {|i| i.evaluate }
-         out = []
          arg.each { |i| o.push i }
          o.push @func
          p o
       end
-   
+
    end
-   
+
    class NumberNode < Node  # :nodoc:
-   
+
       def initialize(val)
          @val = val
       end
-   
+
       def evaluate
          p @val
       end
-   
+
    end
-   
+
    class OperateNode < Node  # :nodoc:
-   
+
       def initialize(op, left, right)
          @op = op
          @left = left
          @right = right
       end
-   
+
       def evaluate
          o = []
          o.push @left

data/lib/writeexcel/format.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 ##############################################################################
 #
 # Format - A class for defining Excel formatting.
@@ -1572,4 +1573,3 @@ class Format < Colors
 end  # class Format
 
 end  # module Writeexcel
-

data/lib/writeexcel/formula.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 ###############################################################################
 #
 # Formula - A class for generating Excel formulas.
@@ -62,7 +63,6 @@ class Formula < ExcelFormulaParser       #:nodoc:
   #
   def parse_tokens(tokens)
     parse_str   = ''
-    last_type   = ''
     modifier    = ''
     num_args    = 0
     _class      = 0

data/lib/writeexcel/helper.rb

@@ -42,9 +42,9 @@
   private :utf8_to_16le
 
   def ascii_to_16be(ascii)
-    ascii.unpack("C*").pack("n*")
-    ruby_19 { ascii.force_encoding('UTF-16BE') }
-    ascii
+    str_16be = ascii.unpack("C*").pack("n*")
+    ruby_19 { str_16be.force_encoding('UTF-16BE') }
+    str_16be
   end
   private :ascii_to_16be
 

data/lib/writeexcel/properties.rb

@@ -178,7 +178,7 @@ end
 #
 def pack_VT_I2(value)       #:nodoc:
     type    = 0x0002
-    data = [type, value].pack('VV')
+    [type, value].pack('VV')
 end
 
 ###############################################################################

data/lib/writeexcel/shared_string_table.rb

@@ -109,10 +109,10 @@ class Workbook < BIFFWriter
             written      += space_remaining
 
             # Reduce the current block length by the amount written
-            block_length -= continue_limit -continue -align
+            block_length -= continue_limit - continue - align
 
             # Store the max size for this block
-            block_sizes.push(continue_limit -align)
+            block_sizes.push(continue_limit - align)
 
             # If the current string was split then the next CONTINUE block
             # should have the string continue flag (grbit) set unless the
@@ -125,10 +125,10 @@ class Workbook < BIFFWriter
             end
           else
             # Store the max size for this block
-            block_sizes.push(written +continue)
+            block_sizes.push(written + continue)
 
             # Not enough space to start the string in the current block
-            block_length -= continue_limit -space_remaining -continue
+            block_length -= continue_limit - space_remaining - continue
             continue = 0
           end
 
@@ -145,7 +145,7 @@ class Workbook < BIFFWriter
       end
 
       # Store the max size for the last block unless it is empty
-      block_sizes.push(written +continue) if written +continue != 0
+      block_sizes.push(written + continue) if written + continue != 0
 
       block_sizes
     end