writeexcel 0.6.18 → 0.6.19

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 9f08faee160c80efda98d7e3f42d07aa547a92ca
+  data.tar.gz: d1e75487c065ad0ac74dc978aac6218c21621aa3
+SHA512:
+  metadata.gz: c6e152b9677247808da606c2bacb7f403b4c45f3f6f093ce6958a5de510d1bac8c81adb3f2e47591ffa79183f348db3c5f4429264c4d96abc81783eb6e6cb33f
+  data.tar.gz: 61d1223ff7e8884ec3a92d79b8ec6af8d0f15696d0f1958c4a0a45c813d2aee5deebe0b470d6028423562a518265fd1f224d17b850c451ad506a324f71f937e2

data/README.rdoc

@@ -90,6 +90,9 @@ You must save source file in UTF8 and run ruby with -Ku option or set $KCODE='u'
 when use urf8 string data.
 
 == Recent Changes
+v0.6.19
+* Bug fix in Worksheet#write_url_internal
+
 v0.6.18
 * Bug fix in compatibility_mode (Worksheet#write_number).
 

data/examples/hyperlink2.rb

@@ -0,0 +1,129 @@
+#!/usr/bin/ruby
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+# Example of how to use the WriteExcel module to write internal and internal
+# hyperlinks.
+#
+# If you wish to run this program and follow the hyperlinks you should create
+# the following directory structure:
+#
+#     C:\ -- Temp --+-- Europe
+#                   |
+#                   \-- Asia
+#
+#
+# See also hyperlink1.rb for web URL examples.
+#
+# reverse('©'), March 2002, John McNamara, jmcnamara@cpan.org
+#
+# original written in Perl by John McNamara
+# converted to Ruby by Hideo Nakamura, cxn03651@msj.biglobe.ne.jp
+#
+require 'rubygems'
+require 'writeexcel'
+
+# Create three workbooks:
+#   C:\Temp\Europe\Ireland.xls
+#   C:\Temp\Europe\Italy.xls
+#   C:\Temp\Asia\China.xls
+#
+ireland   = WriteExcel.new('C:\Temp\Europe\Ireland.xls')
+ire_links = ireland.add_worksheet('Links')
+ire_sales = ireland.add_worksheet('Sales')
+ire_data  = ireland.add_worksheet('Product Data')
+
+italy     = WriteExcel.new('C:\Temp\Europe\Italy.xls')
+ita_links = italy.add_worksheet('Links')
+ita_sales = italy.add_worksheet('Sales')
+ita_data  = italy.add_worksheet('Product Data')
+
+china     = WriteExcel.new('C:\Temp\Asia\China.xls')
+cha_links = china.add_worksheet('Links')
+cha_sales = china.add_worksheet('Sales')
+cha_data  = china.add_worksheet('Product Data')
+
+# Add a format
+format = ireland.add_format(:color => 'green', :bold => 1)
+ire_links.set_column('A:B', 25)
+
+
+###############################################################################
+#
+# Examples of internal links
+#
+ire_links.write('A1', 'Internal links', format)
+
+# Internal link
+ire_links.write('A2', 'internal:Sales!A2')
+
+# Internal link to a range
+ire_links.write('A3', 'internal:Sales!A3:D3')
+
+# Internal link with an alternative string
+ire_links.write('A4', 'internal:Sales!A4', 'Link')
+
+# Internal link with a format
+ire_links.write('A5', 'internal:Sales!A5', format)
+
+# Internal link with an alternative string and format
+ire_links.write('A6', 'internal:Sales!A6', 'Link', format)
+
+# Internal link (spaces in worksheet name)
+ire_links.write('A7', "internal:'Product Data'!A7")
+
+
+###############################################################################
+#
+# Examples of external links
+#
+ire_links.write('B1', 'External links', format)
+
+# External link to a local file
+ire_links.write('B2', 'external:Italy.xls')
+
+# External link to a local file with worksheet
+ire_links.write('B3', 'external:Italy.xls#Sales!B3')
+
+# External link to a local file with worksheet and alternative string
+ire_links.write('B4', 'external:Italy.xls#Sales!B4', 'Link')
+
+# External link to a local file with worksheet and format
+ire_links.write('B5', 'external:Italy.xls#Sales!B5', format)
+
+# External link to a remote file, absolute path
+ire_links.write('B6', 'external:c:/Temp/Asia/China.xls')
+
+# External link to a remote file, relative path
+ire_links.write('B7', 'external:../Asia/China.xls')
+
+# External link to a remote file with worksheet
+ire_links.write('B8', 'external:c:/Temp/Asia/China.xls#Sales!B8')
+
+# External link to a remote file with worksheet (with spaces in the name)
+ire_links.write('B9', "external:c:/Temp/Asia/China.xls#'Product Data'!B9")
+
+
+###############################################################################
+#
+# Some utility links to return to the main sheet
+#
+ire_sales.write('A2', 'internal:Links!A2', 'Back')
+ire_sales.write('A3', 'internal:Links!A3', 'Back')
+ire_sales.write('A4', 'internal:Links!A4', 'Back')
+ire_sales.write('A5', 'internal:Links!A5', 'Back')
+ire_sales.write('A6', 'internal:Links!A6', 'Back')
+ire_data.write('A7', 'internal:Links!A7', 'Back')
+
+ita_links.write('A1', 'external:Ireland.xls#Links!B2', 'Back')
+ita_sales.write('B3', 'external:Ireland.xls#Links!B3', 'Back')
+ita_sales.write('B4', 'external:Ireland.xls#Links!B4', 'Back')
+ita_sales.write('B5', 'external:Ireland.xls#Links!B5', 'Back')
+cha_links.write('A1', 'external:../Europe/Ireland.xls#Links!B6', 'Back')
+cha_sales.write('B8', 'external:../Europe/Ireland.xls#Links!B8', 'Back')
+cha_data.write('B9', 'external:../Europe/Ireland.xls#Links!B9', 'Back')
+
+ireland.close
+italy.close
+china.close
+

data/lib/writeexcel/convert_date_time.rb

@@ -1,3 +1,4 @@
+# -*- encoding: utf-8 -*-
 module ConvertDateTime
   #
   # The function takes a date and time in ISO8601 "yyyy-mm-ddThh:mm:ss.ss" format
@@ -18,14 +19,7 @@ module ConvertDateTime
   #            undef if the date is invalid.
   #
   def convert_date_time(date_time_string, date_1904 = false)       #:nodoc:
-    date_time = date_time_string
-
-    days      = 0 # Number of days since epoch
-    seconds   = 0 # Time expressed as fraction of 24h hours in seconds
-
-    # Strip leading and trailing whitespace.
-    date_time.sub!(/^\s+/, '')
-    date_time.sub!(/\s+$/, '')
+    date_time = date_time_string.sub(/^\s+/, '').sub(/\s+$/, '').sub(/Z$/, '')
 
     # Check for invalid date char.
     return nil if date_time =~ /[^0-9T:\-\.Z]/
@@ -33,8 +27,7 @@ def convert_date_time(date_time_string, date_1904 = false)       #:nodoc:
     # Check for "T" after date or before time.
     return nil unless date_time =~ /\dT|T\d/
 
-    # Strip trailing Z in ISO8601 date.
-    date_time.sub!(/Z$/, '')
+    seconds   = 0 # Time expressed as fraction of 24h hours in seconds
 
     # Split into date and time.
     date, time = date_time.split(/T/)

data/lib/writeexcel/data_validations.rb

@@ -271,12 +271,11 @@ def pack_dv_formula(formula)   #:nodoc:
 
       # Strip the = sign at the beginning of the formula string
       formula = formula.to_s unless formula.respond_to?(:to_str)
-      formula.sub!(/^=/, '')
 
       # In order to raise formula errors from the point of view of the calling
       # program we use an eval block and re-raise the error from here.
       #
-      tokens = @parser.parse_formula(formula)   # ????
+      tokens = @parser.parse_formula(formula.sub(/^=/, ''))   # ????
 
       #       if ($@) {
       #           $@ =~ s/\n$//;  # Strip the \n used in the Formula.pm die()

data/lib/writeexcel/version.rb

@@ -1,5 +1,5 @@
 require 'writeexcel'
 
 class WriteExcel < Workbook
-  VERSION = "0.6.18"
+  VERSION = "0.6.19"
 end

data/lib/writeexcel/worksheet.rb

@@ -2876,13 +2876,10 @@ def write_formula(*args)
   #     worksheet3.repeat_formula('B1', now)
   #
   def store_formula(formula)       #:nodoc:
-    # Strip the = sign at the beginning of the formula string
-    formula.sub!(/^=/, '')
-
     # In order to raise formula errors from the point of view of the calling
     # program we use an eval block and re-raise the error from here.
     #
-    tokens = parser.parse_formula(formula)
+    tokens = parser.parse_formula(formula.sub(/^=/, ''))
 
     #       if ($@) {
     #           $@ =~ s/\n$//  # Strip the \n used in the Formula.pm die()
@@ -5219,10 +5216,10 @@ def write_url_internal(row1, col1, row2, col2, url, str = nil, format = nil)
     xf     = format || url_format        # The cell format
 
     # Strip URL type
-    url.sub!(/^internal:/, '')
+    url = url.sub(/^internal:/, '')
 
     # Write the visible label but protect against url recursion in write().
-    str          = url unless str
+    str          = url.dup unless str
     error        = write_string(row1, col1, str, xf)
     return error if error == -2
 
@@ -5236,13 +5233,14 @@ def write_url_internal(row1, col1, row2, col2, url, str = nil, format = nil)
     encoding    = 0
 
     # Convert an Utf8 URL type and to a null terminated wchar string.
-    if is_utf8?(str)
-      # Quote sheet name if not already, i.e., Sheet!A1 to 'Sheet!A1'.
-      url.sub!(/^(.+)!/, "'\1'!") if not url =~ /^'/
-      # URL is null terminated.
-      ruby_18 { url = utf8_to_16be(url) + "\0\0" } ||
-      ruby_19 { url = url.encode('UTF-16LE') + "\0\0".encode('UTF-16LE') }
-      encoding = 1
+    ruby_18 do
+      if is_utf8?(url)
+        # Quote sheet name if not already, i.e., Sheet!A1 to 'Sheet!A1'.
+        url = "'#{sheetname_from_url(url)}'!#{cell_from_url(url)}" if not url =~ /^'/
+        # URL is null terminated.
+        ruby_18 { url = utf8_to_16be(url) + "\0\0" } ||
+          encoding = 1
+      end
     end
 
     # Convert an Ascii URL type and to a null terminated wchar string.
@@ -5252,7 +5250,7 @@ def write_url_internal(row1, col1, row2, col2, url, str = nil, format = nil)
     end
 
     # Pack the length of the URL as chars (not wchars)
-    url_len     = [(url.length/2).to_i].pack("V")
+    url_len     = [(url.bytesize/2).to_i].pack("V")
 
     # Calculate the data length
     length         = 0x24 + url.bytesize
@@ -5267,6 +5265,16 @@ def write_url_internal(row1, col1, row2, col2, url, str = nil, format = nil)
     error
   end
 
+  def sheetname_from_url(url)
+    sheetname, cell = url.split('!')
+    sheetname
+  end
+
+  def cell_from_url(url)
+    sheetname, cell = url.split('!')
+    cell
+  end
+
   #
   # Write links to external directory names such as 'c:\foo.xls',
   # c:\foo.xls#Sheet1!A1', '../../foo.xls'. and '../../foo.xls#Sheet1!A1'.
@@ -5279,7 +5287,7 @@ def write_url_internal(row1, col1, row2, col2, url, str = nil, format = nil)
   def write_url_external(row1, col1, row2, col2, url, str = nil, format = nil)       #:nodoc:
     # Network drives are different. We will handle them separately
     # MS/Novell network drives and shares start with \\
-    if url =~ /^external:\\\\/
+    if url =~ /^external:(\\\\|\/\/)/
       return write_url_external_net(row1, col1, row2, col2, url, str, format)
     end
 
@@ -5290,12 +5298,10 @@ def write_url_external(row1, col1, row2, col2, url, str = nil, format = nil)
 
     # Strip URL type and change Unix dir separator to Dos style (if needed)
     #
-    url.sub!(/^external:/, '')
-    url.gsub!(%r|/|, '\\')
-
+    url = url.sub(/^external:/, '').gsub(%r|/|, '\\')
 
     # Write the visible label but protect against url recursion in write().
-    str = url.sub!(/\#/, ' - ') unless str
+    str = url.sub(/\#/, ' - ') unless str
     error        = write_string(row1, col1, str, xf)
     return error if error == -2
 
@@ -5309,7 +5315,7 @@ def write_url_external(row1, col1, row2, col2, url, str = nil, format = nil)
     dir_long, link_type, sheet_len, sheet = analyze_link(url, absolute)
 
     # Pack the link type
-    link_type      = link_type.pack("V")
+    link_type      = [link_type].pack("V")
 
     # Calculate the up-level dir count e.g. (..\..\..\ == 3)
     up_count    = 0
@@ -5375,11 +5381,10 @@ def write_url_external_net(row1, col1, row2, col2, url, str, format)       #:nod
 
     # Strip URL type and change Unix dir separator to Dos style (if needed)
     #
-    url.sub!(/^external:/, '')
-    url.gsub!(%r|/|, '\\')
+    url = url.sub(/^external:/, '').gsub!(%r|/|, '\\')
 
     # Write the visible label but protect against url recursion in write().
-    str = url.sub!(/\#/, ' - ') unless str
+    str = url.sub(/\#/, ' - ') unless str
     error        = write_string(row1, col1, str, xf)
     return error if error == -2
 

data/test/test_04_dimensions.rb

@@ -24,6 +24,15 @@ def setup
     @smiley              = [0x263a].pack('n')
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_no_worksheet_cell_data
     data     = @worksheet.__send__("store_dimensions")
 
@@ -369,6 +378,13 @@ def test_repeat_formula
     assert_equal(expected, results)
   end
 
+  def test_store_formula_should_not_change_formula_string
+    formula = '=SUM(A1:D1)'
+    @worksheet.store_formula(formula)
+
+    assert_equal('=SUM(A1:D1)', formula)
+  end
+
   def test_merge_range
     formula = @worksheet.__send__("store_formula", '=A1 * 3 + 50')
     @worksheet.merge_range('C6:E8', 'Test', @format)

data/test/test_05_rows.rb

@@ -19,6 +19,15 @@ class TC_rows < Test::Unit::TestCase
   def setup
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_1
     file  = StringIO.new
     workbook = WriteExcel.new(file)

data/test/test_06_extsst.rb

@@ -55,6 +55,15 @@ def setup
     ]
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_to_tests
     @tests.each do |test|
       io = StringIO.new

data/test/test_11_date_time.rb

@@ -26,6 +26,13 @@ def fit_cmp(a, b)
     return (a-b).abs < @fit_delta
   end
 
+  def test_convert_date_time_should_not_change_date_time_string
+    date_time = ' 1899-12-31T00:00:00.0004Z '
+    @worksheet.convert_date_time(date_time)
+
+    assert_equal(' 1899-12-31T00:00:00.0004Z ', date_time)
+  end
+
   def test_float_comparison_function
     # pass: diff < @fit_delta
     date_time = '1899-12-31T00:00:00.0004'

data/test/test_21_escher.rb

@@ -29,6 +29,15 @@ def setup
     @worksheet = @workbook.add_worksheet
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_for_store_mso_dg_container
     caption = sprintf(" \t_store_mso_dg_container()")
     data    = [0xC8]

data/test/test_22_mso_drawing_group.rb

@@ -32,6 +32,15 @@ def setup
     @worksheet3 = @workbook.add_worksheet
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
 =begin
   def test_1_time
     count = 1

data/test/test_23_note.rb

@@ -21,6 +21,15 @@ def setup
     @worksheet  = @workbook.add_worksheet
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_blank_author_name
     comment = Writeexcel::Worksheet::Comment.new(@worksheet, 2, 0, 'Test')
     obj_id   = 1

data/test/test_24_txo.rb

@@ -21,6 +21,15 @@ def setup
     @worksheet  = @workbook.add_worksheet
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_txo
     string     = 'aaa'
     comment = Writeexcel::Worksheet::Comment.new(@worksheet, 1, 1, ' ')

data/test/test_25_position_object.rb

@@ -25,6 +25,15 @@ def setup
     @worksheet  = @workbook.add_worksheet
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
 ###############################################################################
 #
 # Tests extracted from images imported into Excel.

data/test/test_30_validation_dval.rb

@@ -21,6 +21,15 @@ def setup
     @validations = Writeexcel::Worksheet::DataValidations.new
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_1
     obj_id     = 1
     dv_count   = 1

data/test/test_31_validation_dv_strings.rb

@@ -22,6 +22,15 @@ def setup
     @data_validation = Writeexcel::Worksheet::DataValidation.new(worksheet.__send__("parser"), {})
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_empty_string
     string      = ''
     max_length  = 32

data/test/test_32_validation_dv_formula.rb

@@ -22,6 +22,15 @@ def setup
     @data_validation = Writeexcel::Worksheet::DataValidation.new(@worksheet.__send__("parser"), {})
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_integer_values
     formula      = '10'
 
@@ -192,6 +201,13 @@ def test_undefined_value
     assert_equal(target, result, caption)
   end
 
+  def test_pack_dv_formula_should_not_change_formula_string
+    formula = '=SUM(A1:D1)'
+    @data_validation.__send__("pack_dv_formula", formula)
+
+    assert_equal('=SUM(A1:D1)', formula)
+  end
+
   ###############################################################################
   #
   # Unpack the binary data into a format suitable for printing in tests.

data/test/test_42_set_properties.rb

@@ -29,6 +29,15 @@ def setup
     @test_file = StringIO.new
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_same_as_previous_plus_creation_date
     smiley = '☺'   # chr 0x263A;    in perl
 

data/test/test_example_match.rb

@@ -426,6 +426,115 @@ def test_hyperlink1
     compare_file("#{PERL_OUTDIR}/hyperlink.xls", @file)
   end
 
+  def test_hyperlink2
+    # Create workbook1
+    ireland   = WriteExcel.new(@file)
+    ire_links = ireland.add_worksheet('Links')
+    ire_sales = ireland.add_worksheet('Sales')
+    ire_data  = ireland.add_worksheet('Product Data')
+
+    file2 = StringIO.new
+    italy     = WriteExcel.new(file2)
+    ita_links = italy.add_worksheet('Links')
+    ita_sales = italy.add_worksheet('Sales')
+    ita_data  = italy.add_worksheet('Product Data')
+
+    file3 = StringIO.new
+    china     = WriteExcel.new(file3)
+    cha_links = china.add_worksheet('Links')
+    cha_sales = china.add_worksheet('Sales')
+    cha_data  = china.add_worksheet('Product Data')
+
+    # Add a format
+    format = ireland.add_format(:color => 'green', :bold => 1)
+    ire_links.set_column('A:B', 25)
+
+
+    ###############################################################################
+    #
+    # Examples of internal links
+    #
+    ire_links.write('A1', 'Internal links', format)
+
+    # Internal link
+    ire_links.write('A2', 'internal:Sales!A2')
+
+    # Internal link to a range
+    ire_links.write('A3', 'internal:Sales!A3:D3')
+
+    # Internal link with an alternative string
+    ire_links.write('A4', 'internal:Sales!A4', 'Link')
+
+    # Internal link with a format
+    ire_links.write('A5', 'internal:Sales!A5', format)
+
+    # Internal link with an alternative string and format
+    ire_links.write('A6', 'internal:Sales!A6', 'Link', format)
+
+    # Internal link (spaces in worksheet name)
+    ire_links.write('A7', "internal:'Product Data'!A7")
+
+
+    ###############################################################################
+    #
+    # Examples of external links
+    #
+    ire_links.write('B1', 'External links', format)
+
+    # External link to a local file
+    ire_links.write('B2', 'external:Italy.xls')
+
+    # External link to a local file with worksheet
+    ire_links.write('B3', 'external:Italy.xls#Sales!B3')
+
+    # External link to a local file with worksheet and alternative string
+    ire_links.write('B4', 'external:Italy.xls#Sales!B4', 'Link')
+
+    # External link to a local file with worksheet and format
+    ire_links.write('B5', 'external:Italy.xls#Sales!B5', format)
+
+    # External link to a remote file, absolute path
+    ire_links.write('B6', 'external:c:/Temp/Asia/China.xls')
+
+    # External link to a remote file, relative path
+    ire_links.write('B7', 'external:../Asia/China.xls')
+
+    # External link to a remote file with worksheet
+    ire_links.write('B8', 'external:c:/Temp/Asia/China.xls#Sales!B8')
+
+    # External link to a remote file with worksheet (with spaces in the name)
+    ire_links.write('B9', "external:c:/Temp/Asia/China.xls#'Product Data'!B9")
+
+
+    ###############################################################################
+    #
+    # Some utility links to return to the main sheet
+    #
+    ire_sales.write('A2', 'internal:Links!A2', 'Back')
+    ire_sales.write('A3', 'internal:Links!A3', 'Back')
+    ire_sales.write('A4', 'internal:Links!A4', 'Back')
+    ire_sales.write('A5', 'internal:Links!A5', 'Back')
+    ire_sales.write('A6', 'internal:Links!A6', 'Back')
+    ire_data.write('A7', 'internal:Links!A7', 'Back')
+
+    ita_links.write('A1', 'external:Ireland.xls#Links!B2', 'Back')
+    ita_sales.write('B3', 'external:Ireland.xls#Links!B3', 'Back')
+    ita_sales.write('B4', 'external:Ireland.xls#Links!B4', 'Back')
+    ita_sales.write('B5', 'external:Ireland.xls#Links!B5', 'Back')
+    cha_links.write('A1', 'external:../Europe/Ireland.xls#Links!B6', 'Back')
+    cha_sales.write('B8', 'external:../Europe/Ireland.xls#Links!B8', 'Back')
+    cha_data.write('B9', 'external:../Europe/Ireland.xls#Links!B9', 'Back')
+
+    ireland.close
+    italy.close
+    china.close
+
+    # do assertion
+    compare_file("#{PERL_OUTDIR}/Ireland.xls", @file)
+    compare_file("#{PERL_OUTDIR}/Italy.xls", file2)
+    compare_file("#{PERL_OUTDIR}/China.xls", file3)
+  end
+
   def test_copyformat
     # Create workbook1
     workbook1       = WriteExcel.new(@file)

data/test/test_worksheet.rb

@@ -15,6 +15,15 @@ def setup
     @format  = Writeexcel::Format.new(:color=>"green")
   end
 
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @ws.instance_variable_get(:@filehandle)
+      @ws.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
   def test_methods_exist
     assert_respond_to(@ws, :write)
     assert_respond_to(@ws, :write_blank)
@@ -99,6 +108,26 @@ def test_new
     assert_equal(@sheetname, @ws.name)
   end
 
+  def test_write_url_should_not_change_internal_url_string
+    internal_url = 'internal:Sheet2!A1'
+    @ws.write_url(0, 0, internal_url)
+
+    assert_equal('internal:Sheet2!A1', internal_url)
+  end
+
+  def test_write_url_should_not_change_external_url_string
+    external_url = 'external:c:\temp\foo.xls#Sheet2!A1'
+    @ws.write_url(1, 1, external_url)
+
+    assert_equal('external:c:\temp\foo.xls#Sheet2!A1', external_url)
+  end
+
+  def test_write_url_should_not_change_external_net_url_string
+    external_net_url = 'external://NETWORK/share/foo.xls'
+    @ws.write_url(1, 1, external_net_url)
+
+    assert_equal('external://NETWORK/share/foo.xls', external_net_url)
+  end
 
   def assert_equal_filesize(target, test, msg = "Bad file size")
     assert_equal(File.size(target),File.size(test),msg)

data/test/test_write_formula_does_not_change_formula_string.rb

@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+require 'writeexcel'
+require 'stringio'
+
+class TestWriteFormula < Test::Unit::TestCase
+  def setup
+    @workbook = WriteExcel.new(StringIO.new)
+    @worksheet = @workbook.add_worksheet('')
+  end
+
+  def teardown
+    if @workbook.instance_variable_get(:@filehandle)
+      @workbook.instance_variable_get(:@filehandle).close(true)
+    end
+    if @worksheet.instance_variable_get(:@filehandle)
+      @worksheet.instance_variable_get(:@filehandle).close(true)
+    end
+  end
+
+  def test_write_formula_does_not_change_formula_string
+    formula = '=PI()'
+    @worksheet.write('A1', formula)
+
+    assert_equal('=PI()', formula)
+  end
+end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: writeexcel
 version: !ruby/object:Gem::Version
-  version: 0.6.18
-  prerelease: 
+  version: 0.6.19
 platform: ruby
 authors:
 - Hideo NAKAMURA
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-09 00:00:00.000000000 Z
+date: 2013-03-30 00:00:00.000000000 Z
 dependencies: []
 description: Multiple worksheets can be added to a workbook and formatting can be
   applied to cells. Text, numbers, formulas, hyperlinks and images can be written
@@ -65,6 +64,7 @@ files:
 - examples/header.rb
 - examples/hide_sheet.rb
 - examples/hyperlink.rb
+- examples/hyperlink2.rb
 - examples/images.rb
 - examples/indent.rb
 - examples/merge1.rb
@@ -156,6 +156,9 @@ files:
 - test/perl_output/Chart3.xls.data
 - test/perl_output/Chart4.xls.data
 - test/perl_output/Chart5.xls.data
+- test/perl_output/China.xls
+- test/perl_output/Ireland.xls
+- test/perl_output/Italy.xls
 - test/perl_output/README
 - test/perl_output/a_simple.xls
 - test/perl_output/autofilter.xls
@@ -269,32 +272,32 @@ files:
 - test/test_storage_lite.rb
 - test/test_workbook.rb
 - test/test_worksheet.rb
+- test/test_write_formula_does_not_change_formula_string.rb
 - utils/add_magic_comment.rb
 - writeexcel.gemspec
 - writeexcel.rdoc
 homepage: http://github.com/cxn03651/writeexcel#readme
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Write to a cross-platform Excel binary file.
 test_files:
 - test/excelfile/Chart1.xls
@@ -308,6 +311,9 @@ test_files:
 - test/perl_output/Chart3.xls.data
 - test/perl_output/Chart4.xls.data
 - test/perl_output/Chart5.xls.data
+- test/perl_output/China.xls
+- test/perl_output/Ireland.xls
+- test/perl_output/Italy.xls
 - test/perl_output/README
 - test/perl_output/a_simple.xls
 - test/perl_output/autofilter.xls
@@ -421,3 +427,4 @@ test_files:
 - test/test_storage_lite.rb
 - test/test_workbook.rb
 - test/test_worksheet.rb
+- test/test_write_formula_does_not_change_formula_string.rb