write_xlsx 1.04.0 → 1.08.2

data/lib/write_xlsx/workbook.rb

@@ -52,6 +52,7 @@ module Writexlsx
     attr_reader :max_url_length # :nodoc:
     attr_reader :strings_to_urls # :nodoc:
     attr_reader :default_url_format # :nodoc:
+    attr_reader :read_only # :nodoc:
 
     #
     # A new Excel workbook is created using the +new+ constructor
@@ -133,6 +134,7 @@ module Writexlsx
 
       @max_url_length      = 2079
       @has_comments        = false
+      @read_only           = 0
       if options[:max_url_length]
         @max_url_length = options[:max_url_length]
 
@@ -292,6 +294,9 @@ module Writexlsx
           # Write the XLSX file version.
           write_file_version
 
+          # Write the fileSharing element.
+          write_file_sharing
+
           # Write the workbook properties.
           write_workbook_pr
 
@@ -954,6 +959,13 @@ module Writexlsx
       end
     end
 
+    #
+    # Set the Excel "Read-only recommended" save option.
+    #
+    def read_only_recommended
+      @read_only = 2
+    end
+
     #
     # set_calc_mode()
     #
@@ -1311,6 +1323,17 @@ module Writexlsx
       @writer.empty_tag('fileVersion', attributes)
     end
 
+    #
+    # Write the <fileSharing> element.
+    #
+    def write_file_sharing
+      return if !ptrue?(@read_only)
+
+      attributes = []
+      attributes << ['readOnlyRecommended', 1]
+      @writer.empty_tag('fileSharing', attributes)
+    end
+
     def write_workbook_pr #:nodoc:
       attributes = []
       attributes << ['codeName', @vba_codename]  if ptrue?(@vba_codename)

data/lib/write_xlsx/worksheet/data_validation.rb

@@ -138,12 +138,7 @@ module Writexlsx
           row_first, row_last = row_last, row_first if row_first > row_last
           col_first, col_last = col_last, col_first if col_first > col_last
 
-          # If the first and last cell are the same write a single cell.
-          if row_first == row_last && col_first == col_last
-            sqref += xl_rowcol_to_cell(row_first, col_first)
-          else
-            sqref += xl_range(row_first, row_last, col_first, col_last)
-          end
+          sqref += xl_range(row_first, row_last, col_first, col_last)
         end
 
         if @validate != 'none'

data/lib/write_xlsx/worksheet.rb

@@ -381,6 +381,7 @@ module Writexlsx
       @comments = Package::Comments.new(self)
       @buttons_array          = []
       @header_images_array    = []
+      @ignore_errors          = nil
 
       @validations = []
 
@@ -388,6 +389,9 @@ module Writexlsx
       @data_bars_2010 = []
       @dxf_priority   = 1
 
+      @protected_ranges     = []
+      @num_protected_ranges = 0
+
       if excel2003_style?
         @original_row_height      = 12.75
         @default_row_height       = 12.75
@@ -414,6 +418,7 @@ module Writexlsx
           write_cols
           write_sheet_data
           write_sheet_protection
+          write_protected_ranges
           # write_sheet_calc_pr
           write_phonetic_pr if excel2003_style?
           write_auto_filter
@@ -427,6 +432,7 @@ module Writexlsx
           write_header_footer
           write_row_breaks
           write_col_breaks
+          write_ignored_errors
           write_drawings
           write_legacy_drawing
           write_legacy_drawing_hf
@@ -616,7 +622,25 @@ module Writexlsx
 
       # Set the password after the user defined values.
       @protect[:password] =
-        sprintf("%X", encode_password(password)) if password && password != ''
+        encode_password(password) if password && password != ''
+    end
+
+    #
+    # Unprotect ranges within a protected worksheet.
+    #
+    def unprotect_range(range, range_name = nil, password = nil)
+      if range.nil?
+        raise "The range must be defined in unprotect_range())\n"
+      else
+        range.gsub!(/\$/, "")
+        range.sub!(/^=/, "")
+        @num_protected_ranges += 1
+      end
+
+      range_name ||= "Range#{@num_protected_ranges}"
+      password   &&= encode_password(password)
+
+      @protected_ranges << [range, range_name, password]
     end
 
     def protect_default_settings  # :nodoc:
@@ -818,12 +842,7 @@ module Writexlsx
         row_first, row_last = row_last, row_first if row_first > row_last
         col_first, col_last = col_last, col_first if col_first > col_last
 
-        # If the first and last cell are the same write a single cell.
-        if row_first == row_last && col_first == col_last
-          sqref = active_cell
-        else
-          sqref = xl_range(row_first, row_last, col_first, col_last)
-        end
+        sqref = xl_range(row_first, row_last, col_first, col_last)
       else          # Single cell selection.
         sqref = active_cell
       end
@@ -1207,14 +1226,10 @@ module Writexlsx
     # distribution.
     #
     def set_header(string = '', margin = 0.3, options = {})
-      raise 'Header string must be less than 255 characters' if string.length >= 255
+      raise 'Header string must be less than 255 characters' if string.length > 255
       # Replace the Excel placeholder &[Picture] with the internal &G.
       @page_setup.header = string.gsub(/&\[Picture\]/, '&G')
 
-      if string.size >= 255
-        raise 'Header string must be less than 255 characters'
-      end
-
       if options[:align_with_margins]
         @page_setup.header_footer_aligns = options[:align_with_margins]
       end
@@ -1255,17 +1270,13 @@ module Writexlsx
     # The syntax of the set_footer() method is the same as set_header()
     #
     def set_footer(string = '', margin = 0.3, options = {})
-      raise 'Footer string must be less than 255 characters' if string.length >= 255
+      raise 'Footer string must be less than 255 characters' if string.length > 255
 
       @page_setup.footer                = string.dup
 
       # Replace the Excel placeholder &[Picture] with the internal &G.
       @page_setup.footer = string.gsub(/&\[Picture\]/, '&G')
 
-      if string.size >= 255
-        raise 'Header string must be less than 255 characters'
-      end
-
       if options[:align_with_margins]
         @page_setup.header_footer_aligns = options[:align_with_margins]
       end
@@ -2514,7 +2525,9 @@ module Writexlsx
       col1, col2 = col2, col1 if col1 > col2
 
       # Check that row and col are valid and store max and min values
+      check_dimensions(row1, col1)
       check_dimensions(row2, col2)
+      store_row_col_max_min_values(row1, col1)
       store_row_col_max_min_values(row2, col2)
 
       # Define array range
@@ -3046,14 +3059,16 @@ module Writexlsx
 
       if options.first.class == Hash
         # Newer hash bashed options
-        params = options.first
-        x_offset = params[:x_offset]
-        y_offset = params[:y_offset]
-        x_scale  = params[:x_scale]
-        y_scale  = params[:y_scale]
-        anchor   = params[:object_position]
-        url      = params[:url]
-        tip      = params[:tip]
+        params      = options.first
+        x_offset    = params[:x_offset]
+        y_offset    = params[:y_offset]
+        x_scale     = params[:x_scale]
+        y_scale     = params[:y_scale]
+        anchor      = params[:object_position]
+        url         = params[:url]
+        tip         = params[:tip]
+        description = params[:description]
+        decorative  = params[:decorative]
       else
         x_offset, y_offset, x_scale, y_scale, anchor = options
       end
@@ -3065,7 +3080,7 @@ module Writexlsx
 
       @images << [
         row, col, image, x_offset, y_offset,
-        x_scale, y_scale, url, tip, anchor
+        x_scale, y_scale, url, tip, anchor, description, decorative
       ]
     end
 
@@ -3363,9 +3378,11 @@ module Writexlsx
       row_first,  row_last  = row_last,  row_first  if row_first > row_last
       col_first, col_last = col_last, col_first if col_first > col_last
 
-      # Check that column number is valid and store the max value
-      check_dimensions(row_last, col_last)
-      store_row_col_max_min_values(row_last, col_last)
+      # Check that the data range is valid and store the max and min values.
+      check_dimensions(row_first, col_first)
+      check_dimensions(row_last,  col_last)
+      store_row_col_max_min_values(row_first, col_first)
+      store_row_col_max_min_values(row_last,  col_last)
 
       # Store the merge range.
       @merge << [row_first, col_first, row_last, col_last]
@@ -3428,9 +3445,11 @@ module Writexlsx
       row_first, row_last = row_last, row_first if row_first > row_last
       col_first, col_last = col_last, col_first if col_first > col_last
 
-      # Check that column number is valid and store the max value
-      check_dimensions(row_last, col_last)
-      store_row_col_max_min_values(row_last, col_last)
+      # Check that the data range is valid and store the max and min values.
+      check_dimensions(row_first, col_first)
+      check_dimensions(row_last,  col_last)
+      store_row_col_max_min_values(row_first, col_first)
+      store_row_col_max_min_values(row_last,  col_last)
 
       # Store the merge range.
       @merge << [row_first, col_first, row_last, col_last]
@@ -5738,7 +5757,7 @@ module Writexlsx
       name = chart.name
 
       # Create a Drawing object to use with worksheet unless one already exists.
-      drawing = Drawing.new(drawing_type, dimensions, 0, 0, name, nil, anchor, drawing_rel_index, 0, nil)
+      drawing = Drawing.new(drawing_type, dimensions, 0, 0, name, nil, anchor, drawing_rel_index, 0, nil, 0)
       if !drawings?
         @drawings = Drawings.new
         @drawings.add_drawing_object(drawing)
@@ -6062,6 +6081,30 @@ module Writexlsx
       end
     end
 
+    #
+    # Ignore worksheet errors/warnings in user defined ranges.
+    #
+    def ignore_errors(ignores)
+      # List of valid input parameters.
+      valid_parameter_keys = [
+        :number_stored_as_text,
+        :eval_error,
+        :formula_differs,
+        :formula_range,
+        :formula_unlocked,
+        :empty_cell_reference,
+        :list_data_validation,
+        :calculated_column,
+        :two_digit_text_year
+      ]
+
+      unless (ignores.keys - valid_parameter_keys).empty?
+        raise "Unknown parameter '#{ignores.key - valid_parameter_keys}' in ignore_errors()."
+      end
+
+      @ignore_errors = ignores
+    end
+
     def write_ext(url)
       attributes = [
         ['xmlns:x14', "#{OFFICE_URL}spreadsheetml/2009/9/main"],
@@ -6464,7 +6507,7 @@ module Writexlsx
       drawing_type = 2
 
       row, col, image, x_offset, y_offset,
-      x_scale, y_scale, url, tip, anchor = @images[index]
+      x_scale, y_scale, url, tip, anchor, description, decorative = @images[index]
 
       width  *= x_scale
       height *= y_scale
@@ -6479,7 +6522,7 @@ module Writexlsx
       height = (0.5 + (height * 9_525)).to_i
 
       # Create a Drawing object to use with worksheet unless one already exists.
-      drawing = Drawing.new(drawing_type, dimensions, width, height, name, nil, anchor, 0, 0, tip)
+      drawing = Drawing.new(drawing_type, dimensions, width, height, name, nil, anchor, 0, 0, tip, decorative)
       if !drawings?
         drawings = Drawings.new
         drawings.embedded = 1
@@ -6492,6 +6535,10 @@ module Writexlsx
       end
       drawings.add_drawing_object(drawing)
 
+      if description
+        drawing.description = description
+      end
+
       if url
         rel_type = '/hyperlink'
         target_mode = 'External'
@@ -6499,10 +6546,19 @@ module Writexlsx
           target = escape_url(url)
         end
         if url =~ /^external:/
-          target = escape_url(url.sub(/^external:/, 'file:///'))
+          target = escape_url(url.sub(/^external:/, ''))
+
           # Additional escape not required in worksheet hyperlinks
           target = target.gsub(/#/, '%23')
+
+          # Prefix absolute paths (not relative) with file:///
+          if target =~ /^\w:/ || target =~ /^\\\\/
+            target = "file:///#{target}"
+          else
+            target = target.gsub(/\\/, '/')
+          end
         end
+
         if url =~ /^internal:/
           target      = url.sub(/^internal:/, '#')
           target_mode = nil
@@ -6645,7 +6701,7 @@ EOS
       shape.calc_position_emus(self)
 
       drawing_type = 3
-      drawing = Drawing.new(drawing_type, shape.dimensions, shape.width_emu, shape.height_emu, shape.name, shape, shape.anchor, drawing_rel_index, 0, nil)
+      drawing = Drawing.new(drawing_type, shape.dimensions, shape.width_emu, shape.height_emu, shape.name, shape, shape.anchor, drawing_rel_index, 0, nil, 0)
       drawings.add_drawing_object(drawing)
     end
     public :prepare_shape
@@ -6735,6 +6791,8 @@ EOS
       chars.each { |c| encoded_password ^= c }
       encoded_password ^= count
       encoded_password ^= 0xCE4B
+
+      sprintf("%X", encoded_password)
     end
 
     #
@@ -7550,6 +7608,32 @@ EOS
       @writer.empty_tag('sheetProtection', attributes)
     end
 
+    #
+    # Write the <protectedRanges> element.
+    #
+    def write_protected_ranges
+      return if @num_protected_ranges == 0
+
+      @writer.tag_elements('protectedRanges') do
+        @protected_ranges.each do |protected_range|
+          write_protected_range(*protected_range)
+        end
+      end
+    end
+
+    #
+    # Write the <protectedRange> element.
+    #
+    def write_protected_range(sqref, name, password)
+      attributes = []
+
+      attributes << ['password', password] if password
+      attributes << ['sqref',    sqref]
+      attributes << ['name',     name]
+
+      @writer.empty_tag('protectedRange', attributes)
+    end
+
     #
     # Write the <drawing> elements.
     #
@@ -8082,5 +8166,44 @@ EOS
       end
       col
     end
+
+    #
+    # Write the <ignoredErrors> element.
+    #
+    def write_ignored_errors
+      return unless @ignore_errors
+
+      ignore = @ignore_errors
+
+      @writer.tag_elements('ignoredErrors' ) do
+        {
+          :number_stored_as_text => 'numberStoredAsText',
+          :eval_error            => 'evalError',
+          :formula_differs       => 'formula',
+          :formula_range         => 'formulaRange',
+          :formula_unlocked      => 'unlockedFormula',
+          :empty_cell_reference  => 'emptyCellReference',
+          :list_data_validation  => 'listDataValidation',
+          :calculated_column     => 'calculatedColumn',
+          :two_digit_text_year   => 'twoDigitTextYear'
+        }.each do |key, value|
+          if ignore[key]
+            write_ignored_error(value, ignore[key])
+          end
+        end
+      end
+    end
+
+    #
+    # Write the <ignoredError> element.
+    #
+    def write_ignored_error(type, sqref)
+      attributes = {
+        'sqref' => sqref,
+        type    => 1
+      }
+
+      @writer.empty_tag('ignoredError', attributes)
+    end
   end
 end

data/test/drawing/{test_write_ext.rb → test_write_xdr_ext.rb}

@@ -2,7 +2,7 @@
 require 'helper'
 require 'write_xlsx/drawing'
 
-class TestWriteExt < Minitest::Test
+class TestWriteXdrExt < Minitest::Test
   def setup
     @drawing = Writexlsx::Drawings.new
   end
@@ -10,7 +10,7 @@ class TestWriteExt < Minitest::Test
   def test_write_ext
     expected = '<xdr:ext cx="9308969" cy="6078325"/>'
 
-    @drawing.__send__(:write_ext, 9308969, 6078325)
+    @drawing.__send__(:write_xdr_ext, 9308969, 6078325)
     result = @drawing.instance_variable_get(:@writer).string
 
     assert_equal(expected, result)

data/test/regression/test_array_formula04.rb

@@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+
+class TestRegressionArrayFormula04 < Minitest::Test
+  def setup
+    setup_dir_var
+  end
+
+  def teardown
+    @tempfile.close(true)
+  end
+
+  def test_array_formula04
+    @xlsx = 'array_formula04.xlsx'
+    workbook  = WriteXLSX.new(@io)
+    worksheet = workbook.add_worksheet
+
+    worksheet.write_array_formula(
+      'A1:A3',
+      '{=SUM(B1:C1*B2:C2)}',
+      nil,
+      0
+    )
+
+    workbook.close
+    compare_for_regression(
+      [ 'xl/calcChain.xml', '[Content_Types].xml', 'xl/_rels/workbook.xml.rels' ],
+      {'xl/workbook.xml' => ['<workbookView']}
+    )
+  end
+end

data/test/regression/test_chart_crossing01.rb

@@ -33,7 +33,7 @@ class TestRegressionChartCrossing01 < Minitest::Test
 
     chart.set_y_axis(:crossing => 'max')
 
-    # Not stictly required. Just to match reference file.
+    # Not strictly required. Just to match reference file.
     chart.set_x_axis(:position => 't')
 
     worksheet.insert_chart('E9', chart)

data/test/regression/test_chart_crossing05.rb

@@ -0,0 +1,46 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+
+class TestRegressionChartCrossing05 < Minitest::Test
+  def setup
+    setup_dir_var
+  end
+
+  def teardown
+    @tempfile.close(true)
+  end
+
+  def test_chart_crossing05
+    @xlsx = 'chart_crossing05.xlsx'
+    workbook  = WriteXLSX.new(@io)
+    worksheet = workbook.add_worksheet
+    chart     = workbook.add_chart(:type => 'column', :embedded => 1)
+
+    # For testing, copy the randomly generated axis ids in the target xlsx file.
+    chart.instance_variable_set(:@axis_ids, [55948032, 55950336])
+
+    data = [
+            [1, 2, 3,  4,  5],
+            [2, 4, 6,  8, 10],
+            [3, 6, 9, 12, 15]
+           ]
+
+    worksheet.write('A1', data)
+
+    chart.add_series(:values => '=Sheet1!$A$1:$A$5')
+    chart.add_series(:values => '=Sheet1!$B$1:$B$5')
+    chart.add_series(:values => '=Sheet1!$C$1:$C$5')
+
+    chart.set_x_axis(:crossing => 'min')
+
+    worksheet.insert_chart('E9', chart)
+
+    workbook.close
+    compare_for_regression(
+      nil,
+      {
+        'xl/charts/chart1.xml' => [ '<c:pageMargins' ]
+      }
+    )
+  end
+end

data/test/regression/test_chart_crossing06.rb

@@ -0,0 +1,46 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+
+class TestRegressionChartCrossing06 < Minitest::Test
+  def setup
+    setup_dir_var
+  end
+
+  def teardown
+    @tempfile.close(true)
+  end
+
+  def test_chart_crossing06
+    @xlsx = 'chart_crossing06.xlsx'
+    workbook  = WriteXLSX.new(@io)
+    worksheet = workbook.add_worksheet
+    chart     = workbook.add_chart(:type => 'column', :embedded => 1)
+
+    # For testing, copy the randomly generated axis ids in the target xlsx file.
+    chart.instance_variable_set(:@axis_ids, [72794880, 72796416])
+
+    data = [
+            [1, 2, 3,  4,  5],
+            [2, 4, 6,  8, 10],
+            [3, 6, 9, 12, 15]
+           ]
+
+    worksheet.write('A1', data)
+
+    chart.add_series(:values => '=Sheet1!$A$1:$A$5')
+    chart.add_series(:values => '=Sheet1!$B$1:$B$5')
+    chart.add_series(:values => '=Sheet1!$C$1:$C$5')
+
+    chart.set_y_axis(:crossing => 'min')
+
+    worksheet.insert_chart('E9', chart)
+
+    workbook.close
+    compare_for_regression(
+      nil,
+      {
+        'xl/charts/chart1.xml' => [ '<c:pageMargins' ]
+      }
+    )
+  end
+end

data/test/regression/test_chart_data_labels26.rb

@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+
+class TestRegressionChartDataLabels26 < Minitest::Test
+  def setup
+    setup_dir_var
+  end
+
+  def teardown
+    @tempfile.close(true)
+  end
+
+  def test_chart_data_labels26
+    @xlsx = 'chart_data_labels26.xlsx'
+    workbook  = WriteXLSX.new(@io)
+    worksheet = workbook.add_worksheet
+    chart     = workbook.add_chart(:type => 'column', :embedded => 1)
+
+    # For testing, copy the randomly generated axis ids in the target xlsx file.
+    chart.instance_variable_set(:@axis_ids, [48514944, 48516480])
+
+    data = [
+      [ 1,  2,  3,  4,  5],
+      [ 2,  4,  6,  8, 10],
+      [ 3,  6,  9, 12, 15],
+      [10, 20, 30, 40, 50]
+    ]
+
+    worksheet.write('A1', data)
+
+    chart.add_series(
+      :values      => '=Sheet1!$A$1:$A$5',
+      :data_labels => {:value    => 1, :custom => [{:value => 33}]}
+    )
+
+    chart.add_series(:values => '=Sheet1!$B$1:$B$5')
+    chart.add_series(:values => '=Sheet1!$C$1:$C$5')
+
+    worksheet.insert_chart('E9', chart)
+
+    workbook.close
+    compare_for_regression
+  end
+end

data/test/regression/test_chart_data_labels27.rb

@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+
+class TestRegressionChartDataLabels27 < Minitest::Test
+  def setup
+    setup_dir_var
+  end
+
+  def teardown
+    @tempfile.close(true)
+  end
+
+  def test_chart_data_labels27
+    @xlsx = 'chart_data_labels27.xlsx'
+    workbook  = WriteXLSX.new(@io)
+    worksheet = workbook.add_worksheet
+    chart     = workbook.add_chart(:type => 'column', :embedded => 1)
+
+    # For testing, copy the randomly generated axis ids in the target xlsx file.
+    chart.instance_variable_set(:@axis_ids, [48514944, 48516480])
+
+    data = [
+      [ 1,  2,  3,  4,  5],
+      [ 2,  4,  6,  8, 10],
+      [ 3,  6,  9, 12, 15],
+      [10, 20, 30, 40, 50]
+    ]
+
+    worksheet.write('A1', data)
+
+    chart.add_series(
+      :values      => '=Sheet1!$A$1:$A$5',
+      :data_labels => {:value    => 1, :custom => [{:value => '=Sheet1!$D$1'}]}
+    )
+
+    chart.add_series(:values => '=Sheet1!$B$1:$B$5')
+    chart.add_series(:values => '=Sheet1!$C$1:$C$5')
+
+    worksheet.insert_chart('E9', chart)
+
+    workbook.close
+    compare_for_regression
+  end
+end