write_xlsx 0.85.6 → 0.85.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7d9381b5893f5bba74793716ade4ac8560af6c18953acebe9eb1b13afbc7efc5
-  data.tar.gz: aff6349570d4111a80b991504d0e1293c6e650c793028bef340fbdcb65fb355e
+  metadata.gz: 89f382bd2df994369316a0422365541984f53ec084c5d3bb1c5d5a03523757a9
+  data.tar.gz: 363697c51b2250602fd5122aa3e9c7a6c71ec755a671e659f08f19c58b184792
 SHA512:
-  metadata.gz: a86c39e414f965061cec64e49aa8163a8d09a0e0707ba602647377b34a1d6bbd12a702a27a8c496b3d31ac93f0b4ea9e629d48eb8c5fbce4e527b6182aefb8d4
-  data.tar.gz: b8e18e11a09b91fc86ec2fe5d6eeeb5047e27cb1378e67b871df141084040f469deabd593076a77666d1d03564bdcdf104f7ba6476b011b8a87c54c1c74fb622
+  metadata.gz: c719aa61decdc25064a72704d015d8a1eea48b3a94ccb7ccaf01e99456a6521c5c4fc5a5ee738a721c1e06c4632c737cf47d14afd3830a164162a789acc6e452
+  data.tar.gz: 96f55161f36511ef22708a377ea647f21f4ae76c978039b0c85c32c5db55ac0330f3e4c7a0e1f030d60c3d00c0c96f6c3f045bbfd240a2e2031c8ced2b2c2945

data/Changes

@@ -1,5 +1,20 @@
 Change history of write_xlsx rubygem.
 
+2020-10-23 v0.85.11
+   Added Worksheet#update_range_format_with_params
+
+2020-10-23 v0.85.10
+   Fix frozen string litterals problems in Format#set_align
+
+2020-09-07 v0.85.9
+   apply pull-request #59 and #60
+
+2020-09-03 v0.85.8
+   apply pull-request #58 and #52
+
+2019-06-20 v0.85.7
+   apply pull-request #26
+
 2019-02-10 v0.85.6
    Fix work well in ms windows.
 

data/README.md

@@ -84,7 +84,7 @@ the first worksheet in an Excel XML spreadsheet called ruby.xlsx:
 ## Copyright
 Original Perl module was written by John McNamara(jmcnamara@cpan.org).
 
-Converted to ruby by Hideo NAKAMURA(cxn03651@msj.biglobe.ne.jp)
+Converted to ruby by Hideo NAKAMURA(nakamrua.hideo@gmail.com)
 Copyright (c) 2012-2018 Hideo NAKAMURA.
 
 See LICENSE.txt for further details.

data/examples/update_range_format_with_params.rb

@@ -0,0 +1,33 @@
+#!/usr/bin/env ruby
+# -*- coding: utf-8 -*-
+
+#######################################################################
+#
+# A simple example of how to use the write_xlsx gem to
+# update format of the range of cells.
+#
+
+require 'write_xlsx'
+
+workbook = WriteXLSX.new('update_range_format_with_params.xlsx')
+worksheet = workbook.add_worksheet
+
+common_format = workbook.add_format(align: 'center', border: 1)
+
+table_contents = [
+  ['Table', 'Header', 'Contents'],
+  ['table', 'body', 'contents'],
+  ['table', 'body', 'contents'],
+  ['table', 'body', 'contents']
+]
+
+worksheet.write_col(0, 0, table_contents, common_format)
+worksheet.update_range_format_with_params(
+  0, 0, 0, 2,
+  bold: 1, top: 2, bottom: 2, bg_color: 31
+)
+worksheet.update_range_format_with_params(0, 0, 3, 0, left: 2)
+worksheet.update_range_format_with_params(0, 2, 3, 2, right: 2)
+worksheet.update_range_format_with_params(3, 0, 3, 2, bottom: 2)
+
+workbook.close

data/lib/write_xlsx/chart.rb

@@ -2631,7 +2631,7 @@ def write_custom_error_base(tag, values, data)
     end
 
     def write_num_ref_or_lit(values, data)
-      if values =~ /^=/                     # '=Sheet1!$A$1:$A$5'
+      if values.to_s =~ /^=/                     # '=Sheet1!$A$1:$A$5'
         write_num_ref(values, data, 'num')
       else                                  # [1, 2, 3]
         write_num_lit(values)

data/lib/write_xlsx/format.rb

@@ -287,11 +287,10 @@ def set_format_properties(*properties)   # :nodoc:
 
           # Create a sub to set the property.
           if value.respond_to?(:to_str) || !value.respond_to?(:+)
-            s = "set_#{key}('#{value}')"
+            send("set_#{key}", value.to_s)
           else
-            s = "set_#{key}(#{value})"
+            send("set_#{key}", value)
           end
-          eval s
         end
       end
     end
@@ -507,7 +506,7 @@ def self.color(color_code)
     def set_align(location)
       return unless location             # No default
 
-      location.downcase!
+      location = location.downcase
 
       set_text_h_align(1) if location == 'left'
       set_text_h_align(2) if location == 'centre'

data/lib/write_xlsx/package/conditional_format.rb

@@ -306,7 +306,7 @@ def range_start_cell_for_conditional_formatting(*args)  # :nodoc:
 
       def row_col_param_for_conditional_formatting(*args)
         # Check for a cell reference in A1 notation and substitute row and column
-        if args[0] =~ /^\D/
+        if args[0].to_s =~ /^\D/
           # Check for a user defined multiple range like B3:K6,B8:K11.
           user_range = args[0].sub(/^=/, '').gsub(/\s*,\s*/, ' ').gsub(/\$/, '') if args[0] =~ /,/
         end
@@ -383,7 +383,7 @@ def check_conditional_formatting_parameters(param)  # :nodoc:
       end
 
       def convert_date_time_if_required(val)
-        if val =~ /T/
+        if val.to_s =~ /T/
           date_time = convert_date_time(val)
           raise "Invalid date/time value '#{val}' in conditional_formatting()" unless date_time
           date_time

data/lib/write_xlsx/package/shared_strings.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 require 'write_xlsx/package/xml_writer_simple'
 require 'write_xlsx/utility'
 
@@ -8,29 +9,33 @@ class SharedStrings
 
       include Writexlsx::Utility
 
+      PRESERVE_SPACE_ATTRIBUTES = ['xml:space', 'preserve'].freeze
+
       def initialize
-        @writer  = Package::XMLWriterSimple.new
-        @strings = [] # string table
-        @count   = {} # => count
+        @writer        = Package::XMLWriterSimple.new
+        @strings       = [] # string table
+        @strings_index = {} # string table index
+        @count         = 0 # count
       end
 
       def index(string, params = {})
         add(string) unless params[:only_query]
-        @strings.index(string)
+        @strings_index[string]
       end
 
       def add(string)
-        str = string.dup
-        if @count[str]
-          @count[str] += 1
-        else
+        unless @strings_index[string]
+          # Only first time the string will be append to list
+          # next time we only check and not #dup it
+          str = string.dup.freeze
           @strings << str
-          @count[str] = 1
+          @strings_index[str] = @strings.size - 1
         end
+        @count += 1
       end
 
       def string(index)
-        @strings[index].dup
+        @strings[index]
       end
 
       def empty?
@@ -77,7 +82,6 @@ def write_sst_strings
       # Write the <si> element.
       #
       def write_si(string)
-        string = string.dup
         attributes = []
 
         # Excel escapes control characters with _xHHHH_ and also escapes any
@@ -100,7 +104,7 @@ def write_si(string)
         end
 
         # Add attribute to preserve leading or trailing whitespace.
-        attributes << ['xml:space', 'preserve'] if string =~ /\A\s|\s\Z/
+        attributes << PRESERVE_SPACE_ATTRIBUTES if string =~ /\A\s|\s\Z/
 
         # Write any rich strings without further tags.
         if string =~ %r{^<r>} && string =~ %r{</r>$}
@@ -120,7 +124,7 @@ def add_c2_c3(string)
       end
 
       def total_count
-        @count.values.inject(0) { |sum, count| sum += count }
+        @count
       end
 
       def unique_count

data/lib/write_xlsx/package/styles.rb

@@ -49,7 +49,7 @@ def set_style_properties(xf_formats, palette, font_count, num_format_count, bord
       # based on the default or user defined values in the Workbook palette.
       #
       def palette_color(index)
-      if index =~ /^#([0-9A-F]{6})$/i
+      if index.to_s =~ /^#([0-9A-F]{6})$/i
         "FF#{$1.upcase}"
       else
         "FF#{super(index)}"

data/lib/write_xlsx/package/xml_writer_simple.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 #
 # XMLWriterSimple
 #
@@ -29,10 +30,9 @@ def tag_elements(tag, attributes = [])
       end
 
       def tag_elements_str(tag, attributes = [])
-        str = ''
-        str << start_tag_str(tag, attributes)
-        str << yield
-        str << end_tag_str(tag)
+        str = start_tag_str(tag, attributes) +
+              yield +
+              end_tag_str(tag)
       end
 
       def start_tag(tag, attr = [])
@@ -65,7 +65,7 @@ def empty_tag_encoded_str(tag, attr = [])
       end
 
       def data_element(tag, data, attr = [])
-        tag_elements(tag, attr) { io_write("#{escape_data(data)}") }
+        tag_elements(tag, attr) { io_write(escape_data(data)) }
       end
 
       #
@@ -118,7 +118,7 @@ def key_vals(attribute)
       end
 
       def escape_attributes(str = '')
-        return str if !(str =~ /["&<>]/)
+        return str if !(str.to_s =~ /["&<>]/)
 
         str.
           gsub(/&/, "&amp;").
@@ -128,7 +128,7 @@ def escape_attributes(str = '')
       end
 
       def escape_data(str = '')
-        if str =~ /[&<>]/
+        if str.to_s =~ /[&<>]/
           str.gsub(/&/, '&amp;').
             gsub(/</, '&lt;').
             gsub(/>/, '&gt;')

data/lib/write_xlsx/utility.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 require 'write_xlsx/col_name'
 
 module Writexlsx
@@ -243,7 +244,7 @@ def put_deprecate_message(method)
 
     # Check for a cell reference in A1 notation and substitute row and column
     def row_col_notation(args)   # :nodoc:
-      if args[0] =~ /^\D/
+      if args[0].to_s =~ /^\D/
         substitute_cellref(*args)
       else
         args
@@ -303,11 +304,12 @@ def write_color(writer, name, value) #:nodoc:
       writer.empty_tag('color', attributes)
     end
 
+    PERL_TRUE_VALUES = [false, nil, 0, "0", "", [], {}].freeze
     #
     # return perl's boolean result
     #
     def ptrue?(value)
-      if [false, nil, 0, "0", "", [], {}].include?(value)
+      if PERL_TRUE_VALUES.include?(value)
         false
       else
         true

data/lib/write_xlsx/version.rb

@@ -1 +1 @@
-WriteXLSX_VERSION = "0.85.6"
+WriteXLSX_VERSION = "0.85.11"

data/lib/write_xlsx/workbook.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 require 'write_xlsx/package/xml_writer_simple'
 require 'write_xlsx/package/packager'
 require 'write_xlsx/sheets'
@@ -926,7 +927,7 @@ def set_calc_mode(mode, calc_id = nil)
     #
     def set_custom_color(index, red = 0, green = 0, blue = 0)
       # Match a HTML #xxyyzz style parameter
-      if red =~ /^#(\w\w)(\w\w)(\w\w)/
+      if red.to_s =~ /^#(\w\w)(\w\w)(\w\w)/
         red   = $1.hex
         green = $2.hex
         blue  = $3.hex
@@ -972,8 +973,9 @@ def date_1904? #:nodoc:
     # Add a string to the shared string table, if it isn't already there, and
     # return the string index.
     #
-    def shared_string_index(str, params = {}) #:nodoc:
-      @shared_strings.index(str, params)
+    EMPTY_HASH = {}.freeze
+    def shared_string_index(str) #:nodoc:
+      @shared_strings.index(str, EMPTY_HASH)
     end
 
     def str_unique   # :nodoc:

data/lib/write_xlsx/worksheet.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 require 'write_xlsx/package/xml_writer_simple'
 require 'write_xlsx/package/button'
 require 'write_xlsx/colors'
@@ -720,7 +721,7 @@ def protect_default_settings  # :nodoc:
     #
     def set_column(*args)
       # Check for a cell reference in A1 notation and substitute row and column
-      if args[0] =~ /^\D/
+      if args[0].to_s =~ /^\D/
         row1, firstcol, row2, lastcol, *data = substitute_cellref(*args)
       else
         firstcol, lastcol, *data = args
@@ -2188,7 +2189,7 @@ def write_comment(*args)
     def write_number(*args)
       # Check for a cell reference in A1 notation and substitute row and column
       row, col, num, xf = row_col_notation(args)
-      raise WriteXLSXInsufficientArgumentError if [row, col, num].include?(nil)
+      raise WriteXLSXInsufficientArgumentError if row.nil? || col.nil? || num.nil?
 
       # Check that row and col are valid and store max and min values
       check_dimensions(row, col)
@@ -2230,13 +2231,13 @@ def write_string(*args)
       # Check for a cell reference in A1 notation and substitute row and column
       row, col, str, xf = row_col_notation(args)
       str &&= str.to_s
-      raise WriteXLSXInsufficientArgumentError if [row, col, str].include?(nil)
+      raise WriteXLSXInsufficientArgumentError if row.nil? || col.nil? || str.nil?
 
       # Check that row and col are valid and store max and min values
       check_dimensions(row, col)
       store_row_col_max_min_values(row, col)
 
-      index = shared_string_index(str[0, STR_MAX])
+      index = shared_string_index(str.length > STR_MAX ? str[0, STR_MAX] : str)
 
       store_data_to_table(StringCellData.new(self, row, col, index, xf))
     end
@@ -2527,6 +2528,91 @@ def write_array_formula(*args)
       end
     end
 
+    #
+    # :call-seq:
+    #   update_format_with_params(row, col, format_params)
+    #
+    # Update formatting of the cell to the specified row and column (zero indexed).
+    #
+    #     worksheet.update_format_with_params(0, 0, color: 'red')
+    #
+    # This method is used to update formatting of the cell keeping cell contents 
+    # and formatting.
+    #
+    # If the cell doesn't have CellData object, this method create a CellData 
+    # using write_blank method.
+    # If the cell has CellData, this method fetch contents and format of cell from 
+    # the CellData object and recreate CellData using write method.
+    #
+    def update_format_with_params(*args)
+      row, col, params = row_col_notation(args)
+      raise WriteXLSXInsufficientArgumentError if row.nil? || col.nil? || params.nil?
+
+      # Check that row and col are valid and store max and min values
+      check_dimensions(row, col)
+      store_row_col_max_min_values(row, col)
+
+      format = nil
+      cell_data = nil
+      if @cell_data_table[row].nil? || @cell_data_table[row][col].nil?
+        format = @workbook.add_format(params)
+        write_blank(row, col, format)
+      else
+        if @cell_data_table[row][col].xf.nil?
+          format = @workbook.add_format(params)
+          cell_data = @cell_data_table[row][col]
+        else
+          format = @workbook.add_format
+          cell_data = @cell_data_table[row][col]
+          format.copy(cell_data.xf)
+          format.set_format_properties(params)
+        end
+        # keep original value of cell
+        if cell_data.is_a? FormulaCellData
+          value = "=#{cell_data.token}"
+        elsif cell_data.is_a? FormulaArrayCellData
+          value = "{=#{cell_data.token}}"
+        elsif cell_data.is_a? StringCellData
+          value = @workbook.shared_strings.string(cell_data.data[:sst_id])
+        else
+          value = cell_data.data
+        end
+        write(row, col, value, format)
+      end
+    end
+
+    #
+    # :call-seq:
+    #   update_range_format_with_params(row_first, col_first, row_last, col_last, format_params)
+    #
+    # Update formatting of cells in range to the specified row and column (zero indexed).
+    #
+    #     worksheet.update_range_format_with_params(0, 0, 3, 3, color: 'red')
+    #
+    # This method is used to update formatting of multiple cells keeping cells' contents 
+    # and formatting.
+    #
+    #
+    def update_range_format_with_params(*args)
+      row_first, col_first, row_last, col_last, params = row_col_notation(args)
+
+      raise WriteXLSXInsufficientArgumentError if [row_first, col_first, row_last, col_last, params].include?(nil)
+
+      # Swap last row/col with first row/col as necessary
+      row_first,  row_last  = row_last,  row_first  if row_first > row_last
+      col_first, col_last = col_last, col_first if col_first > col_last
+
+      # Check that column number is valid and store the max value
+      check_dimensions(row_last, col_last)
+      store_row_col_max_min_values(row_last, col_last)
+
+      (row_first..row_last).each do |row|
+        (col_first..col_last).each do |col|
+          update_format_with_params(row, col, params)
+        end
+      end
+    end
+
     #
     # The outline_settings() method is used to control the appearance of
     # outlines in Excel. Outlines are described in
@@ -5810,7 +5896,7 @@ def excel2003_style? # :nodoc:
     # based on the default or user defined values in the Workbook palette.
     #
     def palette_color(index) #:nodoc:
-      if index =~ /^#([0-9A-F]{6})$/i
+      if index.to_s =~ /^#([0-9A-F]{6})$/i
         "FF#{$1.upcase}"
       else
         "FF#{super(index)}"
@@ -6099,7 +6185,7 @@ def parse_filter_tokens(expression, tokens)     #:nodoc:
       # Special handling of "Top" filter expressions.
       if tokens[0] =~ /^top|bottom$/i
         value = tokens[1]
-        if (value =~ /\D/ or value.to_i < 1 or value.to_i > 500)
+        if (value.to_s =~ /\D/ or value.to_i < 1 or value.to_i > 500)
           raise "The value '#{value}' in expression '#{expression}' " +
           "must be in the range 1 to 500"
         end
@@ -6128,7 +6214,7 @@ def parse_filter_tokens(expression, tokens)     #:nodoc:
       end
 
       # Special handling for Blanks/NonBlanks.
-      if (token =~ /^blanks|nonblanks$/i)
+      if (token.to_s =~ /^blanks|nonblanks$/i)
         # Only allow Equals or NotEqual in this context.
         if (operator != 2 and operator != 5)
           raise "The operator '#{tokens[1]}' in expression '#{expression}' " +
@@ -6156,7 +6242,7 @@ def parse_filter_tokens(expression, tokens)     #:nodoc:
 
       # if the string token contains an Excel match character then change the
       # operator type to indicate a non "simple" equality.
-      if (operator == 2 and token =~ /[*?]/)
+      if (operator == 2 and token.to_s =~ /[*?]/)
         operator = 22
       end
 
@@ -7510,8 +7596,8 @@ def calc_spans(data, row_num, span_min, span_max)
     # Add a string to the shared string table, if it isn't already there, and
     # return the string index.
     #
-    def shared_string_index(str, params = {}) #:nodoc:
-      @workbook.shared_string_index(str, params)
+    def shared_string_index(str) #:nodoc:
+      @workbook.shared_string_index(str)
     end
 
     #
@@ -7634,7 +7720,7 @@ def set_active_pane_and_cell_selections(row, col, top_row, left_col, active_cell
 
     def prepare_filter_column(col) # :nodoc:
       # Check for a column reference in A1 notation and substitute.
-      if col =~ /^\D/
+      if col.to_s =~ /^\D/
         col_letter = col
 
         # Convert col ref to a cell ref and then to a col number.

data/lib/write_xlsx/worksheet/cell_data.rb

@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 
 module Writexlsx
   class Worksheet
@@ -63,9 +64,10 @@ def data
         { :sst_id => token }
       end
 
+      TYPE_STR_ATTRS = ['t', 's'].freeze
       def write_cell
         attributes = cell_attributes
-        attributes << ['t', 's']
+        attributes << TYPE_STR_ATTRS
         @worksheet.writer.tag_elements('c', attributes) do
           @worksheet.write_cell_value(token)
         end

data/lib/write_xlsx/worksheet/data_validation.rb

@@ -282,7 +282,7 @@ def valid_criteria_type  # :nodoc:
 
       def convert_date_time_value(key)  # :nodoc:
         value = instance_variable_get("@#{key}")
-        if value && value =~ /T/
+        if value && value.to_s =~ /T/
           date_time = convert_date_time(value)
           instance_variable_set("@#{key}", date_time) if date_time
           date_time

data/lib/write_xlsx/worksheet/hyperlink.rb

@@ -24,7 +24,7 @@ def initialize(url, str, tip)
         str ||= url.dup
 
         # Strip the mailto header.
-        str.sub!(/^mailto:/, '')
+        normalized_str = str.sub(/^mailto:/, '')
 
         # Escape URL unless it looks already escaped.
         url = escape_url(url)
@@ -35,7 +35,7 @@ def initialize(url, str, tip)
         end
 
         @url       = url
-        @str       = str
+        @str       = normalized_str
         @url_str   = nil
         @tip       = tip
       end

data/test/regression/test_update_range_format_with_params.rb

@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+
+class TestUpdateRangeFormatWithParams < Test::Unit::TestCase
+  def setup
+    setup_dir_var
+  end
+
+  def teardown
+    @tempfile.close(true)
+  end
+
+  def test_update_range_format_with_params
+    @xlsx = 'update_range_format_with_params.xlsx'
+    workbook  = WriteXLSX.new(@io)
+    worksheet = workbook.add_worksheet
+
+    common_format = workbook.add_format(align: 'center', border: 1)
+
+    table_contents = [
+      ['Table', 'Header', 'Contents'],
+      ['table', 'body', 'contents'],
+      ['table', 'body', 'contents'],
+      ['table', 'body', 'contents']
+    ]
+
+    worksheet.write_col(0, 0, table_contents, common_format)
+    worksheet.update_range_format_with_params(
+      0, 0, 0, 2,
+      bold: 1, top: 2, bottom: 2, bg_color: 31
+    )
+    worksheet.update_range_format_with_params(0, 0, 3, 0, left: 2)
+    worksheet.update_range_format_with_params(0, 2, 3, 2, right: 2)
+    worksheet.update_range_format_with_params(3, 0, 3, 2, bottom: 2)
+
+    workbook.close
+    compare_for_regression(
+      nil,
+      {'xl/workbook.xml' => ['<workbookView']}
+    )
+  end
+end

data/test/run_test.rb

@@ -0,0 +1,9 @@
+base_dir = File.expand_path(File.join(File.dirname(__FILE__), ".."))
+lib_dir  = File.join(base_dir, "lib")
+test_dir = File.join(base_dir, "test")
+
+$LOAD_PATH.unshift(lib_dir)
+
+require 'test/unit'
+
+exit Test::Unit::AutoRunner.run(true, test_dir)

data/test/test_xml_writer_simple.rb

@@ -23,11 +23,11 @@ def test_empty_tag_with_xml_decl
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <foo/>
 EOS
-    assert_equal(expected, @obj.xml_decl << @obj.empty_tag('foo') << "\n")
+    assert_equal(expected, @obj.xml_decl + @obj.empty_tag('foo') + "\n")
   end
 
   def test_start_end_tag
-    assert_equal("<foo></foo>", @obj.start_tag('foo') << @obj.end_tag('foo'))
+    assert_equal("<foo></foo>", @obj.start_tag('foo') + @obj.end_tag('foo'))
   end
 
   def test_attribute
@@ -39,7 +39,7 @@ def test_attribute
   def test_character_data
     assert_equal(
       "<foo>&lt;tag&gt;&amp;amp;&lt;/tag&gt;</foo>",
-      @obj.start_tag('foo') << @obj.characters("<tag>&amp;</tag>") << @obj.end_tag('foo')
+      @obj.start_tag('foo') + @obj.characters("<tag>&amp;</tag>") + @obj.end_tag('foo')
     )
   end
 

data/test/worksheet/test_format.rb

@@ -0,0 +1,17 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+require 'write_xlsx'
+require 'stringio'
+
+class TestFormat < Test::Unit::TestCase
+  def setup
+    @workbook = WriteXLSX.new(StringIO.new)
+    @format   = @workbook.add_format
+  end
+
+  def test_set_align_with_frozen_parameter
+    assert_nothing_raised do
+      @format.set_align('LEFT'.freeze)
+    end
+  end
+end

data/test/worksheet/test_update_format_methods.rb

@@ -0,0 +1,111 @@
+# -*- coding: utf-8 -*-
+require 'helper'
+require 'write_xlsx'
+require 'stringio'
+
+class TestUpdateFormatMethods < Test::Unit::TestCase
+  def setup
+    @workbook = WriteXLSX.new(StringIO.new)
+    @worksheet = @workbook.add_worksheet('')
+  end
+
+  def test_update_format_with_params_with_insufficient_args_raise_InsufficientArgumentError
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_format_with_params
+    end
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_format_with_params(0)
+    end
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_format_with_params('A1')
+    end
+  end
+
+  def test_update_format_with_params_with_valid_arg_not_raise
+    assert_nothing_raised do
+      @worksheet.update_format_with_params(0, 0, color: 'red', border: 2)
+    end
+    assert_nothing_raised do
+      @worksheet.update_format_with_params('B2', align: 'center')
+    end
+  end
+
+  def test_update_format_with_params_should_write_blank_when_there_is_no_CellData
+    assert_nil(@worksheet.instance_variable_get(:@cell_data_table)[0])
+    @worksheet.update_format_with_params(0, 0, left: 4)
+    assert @worksheet.instance_variable_get(:@cell_data_table)[0][0] != nil
+  end
+
+  def test_update_format_with_params_should_keep_data_when_updating_format
+    number = 153
+    @worksheet.write(0, 0, number)
+    @worksheet.update_format_with_params(0, 0, bg_color: 'gray')
+    assert_equal(@worksheet.instance_variable_get(:@cell_data_table)[0][0].data, number)
+
+    string = 'Hello, World!'
+    @worksheet.write(0, 0, string)
+    @worksheet.update_format_with_params(0, 0, bg_color: 'gray')
+    written_string = @workbook.shared_strings.string(@worksheet.instance_variable_get(:@cell_data_table)[0][0].data[:sst_id])
+    assert_equal(written_string, string)
+
+    formula = '=1+1'
+    @worksheet.write(0, 0, formula)
+    @worksheet.update_format_with_params(0, 0, bg_color: 'gray')
+    assert_equal(@worksheet.instance_variable_get(:@cell_data_table)[0][0].token, '1+1')
+
+    array_formula = '{=SUM(B1:C1*B2:C2)}'
+    @worksheet.write('A1', array_formula)
+    @worksheet.update_format_with_params(0, 0, bg_color: 'gray')
+    assert_equal(@worksheet.instance_variable_get(:@cell_data_table)[0][0].token, 'SUM(B1:C1*B2:C2)')
+
+    url = 'https://www.writexlsx.io'
+    @worksheet.write(0, 0, url)
+    @worksheet.update_format_with_params(0, 0, bg_color: 'gray')
+    written_string = @workbook.shared_strings.string(@worksheet.instance_variable_get(:@cell_data_table)[0][0].data[:sst_id])
+    assert_equal(written_string, url)
+
+    string = 'Hello, World!'
+    format = @workbook.add_format(color: 'white')
+    @worksheet.write(0, 0, string, format)
+    @worksheet.update_format_with_params(0, 0, bg_color: 'gray')
+    written_string = @workbook.shared_strings.string(@worksheet.instance_variable_get(:@cell_data_table)[0][0].data[:sst_id])
+    assert_equal(written_string, string)
+  end
+
+  def test_update_format_with_params_should_not_update_other_cells_format
+    format = @workbook.add_format(bold: 1)
+    @worksheet.write_row(0, 0, ['', '', '', '', ''], format)
+    @worksheet.update_format_with_params(0, 0, bold: 0)
+    assert_not_equal(@worksheet.instance_variable_get(:@cell_data_table)[0][0].xf, 
+                     @worksheet.instance_variable_get(:@cell_data_table)[0][1].xf )
+    assert_equal(@worksheet.instance_variable_get(:@cell_data_table)[0][0].xf.bold, 0)
+    assert_equal(@worksheet.instance_variable_get(:@cell_data_table)[0][1].xf.bold, 1)
+  end
+
+  def test_update_range_format_with_params_with_insufficient_args_raise_InsufficientArgumentError
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_range_format_with_params
+    end
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_range_format_with_params(0, 0)
+    end
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_range_format_with_params('A1')
+    end
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_range_format_with_params(0, 0, 3, 3)
+    end
+    assert_raise(WriteXLSXInsufficientArgumentError) do
+      @worksheet.update_range_format_with_params('A2:C2')
+    end
+  end
+
+  def test_update_range_format_with_params_with_valid_arg_not_raise
+    assert_nothing_raised do
+      @worksheet.update_range_format_with_params(0, 0, 3, 3, bold: 1)
+    end
+    assert_nothing_raised do
+      @worksheet.update_range_format_with_params('A2:D5', bold: 1)
+    end
+  end
+end

data/write_xlsx.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |gem|
   gem.name          = "write_xlsx"
   gem.version       = WriteXLSX_VERSION
   gem.authors       = ["Hideo NAKAMURA"]
-  gem.email         = ["cxn03651@msj.biglobe.ne.jp"]
+  gem.email         = ["nakamura.hideo@gmail.com"]
   gem.description   = "write_xlsx is a gem to create a new file in the Excel 2007+ XLSX format."
   gem.summary       = "write_xlsx is a gem to create a new file in the Excel 2007+ XLSX format."
   gem.homepage = "http://github.com/cxn03651/write_xlsx#readme"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: write_xlsx
 version: !ruby/object:Gem::Version
-  version: 0.85.6
+  version: 0.85.11
 platform: ruby
 authors:
 - Hideo NAKAMURA
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-10 00:00:00.000000000 Z
+date: 2020-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -68,7 +68,7 @@ dependencies:
         version: '0'
 description: write_xlsx is a gem to create a new file in the Excel 2007+ XLSX format.
 email:
-- cxn03651@msj.biglobe.ne.jp
+- nakamura.hideo@gmail.com
 executables:
 - extract_vba.rb
 extensions: []
@@ -154,6 +154,7 @@ files:
 - examples/stocks.rb
 - examples/tab_colors.rb
 - examples/tables.rb
+- examples/update_range_format_with_params.rb
 - examples/vbaProject.bin
 - lib/write_xlsx.rb
 - lib/write_xlsx/chart.rb
@@ -978,6 +979,7 @@ files:
 - test/regression/test_tutorial01.rb
 - test/regression/test_tutorial02.rb
 - test/regression/test_tutorial03.rb
+- test/regression/test_update_range_format_with_params.rb
 - test/regression/test_urls_as_strings.rb
 - test/regression/test_utf8_01.rb
 - test/regression/test_utf8_03.rb
@@ -1561,6 +1563,7 @@ files:
 - test/regression/xlsx_files/tutorial01.xlsx
 - test/regression/xlsx_files/tutorial02.xlsx
 - test/regression/xlsx_files/tutorial03.xlsx
+- test/regression/xlsx_files/update_range_format_with_params.xlsx
 - test/regression/xlsx_files/urls_as_strings.xlsx
 - test/regression/xlsx_files/utf8_01.xlsx
 - test/regression/xlsx_files/utf8_03.xlsx
@@ -1578,6 +1581,7 @@ files:
 - test/regression/xlsx_files/vml03.xlsx
 - test/regression/xlsx_files/vml04.xlsx
 - test/republic.png
+- test/run_test.rb
 - test/test_col_name.rb
 - test/test_delete_files.rb
 - test/test_example_match.rb
@@ -1620,6 +1624,7 @@ files:
 - test/worksheet/test_convert_date_time_03.rb
 - test/worksheet/test_convert_date_time_04.rb
 - test/worksheet/test_extract_filter_tokens.rb
+- test/worksheet/test_format.rb
 - test/worksheet/test_parse_filter_expression.rb
 - test/worksheet/test_position_object.rb
 - test/worksheet/test_repeat_formula.rb
@@ -1634,6 +1639,7 @@ files:
 - test/worksheet/test_sparkline_09.rb
 - test/worksheet/test_sparkline_10.rb
 - test/worksheet/test_sparkline_11.rb
+- test/worksheet/test_update_format_methods.rb
 - test/worksheet/test_worksheet_01.rb
 - test/worksheet/test_worksheet_02.rb
 - test/worksheet/test_worksheet_03.rb
@@ -1709,8 +1715,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: write_xlsx is a gem to create a new file in the Excel 2007+ XLSX format.
@@ -2490,6 +2495,7 @@ test_files:
 - test/regression/test_tutorial01.rb
 - test/regression/test_tutorial02.rb
 - test/regression/test_tutorial03.rb
+- test/regression/test_update_range_format_with_params.rb
 - test/regression/test_urls_as_strings.rb
 - test/regression/test_utf8_01.rb
 - test/regression/test_utf8_03.rb
@@ -3073,6 +3079,7 @@ test_files:
 - test/regression/xlsx_files/tutorial01.xlsx
 - test/regression/xlsx_files/tutorial02.xlsx
 - test/regression/xlsx_files/tutorial03.xlsx
+- test/regression/xlsx_files/update_range_format_with_params.xlsx
 - test/regression/xlsx_files/urls_as_strings.xlsx
 - test/regression/xlsx_files/utf8_01.xlsx
 - test/regression/xlsx_files/utf8_03.xlsx
@@ -3090,6 +3097,7 @@ test_files:
 - test/regression/xlsx_files/vml03.xlsx
 - test/regression/xlsx_files/vml04.xlsx
 - test/republic.png
+- test/run_test.rb
 - test/test_col_name.rb
 - test/test_delete_files.rb
 - test/test_example_match.rb
@@ -3132,6 +3140,7 @@ test_files:
 - test/worksheet/test_convert_date_time_03.rb
 - test/worksheet/test_convert_date_time_04.rb
 - test/worksheet/test_extract_filter_tokens.rb
+- test/worksheet/test_format.rb
 - test/worksheet/test_parse_filter_expression.rb
 - test/worksheet/test_position_object.rb
 - test/worksheet/test_repeat_formula.rb
@@ -3146,6 +3155,7 @@ test_files:
 - test/worksheet/test_sparkline_09.rb
 - test/worksheet/test_sparkline_10.rb
 - test/worksheet/test_sparkline_11.rb
+- test/worksheet/test_update_format_methods.rb
 - test/worksheet/test_worksheet_01.rb
 - test/worksheet/test_worksheet_02.rb
 - test/worksheet/test_worksheet_03.rb