wright 0.2.0 → 0.3.0

data/spec/provider/package/homebrew_spec.rb

@@ -16,23 +16,6 @@ describe Wright::Provider::Package::Homebrew do
   before :each do
     homebrew_dir = File.join(File.dirname(__FILE__), 'homebrew')
     @fake_capture3 = FakeCapture3.new(homebrew_dir)
-    @install_message = ->(pkg) { "INFO: install package: '#{pkg}'\n" }
-    @install_message_dry = lambda do |pkg|
-      "INFO: (would) install package: '#{pkg}'\n"
-    end
-    @install_message_debug = lambda do |pkg|
-      "DEBUG: package already installed: '#{pkg}'\n"
-    end
-    @remove_message = ->(pkg) { "INFO: remove package: '#{pkg}'\n" }
-    @remove_message_dry = lambda do |pkg|
-      "INFO: (would) remove package: '#{pkg}'\n"
-    end
-    @remove_message_debug = lambda do |pkg|
-      "DEBUG: package already removed: '#{pkg}'\n"
-    end
-    @version_warning = lambda do |pkg, version|
-      "WARN: ignoring package version: '#{pkg} (#{version})'"
-    end
   end
 
   describe '#installed_versions' do
@@ -73,36 +56,15 @@ describe Wright::Provider::Package::Homebrew do
     end
   end
 
-  describe '#install' do
-    it 'should install packages that are not currently installed' do
+  describe '#install_package' do
+    it 'should install packages' do
       pkg_name = 'cd-discid'
       pkg_provider = package_provider(pkg_name)
-      brew_info_cmd = brew(:info, pkg_name)
       brew_install_cmd = brew(:install, pkg_name)
 
-      @fake_capture3.expect(brew_info_cmd)
       @fake_capture3.expect(brew_install_cmd)
       @fake_capture3.stub do
-        lambda do
-          reset_logger
-          pkg_provider.install
-          pkg_provider.updated?.must_equal true
-        end.must_output @install_message.call(pkg_name)
-      end
-    end
-
-    it 'should not try to install packages that are already installed' do
-      pkg_name = 'lame'
-      pkg_provider = package_provider(pkg_name)
-      brew_info_cmd = brew(:info, pkg_name)
-
-      @fake_capture3.expect(brew_info_cmd)
-      @fake_capture3.stub do
-        lambda do
-          reset_logger
-          pkg_provider.install
-          pkg_provider.updated?.must_equal false
-        end.must_output @install_message_debug.call(pkg_name)
+        pkg_provider.send(:install_package)
       end
     end
 
@@ -110,34 +72,27 @@ describe Wright::Provider::Package::Homebrew do
       pkg_name = 'cd-discid'
       pkg_version = '1.1'
       pkg_provider = package_provider(pkg_name, pkg_version)
-      brew_info_cmd = brew(:info, pkg_name)
       brew_install_cmd = brew(:install, pkg_name)
+      version_warning =
+        "WARN: ignoring package version: '#{pkg_name} (#{pkg_version})'\n"
 
-      install_message_with_warning =
-        @install_message.call(pkg_name) +
-        @version_warning.call(pkg_name, pkg_version) + "\n"
-
-      @fake_capture3.expect(brew_info_cmd)
       @fake_capture3.expect(brew_install_cmd)
       @fake_capture3.stub do
         lambda do
           reset_logger
-          pkg_provider.install
-          pkg_provider.updated?.must_equal true
-        end.must_output install_message_with_warning
+          pkg_provider.send(:install_package)
+        end.must_output version_warning
       end
     end
 
     it 'should raise exceptions for unavailable packages' do
       pkg_name = 'not-a-real-package'
       pkg_provider = package_provider(pkg_name)
-      brew_info_cmd = brew(:info, pkg_name)
       brew_install_cmd = brew(:install, pkg_name)
 
-      @fake_capture3.expect(brew_info_cmd)
       @fake_capture3.expect(brew_install_cmd)
       @fake_capture3.stub do
-        e = -> { pkg_provider.install }.must_raise RuntimeError
+        e = -> { pkg_provider.send(:install_package) }.must_raise RuntimeError
         wright_error = "cannot install package '#{pkg_name}'"
         brew_error = "Error: No available formula for #{pkg_name} "
         e.message.must_equal %(#{wright_error}: "#{brew_error}")
@@ -145,123 +100,15 @@ describe Wright::Provider::Package::Homebrew do
     end
   end
 
-  describe '#remove' do
-    it 'should remove packages that are currently installed' do
+  describe '#remove_package' do
+    it 'should remove packages' do
       pkg_name = 'lame'
       pkg_provider = package_provider(pkg_name)
-      brew_info_cmd = brew(:info, pkg_name)
       brew_uninstall_cmd = brew(:uninstall, pkg_name)
 
-      @fake_capture3.expect(brew_info_cmd)
       @fake_capture3.expect(brew_uninstall_cmd)
       @fake_capture3.stub do
-        lambda do
-          reset_logger
-          pkg_provider.remove
-          pkg_provider.updated?.must_equal true
-        end.must_output @remove_message.call(pkg_name)
-      end
-    end
-
-    it 'should not try to remove packages that are already removed' do
-      pkg_name = 'cd-discid'
-      pkg_provider = package_provider(pkg_name)
-      brew_info_cmd = brew(:info, pkg_name)
-
-      @fake_capture3.expect(brew_info_cmd)
-      @fake_capture3.stub do
-        lambda do
-          reset_logger
-          pkg_provider.remove
-          pkg_provider.updated?.must_equal false
-        end.must_output @remove_message_debug.call(pkg_name)
-      end
-    end
-
-    it 'should remove package versions that are currently installed' do
-      pkg_name = 'lame'
-      pkg_version = '3.99.5'
-      pkg_provider = package_provider(pkg_name, pkg_version)
-      brew_info_cmd = brew(:info, pkg_name)
-      brew_uninstall_cmd = brew(:uninstall, pkg_name)
-
-      @fake_capture3.expect(brew_info_cmd)
-      @fake_capture3.expect(brew_uninstall_cmd)
-
-      @fake_capture3.stub do
-        lambda do
-          reset_logger
-          pkg_provider.remove
-          pkg_provider.updated?.must_equal true
-        end.must_output @remove_message.call(pkg_name)
-      end
-    end
-  end
-
-  describe 'dry_run' do
-    it 'should not actually install packages' do
-      pkg_name = 'cd-discid'
-      pkg_provider = package_provider(pkg_name)
-      brew_cmd = brew(:info, pkg_name)
-
-      Wright.dry_run do
-        @fake_capture3.expect(brew_cmd)
-        @fake_capture3.stub do
-          lambda do
-            reset_logger
-            pkg_provider.install
-          end.must_output @install_message_dry.call(pkg_name)
-        end
-      end
-    end
-
-    it 'should not try to install packages that are already installed' do
-      pkg_name = 'lame'
-      pkg_provider = package_provider(pkg_name)
-      brew_cmd = brew(:info, pkg_name)
-
-      Wright.dry_run do
-        @fake_capture3.expect(brew_cmd)
-        @fake_capture3.stub do
-          lambda do
-            reset_logger
-            pkg_provider.install
-            pkg_provider.updated?.must_equal false
-          end.must_output @install_message_debug.call(pkg_name)
-        end
-      end
-    end
-
-    it 'should not actually remove packages' do
-      pkg_name = 'lame'
-      pkg_provider = package_provider(pkg_name)
-      brew_cmd = brew(:info, pkg_name)
-
-      Wright.dry_run do
-        @fake_capture3.expect(brew_cmd)
-        @fake_capture3.stub do
-          lambda do
-            reset_logger
-            pkg_provider.remove
-          end.must_output @remove_message_dry.call(pkg_name)
-        end
-      end
-    end
-
-    it 'should not try to remove packages that are already removed' do
-      pkg_name = 'cd-discid'
-      pkg_provider = package_provider(pkg_name)
-      brew_cmd = brew(:info, pkg_name)
-
-      Wright.dry_run do
-        @fake_capture3.expect(brew_cmd)
-        @fake_capture3.stub do
-          lambda do
-            reset_logger
-            pkg_provider.remove
-            pkg_provider.updated?.must_equal false
-          end.must_output @remove_message_debug.call(pkg_name)
-        end
+        pkg_provider.send(:remove_package)
       end
     end
   end

data/spec/provider/package_spec.rb

@@ -4,15 +4,15 @@ require 'wright/provider'
 require 'wright/provider/package'
 
 describe Wright::Provider::Package do
-  before(:each) do
-    Wright::Provider::Package.send(:public, :uptodate?)
-  end
+  describe '#uptodate?' do
+    before(:each) do
+      Wright::Provider::Package.send(:public, :uptodate?)
+    end
 
-  after(:each) do
-    Wright::Provider::Package.send(:private, :uptodate?)
-  end
+    after(:each) do
+      Wright::Provider::Package.send(:private, :uptodate?)
+    end
 
-  describe '#uptodate?' do
     it 'should return the correct status' do
       pkg_resource = OpenStruct.new(name: 'foo')
       pkg_provider = Wright::Provider::Package.new(pkg_resource)
@@ -60,4 +60,148 @@ describe Wright::Provider::Package do
       e.message.must_equal "invalid action 'foobarbaz'"
     end
   end
+
+  describe '#install' do
+    before(:each) do
+      pkg = 'foo'
+      @resource = OpenStruct.new(name: pkg)
+      @package = Wright::Provider::Package.new(@resource)
+      @mock_provider = Minitest::Mock.new
+      @installed_versions_stub = -> { @mock_provider.installed_versions }
+      @install_package_stub = -> { @mock_provider.install_package }
+
+      @install_message = "INFO: install package: '#{pkg}'\n"
+      @install_message_dry = "INFO: (would) install package: '#{pkg}'\n"
+      @install_message_debug = "DEBUG: package already installed: '#{pkg}'\n"
+    end
+
+    it 'should install packages that are not yet installed' do
+      @mock_provider.expect(:installed_versions, [])
+      @mock_provider.expect(:install_package, true)
+
+      @package.stub(:installed_versions, @installed_versions_stub) do
+        @package.stub(:install_package, @install_package_stub) do
+          lambda do
+            reset_logger
+            @package.install
+            @package.updated?.must_equal true
+          end.must_output @install_message
+        end
+      end
+      @mock_provider.verify
+    end
+
+    it 'should not try to install packages that already installed' do
+      @mock_provider.expect(:installed_versions, ['1.2.3'])
+
+      @package.stub(:installed_versions, @installed_versions_stub) do
+        @package.stub(:install_package, @install_package_stub) do
+          lambda do
+            reset_logger
+            @package.install
+            @package.updated?.must_equal false
+          end.must_output @install_message_debug
+        end
+      end
+      @mock_provider.verify
+    end
+
+    it 'should not try to install packages in dry-run mode' do
+      @mock_provider.expect(:installed_versions, [])
+
+      @package.stub(:installed_versions, @installed_versions_stub) do
+        lambda do
+          reset_logger
+          Wright.dry_run { @package.install }
+          @package.updated?.must_equal true
+        end.must_output @install_message_dry
+      end
+      @mock_provider.verify
+    end
+  end
+
+  describe '#remove' do
+    before(:each) do
+      pkg = 'foo'
+      @resource = OpenStruct.new(name: pkg)
+      @package = Wright::Provider::Package.new(@resource)
+      @mock_provider = Minitest::Mock.new
+      @installed_versions_stub = -> { @mock_provider.installed_versions }
+      @remove_package_stub = -> { @mock_provider.remove_package }
+
+      @remove_message = "INFO: remove package: '#{pkg}'\n"
+      @remove_message_dry = "INFO: (would) remove package: '#{pkg}'\n"
+      @remove_message_debug = "DEBUG: package already removed: '#{pkg}'\n"
+    end
+
+    it 'should remove packages that are currently installed' do
+      @mock_provider.expect(:installed_versions, ['1.2.3'])
+      @mock_provider.expect(:remove_package, true)
+
+      @package.stub(:installed_versions, @installed_versions_stub) do
+        @package.stub(:remove_package, @remove_package_stub) do
+          lambda do
+            reset_logger
+            @package.remove
+            @package.updated?.must_equal true
+          end.must_output @remove_message
+        end
+      end
+      @mock_provider.verify
+    end
+
+    it 'should not try to remove packages that are already removed' do
+      @mock_provider.expect(:installed_versions, [])
+
+      @package.stub(:installed_versions, @installed_versions_stub) do
+        @package.stub(:remove_package, @remove_package_stub) do
+          lambda do
+            reset_logger
+            @package.remove
+            @package.updated?.must_equal false
+          end.must_output @remove_message_debug
+        end
+      end
+      @mock_provider.verify
+    end
+
+    it 'should not try to remove packages in dry-run mode' do
+      @mock_provider.expect(:installed_versions, ['1.2.3'])
+
+      @package.stub(:installed_versions, @installed_versions_stub) do
+        @package.stub(:remove_package, @remove_package_stub) do
+          lambda do
+            reset_logger
+            Wright.dry_run { @package.remove }
+            @package.updated?.must_equal true
+          end.must_output @remove_message_dry
+        end
+      end
+      @mock_provider.verify
+    end
+  end
+
+  describe '#installed_versions' do
+    it 'should raise an exception' do
+      resource = OpenStruct.new(name: 'foo')
+      provider = Wright::Provider::Package.new(resource)
+      -> { provider.installed_versions }.must_raise(NotImplementedError)
+    end
+  end
+
+  describe '#install_package' do
+    it 'should raise an exception' do
+      resource = OpenStruct.new(name: 'foo')
+      provider = Wright::Provider::Package.new(resource)
+      -> { provider.send(:install_package) }.must_raise(NotImplementedError)
+    end
+  end
+
+  describe '#remove_package' do
+    it 'should raise an exception' do
+      resource = OpenStruct.new(name: 'foo')
+      provider = Wright::Provider::Package.new(resource)
+      -> { provider.send(:remove_package) }.must_raise(NotImplementedError)
+    end
+  end
 end

data/spec/provider/user/darwin_directory_service/dscl-delete-user.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service/dscl-new-user-full-name.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service/dscl-new-user-home.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service/dscl-new-user-password.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service/dscl-new-user-primary-group.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service/dscl-new-user-shell.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service/dscl-new-user-uid.return

@@ -0,0 +1 @@
+0

data/spec/provider/user/darwin_directory_service_spec.rb

@@ -0,0 +1,167 @@
+require_relative '../../spec_helper'
+
+require 'fakeetc'
+require 'wright/provider'
+require 'wright/provider/user'
+require 'wright/provider/user/darwin_directory_service'
+
+describe Wright::Provider::User::DarwinDirectoryService do
+  def dscl(command, user, key, value)
+    %W(dscl . -#{command} /Users/#{user} #{key} #{value})
+  end
+
+  before(:each) do
+    darwin_directory_service_dir =
+      File.join(File.dirname(__FILE__), 'darwin_directory_service')
+    @fake_capture3 = FakeCapture3.new(darwin_directory_service_dir, {})
+    @staff_gid = 20
+    @resource = OpenStruct.new(name: 'johndoe')
+    FakeEtc.add_users('dummy' => { uid: 23 })
+    FakeEtc.add_groups('staff' => { gid: @staff_gid },
+                       'anonymous' => { gid: 123 })
+  end
+
+  after(:each) do
+    FakeEtc.clear_users
+    FakeEtc.clear_groups
+  end
+
+  describe '#add_user' do
+    before(:each) do
+      Wright::Provider::User::DarwinDirectoryService.send(:public, :add_user)
+    end
+
+    after(:each) do
+      Wright::Provider::User::DarwinDirectoryService.send(:private, :add_user)
+    end
+
+    it 'should add users' do
+      provider = Wright::Provider::User::DarwinDirectoryService.new(@resource)
+      user = @resource.name
+
+      @fake_capture3.expect(dscl(:create, user, 'UniqueID', 500),
+                            'dscl-new-user-uid')
+      @fake_capture3.expect(dscl(:create, user, 'UserShell', '/bin/bash'),
+                            'dscl-new-user-shell')
+      @fake_capture3.expect(dscl(:create, user, 'RealName', ''),
+                            'dscl-new-user-full-name')
+      @fake_capture3.expect(dscl(:create,
+                                 user,
+                                 'NFSHomeDirectory',
+                                 "/Users/#{user}"),
+                            'dscl-new-user-home')
+      @fake_capture3.expect(dscl(:create, user, 'PrimaryGroupID', @staff_gid),
+                            'dscl-new-user-primary-group')
+      @fake_capture3.expect(dscl(:create, user, 'Password', '*'),
+                            'dscl-new-user-password')
+      @fake_capture3.stub do
+        FakeEtc { provider.add_user }
+      end
+    end
+
+    it 'should add system users' do
+      user = @resource.name
+      resource = OpenStruct.new(name: user, system: true)
+      provider = Wright::Provider::User::DarwinDirectoryService.new(resource)
+
+      @fake_capture3.expect(dscl(:create, user, 'UniqueID', 1),
+                            'dscl-new-user-uid')
+      @fake_capture3.expect(dscl(:create, user, 'UserShell', '/bin/bash'),
+                            'dscl-new-user-shell')
+      @fake_capture3.expect(dscl(:create, user, 'RealName', ''),
+                            'dscl-new-user-full-name')
+      @fake_capture3.expect(dscl(:create,
+                                 user,
+                                 'NFSHomeDirectory',
+                                 "/Users/#{user}"),
+                            'dscl-new-user-home')
+      @fake_capture3.expect(dscl(:create, user, 'PrimaryGroupID', @staff_gid),
+                            'dscl-new-user-primary-group')
+      @fake_capture3.expect(dscl(:create, user, 'Password', '*'),
+                            'dscl-new-user-password')
+      @fake_capture3.stub do
+        FakeEtc { provider.add_user }
+      end
+    end
+
+    it 'should add users with options' do
+      user = @resource.name
+      resource = OpenStruct.new(name: user,
+                                uid: 42,
+                                primary_group: 'anonymous',
+                                full_name: 'John Doe',
+                                groups: [],
+                                shell: '/bin/zsh',
+                                home: "/home/#{user}",
+                                system: true)
+      provider = Wright::Provider::User::DarwinDirectoryService.new(resource)
+
+      @fake_capture3.expect(dscl(:create, user, 'UniqueID', 42),
+                            'dscl-new-user-uid')
+      @fake_capture3.expect(dscl(:create, user, 'UserShell', '/bin/zsh'),
+                            'dscl-new-user-shell')
+      @fake_capture3.expect(dscl(:create, user, 'RealName', 'John Doe'),
+                            'dscl-new-user-full-name')
+      @fake_capture3.expect(dscl(:create,
+                                 user,
+                                 'NFSHomeDirectory',
+                                 "/home/#{user}"),
+                            'dscl-new-user-home')
+      @fake_capture3.expect(dscl(:create, user, 'PrimaryGroupID', 123),
+                            'dscl-new-user-primary-group')
+      @fake_capture3.expect(dscl(:create, user, 'Password', '*'),
+                            'dscl-new-user-password')
+      @fake_capture3.stub do
+        FakeEtc { provider.add_user }
+      end
+    end
+  end
+
+  describe '#update_user' do
+    before(:each) do
+      Wright::Provider::User::DarwinDirectoryService.send(:public,
+                                                          :update_user)
+    end
+
+    after(:each) do
+      Wright::Provider::User::DarwinDirectoryService.send(:private,
+                                                          :update_user)
+    end
+
+    it 'should update users' do
+      user = @resource.name
+      @resource.uid = 42
+      provider = Wright::Provider::User::DarwinDirectoryService.new(@resource)
+
+      FakeEtc.add_users(@resource.name => { uid: @resource.uid + 1 })
+      @fake_capture3.expect(dscl(:create, user, 'UniqueID', @resource.uid),
+                            'dscl-new-user-uid')
+      @fake_capture3.stub do
+        FakeEtc { provider.update_user }
+      end
+    end
+  end
+
+  describe '#delete_user' do
+    before(:each) do
+      Wright::Provider::User::DarwinDirectoryService.send(:public,
+                                                          :delete_user)
+    end
+
+    after(:each) do
+      Wright::Provider::User::DarwinDirectoryService.send(:private,
+                                                          :delete_user)
+    end
+
+    it 'should delete users' do
+      provider = Wright::Provider::User::DarwinDirectoryService.new(@resource)
+
+      FakeEtc.add_users(@resource.name => {})
+      @fake_capture3.expect(%W(dscl . -delete /Users/#{@resource.name}),
+                            'dscl-delete-user')
+      @fake_capture3.stub do
+        FakeEtc { provider.delete_user }
+      end
+    end
+  end
+end

data/spec/provider/user/gnu_passwd_spec.rb

@@ -5,7 +5,7 @@ require 'wright/provider'
 require 'wright/provider/user'
 require 'wright/provider/user/gnu_passwd'
 
-describe Wright::Provider::User do
+describe Wright::Provider::User::GnuPasswd do
   before(:each) do
     username = 'johndoe'
     @resource = OpenStruct.new(name: username)
@@ -24,7 +24,7 @@ describe Wright::Provider::User do
     end
 
     after(:each) do
-      Wright::Provider::User.send(:private, :add_user)
+      Wright::Provider::User::GnuPasswd.send(:private, :add_user)
     end
 
     it 'should add users' do
@@ -70,7 +70,7 @@ describe Wright::Provider::User do
     end
 
     after(:each) do
-      Wright::Provider::User.send(:private, :update_user)
+      Wright::Provider::User::GnuPasswd.send(:private, :update_user)
     end
 
     it 'should update users' do
@@ -85,13 +85,13 @@ describe Wright::Provider::User do
     end
   end
 
-  describe '#update_user' do
+  describe '#delete_user' do
     before(:each) do
       Wright::Provider::User::GnuPasswd.send(:public, :delete_user)
     end
 
     after(:each) do
-      Wright::Provider::User.send(:private, :delete_user)
+      Wright::Provider::User::GnuPasswd.send(:private, :delete_user)
     end
 
     it 'should delete users' do