wrest 0.0.8 → 0.0.9

data/spec/functional/sample_rails_app/vendor/plugins/resource_full/spec/resource_full/retrieve_spec.rb

@@ -0,0 +1,173 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe "ResourceFull::Retrieve", :type => :controller do
+  controller_name "resource_full_mock_users"
+  
+  before :each do
+    ResourceFullMockUser.delete_all
+    ResourceFullMockUsersController.resource_identifier = :id
+    ResourceFullMockUsersController.queryable_params = []
+  end
+  
+  it "defines custom methods based on the class name" do
+    controller.should respond_to(
+      :find_resource_full_mock_user, 
+      :find_all_resource_full_mock_users, 
+      :update_resource_full_mock_user, 
+      :destroy_resource_full_mock_user, 
+      :new_resource_full_mock_user
+    )
+  end
+  
+  it "changes the custom methods if the model name is changed" do
+    controller.class.exposes ResourceFullMock
+    controller.should respond_to(:find_resource_full_mock)
+    controller.should_not respond_to(:find_resource_full_mock_user)
+    controller.class.exposes ResourceFullMockUser # cleanup
+  end
+    
+  it "finds the requested model object" do
+    user = ResourceFullMockUser.create!
+    get :show, :id => user.id
+    assigns(:resource_full_mock_user).should == user
+  end
+  
+  describe "resource_identifier and identified_by" do
+    controller_name "resource_full_mock_users"
+    
+    before :each do
+      ResourceFullMockUser.delete_all
+      ResourceFullMockUsersController.resource_identifier = :id
+    end
+    
+    def get_should_retrieve_by_first_name
+      eustace = ResourceFullMockUser.create! :first_name => "eustace"
+      eustace_noise = ResourceFullMockUser.create! :first_name => eustace.id
+      get :show, :id => "eustace"
+      assigns(:resource_full_mock_user).should == eustace
+    end
+    
+    def get_should_retrieve_by_id
+      jimbo = ResourceFullMockUser.create! :first_name => "jimbo"
+      jimbo_noise = ResourceFullMockUser.create! :first_name => jimbo.id
+      get :show, :id => jimbo.id
+      assigns(:resource_full_mock_user).should == jimbo
+    end
+    
+    it "finds the requested model object using the correct column if the resource_identifier attribute has been overridden" do
+      ResourceFullMockUsersController.resource_identifier = :first_name
+      get_should_retrieve_by_first_name
+    end
+    
+    it "doesn't find the requested model object if there are none to find" do
+      ResourceFullMockUsersController.resource_identifier = :first_name
+      get :show, :id => "eustace"
+      assigns(:resource_full_mock_user).should be_nil
+    end
+  
+    it "finds the requested model object using the correct column if a block is provided to resource_identifier" do
+      ResourceFullMockUsersController.resource_identifier = lambda do |id| 
+        if id =~ /[0-9]+/
+          :id
+        else :first_name end
+      end
+      get_should_retrieve_by_first_name
+      get_should_retrieve_by_id
+    end
+    
+    it "finds the requested model object only if the optional block provided to identifed_by is true" do
+      ResourceFullMockUsersController.identified_by :first_name, :if => lambda { |id| id =~ /[a-zA-Z]+/ }
+      get_should_retrieve_by_first_name
+      get_should_retrieve_by_id
+    end
+    
+    it "finds the requested model object unless the optional block provided to identifed_by is true" do
+      ResourceFullMockUsersController.identified_by :first_name, :unless => lambda { |id| id =~ /[0-9]+/ }
+      get_should_retrieve_by_first_name
+      get_should_retrieve_by_id
+    end
+    
+    it "finds the requested model object unless it requests a fallback to a numeric id" do
+      ResourceFullMockUsersController.identified_by :first_name, :unless => :id_numeric
+      get_should_retrieve_by_first_name
+      get_should_retrieve_by_id
+    end
+  end
+  
+  it "updates the requested model object based on the given parameters" do
+    user = ResourceFullMockUser.create! :last_name => "threepwood"
+    post :update, :id => user.id, :resource_full_mock_user => { :last_name => "guybrush" }
+    user.reload.last_name.should == "guybrush"
+  end
+  
+  it "updates the requested model object using the correct column if the resource_identifier attribute has been overridden" do
+    ResourceFullMockUsersController.resource_identifier = :first_name
+    user = ResourceFullMockUser.create! :first_name => "guybrush"
+    post :update, :id => "guybrush", :resource_full_mock_user => { :last_name => "threepwood" }
+    user.reload.last_name.should == "threepwood"
+  end
+  
+  it "creates a new model object based on the given parameters" do
+    put :create, :resource_full_mock_user => { :first_name => "guybrush", :last_name => "threepwood" }
+    ResourceFullMockUser.count.should == 1
+    ResourceFullMockUser.find(:first).first_name.should == "guybrush"
+  end
+  
+  it "creates a new model object appropriately if a creational parameter is queryable but not placed in the model object params, as with a nested route" do
+    ResourceFullMockUsersController.queryable_with :first_name
+    put :create, :first_name => "guybrush", :resource_full_mock_user => { :last_name => "threepwood" }
+    ResourceFullMockUser.count.should == 1
+    user = ResourceFullMockUser.find :first
+    user.first_name.should == "guybrush"
+    user.last_name.should == "threepwood"
+  end
+  
+  it "deletes the requested model object" do
+    user = ResourceFullMockUser.create!
+    delete :destroy, :id => user.id
+    ResourceFullMockUser.exists?(user.id).should be_false
+  end
+  
+  it "deletes the requested model object using the correct column if the resource_identifier attribute has been overridden" do
+    ResourceFullMockUsersController.resource_identifier = :first_name
+    user = ResourceFullMockUser.create! :first_name => "guybrush"
+    delete :destroy, :id => "guybrush"
+    ResourceFullMockUser.exists?(user.id).should be_false
+  end
+  
+  describe "with pagination" do
+    controller_name "resource_full_mock_users"
+    
+    before :each do
+      ResourceFullMockUser.delete_all
+      @users = (1..6).collect { ResourceFullMockUser.create! }
+    end
+    
+    after :all do
+      ResourceFullMockUser.delete_all
+    end
+    
+    it "limits the query to the correct number of records given that parameter" do
+      ResourceFullMockUsersController.queryable_with :limit, :scope => lambda {|limit| { :limit => limit }}
+      get :index, :limit => 2
+      assigns(:resource_full_mock_users).should == @users[0..1]
+    end
+    
+    it "offsets the query by the correct number of records" do
+      ResourceFullMockUsersController.queryable_with :limit, :scope => lambda {|limit| { :limit => limit }}
+      ResourceFullMockUsersController.queryable_with :offset, :scope => lambda {|offset| { :offset => offset }}
+      get :index, :offset => 4, :limit => 2
+      assigns(:resource_full_mock_users).should == @users[4..5]
+    end
+    
+    xit "doesn't attempt to paginate if pagination is disabled" do
+      ResourceFullMockUsersController.queryable_with :limit, :scope => lambda {|limit| { :limit => limit }}
+      ResourceFullMockUsersController.queryable_with :offset, :scope => lambda {|offset| { :offset => offset }}
+      ResourceFullMockUsersController.paginatable = false
+      get :index, :offset => 4, :limit => 2
+      assigns(:resource_full_mock_users).should == @users
+      ResourceFullMockUsersController.paginatable = true # cleanup
+    end
+  end
+  
+end

data/spec/functional/sample_rails_app/vendor/plugins/resource_full/spec/spec_helper.rb

@@ -0,0 +1,98 @@
+# This file is copied to ~/spec when you run 'ruby script/generate rspec'
+# from the project root directory.
+ENV["RAILS_ENV"] = "test"
+
+require File.expand_path(File.dirname(__FILE__) + '/../../../../config/environment')  
+require 'spec'
+require 'spec/rails'
+require 'resource_full/core_extensions/from_json'
+
+Spec::Runner.configure do |config|
+  # If you're not using ActiveRecord you should remove these
+  # lines, delete config/database.yml and disable :active_record
+  # in your config/boot.rb
+  config.use_transactional_fixtures = true
+  config.use_instantiated_fixtures  = false
+  config.fixture_path = RAILS_ROOT + '/vendor/plugins/resource_full/spec/fixtures/'
+  config.mock_with :mocha
+  
+  config.before(:all) do
+    ActiveRecord::Base.connection.create_table "resource_full_mock_addresses", :force => true do |t|
+      t.string   "street"
+      t.string   "city"
+      t.string   "state_code"
+      t.integer  "zip"
+      t.integer  "resource_full_mock_user_id"
+      t.timestamps
+    end
+
+    ActiveRecord::Base.connection.create_table "resource_full_mock_users", :force => true do |t|
+      t.string   "first_name"
+      t.string   "last_name"
+      t.date     "birthdate"
+      t.string   "email"
+      t.string   "join_date"
+      t.integer  "income"
+      t.integer  "resource_full_mock_employer_id"
+      t.timestamps
+    end
+    
+    ActiveRecord::Base.connection.create_table "resource_full_mock_employers", :force => true do |t|
+      t.string "name"
+      t.string "email"
+      t.timestamps
+    end
+  end
+end
+
+ActionController::Routing::Routes.draw do |map|
+  map.foo '/foo', :controller => 'resource_full_mocks', :action => 'foo'
+  map.resources :resource_full_mocks, :resource_full_sub_mocks, :resource_full_mock_addresses
+  map.resources :resource_full_mock_users, :collection => {:count => :get} do |users|
+    users.resources :resource_full_mock_addresses
+  end
+  map.resources :resources, :controller => 'resource_full/controllers/resources' do |resource|
+    resource.resources :routes, :controller => 'resource_full/controllers/routes'
+  end
+end
+
+class ResourceFullMock
+  def self.table_name; "mock"; end
+end
+class ResourceFullSubMock < ResourceFullMock; end
+
+# TODO Remove these or find a better way to handle ActiveRecord dependencies.
+class ResourceFullMockEmployer < ActiveRecord::Base
+  has_many :resource_full_mock_users
+end
+
+class ResourceFullMockUser < ActiveRecord::Base
+  belongs_to :resource_full_mock_employer
+  has_many :resource_full_mock_addresses
+end
+
+class ResourceFullMockAddress < ActiveRecord::Base
+  belongs_to :resource_full_mock_user
+end
+
+class ResourceFullMocksController < ResourceFull::Base
+  # dispatch_spec custom methods spec, approx. line 98
+  def foo
+    render :xml => { :foo => "bar" }.to_xml
+  end
+end
+class ResourceFullSubMocksController < ResourceFullMocksController; end
+class ResourceFullMockUsersController < ResourceFull::Base;         end
+class ResourceFullMockAddressesController < ResourceFull::Base;     end
+
+ActionController::Routing.use_controllers! %w{ 
+  resource_full_mock_users 
+  resource_full_mock_addresses 
+  resource_full_mocks
+  resource_full_sub_mocks
+  resource_full/controllers/routes
+  resource_full/controllers/resources
+}
+
+def putsh(stuff); puts ERB::Util.h(stuff) + "<br/>"; end
+def ph(stuff); puts ERB::Util.h(stuff.inspect) + "<br/>"; end

data/spec/functional/sample_rails_app/vendor/plugins/resource_full/uninstall.rb

@@ -0,0 +1 @@
+# Uninstall hook code here

data/spec/{spec_helper.rb → unit/spec_helper.rb}

@@ -1,7 +1,7 @@
-require File.expand_path(File.dirname(__FILE__) + "/../lib/wrest")
+require File.expand_path(File.dirname(__FILE__) + "/../../lib/wrest")
 require 'spec'
 
-["/custom_matchers/**/*.rb"].each{|directory|
+['/../custom_matchers/**/*.rb'].each{|directory|
   Dir["#{File.expand_path(File.dirname(__FILE__) + directory)}"].each { |file|
     require file
   }

data/spec/unit/wrest/components/attributes_container/alias_accessors_spec.rb

@@ -0,0 +1,49 @@
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+module Wrest::Components
+  describe AttributesContainer::AliasAccessors do
+    before :each do
+      @Demon = Class.new
+      @Demon.class_eval do
+        include Wrest::Components::AttributesContainer
+      end
+    end
+
+    it "should provide a macro to enable aliasing accessors" do
+      lambda{ @Demon.class_eval{ alias_accessors :shiriki => :chambala } }.should_not raise_error(NoMethodError)
+    end
+
+    describe 'aliasing' do
+      before :each do
+        @Demon.class_eval{ alias_accessors :sex => :gender, :age => :maturity }
+      end
+
+      it "should provide an accessor methods when we alias to an attribute" do
+        demon = @Demon.new
+        demon.should respond_to(:gender)
+        demon.should respond_to(:gender=)
+        demon.should respond_to(:gender?)
+        demon.should respond_to(:maturity)
+        demon.should respond_to(:maturity=)
+        demon.should respond_to(:maturity?)
+      end
+
+      it "should ensure that the aliased getter method delegates to the actual getter" do
+        demon = @Demon.new :sex => 'male'
+        demon.gender.should == 'male'
+      end
+
+      it "should ensure that the aliased setter method delegates to the actual getter" do
+        demon = @Demon.new
+        demon.should_receive(:sex=).with('male')
+        demon.gender = 'male'
+      end
+
+      it "should ensure that the aliased query method delegates to the actual queryier" do
+        demon = @Demon.new :age => '1000'
+        demon.gender?.should be_false
+        demon.maturity?.should be_true
+      end
+    end
+  end
+end

data/spec/{wrest → unit/wrest}/components/attributes_container/typecaster_spec.rb

@@ -5,8 +5,8 @@ module Wrest::Components
     before :each do
       @Demon = Class.new
       @Demon.class_eval do
-        include AttributesContainer
-        include AttributesContainer::Typecaster
+        include Wrest::Components::AttributesContainer
+        include Wrest::Components::AttributesContainer::Typecaster
       end
     end
 
@@ -16,10 +16,30 @@ module Wrest::Components
       kai_wren.age.should == 1
     end
 
-    it "should not apply a lambda to the value of a given key if it is not a string" do
-      @Demon.class_eval{ typecast :age => lambda{|id_string| id_string.to_i} }
-      kai_wren = @Demon.new('age' => :ooga)
-      kai_wren.age.should == :ooga
+    describe "where the value is not a typecastable type" do
+      it "string should not typecast" do
+        @Demon.class_eval{ typecast :age => lambda{|id_string| id_string.to_i} }
+        kai_wren = @Demon.new('age' => :ooga)
+        kai_wren.age.should == :ooga
+      end
+
+      it "hash should not typecast" do
+        class TestUser
+          include Wrest::Components::AttributesContainer
+        end
+
+        @Demon.class_eval{ typecast :user => lambda{|user| TestUser.new(user)}}
+
+        kai_wren = @Demon.new('user' => {'foo' => 'bar'})
+        kai_wren.user.class.should == TestUser
+        kai_wren.user.foo.should == 'bar'
+      end
+
+      it "array should not typecast" do
+        @Demon.class_eval{ typecast :addresses => lambda{|addresses| addresses.first} }
+        kai_wren = @Demon.new('addresses' => ['foo', 'bar'])
+        kai_wren.addresses.should == 'foo'
+      end
     end
 
     it "should leave nils unchanged" do
@@ -38,8 +58,8 @@ module Wrest::Components
       before :each do
         @Sidhe = Class.new
         @Sidhe.class_eval do
-          include AttributesContainer
-          include AttributesContainer::Typecaster
+          include Wrest::Components::AttributesContainer
+          include Wrest::Components::AttributesContainer::Typecaster
 
           typecast :age => as_integer
         end

data/spec/{wrest → unit/wrest}/components/attributes_container_spec.rb

@@ -12,10 +12,34 @@ require File.dirname(__FILE__) + '/../../spec_helper'
 module Wrest::Components
   describe AttributesContainer do
     class HumanBeing
-      include AttributesContainer
+      include Wrest::Components::AttributesContainer
       always_has :id
     end
 
+    describe "typecasting" do
+      before(:each) do
+        @Demon = Class.new
+
+        @Demon.class_eval do
+          include Wrest::Components::AttributesContainer
+        end
+      end
+
+      it "should delegate to AttributesContainer::Typecaster#typecast to actually do the typecasting" do
+        @Demon.class_eval do
+          typecast :foo => lambda{|value| value.to_i}
+        end
+        @Demon.new(:foo => '1').foo.should == 1
+      end
+      
+      it "should provide helpers for common typecasts" do
+        @Demon.class_eval do
+          typecast :foo => as_integer
+        end
+        @Demon.new(:foo => '1').foo.should == 1
+      end
+    end
+
     it "should allow instantiation with no attributes" do
       lambda{ HumanBeing.new }.should_not raise_error
     end
@@ -26,39 +50,41 @@ module Wrest::Components
           @Demon = Class.new
         end
 
+        # Methods are string in 1.8 and symbols in 1.9. We'll use to_sym to
+        # allow us to build on both.
         it "should define attribute getters at the class level" do
           kai_wren = @Demon.new
-          kai_wren.methods.should_not include('trainer')
+          kai_wren.methods.map(&:to_sym).should_not include(:trainer)
 
           @Demon.class_eval{
-            include AttributesContainer
+            include Wrest::Components::AttributesContainer
             always_has :trainer
           }
 
-          kai_wren.methods.should include('trainer')
+          kai_wren.methods.map(&:to_sym).should include(:trainer)
         end
 
         it "should define attribute setters at the class level" do
           kai_wren = @Demon.new
-          kai_wren.methods.should_not include('trainer=')
+          kai_wren.methods.map(&:to_sym).should_not include(:trainer=)
 
           @Demon.class_eval{
-            include AttributesContainer
+            include Wrest::Components::AttributesContainer
             always_has :trainer
           }
 
-          kai_wren.methods.should include('trainer=')
+          kai_wren.methods.map(&:to_sym).should include(:trainer=)
         end
 
         it "should define attribute query methods at the class level" do
           kai_wren = @Demon.new
-          kai_wren.methods.should_not include('trainer?')
+          kai_wren.methods.map(&:to_sym).should_not include(:trainer?)
 
           @Demon.class_eval{
-            include AttributesContainer
+            include Wrest::Components::AttributesContainer
             always_has :trainer
           }
-          kai_wren.methods.should include('trainer?')
+          kai_wren.methods.map(&:to_sym).should include(:trainer?)
         end
       end
 
@@ -66,7 +92,7 @@ module Wrest::Components
         before :each do
           @Demon = Class.new
           @Demon.class_eval{
-            include AttributesContainer
+            include Wrest::Components::AttributesContainer
             always_has :trainer
 
             def method_missing(method_name, *args)
@@ -155,14 +181,15 @@ module Wrest::Components
         @li_piao.should_not respond_to(:god=)
       end
 
-      it "should fail when query methods for attributes that don't exist are invoked" do
-        lambda{ @li_piao.ooga? }.should raise_error(NoMethodError)
+      it "should return false when query methods for attributes that don't exist are invoked" do
+        @li_piao.ooga?.should be_false
       end
 
       it "should provide query methods for attributes" do
         li_piao = HumanBeing.new( :profession => 'Natural Magician', :enhanced_by => nil)
         li_piao.profession?.should be_true
         li_piao.enhanced_by?.should be_false
+        li_piao.gender?.should be_false
       end
 
       it "should respond to query methods for attributes" do
@@ -179,14 +206,14 @@ module Wrest::Components
         @li_piao.id = 6
         @li_piao.id.should == 6
       end
-      
+
       it "should provide getter and query methods to instance which has corresponding attribute" do
         zotoh_zhaan = HumanBeing.new(:species => "Delvian")
         zotoh_zhaan.species.should == "Delvian"
         zotoh_zhaan.species?.should be_true
         zotoh_zhaan.species = "Human"
         lambda{@li_piao.species}.should raise_error(NoMethodError)
-        lambda{@li_piao.species?}.should raise_error(NoMethodError)
+        @li_piao.species?.should be_false
         @li_piao.should_not respond_to(:species=)
         @li_piao.methods.grep(/:species=/).should be_empty
       end

data/spec/{wrest → unit/wrest}/components/mutators/base_spec.rb

@@ -12,7 +12,7 @@ require File.dirname(__FILE__) + '/../../../spec_helper'
 module Wrest::Components
   describe Mutators::Base do
     it "should raise an exception if mutate is invoked without do_mutate being implemented in a subclass" do
-      lambda{ Class.new(Mutators::Base).new.mutate([]) }.should raise_error(Wrest::Exceptions::MethodNotOverriddenException)
+      lambda{ Class.new(Mutators::Base).new.mutate([]) }.should raise_error(Wrest::Exceptions::MethodNotOverridden)
     end
 
     it "should ensure that the next mutator is invoked for a subclass" do

data/spec/{wrest → unit/wrest}/components/translators_spec.rb

@@ -12,7 +12,7 @@ require File.dirname(__FILE__) + '/../../spec_helper'
 module Wrest::Components
   describe Translators do
     it "should know how to raise an exception if the mime type doesn't exist" do
-      lambda{ Translators.lookup('weird/unknown')}.should raise_error(Wrest::Exceptions::UnsupportedContentTypeException)
+      lambda{ Translators.lookup('weird/unknown')}.should raise_error(Wrest::Exceptions::UnsupportedContentType)
     end
   end
 end

data/spec/{wrest → unit/wrest}/core_ext/string/conversions_spec.rb

@@ -22,4 +22,18 @@ describe String, 'conversions' do
     uri.username.should == 'ooga'
     uri.password.should == 'booga'
   end
+  
+  it "should strip leading spaces from a uri before building it" do
+    ' http://localhost:3000'.to_uri.should == Wrest::Uri.new('http://localhost:3000')
+  end
+  
+  it "should strip trailing spaces from a uri before building it" do
+    'http://localhost:3000  '.to_uri.should == Wrest::Uri.new('http://localhost:3000')
+  end
+  
+  it "should levae the original string  unchanged after building a uri from it" do
+    url = ' http://localhost:3000  '
+    url.to_uri.should == Wrest::Uri.new('http://localhost:3000')
+    url.should == ' http://localhost:3000  '
+  end
 end

data/spec/unit/wrest/http/redirection_spec.rb

@@ -0,0 +1,42 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe Wrest::Http::Redirection do
+  
+  it "should make a request to the url in its location header and return the response" do
+    mock_net_http_response = mock(Net::HTTPRedirection)
+    redirect_url = 'http://redirect.com'
+    redirect_uri = redirect_url.to_uri
+    mock_net_http_response.should_receive(:[]).with('location').and_return(redirect_url)
+    mock_net_http_response.should_receive(:code).and_return('200')
+    
+    Wrest::Uri.should_receive(:new).with(redirect_url, anything).and_return(redirect_uri)
+    
+    
+    after_redirect_request = Wrest::Http::Get.new(redirect_uri)
+    final_mock_response = mock(Wrest::Http::Response)
+    after_redirect_request.should_receive(:invoke).and_return(final_mock_response)
+    
+    Wrest::Http::Get.should_receive(:new).with(redirect_uri, {}, {}, {:username=>nil, :password=>nil}).and_return(after_redirect_request)
+    
+    response = Wrest::Http::Redirection.new(mock_net_http_response)
+    response.follow(:follow_redirects_count => 0, :follow_redirects_limit => 5).should == final_mock_response
+  end
+  
+  it "should raise a Wrest::Exceptions::AutoRedirectLimitExceeded if there are more redirections than the limit" do
+    request_url = 'http://redirect.com'
+
+    response = mock(Net::HTTPRedirection)
+    response.stub!(:code).and_return('301')
+    response.stub!(:message).and_return('')
+    response.stub!(:body).and_return('')
+    response.should_receive(:[]).with('location').exactly(5).times.and_return(request_url)
+    
+    http_connection = mock(Net::HTTP)
+    http_connection.stub!(:read_timeout=)
+    http_connection.should_receive(:request).exactly(5).times.and_return(response)
+    
+    Net::HTTP.should_receive(:new).exactly(5).times.and_return(http_connection)
+
+    lambda{ request_url.to_uri(:follow_redirects_limit => 5).get }.should raise_error(Wrest::Exceptions::AutoRedirectLimitExceeded)
+  end
+end