wrapp 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40c93543e0cd77a1baa9df614d75db5ea48377cf
-  data.tar.gz: d23d98c547556f4eb3b3c5c6a5745f6fe6a96109
+  metadata.gz: caa2b48e6568ce9e7fe82e2dadb45ab812d9e841
+  data.tar.gz: 8ec780d1e205d15cbba9e058a597e40a29b0e830
 SHA512:
-  metadata.gz: cda2fcf14485ab0aef3587f9b546f405e2d100fa28fdfc3b22453753ce980e4a5d96bdf59ad5095e3a3940d647b19ab6eb242c81a57eef9c5587b0c8c7966879
-  data.tar.gz: 3e6c45c4b97368ca26ab1dfc074f6c515ec3afd3eee394bef687a1ce4bcb80e24e00e7d88df239ee53b25ed40d2957b4ed1691f5522e9bccb2232fd2bd7cc714
+  metadata.gz: 2988f61ddf590819b523e552130d9acb2b16bf33835581cae379ab9e65b332c2b694d031e78c0cab1629464c7f7ab43508704a898d8d42927267070f0bea0486
+  data.tar.gz: b5e890e913b625d6e2739c8f63ea4c68dcbfffb66185ee2c84353549bc99311aad78c4f899a6d030e2360475893866bac81be8be1e23ca4b055c8bb23a900236

data/lib/wrapp/app_info.rb

@@ -20,15 +20,9 @@ module Wrapp
     end
 
     def get_property(property)
-      raise "No property found: #{property}" unless
-        properties.has_key?(property)
-      properties[property].strip
-    end
-
-    private
-
-    def properties
-      Plist4r.open plist
+      command_line = Cocaine::CommandLine.new('/usr/libexec/PlistBuddy',
+                                              '-c :cmd :plist')
+      command_line.run(:cmd => "Print #{property}", :plist => plist).strip
     end
   end
 end

data/lib/wrapp/version.rb

@@ -1,3 +1,3 @@
 module Wrapp
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/lib/wrapp.rb

@@ -1,5 +1,5 @@
 require 'mixlib/cli'
-require 'plist4r'
+require 'cocaine'
 require 'wrapp/version'
 require 'wrapp/app_info'
 require 'wrapp/dmg_builder'

data/spec/wrapp/app_info_spec.rb

@@ -4,6 +4,10 @@ module Wrapp
   describe AppInfo do
     let(:app) { AppInfo.new('Info.plist') }
 
+    before do
+      AppInfo.any_instance.stub(:`)
+    end
+
     describe '#full_name' do
       it 'includes the downcased name and version without spaces' do
         app.stub(:name).and_return("Chunky\t Bacon")
@@ -30,29 +34,30 @@ module Wrapp
       end
     end
 
-    describe '#properties' do
-      it 'returns the app properties as hash' do
-        Plist4r.should_receive(:open).with('Info.plist').
-          and_return(:plist_as_hash)
-        expect(app.send(:properties)).to eq(:plist_as_hash)
+    describe '#get_property' do
+      let(:command_line) { double('command_line', :run => '') }
+
+      before do
+        Cocaine::CommandLine.stub(:new).and_return(command_line)
       end
-    end
 
-    describe '#get_property' do
-      context 'with existing property' do
-        it 'returns the striped property' do
-          app.stub(:properties).and_return({})
-          expect { 
-            app.get_property('Chunky')
-          }.to raise_error(/no property found: chunky/i)
-        end
+      it 'builds a new command line object' do
+        Cocaine::CommandLine.should_receive(:new).
+          with('/usr/libexec/PlistBuddy', '-c :cmd :plist').
+          and_return(command_line)
+        app.get_property('Foo')
+      end
+
+      it 'runs the command line with the property' do
+        command_line.should_receive(:run).
+          with(:cmd => 'Print Foo', :plist => 'Info.plist').
+          and_return('')
+        app.get_property('Foo')
       end
 
-      context 'with missing property' do
-        it 'raises an error' do
-          app.stub(:properties).and_return({ 'Chunky' => ' Bacon ' })
-          expect(app.get_property('Chunky')).to eq('Bacon')
-        end
+      it 'strips the output' do
+        command_line.stub(:run).and_return("Chunky\n")
+        expect(app.get_property('')).to eq('Chunky')
       end
     end
   end

data/wrapp.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'plist4r', '~> 1.2'
   spec.add_dependency 'mixlib-cli', '~> 1.3'
+  spec.add_dependency 'cocaine', '~> 0.5'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: wrapp
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Björn Albers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-17 00:00:00.000000000 Z
+date: 2014-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: plist4r
+  name: mixlib-cli
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: mixlib-cli
+  name: cocaine
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -174,7 +174,7 @@ rubyforge_project:
 rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
-summary: wrapp-0.3.0
+summary: wrapp-0.4.0
 test_files:
 - features/step_definitions/wrapp_steps.rb
 - features/support/app.rb