worthwhile 0.0.1.alpha → 0.0.1

data/spec/models/curation_concern/collection_model_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe CurationConcern::CollectionModel do
+  before do
+    class EssentialCollection < ActiveFedora::Base
+      include CurationConcern::CollectionModel
+      def members; @members ||= []; end
+      def save; true; end
+    end
+  end
+  after do
+    Object.send(:remove_const, :EssentialCollection)
+  end
+
+  context '.add_member' do
+    let(:collectible?) { nil }
+    let(:proposed_collectible) { double(collections: []) }
+    subject { EssentialCollection.new }
+    before(:each) {
+      proposed_collectible.stub(:can_be_member_of_collection?).with(subject).and_return(collectible?)
+      proposed_collectible.stub(:save).and_return(true)
+    }
+
+    context 'with itself' do
+      it 'does not add it to the collection\'s members' do
+        expect {
+          subject.add_member(subject)
+        }.to_not change{ subject.members.size }
+      end
+    end
+
+    context 'with a non-collectible object' do
+      let(:collectible?) { false }
+      it 'does not add it to the collection\'s members' do
+        expect {
+          subject.add_member(proposed_collectible)
+        }.to_not change{ subject.members.size }
+      end
+    end
+
+    context 'with a collectible object' do
+      let(:collectible?) { true }
+      it 'adds it to the collection\'s members' do
+        expect {
+          subject.add_member(proposed_collectible)
+        }.to change{ subject.members.size }.by(1)
+      end
+    end
+  end
+end

data/spec/models/curation_concern/work_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe CurationConcern::Work do
+  before do
+    class EssentialWork < ActiveFedora::Base
+      include CurationConcern::Work 
+    end
+  end
+  after do
+    Object.send(:remove_const, :EssentialWork)
+  end
+
+  subject { EssentialWork.new }
+
+  it "should mix together all the goodness" do
+    [::CurationConcern::WithGenericFiles, ::CurationConcern::HumanReadableType, Hydra::AccessControls::Embargoable, ::CurationConcern::WithEditors, Sufia::Noid, Sufia::ModelMethods, Hydra::Collections::Collectible, Solrizer::Common].each do |mixin|
+      expect(subject.class.ancestors).to include(mixin)
+    end
+  end
+
+  describe "human_readable_type" do
+    it "has a default" do
+      expect(subject.human_readable_type).to eq 'Essential Work'
+    end
+    it "should be settable" do
+      EssentialWork.human_readable_type = 'Custom Type'
+      expect(subject.human_readable_type).to eq 'Custom Type'
+    end
+  end
+end

data/spec/models/generic_work_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe GenericWork do
+  it "should have a title" do
+    subject.title = ['foo']
+    expect(subject.title).to eq ['foo']
+  end
+
+  context "with attached files" do
+    subject { FactoryGirl.build(:work_with_files) }
+
+    it "should have two files" do
+      expect(subject.generic_files.size).to eq 2
+      expect(subject.generic_files.first).to be_kind_of Worthwhile::GenericFile
+    end
+  end
+
+  describe "to_solr" do
+    subject { FactoryGirl.build(:work, date_uploaded: Date.today).to_solr }
+    it "indexes some fields" do
+      expect(subject.keys).to include 'desc_metadata__date_uploaded_dtsi'
+    end
+  end
+end

data/spec/models/worthwhile/content_version_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+module Worthwhile
+  describe ContentVersion do
+    let(:content) { double }
+    let(:created_on) { Time.now }
+    let(:version_id) { 'content.1'}
+    let(:committer_name) { 'darryl' }
+    let(:raw_version) { double(dsCreateDate: created_on, versionID: version_id) }
+    subject { described_class.new(content, raw_version) }
+
+    before(:each) do
+      content.stub(:version_committer).with(raw_version).and_return(committer_name)
+    end
+    its(:created_on) { should eq(created_on) }
+    its(:committer_name) { should eq(committer_name) }
+    its(:version_id) { should eq version_id }
+    its(:formatted_created_on) { should eq created_on.localtime.to_formatted_s(:long_ordinal)}
+  end
+  describe ContentVersion::Null do
+    subject { described_class.new(double)}
+    its(:created_on) { should eq 'unknown'}
+    its(:committer_name) { should eq 'unknown'}
+    its(:version_id) { should eq 'unknown'}
+    its(:formatted_created_on) { should eq 'unknown'}
+  end
+end

data/spec/models/worthwhile/generic_file_spec.rb

@@ -4,4 +4,81 @@ describe Worthwhile::GenericFile do
   it "should have depositor" do
     subject.depositor = 'tess@example.com'
   end
+
+  describe "to_solr" do
+    before do
+      subject.title = ['One Flew Over the Cuckoo\'s Nest']
+      subject.characterization.metadata.image.height = '500'
+      subject.characterization.metadata.image.width = '600'
+    end
+    let(:solr_doc) { subject.to_solr }
+
+    it "has a solr_doc" do
+      expect(solr_doc['desc_metadata__title_tesim']).to eq ['One Flew Over the Cuckoo\'s Nest']
+      expect(solr_doc['desc_metadata__title_sim']).to eq ['One Flew Over the Cuckoo\'s Nest']
+      expect(solr_doc['height_isi']).to eq 500
+      expect(solr_doc['width_isi']).to eq 600
+    end
+  end
+
+
+  describe 'with a parent work' do
+    let(:parent_pid) { 'pid:123' }
+    let!(:parent) {
+      if ActiveFedora::Base.exists?(parent_pid)
+        ActiveFedora::Base.find(parent_pid).destroy
+      end
+      GenericWork.new pid: parent_pid, title: ['asdf']
+    }
+
+    subject { Worthwhile::GenericFile.create(batch: parent) }
+
+    describe '#remove_representative_relationship' do
+      let(:some_other_pid) { 'something:456' }
+      before do
+        parent.representative = some_other_pid
+        parent.save!
+      end
+
+      context "the parent object doesn't exist" do
+        before do
+          parent.representative = subject.pid
+          parent.save!
+          @parent_pid = parent.pid
+          parent.destroy
+        end
+
+        it "doesn't raise an error" do
+          expect(ActiveFedora::Base.exists?(@parent_pid)).to eq false
+          expect {
+            subject.remove_representative_relationship
+          }.to_not raise_error
+        end
+      end
+
+      context 'it is not the representative' do
+        it "doesn't update parent work when file is deleted" do
+          expect(subject.batch).to eq parent
+          expect(parent.representative).to eq some_other_pid
+          subject.destroy
+          expect(parent.representative).to eq some_other_pid
+        end
+      end
+
+      context 'it is the representative' do
+        before do
+          parent.representative = subject.pid
+          parent.save!
+        end
+
+        it 'updates the parent work when the file is deleted' do
+          expect(subject.batch).to eq parent
+          expect(parent.representative).to eq subject.pid
+          subject.destroy
+          expect(parent.representative).to be_nil
+        end
+      end
+    end
+  end
+
 end

data/spec/models/worthwhile/linked_resource_spec.rb

@@ -0,0 +1,76 @@
+require 'spec_helper'
+
+describe Worthwhile::LinkedResource do
+  subject { Worthwhile::LinkedResource.new }
+
+  it { should respond_to(:human_readable_type) }
+
+  it 'has a #human_readable_short_description' do
+    subject.human_readable_short_description.length.should_not == 0
+  end
+
+  it 'has a .human_readable_short_description' do
+    subject.class.human_readable_short_description.length.should_not == 0
+  end
+
+  it 'uses #noid for #to_param' do
+    subject.stub(:persisted?).and_return(true)
+    subject.to_param.should == subject.noid
+  end
+
+  it 'has no url to display' do
+    subject.to_s.should == nil
+  end
+
+  describe "validating" do
+    subject {Worthwhile::LinkedResource.new}
+    it "should not validate and have an error" do
+      subject.should_not be_valid
+      subject.errors[:url].should == ["can't be blank"]
+    end
+  end
+
+  describe "sanitizing" do
+    context "javascript uri" do
+      subject { FactoryGirl.build(:linked_resource, url: "javascript:void(alert('Hello'));") }
+      it "should be cleared" do
+        subject.url.should be_nil
+      end
+    end
+    context "http uri" do
+      subject { FactoryGirl.build(:linked_resource, url: "http://www.youtube.com/watch?v=oHg5SJYRHA0") }
+      it "should be stored" do
+        expect(subject.to_s).to eq 'http://www.youtube.com/watch?v=oHg5SJYRHA0'
+      end
+    end
+    context "https uri" do
+      subject { FactoryGirl.build(:linked_resource, url: "https://www.youtube.com/watch?v=oHg5SJYRHA0") }
+      it "should be stored" do
+        expect(subject.to_s).to eq 'https://www.youtube.com/watch?v=oHg5SJYRHA0'
+      end
+    end
+    context "ftp uri" do
+      subject { FactoryGirl.build(:linked_resource, url: "ftp://ftp.ed.ac.uk") }
+      it "should be stored" do
+        expect(subject.to_s).to eq 'ftp://ftp.ed.ac.uk/'
+      end
+    end
+  end
+
+  context '#to_solr' do
+    subject { Worthwhile::LinkedResource.new(url: 'http://www.youtube.com/watch?v=oHg5SJYRHA0') }
+    it 'should solrize its url' do
+      expect(subject.to_solr.fetch('url_tesim')).to eq(['http://www.youtube.com/watch?v=oHg5SJYRHA0'])
+    end
+  end
+
+  describe "with a persisted resource" do
+    let!(:resource) { FactoryGirl.create(:linked_resource, url: 'http://www.youtube.com/watch?v=oHg5SJYRHA0') }
+
+    it 'has url as its title to display' do
+      expect(resource.to_s).to eq 'http://www.youtube.com/watch?v=oHg5SJYRHA0'
+    end
+
+  end
+
+end

data/spec/routing/worthwhile/routes_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+module Worthwhile
+  describe "routing" do
+    
+
+    describe "Classify concerns" do
+      routes { Worthwhile::Engine.routes }
+      it "routes to #new" do
+        expect(new_classify_concern_path).to eq '/classify_concerns/new'
+        get("/classify_concerns/new").should route_to("worthwhile/classify_concerns#new")
+      end
+    end
+
+    describe "generic work" do
+      routes { Rails.application.routes }
+      it 'routes to #new' do
+        expect(new_curation_concern_generic_work_path).to eq '/concern/generic_works/new'
+        get("/concern/generic_works/new").should route_to("curation_concern/generic_works#new")
+      end
+    end
+  end
+end

data/spec/services/embargo_service_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Worthwhile::EmbargoService do
+  let(:future_date) { 2.days.from_now }
+  let(:past_date) { 2.days.ago }
+
+  let!(:work_with_expired_embargo1) do
+    FactoryGirl.build(:generic_work, embargo_release_date: past_date.to_s).tap do |work|
+      work.save(validate:false)
+    end
+  end
+
+  let!(:work_with_expired_embargo2) do
+    FactoryGirl.build(:generic_work, embargo_release_date: past_date.to_s).tap do |work|
+      work.save(validate:false)
+    end
+  end
+
+  let!(:work_with_embargo_in_effect) { FactoryGirl.create(:generic_work, embargo_release_date: future_date.to_s)}
+  let!(:work_without_embargo) { FactoryGirl.create(:generic_work)}
+
+  describe "#assets_with_expired_embargoes" do
+    it "returns an array of assets with expired embargoes" do
+      returned_pids = subject.assets_with_expired_embargoes.map {|a| a.pid}
+      expect(returned_pids).to include work_with_expired_embargo1.pid,work_with_expired_embargo2.pid
+      expect(returned_pids).to_not include work_with_embargo_in_effect.pid,work_without_embargo.pid
+    end
+  end
+
+  describe "#assets_under_embargo" do
+    it "returns all assets with embargo release date set" do
+      result = subject.assets_under_embargo
+      returned_pids = subject.assets_under_embargo.map {|a| a.pid}
+      expect(returned_pids).to include work_with_expired_embargo1.pid,work_with_expired_embargo2.pid,work_with_embargo_in_effect.pid
+      expect(returned_pids).to_not include work_without_embargo.pid
+    end
+  end
+end

data/spec/services/lease_service_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe Worthwhile::LeaseService do
+  let(:future_date) { 2.days.from_now }
+  let(:past_date) { 2.days.ago }
+
+  let!(:work_with_expired_lease1) do
+    FactoryGirl.build(:generic_work, lease_expiration_date: past_date.to_s).tap do |work|
+      work.save(validate: false)
+    end
+  end
+
+  let!(:work_with_expired_lease2) do
+    FactoryGirl.build(:generic_work, lease_expiration_date: past_date.to_s).tap do |work|
+      work.save(validate: false)
+    end
+  end
+
+  let!(:work_with_lease_in_effect) { FactoryGirl.create(:generic_work, lease_expiration_date: future_date.to_s)}
+  let!(:work_without_lease) { FactoryGirl.create(:generic_work)}
+
+  describe "#assets_with_expired_leases" do
+    it "returns an array of assets with expired embargoes" do
+      returned_pids = subject.assets_with_expired_leases.map {|a| a.pid}
+      expect(returned_pids).to include work_with_expired_lease1.pid,work_with_expired_lease2.pid
+      expect(returned_pids).to_not include work_with_lease_in_effect.pid,work_without_lease.pid
+    end
+  end
+
+  describe "#assets_under_lease" do
+    it "returns an array of assets with expired embargoes" do
+      returned_pids = subject.assets_under_lease.map {|a| a.pid}
+      expect(returned_pids).to include work_with_expired_lease1.pid,work_with_expired_lease2.pid,work_with_lease_in_effect.pid
+      expect(returned_pids).to_not include work_without_lease.pid
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -6,16 +6,37 @@ require 'devise'
 require 'engine_cart'
 EngineCart.load_application!
 
+require 'rspec/its'
 require 'rspec/rails'
-require 'rspec/autorun'
-# require 'capybara/poltergeist'
-# Capybara.javascript_driver = :poltergeist
-# Capybara.default_wait_time = 5
+require 'capybara/poltergeist'
+Capybara.javascript_driver = :poltergeist
+Capybara.default_wait_time = ENV['TRAVIS'] ? 30 : 15
+require 'capybara/rspec'
+require 'capybara/rails'
 
-require 'worthwhile'
 
+if ENV['COVERAGE']
+  require 'simplecov'
+
+  ENGINE_ROOT = File.expand_path('../..', __FILE__)
+
+  # Out of the box, SimpleCov was looking at file in ENGINE_ROOT/spec/internal;
+  # After all that was where Rails was pointed at.
+  SimpleCov.root(ENGINE_ROOT)
+  SimpleCov.start 'rails' do
+    filters.clear
+    add_filter do |src|
+      src.filename !~ /^#{ENGINE_ROOT}/
+    end
+    add_filter '/spec/'
+  end
+  SimpleCov.command_name "spec"
+end
+
+require 'worthwhile'
 
 Dir["./spec/support/**/*.rb"].sort.each {|f| require f}
+require File.expand_path('../matchers', __FILE__)
 
 FactoryGirl.definition_file_paths = [File.expand_path("../factories", __FILE__)]
 FactoryGirl.find_definitions
@@ -23,6 +44,7 @@ FactoryGirl.find_definitions
 
 RSpec.configure do |config|
   config.use_transactional_fixtures = false
+  config.fixture_path = File.expand_path("../fixtures", __FILE__)
 
   config.before :each do
     if Capybara.current_driver == :rack_test
@@ -41,5 +63,8 @@ RSpec.configure do |config|
   config.include Devise::TestHelpers, type: :view
   config.include Warden::Test::Helpers, type: :feature
   config.after(:each, type: :feature) { Warden.test_reset! }
+  config.include Controllers::EngineHelpers, type: :controller
   config.include Capybara::DSL
+  config.infer_spec_type_from_file_location!
+  config.deprecation_stream
 end