works_cited 0.1.3 → 0.1.4

data/spec/factories/users.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :user do
     email { Faker::Internet.email }

data/spec/models/works_cited/contributor_spec.rb

@@ -2,7 +2,6 @@
 
 require 'rails_helper'
 
-# rubocop:disable Metrics/ModuleLength
 module WorksCited
   RSpec.describe Contributor, type: :model do
     let(:doodad) { FactoryBot.create(:doodad) }
@@ -100,4 +99,3 @@ module WorksCited
     end
   end
 end
-# rubocop:enable Metrics/ModuleLength

data/spec/requests/works_cited/citations_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 # This spec was generated by rspec-rails when you ran the scaffold generator.
@@ -12,6 +14,7 @@ require 'rails_helper'
 # of tools you can use to make these specs even more expressive, but we're
 # sticking to rails and rspec-rails APIs to keep things simple and stable.
 
+# rubocop:disable Metrics/ModuleLength
 module WorksCited
   RSpec.describe '/citations', type: :request do
     include Engine.routes.url_helpers
@@ -21,165 +24,197 @@ module WorksCited
 
     # Citation. As you add validations to Citation, be sure to
     # adjust the attributes here as well.
-    let(:valid_attributes) {
+    let(:valid_attributes) do
       { citation_type: 'book', title: Faker::Book.title, record: "#{doodad.class.model_name}:#{doodad.id}" }
-    }
+    end
 
-    let(:invalid_attributes) {
+    let(:invalid_attributes) do
       { citation_type: 'book', title: nil, record: nil }
-    }
+    end
 
-    describe 'GET /show' do
-      it 'disallows when appropriate' do
-        expect { get citation_url(citation) }.to raise_error(CanCan::AccessDenied)
-      end
-      it 'renders a successful response when admin' do
-        sign_in admin
-        get citation_url(citation)
-        expect(response).to be_successful
+    describe 'when anonymous' do
+      describe 'GET /show' do
+        it 'disallows' do
+          expect { get citation_url(citation) }.to raise_error(CanCan::AccessDenied)
+        end
       end
-    end
 
-    describe 'GET /index' do
-      before do
-        Citation.create! valid_attributes
+      describe 'GET /index' do
+        before do
+          Citation.create! valid_attributes
+        end
+        it 'disallows' do
+          expect { get citations_url }.to raise_error(CanCan::AccessDenied)
+        end
       end
-      it 'disallows when appropriate' do
-        expect { get citations_url }.to raise_error(CanCan::AccessDenied)
+
+      describe 'GET /new' do
+        it 'disallows' do
+          expect { get new_citation_url }.to raise_error(CanCan::AccessDenied)
+        end
       end
-      it 'renders a successful response when admin' do
-        sign_in admin
-        get citations_url
-        expect(response).to be_successful
+
+      describe 'GET /edit' do
+        it 'disallows' do
+          expect { get edit_citation_url(citation) }.to raise_error(CanCan::AccessDenied)
+        end
       end
-    end
 
-    describe 'GET /new' do
-      it 'disallows when appropriate' do
-        expect { get new_citation_url }.to raise_error(CanCan::AccessDenied)
+      describe 'PATCH /preview' do
+        it 'disallows' do
+          expect do
+            patch preview_citation_url, params: { citation: valid_attributes }
+          end.to raise_error(CanCan::AccessDenied)
+        end
       end
-      it 'renders a successful response when admin' do
-        sign_in admin
-        get new_citation_url
-        expect(response).to be_successful
+
+      describe 'POST /create' do
+        it 'disallows' do
+          expect { post citations_url, params: { citation: valid_attributes } }.to raise_error(CanCan::AccessDenied)
+        end
       end
-    end
 
-    describe 'GET /edit' do
-      it 'disallows when appropriate' do
-        expect { get edit_citation_url(citation) }.to raise_error(CanCan::AccessDenied)
+      describe 'PATCH /update' do
+        let(:new_attributes) do
+          { citation_type: 'book', title: 'New Title', record_id: doodad.id, record_type: 'Doodad' }
+        end
+        it 'disallows' do
+          expect do
+            patch citation_url(citation), params: { citation: new_attributes }
+          end.to raise_error(CanCan::AccessDenied)
+        end
       end
-      it 'render a successful response when admin' do
-        sign_in admin
-        get edit_citation_url(citation)
-        expect(response).to be_successful
+
+      describe 'DELETE /destroy' do
+        it 'disallows' do
+          expect { delete citation_url(citation) }.to raise_error(CanCan::AccessDenied)
+        end
       end
     end
 
-    describe 'PATCH /preview' do
-      it 'disallows when appropriate' do
-        expect { patch preview_citation_url, params: { citation: valid_attributes } }.to raise_error(CanCan::AccessDenied)
+    describe 'when admin' do
+      before do
+        sign_in admin
       end
-      describe 'when admin' do
-        before { sign_in admin }
-        context 'with valid parameters' do
-          it 'previews the Citation' do
-            sign_in admin
-            patch preview_citation_url, params: { citation: valid_attributes }
-            expect(response).to be_successful
-          end
+      describe 'GET /show' do
+        it 'renders a successful response when admin' do
+          get citation_url(citation)
+          expect(response).to be_successful
         end
       end
-    end
 
-    describe 'POST /create' do
-      it 'disallows when appropriate' do
-        expect { post citations_url, params: { citation: valid_attributes } }.to raise_error(CanCan::AccessDenied)
+      describe 'GET /index' do
+        before do
+          Citation.create! valid_attributes
+        end
+        it 'renders a successful response when admin' do
+          get citations_url
+          expect(response).to be_successful
+        end
       end
-      describe 'when admin' do
-        before { sign_in admin }
-        context 'with valid parameters' do
-          it 'creates a new Citation' do
-            expect {
-              post citations_url, params: { citation: valid_attributes }
-            }.to change(Citation, :count).by(1)
-          end
 
-          it 'redirects to the created citation' do
-            post citations_url, params: { citation: valid_attributes }
-            expect(response).to redirect_to(citation_url(Citation.last))
-          end
+      describe 'GET /new' do
+        it 'renders a successful response when admin' do
+          get new_citation_url
+          expect(response).to be_successful
         end
+      end
 
-        context 'with invalid parameters' do
-          it 'does not create a new Citation' do
-            expect {
-              post citations_url, params: { citation: invalid_attributes }
-            }.to change(Citation, :count).by(0)
-          end
+      describe 'GET /edit' do
+        it 'render a successful response when admin' do
+          get edit_citation_url(citation)
+          expect(response).to be_successful
+        end
+      end
 
-          it "renders a successful response (i.e. to display the 'new' template)" do
-            post citations_url, params: { citation: invalid_attributes }
-            expect(response).to be_successful
+      describe 'PATCH /preview' do
+        describe 'when admin' do
+          context 'with valid parameters' do
+            it 'previews the Citation' do
+              patch preview_citation_url, params: { citation: valid_attributes }
+              expect(response).to be_successful
+            end
           end
         end
       end
-    end
 
-    describe 'PATCH /update' do
-      let(:new_attributes) {
-        { citation_type: 'book', title: 'New Title', record_id: doodad.id, record_type: 'Doodad' }
-      }
-      it 'disallows when appropriate' do
-        expect { patch citation_url(citation), params: { citation: new_attributes } }.to raise_error(CanCan::AccessDenied)
-      end
-      describe 'when admin' do
-        before { sign_in admin }
-        context 'with valid parameters' do
+      describe 'POST /create' do
+        describe 'when admin' do
+          context 'with valid parameters' do
+            it 'creates a new Citation' do
+              expect do
+                post citations_url, params: { citation: valid_attributes }
+              end.to change(Citation, :count).by(1)
+            end
 
-          it 'updates the requested citation' do
-            patch citation_url(citation), params: { citation: new_attributes }
-            citation.reload
-            expect(citation.title).to eq('New Title')
+            it 'redirects to the created citation' do
+              post citations_url, params: { citation: valid_attributes }
+              expect(response).to redirect_to(citation_url(Citation.last))
+            end
           end
 
-          it 'redirects to the citation' do
-            patch citation_url(citation), params: { citation: new_attributes }
-            citation.reload
-            expect(response).to redirect_to(citation_url(citation))
-          end
-        end
+          context 'with invalid parameters' do
+            it 'does not create a new Citation' do
+              expect do
+                post citations_url, params: { citation: invalid_attributes }
+              end.to change(Citation, :count).by(0)
+            end
 
-        context 'with invalid parameters' do
-          it "renders a successful response (i.e. to display the 'edit' template)" do
-            patch citation_url(citation), params: { citation: invalid_attributes }
-            expect(response).to be_successful
+            it "renders a successful response (i.e. to display the 'new' template)" do
+              post citations_url, params: { citation: invalid_attributes }
+              expect(response).to be_successful
+            end
           end
         end
       end
-    end
 
-    describe 'DELETE /destroy' do
-      it 'disallows when appropriate' do
-        expect { delete citation_url(citation) }.to raise_error(CanCan::AccessDenied)
-      end
-      describe 'when admin' do
-        before do
-          sign_in admin
-          citation # Call it up so it exists ahead of time
+      describe 'PATCH /update' do
+        let(:new_attributes) do
+          { citation_type: 'book', title: 'New Title', record_id: doodad.id, record_type: 'Doodad' }
         end
+        describe 'when admin' do
+          context 'with valid parameters' do
+            it 'updates the requested citation' do
+              patch citation_url(citation), params: { citation: new_attributes }
+              citation.reload
+              expect(citation.title).to eq('New Title')
+            end
+
+            it 'redirects to the citation' do
+              patch citation_url(citation), params: { citation: new_attributes }
+              citation.reload
+              expect(response).to redirect_to(citation_url(citation))
+            end
+          end
 
-        it 'destroys the requested citation' do
-          expect {
-            delete citation_url(citation)
-          }.to change(Citation, :count).by(-1)
+          context 'with invalid parameters' do
+            it "renders a successful response (i.e. to display the 'edit' template)" do
+              patch citation_url(citation), params: { citation: invalid_attributes }
+              expect(response).to be_successful
+            end
+          end
         end
+      end
+
+      describe 'DELETE /destroy' do
+        describe 'when admin' do
+          before do
+            citation # Call it up so it exists ahead of time
+          end
 
-        it 'redirects to the citations list' do
-          delete citation_url(citation)
-          expect(response).to redirect_to(citations_url)
+          it 'destroys the requested citation' do
+            expect do
+              delete citation_url(citation)
+            end.to change(Citation, :count).by(-1)
+          end
+
+          it 'redirects to the citations list' do
+            delete citation_url(citation)
+            expect(response).to redirect_to(citations_url)
+          end
         end
       end
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

data/spec/routing/works_cited/citations_routing_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe WorksCited::CitationsController, type: :routing do

data/works_cited.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: works_cited 0.1.3 ruby lib
+# stub: works_cited 0.1.4 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "works_cited".freeze
-  s.version = "0.1.3"
+  s.version = "0.1.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.metadata = { "source_code_uri" => "http://github.com/gemvein/works_cited" } if s.respond_to? :metadata=
@@ -24,7 +24,6 @@ Gem::Specification.new do |s|
     ".rubocop.yml",
     ".ruby-gemset",
     ".ruby-version",
-    ".travis.yml",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE.txt",
@@ -194,8 +193,8 @@ Gem::Specification.new do |s|
     s.add_runtime_dependency(%q<haml-rails>.freeze, [">= 2.0", "< 3"])
     s.add_runtime_dependency(%q<sass-rails>.freeze, [">= 6", "< 7"])
     s.add_runtime_dependency(%q<cancancan>.freeze, [">= 3.3", "< 4"])
-    s.add_runtime_dependency(%q<vanilla_nested>.freeze, [">= 1.3", "< 2"])
     s.add_runtime_dependency(%q<simple_form>.freeze, [">= 5.1", "< 6"])
+    s.add_runtime_dependency(%q<vanilla_nested>.freeze, [">= 1.3", "< 2"])
     s.add_runtime_dependency(%q<kaminari>.freeze, [">= 1.2.1", "< 2"])
     s.add_development_dependency(%q<database_cleaner>.freeze, [">= 1.8", "< 2"])
     s.add_development_dependency(%q<devise>.freeze, [">= 4.8", "< 5"])
@@ -212,8 +211,8 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<haml-rails>.freeze, [">= 2.0", "< 3"])
     s.add_dependency(%q<sass-rails>.freeze, [">= 6", "< 7"])
     s.add_dependency(%q<cancancan>.freeze, [">= 3.3", "< 4"])
-    s.add_dependency(%q<vanilla_nested>.freeze, [">= 1.3", "< 2"])
     s.add_dependency(%q<simple_form>.freeze, [">= 5.1", "< 6"])
+    s.add_dependency(%q<vanilla_nested>.freeze, [">= 1.3", "< 2"])
     s.add_dependency(%q<kaminari>.freeze, [">= 1.2.1", "< 2"])
     s.add_dependency(%q<database_cleaner>.freeze, [">= 1.8", "< 2"])
     s.add_dependency(%q<devise>.freeze, [">= 4.8", "< 5"])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: works_cited
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Loren Lundgren
@@ -91,45 +91,45 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4'
 - !ruby/object:Gem::Dependency
-  name: vanilla_nested
+  name: simple_form
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '6'
 - !ruby/object:Gem::Dependency
-  name: simple_form
+  name: vanilla_nested
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '1.3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '1.3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: kaminari
   requirement: !ruby/object:Gem::Requirement
@@ -334,7 +334,6 @@ files:
 - ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt