workitcop 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27336368b30a080fc58a6053182931a6abb0addbf3481fc19266a008ab574c3a
-  data.tar.gz: 23cbb18bc27d25f68003200c0eb505efec7200f45b4634fe32d9e69a2b72cdf5
+  metadata.gz: d9a1c429544b92ec47ac6a467cef8d26a1bea4c43371299d323441636b0ecbfc
+  data.tar.gz: 255c41e5e4995120ebea4370b3ef9e3a95773614d580b719c17041eec1883df9
 SHA512:
-  metadata.gz: 9ed01c88aeabb5f4759e710555ba6566d248f800e7fc239ea0634f7a2d735acf6e5551c244fa81e810fc617438bb5094f33d344014300917e5c7afb1dec12d39
-  data.tar.gz: f5ff520cccd27c6d58c687b2a9bf7ab34d38c931c37dd03e6f4037831ecd56309964402301572ddd3faaab6e986fac9f3ec5e2c98488153fb9399a20beeef920
+  metadata.gz: 6513c422e88c53f8287f61fbfeedf160232340bebeea000ebfd2389b6d92b6ffa4b4a657d1a6fff5072281b09ebbc413ace375de128eb686605956dd56b4a869
+  data.tar.gz: 5ea74291617530ff065df00d6ecbd3c9a5f339feb446417fae198667249e746f137424028158df6fe4ad91d364dcf6af10fc71725df7e33513e82688afdd5e50

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Unreleased
 
+## 0.3.0 - 2022-12-08
+
+- Fix an error for `Workit/RestrictOnSend` when not in class. ([@ydah])
+- Add new `Workit/ComitteeAssertSchemaConfirm` cop. ([@ydah])
+- Remove VersionAdded for default.yml. ([@ydah])
+- Change default to `Enabled: false`. ([@ydah])
+
 ## 0.2.0 - 2022-11-07
 
 - Add new `Workit/ActionArgs` cop. ([@ydah])

data/config/default.yml

@@ -6,8 +6,7 @@ inherit_mode:
 Workit/ActionArgs:
   Description: |
     Check for controller action must be using `action_args`.
-  Enabled: pending
-  VersionAdded: '0.2'
+  Enabled: false
   Include:
     - 'controllers/**/*'
   ControllerMethods:
@@ -18,13 +17,16 @@ Workit/ActionArgs:
     - cancel
     - destroy
 
+Workit/ComitteeAssertSchemaConfirm:
+  Description: |
+    Check for not pass expected response status code to check it against the corresponding schema explicitly.
+  Enabled: false
+
 Workit/NoopRescue:
   Description: 'Check for suppress or ignore checked exception.'
   Enabled: false
-  VersionAdded: '0.2'
 
 Workit/RestrictOnSend:
   Description: |
     Check for `RESTRICT_ON_SEND` is defined if `on_send` or `after_send` are defined.
-  Enabled: pending
-  VersionAdded: '0.1'
+  Enabled: false

data/lib/rubocop/cop/workit/comittee_assert_schema_confirm.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Workit
+      # Check for not pass expected response status code to check it against the corresponding schema explicitly.
+      #
+      # @example
+      #   # bad
+      #   it 'something' do
+      #     subject
+      #     expect(response).to have_http_status 400
+      #     do_something
+      #     assert_schema_conform
+      #   end
+      #
+      #   # good
+      #   it 'something' do
+      #     subject
+      #     do_something
+      #     assert_schema_conform(400)
+      #   end
+      #
+      class ComitteeAssertSchemaConfirm < Base
+        include RangeHelp
+        extend AutoCorrector
+
+        MSG = "Pass expected response status code to check it against the corresponding schema explicitly."
+        RESTRICT_ON_SEND = %i[assert_schema_conform assert_response_schema_confirm].freeze
+
+        # @!method have_http_status(node)
+        def_node_search :have_http_status, <<~PATTERN
+          $(send nil? :have_http_status (:int $_))
+        PATTERN
+
+        def on_send(node)
+          return if node.arguments?
+
+          have_http_status(node.parent) do |child_node, value|
+            add_offense(node) do |corrector|
+              corrector.remove(range_by_whole_lines(child_node.parent.loc.expression, include_final_newline: true))
+              corrector.insert_after(node, "(#{value})")
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/workit/restrict_on_send.rb

@@ -30,12 +30,14 @@ module RuboCop
 
         def on_def(node)
           return unless NEED_RESTRICT_ON_SEND.include?(node.method_name)
+          return unless (class_node = class_node(node))
 
-          class_node = class_node(node)
           add_offense(class_node) unless defined_restrict_on_send?(class_node)
         end
 
         def class_node(node)
+          return if node.parent.nil?
+
           if node.parent.class_type?
             node.parent
           else

data/lib/workitcop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Workitcop
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/workitcop.rb

@@ -4,6 +4,7 @@ require_relative "workitcop/inject"
 require_relative "workitcop/version"
 
 require_relative "rubocop/cop/workit/action_args"
+require_relative "rubocop/cop/workit/comittee_assert_schema_confirm"
 require_relative "rubocop/cop/workit/noop_rescue"
 require_relative "rubocop/cop/workit/restrict_on_send"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workitcop
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - ydah
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-11-07 00:00:00.000000000 Z
+date: 2022-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -39,6 +39,7 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop/cop/workit/action_args.rb
+- lib/rubocop/cop/workit/comittee_assert_schema_confirm.rb
 - lib/rubocop/cop/workit/noop_rescue.rb
 - lib/rubocop/cop/workit/restrict_on_send.rb
 - lib/workitcop.rb
@@ -67,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: Custom cops for `RuboCop`.