workhorse 1.2.8 → 1.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e82524a9a4ac0e41a41fe2a1947e3a9e1b58efc96f750f1dfa0ef5ebeeaad39
-  data.tar.gz: a31b41e50239da3e0b1bb416d2e5d1c649083ad7fc30b7b2747e4ec9bd877931
+  metadata.gz: 2d15daf82cef773b8b5d20c371a0a25e57aa52dac2a8adfdede69391229618ec
+  data.tar.gz: 4aa045bb14e3ba2dd74a856681ef3e4b96499e0cbd4cde11020547b27bd6b7bd
 SHA512:
-  metadata.gz: bcf8c18e959ecfe4ea1db71b3e1cc59a88325b5d70be33220cfe4931f92fb982548514a0f47576f792a33659011a7956f6c0075544681f0f312816428c1f5f20
-  data.tar.gz: 557a630d4681f635bfde37da63838a900f6938b6a38f7b188e94a1c4c293972020e91a183dc173fbe02be4d08ddee9a868074c70d219af65a4a7408050211247
+  metadata.gz: 58ae320fa056a04a572a3ac6a8ad9c99af17c93d30fe6a3194d9b68d2ceddee23fbf669c36ab7abbf7427ae4fd3fd5abb8be7da15dd24c3488e2dc357112ac5a
+  data.tar.gz: 02614eaa06c074136467f171038a581bdea771f252b16c717f162442dd3ba270cb12457827fd804940afe525d064b55f3ee59dbadb96c34e70bcfd147f44ca47

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Workhorse Changelog
 
+## 1.2.10 - 2023-01-05
+
+* Attempt to make shutdown of workers more robust by sending both `TERM` and
+  `INT` signals.
+
+  Sitrox reference: #108374.1-1.
+
+## 1.2.9 - 2022-12-08
+
+* Properly detach forked worker processes from parent process to prevent zombie
+  processes
+
+* Reopen STDIN, STDOUT and STDERR pipes to `/dev/null` after forking
+  (daemonizing) worker processes. This detaches from the current TTY which
+  prevents the issue that SSH connections sometimes could not be closed when
+  having daemonized new worker processes.
+
+  Sitrox reference: #107576.
+
 ## 1.2.8 - 2022-11-23
 
 * Add configuration option `lock_shell_commands`. This defaults to `true` to

data/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2017 - 2022 Sitrox
+Copyright (c) 2017 - 2023 Sitrox
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -441,4 +441,4 @@ Please consult the [FAQ](FAQ.md).
 
 ## Copyright
 
-Copyright © 2017 - 2022 Sitrox. See `LICENSE` for further details.
+Copyright © 2017 - 2023 Sitrox. See `LICENSE` for further details.

data/VERSION

@@ -1 +1 @@
-1.2.8
+1.2.10

data/lib/workhorse/daemon.rb

@@ -147,17 +147,26 @@ module Workhorse
     def start_worker(worker)
       pid = fork do
         $0 = process_name(worker)
+
+        # Reopen pipes to prevent #107576
+        STDIN.reopen File.open('/dev/null', 'r')
+        null_out = File.open '/dev/null', 'w'
+        STDOUT.reopen null_out
+        STDERR.reopen null_out
+
         worker.block.call
       end
       IO.write(pid_file_for(worker), pid)
+      Process.detach(pid)
     end
 
     def stop_worker(pid_file, pid, kill = false)
-      signal = kill ? 'KILL' : 'TERM'
+      signals = kill ? %w[KILL] : %w[TERM INT]
 
       loop do
         begin
-          Process.kill(signal, pid)
+          puts "Sending signals #{signals.inspect}".red
+          signals.each { |signal| Process.kill(signal, pid) }
         rescue Errno::ESRCH
           break
         end

data/workhorse.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: workhorse 1.2.8 ruby lib
+# stub: workhorse 1.2.10 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "workhorse".freeze
-  s.version = "1.2.8"
+  s.version = "1.2.10"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2022-11-23"
+  s.date = "2023-01-05"
   s.files = [".github/workflows/ruby.yml".freeze, ".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, "CHANGELOG.md".freeze, "FAQ.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "RUBY_VERSION".freeze, "Rakefile".freeze, "VERSION".freeze, "bin/rubocop".freeze, "lib/active_job/queue_adapters/workhorse_adapter.rb".freeze, "lib/generators/workhorse/install_generator.rb".freeze, "lib/generators/workhorse/templates/bin/workhorse.rb".freeze, "lib/generators/workhorse/templates/config/initializers/workhorse.rb".freeze, "lib/generators/workhorse/templates/create_table_jobs.rb".freeze, "lib/workhorse.rb".freeze, "lib/workhorse/daemon.rb".freeze, "lib/workhorse/daemon/shell_handler.rb".freeze, "lib/workhorse/db_job.rb".freeze, "lib/workhorse/enqueuer.rb".freeze, "lib/workhorse/jobs/cleanup_succeeded_jobs.rb".freeze, "lib/workhorse/jobs/detect_stale_jobs_job.rb".freeze, "lib/workhorse/jobs/run_active_job.rb".freeze, "lib/workhorse/jobs/run_rails_op.rb".freeze, "lib/workhorse/performer.rb".freeze, "lib/workhorse/poller.rb".freeze, "lib/workhorse/pool.rb".freeze, "lib/workhorse/scoped_env.rb".freeze, "lib/workhorse/worker.rb".freeze, "test/active_job/queue_adapters/workhorse_adapter_test.rb".freeze, "test/lib/db_schema.rb".freeze, "test/lib/jobs.rb".freeze, "test/lib/test_helper.rb".freeze, "test/workhorse/db_job_test.rb".freeze, "test/workhorse/enqueuer_test.rb".freeze, "test/workhorse/performer_test.rb".freeze, "test/workhorse/poller_test.rb".freeze, "test/workhorse/pool_test.rb".freeze, "test/workhorse/worker_test.rb".freeze, "workhorse.gemspec".freeze]
   s.rubygems_version = "3.0.3".freeze
   s.summary = "Multi-threaded job backend with database queuing for ruby.".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workhorse
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.10
 platform: ruby
 authors:
 - Sitrox
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-23 00:00:00.000000000 Z
+date: 2023-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler