workhorse 1.2.22 → 1.2.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20eef573615adbfed9958ae1d5f2e005cfca827060f2b632dbd17b624c2273ec
-  data.tar.gz: 3be17bded0b07b544b5d1d2978470d7684dc1d2e4ca6588b03745a02af11bfd2
+  metadata.gz: 97943ac72325488d753fce90321c093208e3503b3071a79dba1495bcb347a22c
+  data.tar.gz: b3d37af6f6f2910cf1fe96cf82bc445852fec78da2f5088dfdd665090b3f451e
 SHA512:
-  metadata.gz: 1a2c29dc077d8557b4d2ff2bdad9f980d0e24f6794f5a42d26ae731f0c8a7ba24e78d980b39ba087d985529ce701860ef9a876eba70b38c10d007f6516ed6a9b
-  data.tar.gz: 88c45f4571b11a51021accaf4145d65fe48fbad6add8170ce830ad31c7e2ddc6b7422e41f1ca1b3f6e0a2bf06351d80f77323889945f25aac16c5068ed51dff7
+  metadata.gz: 5964079c67b84282e5b30cde7bc3af45554da948149bd41a8f0b8fbdffb0f60caa2ca6f7cd95652bd2a3df0dce10046b47bdf1104f2d85d69fcea16cc68d91a3
+  data.tar.gz: 72691ebfd441c0314fb4f3e75fafedbd70b0f036a129cb0e14a54e2919d337e637a1b1adc3e8c8af6d05eb8deb0853e43ca8b7239addf6ae3df63a6b01e575a2

data/CHANGELOG.md

@@ -1,12 +1,27 @@
 # Workhorse Changelog
 
+## 1.2.24 - 2024-10-21
+
+* Fix compatibility with ActiveJob 7.2.x
+
+## 1.2.23 - 2024-08-26
+
+* Fix bug introduced in 1.2.22 where the lock file would not be released. This
+  is done by reverting the changes for `at_exit` handlers. Make sure the Gem
+  'debug' is not loaded (e.g. via `gem 'debug', environment: :development`) for
+  workhorse processes.
+
+  Sitrox reference: #128709.
+
 ## 1.2.22 - 2024-08-20
 
 * Change `retry-on` in actions to `any`: also retry when the action hits a timeout
 
 * Comply with RuboCop
 
-* Skip `at_exit` handlers when exiting in ShellHandler
+* Skip `at_exit` handlers when exiting in ShellHandler. This ensures
+  compatibility with the `debug` gem, which whould otherwise hang when using the
+  Workhorse shell handler.
 
   Sitrox reference: #128333.
 

data/VERSION

@@ -1 +1 @@
-1.2.22
+1.2.24

data/lib/active_job/queue_adapters/workhorse_adapter.rb

@@ -10,6 +10,14 @@ module ActiveJob
     #
     #   Rails.application.config.active_job.queue_adapter = :workhorse
     class WorkhorseAdapter
+      # Defines whether enqueuing should happen implicitly to after commit when called
+      # from inside a transaction. Most adapters should return true, but some adapters
+      # that use the same database as Active Record and are transaction aware can return
+      # false to continue enqueuing jobs as part of the transaction.
+      def enqueue_after_transaction_commit?
+        false
+      end
+
       def enqueue(job) # :nodoc:
         Workhorse.enqueue_active_job(job)
       end

data/lib/workhorse/daemon/shell_handler.rb

@@ -19,22 +19,22 @@ module Workhorse
       begin
         case ARGV.first
         when 'start'
-          exit! daemon.start
+          exit daemon.start
         when 'stop'
-          exit! daemon.stop
+          exit daemon.stop
         when 'kill'
-          exit! daemon.stop(true)
+          exit daemon.stop(true)
         when 'status'
-          exit! daemon.status
+          exit daemon.status
         when 'watch'
-          exit! daemon.watch
+          exit daemon.watch
         when 'restart'
-          exit! daemon.restart
+          exit daemon.restart
         when 'restart-logging'
-          exit! daemon.restart_logging
+          exit daemon.restart_logging
         when 'usage'
           usage
-          exit! 99
+          exit 99
         else
           usage
         end

data/workhorse.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: workhorse 1.2.22 ruby lib
+# stub: workhorse 1.2.24 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "workhorse".freeze
-  s.version = "1.2.22"
+  s.version = "1.2.24"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2024-08-20"
+  s.date = "2024-10-21"
   s.files = [".github/workflows/ruby.yml".freeze, ".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, "CHANGELOG.md".freeze, "FAQ.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "RUBY_VERSION".freeze, "Rakefile".freeze, "VERSION".freeze, "bin/rubocop".freeze, "lib/active_job/queue_adapters/workhorse_adapter.rb".freeze, "lib/generators/workhorse/install_generator.rb".freeze, "lib/generators/workhorse/templates/bin/workhorse.rb".freeze, "lib/generators/workhorse/templates/config/initializers/workhorse.rb".freeze, "lib/generators/workhorse/templates/create_table_jobs.rb".freeze, "lib/workhorse.rb".freeze, "lib/workhorse/active_job_extension.rb".freeze, "lib/workhorse/daemon.rb".freeze, "lib/workhorse/daemon/shell_handler.rb".freeze, "lib/workhorse/db_job.rb".freeze, "lib/workhorse/enqueuer.rb".freeze, "lib/workhorse/jobs/cleanup_succeeded_jobs.rb".freeze, "lib/workhorse/jobs/detect_stale_jobs_job.rb".freeze, "lib/workhorse/jobs/run_active_job.rb".freeze, "lib/workhorse/jobs/run_rails_op.rb".freeze, "lib/workhorse/performer.rb".freeze, "lib/workhorse/poller.rb".freeze, "lib/workhorse/pool.rb".freeze, "lib/workhorse/scoped_env.rb".freeze, "lib/workhorse/worker.rb".freeze, "test/active_job/queue_adapters/workhorse_adapter_test.rb".freeze, "test/lib/db_schema.rb".freeze, "test/lib/jobs.rb".freeze, "test/lib/test_helper.rb".freeze, "test/workhorse/daemon_test.rb".freeze, "test/workhorse/db_job_test.rb".freeze, "test/workhorse/enqueuer_test.rb".freeze, "test/workhorse/performer_test.rb".freeze, "test/workhorse/poller_test.rb".freeze, "test/workhorse/pool_test.rb".freeze, "test/workhorse/worker_test.rb".freeze, "workhorse.gemspec".freeze]
   s.rubygems_version = "3.4.6".freeze
   s.summary = "Multi-threaded job backend with database queuing for ruby.".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workhorse
 version: !ruby/object:Gem::Version
-  version: 1.2.22
+  version: 1.2.24
 platform: ruby
 authors:
 - Sitrox
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-20 00:00:00.000000000 Z
+date: 2024-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler