workhorse 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41fdd839e9d646bc4cff92ec6eda63da5ad24f4d683e9bc42ce167547247fb29
-  data.tar.gz: 317c5da4cbd865d36d4361920f906456f4205ce3f5f09376af15aa7798347175
+  metadata.gz: 4a4f3666d9865ea9578e5bb735c0889a3701be869f07fc52c971777e41dbae4e
+  data.tar.gz: 3fca0dcf3192f1bc954c8963eb272e4aadcba4a6d2616c57600fd5ae2003a3a0
 SHA512:
-  metadata.gz: 6e1138796a7bfae97429073564862ecd3619576ef88e28a3a043550cd054b82fac2ac79f67931080604c91e73b4356c56798d7b2801e2a9e6e8e448ea8ed31e0
-  data.tar.gz: 5f08e73f3a4b816b59c32c902103b39e8d53d42bb8528eed02af0e73fbea576a788e24687cabb482cc652bb259fe40ee35d216f1010b48f4439aa1b52715d0dd
+  metadata.gz: c8437d30f0f38fee5cf2c709642af4a4a85439138ba4fbf07935a18577fdde01c1bcccdd14e84579cefee141393b878669702a835852f5ffddd9e2b39ad73699
+  data.tar.gz: d73c6f4432a64d9e26b1b010dc88ac5c9751cb7a7a99bce2b885e17f0b0967c540704a1d6af4a9cb4bd7e2b59dc89648a98c3de305090fa7d91ed11259c2c5aa

data/.rubocop.yml

@@ -21,6 +21,9 @@ Style/SignalException:
 Lint/RescueWithoutErrorClass:
   Enabled: False
 
+Lint/RescueException:
+  Enabled: False
+
 Style/ConditionalAssignment:
   Enabled: false
 

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Workhorse Change log
 
-## 0.3.5 - unreleased
+## 0.3.6 - 2018-11-14
+
+* Makes sure all exceptions are caught and handled properly, not only exceptions
+  deriving from `StandardError`. In previous releases, this prevented some
+  exceptions like syntax errors to be handled properly.
+
+## 0.3.5 - 2018-10-22
 
 * Adds global callback `on_exception` that allows custom exception handling /
   exception notification.

data/README.md

@@ -252,7 +252,7 @@ callback of your linking, e.g.:
 Workhorse.setup do |config|
   config.on_exception = proc do |e|
     # Use gem 'exception_notification' for notifying about exceptions
-    ExceptionNotifier.notify_exception(exception)
+    ExceptionNotifier.notify_exception(e)
   end
 end
 ```

data/VERSION

@@ -1 +1 @@
-0.3.5
+0.3.6

data/lib/workhorse/performer.rb

@@ -12,7 +12,7 @@ module Workhorse
       fail 'Performer can only run once.' if @started
       @started = true
       perform!
-    rescue => e
+    rescue Exception => e
       Workhorse.on_exception.call(e)
     end
 
@@ -30,7 +30,7 @@ module Workhorse
           perform_wrapped
         end
       end
-    rescue => e
+    rescue Exception => e
       # ---------------------------------------------------------------
       # Mark job as failed
       # ---------------------------------------------------------------

data/lib/workhorse/poller.rb

@@ -25,7 +25,7 @@ module Workhorse
             poll
             sleep
           end
-        rescue => e
+        rescue Exception => e
           worker.log %(Poller stopped with exception:\n#{e.message}\n#{e.backtrace.join("\n")})
         end
       end

data/lib/workhorse/worker.rb

@@ -129,12 +129,12 @@ module Workhorse
         @pool.post do
           begin
             Workhorse::Performer.new(db_job, self).perform
-          rescue => e
+          rescue Exception => e
             log %(#{e.message}\n#{e.backtrace.join("\n")}), :error
           end
         end
       end
-    rescue => e
+    rescue Exception => e
       Workhorse.on_exception.call(e)
     end
 

data/test/lib/jobs.rb

@@ -30,6 +30,12 @@ class FailingTestJob
   end
 end
 
+class SyntaxErrorJob
+  def perform
+    fail SyntaxError
+  end
+end
+
 class DummyRailsOpsOp
   class_attribute :results
   self.results = Concurrent::Array.new

data/test/workhorse/performer_test.rb

@@ -14,6 +14,24 @@ class Workhorse::WorkerTest < WorkhorseTest
     assert_equal 2, DbConnectionTestJob.db_connections.uniq.count
   end
 
+  def test_success
+    Workhorse.enqueue BasicJob.new(sleep_time: 0.1)
+    work 0.2, polling_interval: 0.2
+    assert_equal 'succeeded', Workhorse::DbJob.first.state
+  end
+
+  def test_exception
+    Workhorse.enqueue FailingTestJob
+    work 0.2, polling_interval: 0.2
+    assert_equal 'failed', Workhorse::DbJob.first.state
+  end
+
+  def test_syntax_exception
+    Workhorse.enqueue SyntaxErrorJob
+    work 0.2, polling_interval: 0.2
+    assert_equal 'failed', Workhorse::DbJob.first.state
+  end
+
   def test_on_exception
     old_callback = Workhorse.on_exception
     exception = nil

data/workhorse.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: workhorse 0.3.5 ruby lib
+# stub: workhorse 0.3.6 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "workhorse".freeze
-  s.version = "0.3.5"
+  s.version = "0.3.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2018-10-22"
+  s.date = "2018-11-14"
   s.files = [".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "FAQ.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "RUBY_VERSION".freeze, "Rakefile".freeze, "VERSION".freeze, "bin/rubocop".freeze, "lib/generators/workhorse/install_generator.rb".freeze, "lib/generators/workhorse/templates/bin/workhorse.rb".freeze, "lib/generators/workhorse/templates/config/initializers/workhorse.rb".freeze, "lib/generators/workhorse/templates/create_table_jobs.rb".freeze, "lib/workhorse.rb".freeze, "lib/workhorse/daemon.rb".freeze, "lib/workhorse/daemon/shell_handler.rb".freeze, "lib/workhorse/db_job.rb".freeze, "lib/workhorse/enqueuer.rb".freeze, "lib/workhorse/jobs/cleanup_succeeded_jobs.rb".freeze, "lib/workhorse/jobs/run_rails_op.rb".freeze, "lib/workhorse/performer.rb".freeze, "lib/workhorse/poller.rb".freeze, "lib/workhorse/pool.rb".freeze, "lib/workhorse/worker.rb".freeze, "test/lib/db_schema.rb".freeze, "test/lib/jobs.rb".freeze, "test/lib/test_helper.rb".freeze, "test/workhorse/enqueuer_test.rb".freeze, "test/workhorse/performer_test.rb".freeze, "test/workhorse/poller_test.rb".freeze, "test/workhorse/pool_test.rb".freeze, "test/workhorse/worker_test.rb".freeze, "workhorse.gemspec".freeze]
   s.rubygems_version = "2.7.6".freeze
   s.summary = "Multi-threaded job backend with database queuing for ruby.".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workhorse
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-22 00:00:00.000000000 Z
+date: 2018-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler