worker_plugins 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f77ed60aa6667fcc2fc18e2205e6e2a2c9dffd5fba9499750fc9dbcdea61bf5
-  data.tar.gz: 4292d9a83b73e309e731e00d393d7029750d1a7b6ddbe3685f7379af1efc61c6
+  metadata.gz: 13eab7a67becfdbd1809b1930d1314a86c6c0cb217d39ae19181e1dec7453976
+  data.tar.gz: 65b838cc21313b78f92d43b85a95adba991f50360d05be8ec11a2050b4b75133
 SHA512:
-  metadata.gz: 6aa418455aa98b9068bfa46c71eaf12e9a9943c5f1591e015cd713e7bf0d034beff33d98c15506dadd348811834451958f8d11018407910e0da1c29580059430
-  data.tar.gz: 7e1a09482cca627de3794587a480be4f695e9422bec933abc514ddabd3546c2b05485c0da1c141ed4ae0356ab41943607875bed7e376787050ada52e25551b19
+  metadata.gz: 46ebc5d54657090702d0280e72c5f0d863effcbe7ea478892f492b81bfba829a478220fddbde9f2c9df9e7dc7efc07fa3ec5518aa6b455de81be41c7297e72d9
+  data.tar.gz: 4b76bdfa275a1641d782ef84bc96e5e6658d866fb4aef3831f82986dabea510a4e61becb19179bf6a80535181b2492bd939346da8e53c7c110fd36940f181cf7

data/app/services/worker_plugins/add_query.rb

@@ -24,7 +24,7 @@ class WorkerPlugins::AddQuery < WorkerPlugins::ApplicationService
   def ids_added_already_query
     workplace
       .workplace_links
-      .where(resource_type: model_class.name, resource_id: query_with_selected_ids)
+      .where(resource_type: model_class.name)
   end
 
   def ids_added_already
@@ -43,19 +43,43 @@ class WorkerPlugins::AddQuery < WorkerPlugins::ApplicationService
     @primary_key ||= resources_to_add.klass.primary_key
   end
 
-  def query_with_selected_ids
-    WorkerPlugins::SelectColumnWithTypeCast.execute!(
-      column_name_to_select: :id,
-      column_to_compare_with: WorkerPlugins::WorkplaceLink.column_for_attribute(:resource_id),
-      query:
-    )
-  end
-
   def resources_to_add
+    # Correlate per row with NOT EXISTS instead of NOT IN + a materialized
+    # subquery. The old form expanded into a nested `resource_id IN (SELECT
+    # CAST(users.id AS CHAR) FROM users)` that did a full scan of the target
+    # table when the outer query was unfiltered — 60s+ on 340k+ users. This
+    # uses the `(workplace_id, resource_type, resource_id)` composite index
+    # for an index seek per row.
     @resources_to_add ||= query
       .distinct
-      .where
-      .not(id: ids_added_already)
+      .where("NOT EXISTS (#{existing_workplace_link_exists_sql})")
+  end
+
+  def existing_workplace_link_exists_sql
+    resource_id_column = "#{quote_table(WorkerPlugins::WorkplaceLink.table_name)}.#{quote_column(:resource_id)}"
+
+    workplace
+      .workplace_links
+      .where(resource_type: model_class.name)
+      .where("#{resource_id_column} = #{model_primary_key_cast_for_resource_id}")
+      .select(1)
+      .to_sql
+  end
+
+  def model_primary_key_cast_for_resource_id
+    primary_key_column = "#{quote_table(model_class.table_name)}.#{quote_column(model_class.primary_key)}"
+
+    # MySQL and SQLite do implicit conversion when comparing integer/uuid/string
+    # primary keys to the `resource_id` VARCHAR column. Postgres is strict about
+    # types and needs an explicit cast.
+    return primary_key_column unless postgres?
+
+    primary_key_type = model_class.column_for_attribute(model_class.primary_key).type
+    resource_id_type = WorkerPlugins::WorkplaceLink.column_for_attribute(:resource_id).type
+
+    return primary_key_column if primary_key_type == resource_id_type
+
+    "CAST(#{primary_key_column} AS VARCHAR)"
   end
 
   def select_sql

data/lib/worker_plugins/version.rb

@@ -1,3 +1,3 @@
 module WorkerPlugins
-  VERSION = "0.0.13".freeze
+  VERSION = "0.0.14".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: worker_plugins
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Kasper Stöckel
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-04-15 00:00:00.000000000 Z
+date: 2026-04-22 00:00:00.000000000 Z
 dependencies: []
 description: Rails framework for easily choosing and creating lists of objects and
   execute plugins against them.