workbook 0.8.0 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d11f35120106855bbb5905a7f2611b138293157e135f86b0d8f5248c90f5f83
-  data.tar.gz: ced9b91f1f1f69bbe90151ef78f61885a1ced541c5d3392e46dcb4e7770b58da
+  metadata.gz: 19f7a4905a129fba73781bb8ef9f672573419b5b754508bc3cc28aff968d5fb8
+  data.tar.gz: 7bd07336aaee461b7ff487c683b427ba29d717bee23731d80c1e74d1a1f7cd1e
 SHA512:
-  metadata.gz: 1abccd53682ea4a4718153f0409e43925108740004dfbbba78419d4f80dd7a23add4677c7430812253a6e5559322b1919fb0f2c8f4450575804c8aae68056db6
-  data.tar.gz: 6eb31d092e13c909e6d96d78a594bd3c1e9abd01d88a8cb76fc133c128035786d7f06651123e4c2f0798fa7d8b275f6914ed21152a0eab94efbb80e03083cb95
+  metadata.gz: 5d20a391aee1d3338f08ecddb104cca25411626787bec16a2c0a25e125efa6bbee91f79350a919afcca7d6443fac62ca34d2f2da20985e1eae3b59c73e6f6b7f
+  data.tar.gz: 93d1ffe829d5fb3f591b9ef5244c013f4268d982f8e148893439b7788d8422f99e1449577fd708e753cb26db9029db1a08a1e46e8db0d12860e23db4124a8a82

data/.codeclimate.yml

@@ -0,0 +1,21 @@
+version: "2"
+plugins:
+  rubocop:
+    enabled: true
+    channel: rubocop-1-23-0
+  brakeman:
+    enabled: false
+exclude_patterns:
+  - "config/"
+  - "db/"
+  - "dist/"
+  - "features/"
+  - "**/node_modules/"
+  - "script/"
+  - "**/spec/"
+  - "**/test/"
+  - "**/tests/"
+  - "Tests/"
+  - "**/vendor/"
+  - "**/*_test.go"
+  - "**/*.d.ts"

data/.gitignore

@@ -1,4 +1,5 @@
 untitled document.xls
+untitled document.csv
 test.xls
 compare*.xls
 sharepoint_download_excel.*
@@ -14,4 +15,6 @@ untitled document.xlsx*
 .DS_Store
 doc
 private_*
-test_private_*
+test_private_*
+coverage
+.byebug_history

data/.ruby-version

@@ -1 +1 @@
-2.6.0
+3.2.1

data/.travis.yml

@@ -4,10 +4,10 @@ env:
 sudo: false
 language: ruby
 rvm:
-  - 2.3.0
-  - 2.4.0
-  - 2.5.0
-  - 2.6.0
+  - 2.5.3
+  - 2.6.3
+  - 2.7.1
+  - 3.0.2
 before_install:
   - gem install bundler
 before_script:

data/CHANGELOG.md

@@ -0,0 +1,16 @@
+# Changelog
+
+### 0.9.0 (in progress)
+
+* Dropped inheritance from Array and borrowed from the Enumerable module instead (this might break some existing implementations; please create pull request if you miss Array like functionality)
+
+### 0.8.1
+
+* Adopted [Standard](https://github.com/testdouble/standard) for code formatting
+
+### 0.8.0
+
+* Dropped support for ruby < 2.3.0
+* Added support for 2.6.0
+* Stripping strings before calling to_sym (possibly breaking, as symbols can be used to address columns)
+* Started maintaining a changelog

data/Gemfile

@@ -1,6 +1,8 @@
-source "http://rubygems.org"
+# frozen_string_literal: true
+
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in workbook.gemspec
 
 gemspec
-gem 'rubyzip', :require => 'zip/zip'
+gem "rubyzip", require: "zip/zip"

data/README.md

@@ -1,7 +1,10 @@
 # Workbook
-[![Code Climate](https://codeclimate.com/github/murb/workbook.png)](https://codeclimate.com/github/murb/workbook) [![Build Status](https://travis-ci.org/murb/workbook.svg?branch=master)](https://travis-ci.org/murb/workbook) [![Gem Version](https://badge.fury.io/rb/workbook.svg)](http://badge.fury.io/rb/workbook)
+[![Code Climate](https://codeclimate.com/github/murb/workbook.svg)](https://codeclimate.com/github/murb/workbook)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/058655e705a3f36896e0/test_coverage)](https://codeclimate.com/github/murb/workbook/test_coverage)
+[![Build Status](https://travis-ci.org/murb/workbook.svg?branch=master)](https://travis-ci.org/murb/workbook)
+[![Gem Version](https://badge.fury.io/rb/workbook.svg)](http://badge.fury.io/rb/workbook)
 
-Goal of this gem is to make working with workbooks (spreadsheets) as programmer friendly as possible. Not reinventing a totally new DSL or all kinds of new methodnames, but just borrowing from known concepts such as hashes and arrays (much like (Faster)CSV does)). Workbook is a gem that mimicks a typical spreadsheet, a bundle of sheets, bundled in a *workbook*. A sheet may contain one or more tables (which might the multi table sheets of Apple Numbers or Excel ranges). Basically:
+Goal of this gem is to make working with workbooks (spreadsheets) as programmer friendly as possible. Not reinventing a totally new DSL or all kinds of new methodnames, but just borrowing from known concepts such as hashes and arrays (much like (Faster)CSV does)). Workbook is a gem that mimicks a typical spreadsheet, a bundle of sheets, bundled in a *workbook*. A sheet may contain one or more tables (which might be the multi table sheets of Apple Numbers or Excel ranges). Basically:
 
 * Book
    * Sheet (one or more)
@@ -13,7 +16,7 @@ Subsequently a table consists of:
    * Row (one or more)
       * Cell ( wich has may have a (shared) Format )
 
-Book, Sheet, Table and Row inherit from the base Array class, and hence walks and quacks as such. The row is extended with hashlike lookups (`row[:id]`) and writers (`row[:id]=`). Values are converted to ruby native types, and optional parsers can be added to improve recognition.
+Book, Sheet, Table and Row inherit much of the behaviours from the Array and Hash classes, it tries to walk and quack as such. The row is extended with hashlike lookups (`row[:id]`) and writers (`row[:id]=`). Values are converted to ruby native types, and optional parsers can be added to improve recognition.
 
 In addition to offering you this plain structure it allows for importing .xls, .csv, .xlsx, .txt files (more to come), writing .xls, and .csv  (more to come) and includes several utilities to easily create an overview of the differences between two tables and output basic cell-styling properties as css.
 
@@ -32,7 +35,7 @@ Calling
     s = b.sheet
     t = s.table
 
-will give you an the first Sheet and Table (if one doesn't exist it is created on the fly).
+will give you the first Sheet and Table (if one doesn't exist it is created on the fly).
 
 You can initialize with simple 2-d array like this:
 
@@ -129,8 +132,7 @@ In case you want to display a formatted table in HTML, some conversion is offere
 
 ## Compatibility
 
-Workbook is automatically tested for ruby 1.9, 2.0 and 2.1. Most of it works with 1.8.7 and jruby but not all tests give equal results.
-Check [Travis for Workbook's current build status](https://travis-ci.org/murb/workbook) [![Build Status](https://travis-ci.org/murb/workbook.svg?branch=master)](https://travis-ci.org/murb/workbook).
+Workbook is automatically tested. Check [Travis for Workbook's current build status of the supported ruby versions](https://travis-ci.org/murb/workbook) [![Build Status](https://travis-ci.org/murb/workbook.svg?branch=master)](https://travis-ci.org/murb/workbook).
 
 ## Future
 
@@ -153,4 +155,4 @@ Workbook uses the following gems:
 * [FasterCSV](http://fastercsv.rubyforge.org/) Used for reading CSV (comma separated text) and TXT (tab separated text) files (Copyright © James Edward Gray II; GPL2 & Ruby License)
 * [rchardet](http://rubyforge.org/projects/rchardet) Used for detecting encoding in CSV and TXT importers (Copyright © JMHodges; LGPL)
 * [axslx](https://github.com/randym/axlsx) Used for writing the newer .xlsx files (with formatting) (Copyright © 2011, 2012 Randy Morgan, MIT License)
-* [Nokogiri](http://nokogiri.org/) Used for reading ODS documents (Copyright © 2008 - 2012 Aaron Patterson, Mike Dalessio, Charles Nutter, Sergio Arbeo, Patrick Mahoney, Yoko Harada; MIT Licensed)
+* [Nokogiri](http://nokogiri.org/) Used for reading ODS documents (Copyright © 2008 - 2012 Aaron Patterson, Mike Dalessio, Charles Nutter, Sergio Arbeo, Patrick Mahoney, Yoko Harada; MIT Licensed)

data/Rakefile

@@ -1,14 +1,16 @@
-require 'rake'
-require 'rake/testtask'
-require 'bundler'
+# frozen_string_literal: true
+
+require "rake"
+require "rake/testtask"
+require "bundler"
 require "bundler/gem_tasks"
 
-#Bundler::GemHelper.install_tasks
+# Bundler::GemHelper.install_tasks
 
-task :default => [:test]
+task default: [:test]
 
 Rake::TestTask.new do |t|
   t.libs << "test"
-  t.test_files = FileList['test/test*.rb','test/writers/test*.rb']
+  t.test_files = FileList["test/test*.rb", "test/writers/test*.rb"]
   t.verbose = false
-end
+end

data/lib/workbook/book.rb

@@ -1,17 +1,18 @@
-# -*- encoding : utf-8 -*-
 # frozen_string_literal: true
-require 'open-uri'
-require 'workbook/writers/xls_writer'
-require 'workbook/writers/xlsx_writer'
-require 'workbook/writers/html_writer'
-require 'workbook/readers/xls_reader'
-require 'workbook/readers/xls_shared'
-require 'workbook/readers/xlsx_reader'
-require 'workbook/readers/ods_reader'
-require 'workbook/readers/csv_reader'
-require 'workbook/readers/txt_reader'
-require 'workbook/readers/txt_reader'
-require 'workbook/modules/diff_sort'
+# frozen_string_literal: true
+
+require "forwardable"
+require "open-uri"
+require "workbook/writers/xls_writer"
+require "workbook/writers/xlsx_writer"
+require "workbook/writers/html_writer"
+require "workbook/readers/xls_reader"
+require "workbook/readers/xls_shared"
+require "workbook/readers/xlsx_reader"
+require "workbook/readers/ods_reader"
+require "workbook/readers/csv_reader"
+require "workbook/readers/txt_reader"
+require "workbook/modules/diff_sort"
 
 module Workbook
   # The Book class is the container of sheets. It can be inialized by either the standard initalizer or the open method. The
@@ -33,8 +34,9 @@ module Workbook
     "CDF V2 Document, No summary info"
   ]
 
-  class Book < Array
-
+  class Book
+    include Enumerable
+    extend Forwardable
 
     include Workbook::Readers::XlsShared
     include Workbook::Writers::XlsWriter
@@ -47,14 +49,13 @@ module Workbook
     include Workbook::Readers::TxtReader
     include Workbook::Modules::BookDiffSort
 
+    delegate [:last, :pop, :delete_at, :each, :[]] => :@sheets
+
     # @param [Workbook::Sheet, Array] sheet    create a new workbook based on an existing sheet, or initialize a sheet based on the array
     # @return [Workbook::Book]
-    def initialize sheet=nil
-      if sheet.is_a? Workbook::Sheet
-        self.push sheet
-      elsif sheet
-        self.push Workbook::Sheet.new(sheet, self, {})
-      end
+    def initialize sheet = nil
+      @sheets = []
+      push sheet if sheet
     end
 
     # @return [Workbook::Template] returns the template describing how the document should be/is formatted
@@ -72,37 +73,51 @@ module Workbook
     #
     # @return [String] the title of the workbook
     def title
-      (defined?(@title) and !@title.nil?) ? @title : "untitled document"
+      defined?(@title) && !@title.nil? ? @title : "untitled document"
     end
 
-    def title= t
-      @title = t
-    end
+    attr_writer :title
 
     # Push (like in array) a sheet to the workbook (parameter is optional, default is a new sheet)
     #
-    # @param [Workbook::Sheet] sheet
-    def push sheet=Workbook::Sheet.new
-      super(sheet)
-      sheet.book=(self)
+    # @param [Workbook::Sheet, Array[Array]] sheet
+    def push sheet = Workbook::Sheet.new
+      sheet = Workbook::Sheet.new(sheet) unless sheet.is_a? Workbook::Sheet
+      sheet.book = self
+
+      @sheets.push(sheet)
+      sheet
     end
 
-    # << (like in array) a sheet to the workbook (parameter is optional, default is a new sheet)
+    # Inserts a new Table at the specified index
     #
-    # @param [Workbook::Sheet] sheet
-    def << sheet=Workbook::Sheet.new
-      sheet = Workbook::Sheet.new(sheet) unless sheet.is_a? Workbook::Sheet
-      super(sheet)
-      sheet.book=(self)
+    # @param [Integer] index of the table
+    # @param [Workbook::Table, Array<Array>] table   The new first table of this sheet
+    #
+    # @return [Workbook::Table]
+    def []= index, value
+      table_to_insert = value.is_a?(Workbook::Sheet) ? value : Workbook::Sheet.new
+      table_to_insert.book = self
+      @sheets[index] = table_to_insert
     end
 
+    # returns the index of an item
+    def index item
+      @sheets.index item
+    end
+
+    # << (like in array) a sheet to the workbook (parameter is optional, default is a new sheet)
+    #
+    # @param [Workbook::Sheet, Array[Array]] sheet
+    def << sheet = Workbook::Sheet.new
+      push sheet
+    end
 
     # Sheet returns the first sheet of a workbook, or an empty one.
     #
     # @return [Workbook::Sheet] The first sheet, and creates an empty one if one doesn't exists
     def sheet
-      push Workbook::Sheet.new unless first
-      first
+      first || push
     end
 
     # If the first sheet has any contents
@@ -117,9 +132,9 @@ module Workbook
     # @param [String] filename   a string with a reference to the file to be opened
     # @param [String] extension  an optional string enforcing a certain parser (based on the file extension, e.g. 'txt', 'csv' or 'xls')
     # @return [Workbook::Book] A new instance, based on the filename
-    def import filename, extension=nil, options={}
-      extension = file_extension(filename) unless extension
-      if ['txt','csv','xml'].include?(extension)
+    def import filename, extension = nil, options = {}
+      extension ||= file_extension(filename)
+      if ["txt", "csv", "xml"].include?(extension)
         open_text filename, extension, options
       else
         open_binary filename, extension, options
@@ -131,9 +146,9 @@ module Workbook
     # @param [String] filename a string with a reference to the file to be opened
     # @param [String] extension an optional string enforcing a certain parser (based on the file extension, e.g. 'txt', 'csv' or 'xls')
     # @return [Workbook::Book] A new instance, based on the filename
-    def open_binary filename, extension=nil, options={}
-      extension = file_extension(filename) unless extension
-      f = open(filename)
+    def open_binary filename, extension = nil, options = {}
+      extension ||= file_extension(filename)
+      f = File.open(filename)
       send("load_#{extension}".to_sym, f, options)
     end
 
@@ -141,9 +156,9 @@ module Workbook
     #
     # @param [String] filename   a string with a reference to the file to be opened
     # @param [String] extension  an optional string enforcing a certain parser (based on the file extension, e.g. 'txt', 'csv' or 'xls')
-    def open_text filename, extension=nil, options={}
-      extension = file_extension(filename) unless extension
-      t = text_to_utf8(open(filename).read)
+    def open_text filename, extension = nil, options = {}
+      extension ||= file_extension(filename)
+      t = text_to_utf8(File.open(filename).read)
       send("load_#{extension}".to_sym, t, options)
     end
 
@@ -151,21 +166,20 @@ module Workbook
     #
     # @param [String] filename   a string with a reference to the file to be written to
     # @param [Hash] options  depends on the writer chosen by the file's filetype
-    def write filename, options={}
+    def write filename, options = {}
       extension = file_extension(filename)
       send("write_to_#{extension}".to_sym, filename, options)
     end
 
-
     # Helper method to convert text in a file to UTF-8
     #
     # @param [String] text a string to convert
     def text_to_utf8 text
-      unless text.valid_encoding? and text.encoding == "UTF-8"
+      unless text.valid_encoding? && (text.encoding == "UTF-8")
         # TODO: had some ruby 1.9 problems with rchardet ... but ideally it or a similar functionality will be reintroduced
         source_encoding = text.valid_encoding? ? text.encoding : "US-ASCII"
-        text = text.encode('UTF-8', source_encoding, {:invalid=>:replace, :undef=>:replace, :replace=>""})
-        text = text.gsub("\u0000","") # TODO: this cleanup of nil values isn't supposed to be needed...
+        text = text.encode("UTF-8", source_encoding, invalid: :replace, undef: :replace, replace: "")
+        text = text.delete("\u0000") # TODO: this cleanup of nil values isn't supposed to be needed...
       end
       text
     end
@@ -174,16 +188,16 @@ module Workbook
     #
     # @return [String] The file extension
     def file_extension(filename)
-      ext = File.extname(filename).gsub('.','').downcase if filename
+      ext = File.extname(filename).delete(".").downcase if filename
       # for remote files which has asset id after extension
-      ext.split('?')[0]
+      ext.split("?")[0]
     end
 
     # Load the CSV data contained in the given StringIO or String object
     #
     # @param [StringIO] stringio_or_string StringIO stream or String object, with data in CSV format
     # @param [Symbol] filetype (currently only :csv or :txt), indicating the format of the first parameter
-    def read(stringio_or_string, filetype, options={})
+    def read(stringio_or_string, filetype, options = {})
       raise ArgumentError.new("The filetype parameter should be either :csv or :txt") unless [:csv, :txt].include?(filetype)
       t = stringio_or_string.respond_to?(:read) ? stringio_or_string.read : stringio_or_string.to_s
       t = text_to_utf8(t)
@@ -195,7 +209,7 @@ module Workbook
     # @param [Integer] index    the index of the sheet
     def create_or_open_sheet_at index
       s = self[index]
-      s = self[index] = Workbook::Sheet.new if s == nil
+      s = self[index] = Workbook::Sheet.new if s.nil?
       s.book = self
       s
     end
@@ -206,10 +220,10 @@ module Workbook
       # @param [String] filename of the document
       # @param [String] extension of the document (not required). The parser used is based on the extension of the file, this option allows you to override the default.
       # @return [Workbook::Book] A new instance, based on the filename
-      def open filename, extension=nil
-        wb = self.new
+      def open filename, extension = nil
+        wb = new
         wb.import filename, extension
-        return wb
+        wb
       end
 
       # Create an instance from the given stream or string, which should be in CSV or TXT format
@@ -217,12 +231,11 @@ module Workbook
       # @param [StringIO] stringio_or_string StringIO stream or String object, with data in CSV or TXT format
       # @param [Symbol] filetype (currently only :csv or :txt), indicating the format of the first parameter
       # @return [Workbook::Book] A new instance
-      def read stringio_or_string, filetype, options={}
-        wb = self.new
+      def read stringio_or_string, filetype, options = {}
+        wb = new
         wb.read(stringio_or_string, filetype, options)
         wb
       end
-
     end
   end
 end

data/lib/workbook/cell.rb

@@ -1,18 +1,65 @@
-# -*- encoding : utf-8 -*-
 # frozen_string_literal: true
-require 'workbook/modules/cell'
+# frozen_string_literal: true
+
+require "workbook/modules/cell"
 
 module Workbook
   class Cell
-     include Workbook::Modules::Cell
-
-     # @param [Numeric,String,Time,Date,TrueClass,FalseClass,NilClass] value a valid value
-     # @param [Hash] options a reference to :format (Workbook::Format) can be specified
-     def initialize value=nil, options={}
-       self.format = options[:format] if options[:format]
-       self.row = options[:row]
-       self.value = value
-       @to_sym = nil
-     end
+    include Workbook::Modules::Cell
+
+    class << self
+
+      # returns a symbol representation of a string.
+      # @param [String] value to convert
+      # @example
+      #
+      #     <Workbook::Cell value="yet another value">.to_sym # returns :yet_another_value
+      def value_to_sym value
+        v = nil
+        cell_type ||= ::Workbook::Modules::Cell::CLASS_CELLTYPE_MAPPING[value.class.to_s]
+        value_to_s = value.to_s.strip.downcase
+        unless value.nil? || value_to_s == ""
+          if cell_type == :integer
+            v = "num#{value}".to_sym
+          elsif cell_type == :float
+            v = "num#{value}".sub(".", "_").to_sym
+          else
+            v = value_to_s.strip
+            ends_with_exclamationmark = (v[-1] == "!")
+            ends_with_questionmark = (v[-1] == "?")
+
+            v = _replace_possibly_problematic_characters_from_string(v)
+
+            v = v.encode(Encoding.find("ASCII"), invalid: :replace, undef: :replace, replace: "")
+
+            v = "#{v}!" if ends_with_exclamationmark
+            v = "#{v}?" if ends_with_questionmark
+            v = v.downcase.to_sym
+          end
+        end
+        v
+      end
+
+      private
+
+      def _replace_possibly_problematic_characters_from_string(string)
+        Workbook::Modules::Cell::CHARACTER_REPACEMENTS.each do |ac, rep|
+          ac.each do |s|
+            string = string.gsub(s, rep)
+          end
+        end
+        string
+      end
+
+    end
+
+    # @param [Numeric,String,Time,Date,TrueClass,FalseClass,NilClass] value a valid value
+    # @param [Hash] options a reference to :format (Workbook::Format) can be specified
+    def initialize value = nil, options = {}
+      self.format = options[:format] if options[:format]
+      self.row = options[:row]
+      self.value = value
+      @to_sym = nil
+    end
   end
 end

data/lib/workbook/column.rb

@@ -1,33 +1,39 @@
-# -*- encoding : utf-8 -*-
 # frozen_string_literal: true
+# frozen_string_literal: true
+
 module Workbook
+  # Column helps us to store general properties of a column, and lets us easily perform operations on values within a column, it also exposes a read only Enumerable API to access the cells in the column.
 
-  # Column helps us to store general properties of a column, and lets us easily perform operations on values within a column
   class Column
-    attr_accessor :limit, :width #character limit
+    include Enumerable
+    extend Forwardable
+
+    delegate [:first, :last, :each, :count, :include?, :index, :to_csv, :length, :empty?] => :cells
 
-    def initialize(table=nil, options={})
+    attr_accessor :limit, :width # character limit
+
+    def initialize(table = nil, options = {})
       self.table = table
-      options.each{ |k,v| self.public_send("#{k}=",v) }
+      options.each { |k, v| public_send("#{k}=", v) }
     end
 
     # Returns column type, either :primary_key, :string, :text, :integer, :float, :decimal, :datetime, :date, :binary, :boolean
     def column_type
       return @column_type if defined?(@column_type)
-      ind = self.index
+      ind = index
       table[1..500].each do |row|
-        if row[ind] and row[ind].cell_type
+        if row[ind]&.cell_type
           cel_column_type = row[ind].cell_type
-          if !defined?(@column_type) or @column_type.nil?
+          if !defined?(@column_type) || @column_type.nil?
             @column_type = cel_column_type
-          elsif cel_column_type == @column_type or cel_column_type == :nil
+          elsif (cel_column_type == @column_type) || (cel_column_type == :nil)
           else
             @column_type = :string
             break
           end
         end
       end
-      return @column_type
+      @column_type
     end
 
     # Returns index of the column within the table's columns-set
@@ -39,14 +45,12 @@ module Workbook
     # Set the table this column belongs to
     # @param [Workbook::Table] table this column belongs to
     def table= table
-      raise(ArgumentError, "value should be nil or Workbook::Table") unless [NilClass,Workbook::Table].include? table.class
+      raise(ArgumentError, "value should be nil or Workbook::Table") unless [NilClass, Workbook::Table].include? table.class
       @table = table
     end
 
     # @return [Workbook::Table]
-    def table
-      @table
-    end
+    attr_reader :table
 
     def column_type= column_type
       if [:primary_key, :string, :text, :integer, :float, :decimal, :datetime, :date, :binary, :boolean].include? column_type
@@ -57,25 +61,26 @@ module Workbook
       end
     end
 
+    def cells
+      table_header_object_id = table.header.object_id
+      table.map{|r| r[index] unless r.object_id == table_header_object_id }.compact
+    end
+
     def head_value
-      begin
-        table.header[index].value
-      rescue
-        return "!noheader!"
-      end
+      table.header[index].value
+    rescue
+      "!noheader!"
     end
 
     def inspect
       "<Workbook::Column index=#{index}, header=#{head_value}>"
     end
 
-    #default cell
-    def default
-      return @default
-    end
+    # default cell
+    attr_reader :default
 
     def default= value
-      @default = value if value.class == Cell
+      @default = value if value.instance_of?(Cell)
       @default = Cell.new(value)
     end
 
@@ -84,13 +89,12 @@ module Workbook
       # @param [String] string that typically identifies a column
       # @return [Integer]
       def alpha_index_to_number_index string
-        string.upcase!
         sum = 0
-        string.chars.each_with_index do | char, char_index|
-          sum = sum * 26 + char.unpack('U')[0]-64
+        string.upcase.chars.each_with_index do |char, char_index|
+          sum = sum * 26 + char.unpack1("U") - 64
         end
-        return sum-1
+        sum - 1
       end
     end
   end
-end
+end