workarea-stripe 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 596907c9a6f4145170a89081d483847c24a887fde0205fc220f6f486b0380b9a
-  data.tar.gz: d5d665bca919e45c31be1e5e81c913cada79e97f47cf48392d35080bf55cb49d
+  metadata.gz: cd29764a459c7d4f9532363e3e62359a8a12fed89510e74e379dd7b69218d340
+  data.tar.gz: 613eb162eb6fa2ed29550dd4c7860a0172a5792d9a9e1cd01b7be8b8e01726db
 SHA512:
-  metadata.gz: 307a8647ac8a4530a7d5bedf16905f5018a00681372e42545056afcf118e51fa090e97226c6ca71acc83fb4b0bb0bc1263053787220ba918598e9321671d1997
-  data.tar.gz: baa5fc1dd1e49fda591486c0da7a4cef2b50a1ac4e73523f8ad8cfafb7be4d804022c3f297a9c9b9895a31309aa0c4a96364cec543e725c10600dde6e63e3920
+  metadata.gz: f59a0dbfa719242fa226214ac8a57b51b86600854130b207977dc3413a64b0afb630a60fcd21473b200966e0d5b5de153d7b34b000d09dc3e8149e9e0f1e4110
+  data.tar.gz: e4b9d070a3900730e22de2acd0c79ab32db42e05991e0a2f26484ffeec7030492387a19d32193812dc03e977cf73077ede35b5e9c57bf85d5aed1783a416f33a

data/.github/workflows/ci.yml

@@ -0,0 +1,57 @@
+name: CI
+on: [push]
+
+jobs:
+  static_analysis:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: workarea-commerce/ci/bundler-audit@v1
+    - uses: workarea-commerce/ci/rubocop@v1
+    - uses: workarea-commerce/ci/eslint@v1
+      with:
+        args: '**/*.js'
+
+  admin_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:admin
+
+  core_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:core
+
+  storefront_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:storefront
+
+  plugins_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:plugins

data/.gitignore

@@ -17,3 +17,4 @@ log/*.log
 test/dummy/log/*.log
 test/dummy/db/*.sqlite3
 test/dummy/db/*.sqlite3-journal
+.rubocop-http*

data/.rubocop.yml

@@ -0,0 +1,3 @@
+inherit_from:
+  - https://raw.githubusercontent.com/workarea-commerce/workarea/master/.rubocop.yml
+

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+Workarea Stripe 1.1.0 (2019-11-26)
+--------------------------------------------------------------------------------
+
+*   Remove decorator for test that was removed in base
+
+    Ben Crouse
+
+*   Update credit card issuer validation to allow strip tokens
+
+    Jeff Yucis
+
+*   Update README
+
+    Matt Duffy
+
+
+
 Workarea Stripe 1.0.0 (2019-08-21)
 --------------------------------------------------------------------------------
 

data/Gemfile

@@ -1,8 +1,6 @@
 source 'https://rubygems.org'
-git_source(:github) { |repo| "git@github.com:#{repo}.git" }
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gemspec
 
-gem 'workarea'
-
-gem 'byebug'
+gem 'workarea', github: 'workarea-commerce/workarea'

data/README.md

@@ -3,14 +3,28 @@ Workarea Stripe
 
 Stripe plugin for the Workarea platform.
 
+Getting Started
+--------------------------------------------------------------------------------
+
+Add the gem to your application's Gemfile:
+
+```ruby
+# ...
+gem 'workarea-stripe'
+# ...
+```
+
+Update your application's bundle.
+
+```bash
+cd path/to/application
+bundle
+```
+
 Configuration
 --------------------------------------------------------------------------------
 
-To configure the stripe plugin you will need both a public and secret key from stripe.
-Setting up a stripe sandbox for development is very easy, just create an account
-at <https://dashboard.stripe.com/register>.
-Once you have an account visit <https://dashboard.stripe.com/account/apikeys> to
-access your keys.
+To configure the stripe plugin you will need both a public and secret key from stripe. Setting up a stripe sandbox for development is very easy, just create an account at <https://dashboard.stripe.com/register>. Once you have an account visit <https://dashboard.stripe.com/account/apikeys> to access your keys.
 
 Add the following configuration to your app secrets
 
@@ -42,49 +56,12 @@ example:
 
 See the checkouts/payment.html.haml view in this plugin for reference.
 
-Getting Started
---------------------------------------------------------------------------------
-
-This gem contains a rails engine that must be mounted onto a host Rails application.
-
-To access Workarea gems and source code, you must be an employee of WebLinc or a licensed retailer or partner.
-
-Workarea gems are hosted privately at https://gems.weblinc.com/.
-You must have individual or team credentials to install gems from this server. Add your gems server credentials to Bundler:
-
-    bundle config gems.weblinc.com my_username:my_password
-
-Or set the appropriate environment variable in a shell startup file:
-
-    export BUNDLE_GEMS__WEBLINC__COM='my_username:my_password'
-
-Then add the gem to your application's Gemfile specifying the source:
-
-    # ...
-    gem 'workarea-stripe', source: 'https://gems.weblinc.com'
-    # ...
-
-Or use a source block:
-
-    # ...
-    source 'https://gems.weblinc.com' do
-      gem 'workarea-stripe'
-    end
-    # ...
-
-Update your application's bundle.
-
-    cd path/to/application
-    bundle
-
-Workarea Platform Documentation
+Workarea Commerce Documentation
 --------------------------------------------------------------------------------
 
-See [http://developer.weblinc.com](http://developer.weblinc.com) for Workarea platform documentation.
+See [https://developer.workarea.com](https://developer.workarea.com) for Workarea Commerce documentation.
 
-Copyright & Licensing
+License
 --------------------------------------------------------------------------------
 
-Copyright WebLinc 2018. All rights reserved.
-
-For licensing, contact sales@workarea.com.
+Workarea Stripe is released under the [Business Software License](LICENSE)

data/Rakefile

@@ -34,10 +34,10 @@ desc "Release version #{Workarea::Stripe::VERSION} of the gem"
 task :release do
   host = "https://#{ENV['BUNDLE_GEMS__WEBLINC__COM']}@gems.weblinc.com"
 
-  #Rake::Task['workarea:changelog'].execute
-  #system 'git add CHANGELOG.md'
-  #system 'git commit -m "Update CHANGELOG"'
-  #system 'git push origin HEAD'
+  Rake::Task['workarea:changelog'].execute
+  system 'git add CHANGELOG.md'
+  system 'git commit -m "Update CHANGELOG"'
+  system 'git push origin HEAD'
 
   system "git tag -a v#{Workarea::Stripe::VERSION} -m 'Tagging #{Workarea::Stripe::VERSION}'"
   system 'git push --tags'

data/app/models/workarea/payment/credit_card.decorator

@@ -23,5 +23,10 @@ module Workarea
         end
       end
     end
+
+    def issuer_accepted
+      return if stripe?
+      super
+    end
   end
 end

data/lib/active_merchant/billing/bogus_stripe_gateway.rb

@@ -17,7 +17,7 @@ module ActiveMerchant
       def store(paysource, options = {})
         case normalize(paysource)
         when /1$/, /^tok/, ""
-          Response.new(true, SUCCESS_MESSAGE, { "id" => "cus_5678", "sources" => { "data" => [{ "id" => 'card_1111', "last4" => '1111', "exp_month" => "1", "exp_year" => "2020", "brand" => "Visa" }] } }, test: true)
+          Response.new(true, SUCCESS_MESSAGE, { "id" => "cus_5678", "sources" => { "data" => [{ "id" => 'card_1111', "last4" => '1111', "exp_month" => "1", "exp_year" => "2020", "brand" => "Test Card" }] } }, test: true)
         when /2$/
           Response.new(false, FAILURE_MESSAGE, { billingid: nil, error: FAILURE_MESSAGE }, test: true, error_code: STANDARD_ERROR_CODE[:processing_error])
         else

data/lib/workarea/stripe/version.rb

@@ -1,5 +1,5 @@
 module Workarea
   module Stripe
-    VERSION = '1.0.0'
+    VERSION = '1.1.0'
   end
 end

data/test/system/workarea/storefront/download_system_test.decorator

@@ -0,0 +1,61 @@
+module Workarea
+  decorate Storefront::DownloadSystemTest, with: :stripe do
+    def test_checking_out_with_downloadable_product
+      setup_checkout_specs
+
+      Order.first.items.delete_all
+
+      product = create_product(
+        name: 'Digital Product',
+        variants: [
+          { sku: 'SKU1', regular: 10.to_m, tax_code: '001' },
+          { sku: 'SKU2', regular: 15.to_m, tax_code: '001' }
+        ]
+      )
+
+      create_fulfillment_sku(id: 'SKU1', policy: :download, file: product_image_file)
+      create_fulfillment_sku(id: 'SKU2', policy: :download, file: product_image_file)
+
+      visit storefront.product_path(product)
+
+      within '.product-details__add-to-cart-form' do
+        select product.skus.first, from: 'sku'
+        click_button t('workarea.storefront.products.add_to_cart')
+      end
+
+      assert(page.has_content?('Success'))
+
+      start_guest_checkout
+
+      assert_current_path(storefront.checkout_addresses_path)
+
+      fill_in_email
+      fill_in_billing_address
+      click_button t('workarea.storefront.checkouts.continue_to_payment')
+
+      assert_current_path(storefront.checkout_payment_path)
+      assert(page.has_content?('Success'))
+
+      fill_in_credit_card
+      click_button t('workarea.storefront.checkouts.place_order')
+
+      assert_current_path(storefront.checkout_confirmation_path)
+      assert(page.has_content?('Success'))
+      assert(page.has_content?(t('workarea.storefront.flash_messages.order_placed')))
+      assert(page.has_content?(Order.first.id))
+
+      assert(page.has_content?('1019 S. 47th St.'))
+      assert(page.has_content?('Philadelphia'))
+      assert(page.has_content?('PA'))
+      assert(page.has_content?('19143'))
+
+      assert(page.has_content?('Test Card'))
+
+      assert(page.has_content?('Digital Product'))
+      assert(page.has_content?('$10.00'))
+      assert(page.has_content?('$0.70'))
+      assert(page.has_content?('$10.70'))
+      assert(page.has_content?(t('workarea.storefront.orders.download')))
+    end
+  end
+end

data/test/system/workarea/storefront/guest_checkout_system_test.decorator

@@ -92,7 +92,7 @@ decorate Workarea::Storefront::GuestCheckoutSystemTest, with: :stripe do
     assert(page.has_content?('PA'))
     assert(page.has_content?('19143'))
 
-    assert(page.has_content?('Visa'))
+    assert(page.has_content?('Test Card'))
 
     assert(page.has_content?(instruction))
 

data/test/system/workarea/storefront/stripe_payment_system_test.rb

@@ -79,7 +79,7 @@ module Workarea
         assert(page.has_content?('PA'))
         assert(page.has_content?('19143'))
 
-        assert(page.has_content?('Visa'))
+        assert(page.has_content?('Test Card'))
         assert(page.has_content?('1111'))
 
         assert(page.has_content?(instruction))

data/workarea-stripe.gemspec

@@ -17,5 +17,5 @@ Gem::Specification.new do |s|
 
   s.license = 'Business Software License'
 
-  s.add_dependency 'workarea', '~> 3.x', '>= 3.2.0'
+  s.add_dependency 'workarea', '>= 3.5.x'
 end

metadata

@@ -1,35 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: workarea-stripe
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Jeff Yucis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-21 00:00:00.000000000 Z
+date: 2019-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.x
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 3.5.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.x
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 3.5.x
 description: Stripe payment processor integration for the Workarea Commerce Platform
 email:
 - jyucis@weblinc.com
@@ -38,11 +32,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".editorconfig"
-- ".eslintrc"
+- ".eslintrc.json"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/documentation-request.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/ci.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
@@ -136,7 +132,7 @@ files:
 - test/support/stripe_public_key.rb
 - test/system/workarea/storefront/analytics_system_test.decorator
 - test/system/workarea/storefront/credit_cards_system_test.decorator
-- test/system/workarea/storefront/digital_products_system_test.decorator
+- test/system/workarea/storefront/download_system_test.decorator
 - test/system/workarea/storefront/guest_checkout_system_test.decorator
 - test/system/workarea/storefront/logged_in_checkout_system_test.decorator
 - test/system/workarea/storefront/no_js_system_test.decorator
@@ -164,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Stripe payment processor integration for the Workarea Commerce Platform

data/test/system/workarea/storefront/digital_products_system_test.decorator

@@ -1,67 +0,0 @@
-decorate Workarea::Storefront::DigitalProductsSystemTest, with: :stripe do
-  def fill_in_credit_card
-    page.driver.browser.switch_to.frame "stripe-payment-frame"
-
-    find('input[name="cardnumber"]').set('4111111111111111')
-    find('input[name="exp-date"]').set('12/21')
-    find('input[name="cvc"]').set('999')
-    find('input[name="postal"]').set('19143')
-
-    page.driver.browser.switch_to.default_content
-  end
-
-
-  def test_checking_out_with_a_digital_product
-    setup_checkout_specs
-
-    Workarea::Order.first.items.delete_all
-
-    product = create_product(
-      name: 'Digital Product',
-      digital: true,
-      variants: [
-        { sku: 'SKU1', regular: 10.to_m },
-        { sku: 'SKU2', regular: 15.to_m },
-        { sku: 'SKU3', regular: 25.to_m }
-      ]
-    )
-
-    visit storefront.product_path(product)
-
-    within '.product-details__add-to-cart-form' do
-      select product.skus.first, from: 'sku'
-      click_button t('workarea.storefront.products.add_to_cart')
-    end
-
-    assert(page.has_content?('Success'))
-
-    start_guest_checkout
-
-    assert_current_path(storefront.checkout_addresses_path)
-
-    fill_in_email
-    fill_in_billing_address
-    click_button t('workarea.storefront.checkouts.continue_to_payment')
-
-    assert_current_path(storefront.checkout_payment_path)
-    assert(page.has_content?('Success'))
-
-    fill_in_credit_card
-    click_button t('workarea.storefront.checkouts.place_order')
-
-    assert_current_path(storefront.checkout_confirmation_path)
-    assert(page.has_content?('Success'))
-    assert(page.has_content?(t('workarea.storefront.flash_messages.order_placed')))
-    assert(page.has_content?(Workarea::Order.first.id))
-
-    assert(page.has_content?('1019 S. 47th St.'))
-    assert(page.has_content?('Philadelphia'))
-    assert(page.has_content?('PA'))
-    assert(page.has_content?('19143'))
-
-    assert(page.has_content?('Visa'))
-
-    assert(page.has_content?('Digital Product'))
-    assert(page.has_content?('$10.00'))
-  end
-end