workarea-storefront 3.5.11 → 3.5.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d17dfbda0e576cfb677b85dfeeec873e3298a1bb50cfdaba1e2718230d48cb7
-  data.tar.gz: 31fa8f33a31315e15944a7a1849504cf476f1cfbc3592e22a7e1c0447aaf5136
+  metadata.gz: 34dae4a866fa8dc6c2bed7e2c9da094199bdfda6f2859ea718e77310756bc875
+  data.tar.gz: 572eeb5fa03e1a3dba3683c83eb21844e372e1c1a4cb65dc771a8babe48970b6
 SHA512:
-  metadata.gz: 1b5dd4aa87edc5d005e42a759fa7134269e959da444ac58e66de114f8d12fbb70092b788f60222cb2ebf0ed99c15bdea2987b4fb4af06f2c73ada22cee676e57
-  data.tar.gz: 73204e45143a99faae0979672ab3250d5fb62e5f8176eee60b7d58f74e82bbabb9dde03b12b24c5286bb018a26555a7e06a267daab45ca2e4aae4c2a03f7e1eb
+  metadata.gz: c7a9687e4759d591490c9d109ba617c09d88727d0412a51e611d4d5aad60c31f4da51b01fc677dde2b1c3db2f89856b880e7ad30a001898e9e14968895e43a9c
+  data.tar.gz: 323651e9ccedecab9d6be53a4dc2040ec8d6f8b8af4d2968cc34e82d66f15651937a83ac6ba42a6606363d773dfc8efde346874ce6d9ecd2dfefd3a8ab1283a3

data/app/controllers/workarea/storefront/checkout/addresses_controller.rb

@@ -46,6 +46,8 @@ module Workarea
         end
 
         def validate_shipping_options
+          return unless current_order.requires_shipping?
+
           available_options = Workarea::Storefront::CartViewModel.new(current_order).shipping_options
 
           if available_options.empty?

data/app/controllers/workarea/storefront/checkouts_controller.rb

@@ -44,7 +44,7 @@ module Workarea
           segment_ids: current_segments.map(&:id)
         )
 
-        update_tracking!(email: current_order.email)
+        update_tracking!(email: current_order.email) unless current_order.email.blank?
       end
 
       def with_order_lock

data/app/controllers/workarea/storefront/users/credit_cards_controller.rb

@@ -61,11 +61,8 @@ module Workarea
                     params[:credit_card].permit(
                       :first_name,
                       :last_name,
-                      :number,
-                      :month,
-                      :year,
-                      :cvv,
-                      :default
+                      :default,
+                      *Workarea.config.credit_card_attributes
                     )
                   end
 

data/test/integration/workarea/storefront/checkouts_integration_test.rb

@@ -345,6 +345,39 @@ module Workarea
 
         assert(flash[:error].present?)
       end
+
+      def test_not_setting_a_blank_tracking_email
+        cookies[:email] = 'foo@bar.com'
+        get storefront.checkout_shipping_path
+        assert_equal('foo@bar.com', cookies[:email])
+      end
+
+      def test_no_required_shipping_address_options_flash_message
+        product = create_product(name: 'Digital Product', variants: [{ sku: 'SKU' }])
+        create_fulfillment_sku(id: 'SKU', policy: :download, file: product_image_file)
+
+        post storefront.cart_items_path,
+          params: { product_id: product.id, sku: product.skus.first, quantity: 1 }
+
+        get storefront.checkout_addresses_path
+
+        patch storefront.checkout_addresses_path,
+          params: {
+            email: 'bcrouse@weblinc.com',
+            billing_address: {
+              first_name:   'Ben',
+              last_name:    'Crouse',
+              street:       '12 N. 3rd St.',
+              city:         'Philadelphia',
+              region:       'PA',
+              postal_code:  '19106',
+              country:      'US',
+              phone_number: '2159251800'
+            }
+          }
+
+        refute(flash[:error].present?)
+      end
     end
   end
 end

data/test/integration/workarea/storefront/place_order_integration_test.rb

@@ -3,7 +3,9 @@ require 'test_helper'
 module Workarea
   module Storefront
     class PlaceOrderIntegrationTest < Workarea::IntegrationTest
-      setup do
+      setup :setup_checkout
+
+      def setup_checkout
         create_tax_category(
           name: 'Sales Tax',
           code: '001',

data/test/integration/workarea/storefront/segments_integration_test.rb

@@ -271,6 +271,19 @@ module Workarea
           headers: { 'HTTP_REFERER' => 'https://www.facebook.com/' }
         assert_equal(google.id.to_s, response.headers['X-Workarea-Segments'])
       end
+
+      def test_missing_email_cookies
+        user = create_user(password: 'w0rkArea!', tags: %w(foo))
+        segment = create_segment(rules: [Segment::Rules::Tags.new(tags: %w(foo))])
+
+        post storefront.login_path,
+          params: { email: user.email, password: 'w0rkArea!' }
+
+        cookies[:email] = nil
+
+        get storefront.current_user_path(format: 'json')
+        assert_equal(segment.id.to_s, response.headers['X-Workarea-Segments'])
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workarea-storefront
 version: !ruby/object:Gem::Version
-  version: 3.5.11
+  version: 3.5.16
 platform: ruby
 authors:
 - Ben Crouse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-13 00:00:00.000000000 Z
+date: 2020-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea-core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.5.11
+        version: 3.5.16
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.5.11
+        version: 3.5.16
 description: Provides user-facing ecommerce storefront functionality for the Workarea
   Commerce Platform.
 email: