workarea-storefront 3.4.45 → 3.5.0.beta.1

data/test/integration/workarea/storefront/cart_items_integration_test.rb

@@ -47,18 +47,6 @@ module Workarea
         assert_equal(5.to_m, order.items.first.total_price)
       end
 
-      def test_fail_to_add_an_item
-        post storefront.cart_items_path,
-          params: {
-            product_id: @product.id,
-            sku: 'SKU1',
-            quantity: -1
-          }
-
-        assert_response(:success)
-        assert_empty(Order.all)
-      end
-
       def test_adding_product_with_shared_skus
         product_2 = Catalog::Product.create!(name: 'Product', variants: [{ sku: 'SKU1' }])
 

data/test/integration/workarea/storefront/categories_integration_test.rb

@@ -16,16 +16,6 @@ module Workarea
         get storefront.category_path(create_category(active: false))
         assert(response.ok?)
       end
-
-      def test_not_accepting_per_page_param
-        products = [create_product, create_product]
-        category = create_category(product_ids: products.map(&:id))
-
-        get storefront.category_path(category, page: 1, per_page: 1)
-        assert(response.ok?)
-        assert_includes(response.body, storefront.product_path(products.first))
-        assert_includes(response.body, storefront.product_path(products.second))
-      end
     end
   end
 end

data/test/integration/workarea/storefront/checkout_side_effects_integration_test.rb

@@ -74,7 +74,7 @@ module Workarea
         assert_equal('Crouse', credit_card.last_name)
         assert_equal('XXXX-XXXX-XXXX-1', credit_card.display_number)
         assert_equal(1, credit_card.month)
-        assert_equal(next_year, credit_card.year)
+        assert_equal(2020, credit_card.year)
         refute(credit_card.token.blank?)
 
         complete_checkout('bcrouse@workarea.com', 'W3bl1nc!')
@@ -151,6 +151,7 @@ module Workarea
       end
 
       def test_updating_metrics
+        create_life_cycle_segments
         create_user(email: 'bcrouse@workarea.com', password: 'W3bl1nc!')
         create_tax_category(code: '001', rates: [{ percentage: 0.06, country: 'US' }])
         create_order_total_discount(amount_type: 'percent', amount: 10)
@@ -208,6 +209,19 @@ module Workarea
         assert_equal(-1, user.discounts)
         assert_kind_of(Time, user.first_order_at)
         assert_kind_of(Time, user.last_order_at)
+        assert_equal(1, user.purchased.product_ids.size)
+
+        segment = Metrics::SegmentByDay.first
+        assert_equal(1, segment.orders)
+        assert_equal(0, segment.returning_orders)
+        assert_equal(1, segment.customers)
+        assert_equal(2, segment.units_sold)
+        assert_equal(2, segment.discounted_units_sold)
+        assert_equal(10, segment.merchandise)
+        assert_equal(-1, segment.discounts)
+        assert_equal(7, segment.shipping)
+        assert_equal(0.96, segment.tax)
+        assert_equal(16.96, segment.revenue)
       end
     end
   end

data/test/integration/workarea/storefront/checkouts_integration_test.rb

@@ -135,7 +135,6 @@ module Workarea
               phone_number: '2159251800'
             }
           }
-
         get storefront.checkout_shipping_path
         patch storefront.checkout_shipping_path
 
@@ -144,6 +143,8 @@ module Workarea
         assert_equal(1, Order.count)
         assert_equal('bcrouse@workarea.com', Order.first.email)
         assert_equal(0, Payment::Profile.count)
+        assert(cookies[:email].present?)
+        original_email_cookie = cookies[:email]
 
         get storefront.checkout_addresses_path
         patch storefront.checkout_addresses_path,
@@ -181,7 +182,7 @@ module Workarea
             credit_card: {
               number: '2',
               month:  1,
-              year:   next_year,
+              year:   2020,
               cvv:    '999'
             }
           }
@@ -193,6 +194,8 @@ module Workarea
         assert_equal(1, Payment::Profile.count)
         assert_equal('bcrouse@weblinc.com', payment_profile.email)
         assert_includes(payment_profile.reference, order.id)
+        assert(cookies[:email].present?)
+        refute_equal(original_email_cookie, cookies[:email])
       end
 
       def test_setting_traffic_referrer
@@ -223,21 +226,41 @@ module Workarea
         assert_equal('https://www.workarea.com/', order.traffic_referrer.uri)
       end
 
-      def test_no_valid_shipping_options
+      def test_saving_segment_ids
+        create_life_cycle_segments
         product = create_product
 
+        post storefront.cart_items_path,
+          params: { product_id: product.id, sku: product.skus.first }
+
+        get storefront.checkout_addresses_path
+        assert_equal(
+          [Segment::FirstTimeVisitor.instance.id],
+          Order.desc(:updated_at).first.segment_ids
+        )
+      end
+
+      def test_saving_fraud_decision
+        complete_checkout
+        order = Order.desc(:created_at).first
+
+        assert(order.fraud_decision.present?)
+        assert(order.placed?)
+        refute(order.fraud_suspected_at.present?)
+        assert(order.fraud_decided_at.present?)
+        assert_equal(:no_decision, order.fraud_decision.decision)
+
         post storefront.cart_items_path,
           params: {
             product_id: product.id,
             sku: product.skus.first,
-            quantity: 2
+            quantity: 1
           }
 
         get storefront.checkout_addresses_path
-
         patch storefront.checkout_addresses_path,
           params: {
-            email: 'bcrouse@weblinc.com',
+            email: 'decline@workarea.com',
             billing_address: {
               first_name:   'Ben',
               last_name:    'Crouse',
@@ -259,15 +282,39 @@ module Workarea
               phone_number: '2159251800'
             }
           }
+        get storefront.checkout_shipping_path
+        patch storefront.checkout_shipping_path
 
-        assert(flash[:error].present?)
+        get storefront.checkout_payment_path
+
+        patch storefront.checkout_place_order_path,
+          params: {
+            payment: 'new_card',
+            credit_card: {
+              number: '2',
+              month:  1,
+              year:   2020,
+              cvv:    '999'
+            }
+          }
+
+        order = Order.desc(:created_at).first
+
+        assert_equal(:declined, order.fraud_decision.decision)
+        assert(order.fraud_suspected_at.present?)
+        assert(order.fraud_decided_at.present?)
+        refute(order.placed?)
       end
 
-      def test_no_required_shipping_address_options_flash_message
-        product = create_product(digital: true)
+      def test_no_valid_shipping_options
+        product = create_product
 
         post storefront.cart_items_path,
-          params: { product_id: product.id, sku: product.skus.first, quantity: 1 }
+          params: {
+            product_id: product.id,
+            sku: product.skus.first,
+            quantity: 2
+          }
 
         get storefront.checkout_addresses_path
 
@@ -283,10 +330,20 @@ module Workarea
               postal_code:  '19106',
               country:      'US',
               phone_number: '2159251800'
+            },
+            shipping_address: {
+              first_name:   'Ben',
+              last_name:    'Crouse',
+              street:       '22 S. 3rd St.',
+              city:         'Philadelphia',
+              region:       'PA',
+              postal_code:  '19106',
+              country:      'US',
+              phone_number: '2159251800'
             }
           }
 
-        refute(flash[:error].present?)
+        assert(flash[:error].present?)
       end
     end
   end

data/test/integration/workarea/storefront/contact_form_integration_test.rb

@@ -4,29 +4,27 @@ module Workarea
   module Storefront
     class ContactFormIntegrationTest < Workarea::IntegrationTest
       def test_inquiry_creation
-        Workarea.with_config do |config|
-          config.email_to = 'test@workarea.com'
+        Workarea.config.email_to = 'test@workarea.com'
 
-          post storefront.contact_path,
-            params: {
-              name: 'Ben Crouse',
-              email: 'bcrouse@workarea.com',
-              subject: 'orders',
-              order_id: 'ORDER123',
-              message: 'test message'
-            }
+        post storefront.contact_path,
+          params: {
+            name: 'Ben Crouse',
+            email: 'bcrouse@workarea.com',
+            subject: 'orders',
+            order_id: 'ORDER123',
+            message: 'test message'
+          }
 
-          result = Inquiry.first
-          assert_equal('Ben Crouse', result.name)
-          assert_equal('bcrouse@workarea.com', result.email)
-          assert(result.subject.present?)
-          assert_equal('ORDER123', result.order_id)
-          assert_equal('test message', result.message)
+        result = Inquiry.first
+        assert_equal('Ben Crouse', result.name)
+        assert_equal('bcrouse@workarea.com', result.email)
+        assert(result.subject.present?)
+        assert_equal('ORDER123', result.order_id)
+        assert_equal('test message', result.message)
 
-          last_email = ActionMailer::Base.deliveries.last
-          assert_includes(last_email.subject, 'Orders')
-          assert_includes(last_email.to, Workarea.config.email_to)
-        end
+        last_email = ActionMailer::Base.deliveries.last
+        assert_includes(last_email.subject, 'Orders')
+        assert_includes(last_email.to, Workarea.config.email_to)
       end
     end
   end

data/test/integration/workarea/storefront/content_blocks_integration_test.rb

@@ -59,10 +59,7 @@ module Workarea
         )
         content.save!
 
-        draft = Content::BlockDraft.create!(
-          block.attributes.merge('content_id' => content.id)
-        )
-
+        draft = block.to_draft.tap(&:save!)
         get storefront.draft_content_block_path(draft)
         assert(response.ok?)
       end

data/test/integration/workarea/storefront/current_checkout_integration_test.rb

@@ -4,26 +4,77 @@ module Workarea
   module Storefront
     class CurrentCheckoutIntegrationTest < Workarea::IntegrationTest
       class CurrentCheckoutController < Storefront::ApplicationController
+        before_action :require_login, only: :logged_in
+
         def test
           current_order.save if params[:save]
           head :ok
         end
+
+        def test_login
+          login(User.find(params[:user_id]))
+          self.current_order = Order.new(id: params[:order_id]) if params[:order_id].present?
+          head :ok
+        end
+
+        def logged_in
+          head :ok
+        end
+
+        def test_logout
+          logout
+          head :ok
+        end
       end
 
       setup do
         Rails.application.routes.prepend do
           get 'current_checkout_test', to: "#{CurrentCheckoutController.controller_path}#test"
+          get 'current_checkout_test_login', to: "#{CurrentCheckoutController.controller_path}#test_login"
+          get 'current_checkout_test_logout', to: "#{CurrentCheckoutController.controller_path}#test_logout"
+          get 'current_checkout_test_login_required', to: "#{CurrentCheckoutController.controller_path}#logged_in"
         end
 
         Rails.application.reload_routes!
+
+        @user = create_user
       end
 
       def test_current_order
         get '/current_checkout_test'
-        assert(session[:order_id].blank?)
+        assert(cookies[:order_id].blank?)
+
+        get '/current_checkout_test', params: { save: true }
+        assert(cookies[:order_id].present?)
+      end
+
+      def test_clearing_current_order
+        get '/current_checkout_test_login', params: { user_id: @user.id, order_id: 'foo' }
+        assert(cookies[:order_id].present?)
 
+        get '/current_checkout_test_logout'
+        assert(cookies[:order_id].blank?)
+      end
+
+      def test_require_login_does_not_clear_current_order
         get '/current_checkout_test', params: { save: true }
-        assert(session[:order_id].present?)
+        assert(cookies[:order_id].present?)
+
+        assert_no_changes 'cookies[:order_id]' do
+          get '/current_checkout_test_login_required'
+        end
+      end
+
+      def test_ip_address_changing_clears_current_order
+        get '/current_checkout_test_login', params: { user_id: @user.id, order_id: 'foo' }
+
+        get '/current_checkout_test_login_required'
+        assert(cookies[:order_id].present?)
+
+        @user.update!(ip_address: '192.168.0.1')
+
+        get '/current_checkout_test_login_required'
+        assert(cookies[:order_id].blank?)
       end
     end
   end

data/test/integration/workarea/storefront/downloads_integration_test.rb

@@ -0,0 +1,38 @@
+require 'test_helper'
+
+module Workarea
+  module Storefront
+    class DownloadsIntegrationTest < Workarea::IntegrationTest
+      def test_show
+        token = create_fulfillment_token(sku: 'SKU1')
+        sku = create_fulfillment_sku(id: 'SKU1', policy: :download, file: product_image_file)
+
+        get storefront.download_path(token)
+        assert(response.ok?)
+        assert_equal(1, token.reload.downloads)
+
+        token.update!(enabled: false)
+
+        get storefront.download_path(token)
+        assert_redirected_to(storefront.root_path)
+        assert(flash[:info].present?)
+        assert_equal(1, token.reload.downloads)
+
+        token.update!(enabled: true)
+        sku.update!(policy: 'ignore')
+
+        get storefront.download_path(token)
+        assert_redirected_to(storefront.root_path)
+        assert(flash[:info].present?)
+        assert_equal(1, token.reload.downloads)
+
+        sku.destroy!
+
+        get storefront.download_path(token)
+        assert_redirected_to(storefront.root_path)
+        assert(flash[:info].present?)
+        assert_equal(1, token.reload.downloads)
+      end
+    end
+  end
+end

data/test/integration/workarea/storefront/email_signups_integration_test.rb

@@ -8,6 +8,7 @@ module Workarea
           params: { email: 'bcrouse@workarea.com' }
 
         assert_redirected_to(storefront.root_path)
+        assert(cookies[:email].present?)
         assert(flash[:success].present?)
         assert_equal(1, Email::Signup.where(email: 'bcrouse@workarea.com').count)
       end
@@ -17,6 +18,7 @@ module Workarea
           params: { email: 'bcrouse@workarea' }
 
         assert_redirected_to(storefront.root_path)
+        assert(cookies[:email].blank?)
         assert(flash[:error].present?)
         assert_equal(0, Email::Signup.count)
       end

data/test/integration/workarea/storefront/guest_browsing_integration_test.rb

@@ -16,8 +16,8 @@ module Workarea
         complete_checkout
         order = Order.placed.first
         assert_nil(order.user_id)
-        assert('admin', order.source)
-        assert(order.checkout_by_id, admin_user.id.to_s)
+        assert_equal('admin', order.source)
+        assert_equal(order.checkout_by_id, admin_user.id.to_s)
       end
     end
   end

data/test/integration/workarea/storefront/impersonations_integration_test.rb

@@ -69,7 +69,7 @@ module Workarea
             credit_card: {
               number: '1',
               month: 1,
-              year: next_year,
+              year: 2020,
               cvv: '999'
             }
           }
@@ -101,7 +101,7 @@ module Workarea
           }
 
         # simulate expiration of admin session.
-        cookies.delete('user_id')
+        reset!
 
         # Cart should be empty now that admin is logged out
         get storefront.checkout_path