workarea-forter 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ca3dfe4d3b7803e1d9c76644c4df4f50b6dea205349b220d38f010160970fda6
-  data.tar.gz: b562e2893713a08e9ebc878f55cf7a503b8702c1377627a5cab3ab6e3aaed9d7
+  metadata.gz: e6c4f679107573bc38a3e4a2ec421d83e53a85907082c678ff47553c4b3f9785
+  data.tar.gz: 1aa0edd84330d5b6fee488117362f134f38b2e2763951585cfc36ce1de1c810d
 SHA512:
-  metadata.gz: 831c1bc85896e8ff76b8b3b53c0566081c0aba02af58dc3153490489d282a3c37a93e170d6d62b04edf10e302ec209092d4067f13891404c346ed3ac9706505c
-  data.tar.gz: c705e20608fdd0046ffc269e094725971f0ad28ae93a7caf79a7b4d47eba85e25addf41f37ac4a576a57885cd26224016151c73ccde9344aba8bcc9516c4e965
+  metadata.gz: 2813c8e8aad7976352238666d8aeccb569e443f946f726ae0d2281c3346602940449613ac1b311da9fd3d8ac86e2420eaaf488c67fdee5ffecfcdc376ad88835
+  data.tar.gz: 877214170590717f90ac8ada8d3db7f57c84be2a62842f156cdfcbb2d7fcc26a6ca1e767a6adddaf72e85f2872c8cff9b5afa799923cc8b9b853d501628fa377

data/.gitignore

@@ -15,3 +15,4 @@ node_modules
 coverage/
 package.json
 yarn.lock
+.rubocop-http*

data/CHANGELOG.md

@@ -1,3 +1,25 @@
+Workarea Forter 1.2.4 (2019-10-16)
+--------------------------------------------------------------------------------
+
+*   Set default Forter API version to 2.3
+
+    API version 2.3 allows for the general payment option, which
+    allows users to pass payment types that are not explicitly supported
+    by Forter.
+    Jeff Yucis
+
+*   Add additional data to forter credit card tender data.
+
+    Adds the gateway name and transaction ID to the credit card
+    information sent to forter when making a decision.
+    Jeff Yucis
+
+*   Update README
+
+    Matt Duffy
+
+
+
 Workarea Forter 1.2.3 (2019-09-17)
 --------------------------------------------------------------------------------
 

data/Gemfile

@@ -3,7 +3,8 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gemspec
 
-gem 'workarea'
+gem 'workarea', github: 'workarea-commerce/workarea', branch: 'v3.4-stable'
+
 gem 'byebug'
 group :test do
   gem 'simplecov', require: false

data/README.md

@@ -20,6 +20,24 @@ This plugin is compatible with following Workarea supported payment types:
 
 Payment types not in this list will still function but are not eligible for fraud protection.
 
+Getting Started
+--------------------------------------------------------------------------------
+
+Add the gem to your application's Gemfile:
+
+```ruby
+# ...
+gem 'workarea-forter'
+# ...
+```
+
+Update your application's bundle.
+
+```bash
+cd path/to/application
+bundle
+```
+
 Configuration
 --------------------------------------------------------------------------------
 Add the secret key to your secrets file:
@@ -43,6 +61,12 @@ You can specify which version of the API via configuration:
 
 If no API version is configured the default of **2.2** will be used.
 
+Setting a configuration value for ```credit_card_gateway_name``` value will improve the decision accuracy. This is the name of the credit card processor used by the host application.
+
+```ruby
+  Workarea.config.forter.credit_card_gateway_name = "Stripe"
+```
+
 Implementation Notes
 --------------------------------------------------------------------------------
 **Verifcation Data**
@@ -64,50 +88,12 @@ Be sure to test that the following data is sent in the **verificationResults**
 
 Credit card authorizations are voided when a transaction is deemed to be fraudulent. The void action relies on the #cancel! method implemented on each tenders authorization class. It is very important to implement and test this method when creating a new payment type.
 
-
-Getting Started
+Workarea Commerce Documentation
 --------------------------------------------------------------------------------
 
-This gem contains a rails engine that must be mounted onto a host Rails application.
+See [https://developer.workarea.com](https://developer.workarea.com) for Workarea Commerce documentation.
 
-To access Workarea gems and source code, you must be an employee of WebLinc or a licensed retailer or partner.
-
-Workarea gems are hosted privately at https://gems.weblinc.com/.
-You must have individual or team credentials to install gems from this server. Add your gems server credentials to Bundler:
-
-    bundle config gems.weblinc.com my_username:my_password
-
-Or set the appropriate environment variable in a shell startup file:
-
-    export BUNDLE_GEMS__WEBLINC__COM='my_username:my_password'
-
-Then add the gem to your application's Gemfile specifying the source:
-
-    # ...
-    gem 'workarea-forter', source: 'https://gems.weblinc.com'
-    # ...
-
-Or use a source block:
-
-    # ...
-    source 'https://gems.weblinc.com' do
-      gem 'workarea-forter'
-    end
-    # ...
-
-Update your application's bundle.
-
-    cd path/to/application
-    bundle
-
-Workarea Platform Documentation
+License
 --------------------------------------------------------------------------------
 
-See [http://developer.weblinc.com](http://developer.weblinc.com) for Workarea platform documentation.
-
-Copyright & Licensing
---------------------------------------------------------------------------------
-
-Copyright WebLinc 2018. All rights reserved.
-
-For licensing, contact sales@workarea.com.
+Workarea Forter is released under the [Business Software License](LICENSE)

data/Rakefile

@@ -34,10 +34,10 @@ desc "Release version #{Workarea::Forter::VERSION} of the gem"
 task :release do
   host = "https://#{ENV['BUNDLE_GEMS__WEBLINC__COM']}@gems.weblinc.com"
 
-  #Rake::Task['workarea:changelog'].execute
-  #system 'git add CHANGELOG.md'
-  #system 'git commit -m "Update CHANGELOG"'
-  #system 'git push origin HEAD'
+  Rake::Task['workarea:changelog'].execute
+  system 'git add CHANGELOG.md'
+  system 'git commit -m "Update CHANGELOG"'
+  system 'git push origin HEAD'
 
   system "git tag -a v#{Workarea::Forter::VERSION} -m 'Tagging #{Workarea::Forter::VERSION}'"
   system 'git push --tags'

data/app/services/workarea/forter/tender/credit_card.rb

@@ -19,7 +19,8 @@ module Workarea
               expirationMonth: cc_month(tender.month),
               expirationYear: tender.year.to_s,
               cardBrand: tender.issuer,
-              nameOnCard: "#{address.first_name} #{address.last_name}"
+              nameOnCard: "#{address.first_name} #{address.last_name}",
+              paymentGatewayData: payment_gateway_data
             }.merge!(verification_results)
           }
         end
@@ -67,6 +68,15 @@ module Workarea
             gateway_class = Workarea.config.gateways.credit_card.class.to_s
             Workarea.config.forter.response_code[gateway_class].call(transaction) rescue nil
           end
+
+          def payment_gateway_data
+            return unless tender.transactions.present? && transaction.present?
+
+            {
+              gatewayName: Workarea::Forter.config.credit_card_gateway_name || "not specified",
+              gatewayTransactionId: transaction.response.authorization.to_s
+            }
+          end
       end
     end
   end

data/config/initializers/workarea.rb

@@ -5,11 +5,13 @@ Workarea.configure do |config|
   config.forter = ActiveSupport::Configurable::Configuration.new
   config.forter.site_id = nil
 
-  config.forter.api_version = "2.2"
+  config.forter.api_version = "2.3"
 
   config.forter.api_timeout = 2
   config.forter.open_timeout = 2
 
+  config.forter.credit_card_gateway_name = nil # name of payment gateway used, ie. Stripe
+
   config.forter.response_code = {
     'ActiveMerchant::Billing::StripeGateway' => -> (transaction) { transaction.params['failure_code'] },
     'ActiveMerchant::Billing::BraintreeBlueGateway' => -> (transaction) { transaction.response.params["braintree_transaction"]["processor_response_code"] },

data/lib/workarea/forter/version.rb

@@ -1,5 +1,5 @@
 module Workarea
   module Forter
-    VERSION = "1.2.3"
+    VERSION = "1.2.4"
   end
 end

data/test/services/workarea/forter/order_test.rb

@@ -4,36 +4,43 @@ module Workarea
   module Foter
     class OrderTest < Workarea::TestCase
       def test_to_h
-        user = create_user(id: 'u-1234', first_name: 'jeffy', last_name: 'tester')
-        order = create_placed_forter_order(overrides = { id: '1234', user_id: user.id })
-        hsh = Forter::Order.new(order).to_h
+         Workarea.with_config do |config|
+          config.forter.credit_card_gateway_name = "cc_processor"
 
-        payment = Workarea::Payment.find('1234')
-        shipping = Workarea::Shipping.find_by_order('1234')
+          user = create_user(id: 'u-1234', first_name: 'jeffy', last_name: 'tester')
+          order = create_placed_forter_order(overrides = { id: '1234', user_id: user.id })
+          hsh = Forter::Order.new(order).to_h
+
+          payment = Workarea::Payment.find('1234')
+          shipping = Workarea::Shipping.find_by_order('1234')
+
+          assert_equal(order.id, hsh[:orderId])
+          assert_equal("WEB", hsh[:orderType])
 
-        assert_equal(order.id, hsh[:orderId])
-        assert_equal("WEB", hsh[:orderType])
+          assert_equal(payment.address.first_name, hsh[:primaryRecipient][:personalDetails][:firstName])
+          assert_equal(payment.address.last_name, hsh[:primaryRecipient][:personalDetails][:lastName])
 
-        assert_equal(payment.address.first_name, hsh[:primaryRecipient][:personalDetails][:firstName])
-        assert_equal(payment.address.last_name, hsh[:primaryRecipient][:personalDetails][:lastName])
+          assert_equal(shipping.address.street, hsh[:primaryRecipient][:address][:address1])
+          assert_equal(shipping.address.city, hsh[:primaryRecipient][:address][:city])
+          assert_equal(shipping.address.country.alpha2, hsh[:primaryRecipient][:address][:country])
 
-        assert_equal(shipping.address.street, hsh[:primaryRecipient][:address][:address1])
-        assert_equal(shipping.address.city, hsh[:primaryRecipient][:address][:city])
-        assert_equal(shipping.address.country.alpha2, hsh[:primaryRecipient][:address][:country])
+          assert_equal(order.total_price.to_s, hsh[:totalAmount][:amountUSD])
 
-        assert_equal(order.total_price.to_s, hsh[:totalAmount][:amountUSD])
+          assert_equal(1, hsh[:cartItems].size)
 
-        assert_equal(1, hsh[:cartItems].size)
+          assert_equal(1, hsh[:payment].size)
+          assert_equal(order.total_price.to_s, hsh[:payment].first[:amount][:amountUSD])
 
-        assert_equal(1, hsh[:payment].size)
-        assert_equal(order.total_price.to_s, hsh[:payment].first[:amount][:amountUSD])
+          assert_equal("cc_processor", hsh[:payment].first[:creditCard][:paymentGatewayData][:gatewayName])
+          assert(hsh[:payment].first[:creditCard][:paymentGatewayData][:gatewayTransactionId].present?)
 
-        assert_equal(user.first_name, hsh[:accountOwner][:firstName])
-        assert_equal(user.last_name, hsh[:accountOwner][:lastName])
-        assert_equal(user.email, hsh[:accountOwner][:email])
-        assert_equal(user.id, hsh[:accountOwner][:accountId])
+          assert_equal(user.first_name, hsh[:accountOwner][:firstName])
+          assert_equal(user.last_name, hsh[:accountOwner][:lastName])
+          assert_equal(user.email, hsh[:accountOwner][:email])
+          assert_equal(user.id, hsh[:accountOwner][:accountId])
 
-        assert_equal("123ABC", hsh[:connectionInformation][:forterTokenCookie])
+          assert_equal("123ABC", hsh[:connectionInformation][:forterTokenCookie])
+        end
       end
 
       def test_to_h_with_no_shipping_address

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workarea-forter
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Jeff Yucis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-17 00:00:00.000000000 Z
+date: 2019-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea