workarea-core 3.5.9 → 3.5.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 277c3f21e9ad08940c1f72830fd89f066987b104d019cb45b670774dc31b91e2
-  data.tar.gz: a256669db5f584453ad3103365446f5cb885bfa55bae6b68240b07782775b8aa
+  metadata.gz: 32f457800d2f9e59fb315b3bdedde57f90d04ea6befdd4cf04dc5b4c78838eaf
+  data.tar.gz: 564f64759f19ea4d0db9b1ea4b7a2c12cdebf629ea2f52b5916519a3c958d611
 SHA512:
-  metadata.gz: 97608d2f8240e4e21862d986599f8a6cbe4f5e461dc0bbb027203fff9d36b2d74f6477f27a9a652a893690146cfcaac3347bd0e263084f85af6438649d4a9c52
-  data.tar.gz: 2affa2d8c642e5f47f690d29ccf01629efaaa41f2963d1b16b9a02a3e690ceb57a22447f0e9ebbf7552973de4b817f6d6f80154a76cca01bc8065e6bfa5620ed
+  metadata.gz: 6ae82b803bfe0daffc1e54953aa54f0c3a045cbe83fbb7b2e0c3d68961746950f442f7d87bee7c6b31c4fb697f685b0db3aa5277b0e6b430e6adabfbab4d9837
+  data.tar.gz: '094e9624ee3213c17dc554e263dc79538c5c09d2db4868d0f1aaa827db8559e60e46728c171364db364d2ff323f6100e0b2edaeea5746a4f59a73cbc51b16832'

data/app/models/workarea/bulk_action/product_edit.rb

@@ -36,15 +36,15 @@ module Workarea
       end
 
       def apply_details!(product)
-        HashUpdate
-          .new(adds: add_details, removes: remove_details)
-          .apply(product.details)
+        product.details = HashUpdate
+          .new(original: product.details, adds: add_details, removes: remove_details)
+          .result
       end
 
       def apply_filters!(product)
-        HashUpdate
-          .new(adds: add_filters, removes: remove_filters)
-          .apply(product.filters)
+        product.filters = HashUpdate
+          .new(original: product.filters, adds: add_filters, removes: remove_filters)
+          .result
       end
 
       def apply_pricing!(product)

data/app/models/workarea/order.rb

@@ -47,13 +47,13 @@ module Workarea
       {
         placed_at: 1,
         reminded_at: 1,
+        fraud_suspected_at: 1,
         checkout_started_at: 1,
         email: 1,
-        "items[0]._id": 1,
-        fraud_suspected_at: 1
+        "items[0]._id": 1
       },
       {
-        name: 'abandoned_order_email_index',
+        name: 'abandoned_order_email_with_fraud_index_v2',
         background: true
       }
     )

data/app/models/workarea/releasable.rb

@@ -72,7 +72,9 @@ module Workarea
         release.preview.changesets_for(self).each { |cs| cs.apply_to(result) }
         result
       else
-        Release.with_current(release) { self.class.find(id) }
+        Release.with_current(release) do
+          Mongoid::QueryCache.uncached { self.class.find(id) }
+        end
       end
     end
 

data/app/models/workarea/release/changeset.rb

@@ -18,6 +18,7 @@ module Workarea
       index({ 'document_path.type' => 1, 'document_path.document_id' => 1 })
       index('changeset.product_ids' => 1)
       index('original.product_ids' => 1)
+      index('releasable_type' => 1, 'releasable_id' => 1)
 
       # Finds changeset by whether the passed document is in the document
       # path of the changeset. Useful for showing embedded changes in the

data/app/models/workarea/search/admin/pricing_discount.rb

@@ -21,7 +21,7 @@ module Workarea
         end
 
         def keywords
-          super + model.promo_codes
+          super + Array.wrap(model.try(:promo_codes))
         end
 
         def facets

data/app/models/workarea/search/storefront.rb

@@ -82,6 +82,14 @@ module Workarea
         @changesets ||= Array.wrap(model.try(:changesets_with_children))
       end
 
+      def releases
+        changesets
+          .uniq(&:release)
+          .reject { |cs| cs.release.blank? }
+          .flat_map { |cs| [cs.release] + cs.release.scheduled_after }
+          .uniq
+      end
+
       def as_document
         Release.with_current(release_id) do
           {
@@ -91,7 +99,7 @@ module Workarea
             active: active,
             active_segment_ids: active_segment_ids,
             release_id: release_id,
-            changeset_release_ids: changesets.map(&:release_id),
+            changeset_release_ids: releases.map(&:id),
             suggestion_content: suggestion_content,
             created_at: model.created_at,
             updated_at: model.updated_at,

data/app/models/workarea/search/storefront/category_query.rb

@@ -144,7 +144,7 @@ module Workarea
             .where(releasable_type: ProductRule.name)
             .any_in(releasable_id: category.product_rules.map(&:id))
             .includes(:release)
-            .to_a
+            .select(&:release)
         end
       end
     end

data/app/models/workarea/search/storefront/product.rb

@@ -122,12 +122,21 @@ module Workarea
           ProductPrimaryImageUrl.new(model).path
         end
 
-        # Override to include release changesets for pricing, featured products, etc.
+        # All {Releasable}s that could affect the product's Elasticsearch document
+        # should add their changesets to this method.
+        #
+        # @example Add to the changesets affecting a product in a decorator
+        #   def changesets
+        #     super.merge(SomeReleasable.for_product(product.id).changesets_with_children)
+        #   end
         #
         # @return [Mongoid::Criteria]
         #
         def changesets
-          @product_changesets ||= ProductReleases.new(model).changesets
+          criteria = model.changesets_with_children
+          pricing.each { |ps| criteria.merge!(ps.changesets_with_children) }
+          criteria.merge!(FeaturedProducts.changesets(model.id))
+          criteria.includes(:release)
         end
 
         private

data/app/queries/workarea/product_releases.rb

@@ -1,4 +1,10 @@
 module Workarea
+  #
+  # TODO remove in v3.6
+  #
+  # This is no longer used, this logic was moved into the search models to allow
+  # it to be used for any model (not just products).
+  #
   class ProductReleases
     attr_reader :product
 

data/app/queries/workarea/search/pagination.rb

@@ -7,7 +7,10 @@ module Workarea
       end
 
       def per_page
-        params[:per_page].presence || Workarea.config.per_page
+        return Workarea.config.per_page if params[:per_page].blank?
+
+        tmp = params[:per_page].to_i
+        tmp > 0 ? tmp : Workarea.config.per_page
       end
 
       def size

data/app/queries/workarea/search/storefront_search.rb

@@ -4,7 +4,7 @@ module Workarea
       attr_reader :params
 
       def initialize(params)
-        @params = params
+        @params = params.with_indifferent_access.except(:per_page)
         @used_middleware = []
       end
 

data/app/services/workarea/direct_upload.rb

@@ -6,22 +6,26 @@ module Workarea
       uri = URI.parse(request_url)
       url = "#{uri.scheme}://#{uri.host}"
       url += ":#{uri.port}" unless uri.port.in? [80, 443]
+      id = "direct_upload_#{url}"
 
-      redis_key = "cors_#{url.optionize}"
-      return if Workarea.redis.get(redis_key) == 'true'
+      response = begin
+        Workarea.s3.get_bucket_cors(Configuration::S3.bucket)
+      rescue Excon::Error::NotFound
+        Excon::Response.new(body: { 'CORSConfiguration' => [] })
+      end
 
-      response = Workarea.s3.get_bucket_cors(Configuration::S3.bucket)
       cors = response.data[:body]
-      cors['CORSConfiguration'] << {
-        'ID' => "direct_upload_#{url}",
-        'AllowedMethod' => 'PUT',
-        'AllowedOrigin' => url,
-        'AllowedHeader' => '*'
-      }
-      cors['CORSConfiguration'].uniq!
-
-      Workarea.s3.put_bucket_cors(Configuration::S3.bucket, cors)
-      Workarea.redis.set(redis_key, 'true')
+
+      unless cors['CORSConfiguration'].pluck('ID').include?(id)
+        cors['CORSConfiguration'] << {
+          'ID' => id,
+          'AllowedMethod' => 'PUT',
+          'AllowedOrigin' => url,
+          'AllowedHeader' => '*'
+        }
+
+        Workarea.s3.put_bucket_cors(Configuration::S3.bucket, cors)
+      end
     end
 
     attr_reader :type, :filename

data/app/services/workarea/hash_update.rb

@@ -5,13 +5,27 @@ module Workarea
       parsed.map(&:to_s).map(&:strip).reject(&:blank?) if parsed.present?
     end
 
-    def initialize(adds: [], updates: [], removes: [])
+    def initialize(original: {}, adds: [], updates: [], removes: [])
+      @original = original
       @adds = Array(adds).flatten.each_slice(2).to_a
       @updates = Array(updates).flatten.each_slice(2).to_a
       @removes = Array(removes).flatten
     end
 
+    def result
+      apply_to(@original.deep_dup)
+    end
+
+    # TODO v3.6 remove this method, doesn't work when the field is localized
+    # @deprecated
     def apply(hash)
+      Workarea.deprecation.deprecate_methods(self.class, apply: :result)
+      apply_to(hash)
+    end
+
+    private
+
+    def apply_to(hash)
       @adds.each do |tuple|
         key, value = *tuple
         hash[key] = self.class.parse_values(value)

data/app/services/workarea/index_release_schedule_previews.rb

@@ -0,0 +1,37 @@
+module Workarea
+  class IndexReleaseSchedulePreviews
+    attr_reader :release, :starts_at, :ends_at
+
+    def initialize(release: nil, starts_at: nil, ends_at: nil)
+      @release = release
+      @starts_at = starts_at
+      @ends_at = ends_at
+    end
+
+    def affected_releases
+      result = Release
+        .scheduled(after: starts_at, before: ends_at)
+        .includes(:changesets)
+        .to_a
+
+      result << release if release.present?
+      result.uniq
+    end
+
+    def affected_models
+      affected_releases.flat_map(&:changesets).flat_map(&:releasable).compact
+    end
+
+    def perform
+      affected_releases.each do |release|
+        affected_models.each do |releasable|
+          Search::Storefront.new(releasable.in_release(release)).destroy
+
+          # Different models have different indexing workers, running callbacks
+          # ensures the appropriate worker is triggered
+          releasable.run_callbacks(:save_release_changes)
+        end
+      end
+    end
+  end
+end

data/app/workers/workarea/index_category_changes.rb

@@ -4,16 +4,29 @@ module Workarea
     include Sidekiq::CallbacksWorker
 
     sidekiq_options(
-      enqueue_on: { Catalog::Category => [:save, :save_release_changes], with: -> { [changes] } },
+      enqueue_on: {
+        Catalog::Category => [:save, :save_release_changes],
+        with: -> { [changes, Release.current.present?] }
+      },
       ignore_if: -> { changes['product_ids'].blank? },
       lock: :until_executing,
       query_cache: true
     )
 
-    def perform(changes)
+    def perform(changes, for_release = false)
       return unless changes['product_ids'].present?
 
-      ids = require_index_ids(*changes['product_ids'])
+      ids = if for_release
+        # This is a shortcut because if you're resorting products within a release,
+        # the `changes` hash doesn't reflect the repositioning within the release,
+        # only the difference between what's live and what's in the release.
+        #
+        # Reindexing all of them is a shortcut to having to manually build a diff
+        # between the changesets in the possible affected releases.
+        changes['product_ids'].flatten.uniq
+      else
+        require_index_ids(*changes['product_ids'])
+      end
 
       if ids.size > max_count
         ids.each { |id| IndexProduct.perform_async(id) }

data/app/workers/workarea/index_release_schedule_change.rb

@@ -0,0 +1,32 @@
+module Workarea
+  class IndexReleaseScheduleChange
+    include Sidekiq::Worker
+    include Sidekiq::CallbacksWorker
+
+    sidekiq_options(
+      enqueue_on: {
+        Release => [:save, :destroy],
+        only_if: -> { publish_at_changed? || destroyed? },
+        with: -> { [id, publish_at_was, publish_at] }
+      },
+      queue: 'releases'
+    )
+
+    def perform(id, previous_publish_at, new_publish_at)
+      # When destroyed, changesets for the release ID will still exist and be used to update the index
+      rescheduled_release = Release.find_or_initialize_by(id: id)
+
+      earlier, later = if rescheduled_release.persisted? && previous_publish_at.present? && new_publish_at.present?
+        [previous_publish_at, new_publish_at].sort
+      elsif previous_publish_at.present?
+        [previous_publish_at, nil]
+      else
+        [new_publish_at, nil]
+      end
+
+      IndexReleaseSchedulePreviews
+        .new(release: rescheduled_release, starts_at: earlier, ends_at: later)
+        .perform
+    end
+  end
+end

data/app/workers/workarea/process_import.rb

@@ -17,11 +17,11 @@ module Workarea
       import.process!
 
     ensure
-      if import.error?
+      if import&.error?
         Admin::DataFileMailer.import_error(id).deliver_now
-      elsif import.failure?
+      elsif import&.failure?
         Admin::DataFileMailer.import_failure(id).deliver_now
-      else
+      elsif import.present?
         Admin::DataFileMailer.import(id).deliver_now
       end
     end

data/app/workers/workarea/publish_release.rb

@@ -8,6 +8,7 @@ module Workarea
       system_user = User.find_system_user!(release.name, 'Release')
 
       Mongoid::AuditLog.record(system_user) { release.publish! }
+      IndexReleaseSchedulePreviews.new(release: release).perform
 
     rescue Mongoid::Errors::DocumentNotFound
       # Doesn't matter, release has been removed

data/lib/tasks/search.rake

@@ -16,7 +16,9 @@ namespace :workarea do
     task admin: :environment do
       setup
       puts 'Indexing admin...'
-      Workarea::Search::Admin.reset_indexes!
+      Workarea::QueuesPauser.with_paused_queues do
+        Workarea::Search::Admin.reset_indexes!
+      end
 
       Mongoid.models.each do |klass|
         next unless Workarea::Search::Admin.for(klass.first).present?
@@ -36,8 +38,10 @@ namespace :workarea do
       setup
       puts 'Indexing storefront...'
 
-      Workarea::Search::Storefront.reset_indexes!
-      Workarea::Search::Storefront.ensure_dynamic_mappings
+      Workarea::QueuesPauser.with_paused_queues do
+        Workarea::Search::Storefront.reset_indexes!
+        Workarea::Search::Storefront.ensure_dynamic_mappings
+      end
 
       # This code finds all unique filters for products so we can index a sample
       # product for each to ensure the dynamic mappings get created.
@@ -83,7 +87,9 @@ namespace :workarea do
       setup
       puts 'Indexing help...'
 
-      Workarea::Search::Help.reset_indexes!
+      Workarea::QueuesPauser.with_paused_queues do
+        Workarea::Search::Help.reset_indexes!
+      end
 
       Workarea::Help::Article.all.each_by(Workarea.config.bulk_index_batch_size) do |help_article|
         Workarea::Search::Help.new(help_article).save

data/lib/workarea/changelog.rake

@@ -67,7 +67,7 @@ namespace :workarea do
           message << "    #{line.strip}"
         end
       end
-      message << "    #{entry[:author]}\n"
+      message << "\n    #{entry[:author]}\n"
     end
 
     # ensure and append to changelog

data/lib/workarea/core.rb

@@ -132,6 +132,7 @@ require 'workarea/ext/freedom_patches/active_support_duration'
 require 'workarea/ext/freedom_patches/premailer'
 require 'workarea/ext/freedom_patches/referer_parser'
 require 'workarea/ext/freedom_patches/mongoid_localized_defaults'
+require 'workarea/ext/freedom_patches/i18n_js'
 require 'workarea/ext/mongoid/list_field'
 require 'workarea/ext/mongoid/each_by'
 require 'workarea/ext/mongoid/except'
@@ -220,6 +221,7 @@ require 'workarea/mail_interceptor'
 require 'workarea/visit'
 require 'workarea/warnings'
 require 'workarea/latest_version'
+require 'workarea/queues_pauser'
 
 #
 # Engines

data/lib/workarea/ext/freedom_patches/i18n_js.rb

@@ -0,0 +1,27 @@
+module I18n
+  module JS
+    class FallbackLocales
+      # i18n-js uses just the second part of this check out-of-the-box. This
+      # causes the I18n fallbacks to get autoloaded without the developer
+      # knowing.
+      #
+      # This surfaces in tests. System or integration tests will do this check
+      # for compiling assets, then I18n fallbacks get autoloaded. So this shows
+      # as some tests not having fallbacks if they run before one of those tests
+      # or magically having fallbacks if they run after one of those types of
+      # tests.
+      #
+      # Adding the `respond_to?` check doesn't cause autoload, but will return
+      # `true` if fallbacks are enabled. Retain the original check because we
+      # want the current I18n::JS backend to be checked, once fallbacks are
+      # `require`d `I18n.respond_to?(:fallbacks)` will always return `true`.
+      #
+      # See also: https://github.com/fnando/i18n-js/blob/master/lib/i18n/js/fallback_locales.rb#L49-L58
+      #
+      def using_i18n_fallbacks_module?
+        I18n.respond_to?(:fallbacks) &&
+          I18n::JS.backend.class.included_modules.include?(I18n::Backend::Fallbacks)
+      end
+    end
+  end
+end

data/lib/workarea/queues_pauser.rb

@@ -0,0 +1,26 @@
+module Workarea
+  module QueuesPauser
+    extend self
+
+    def pause_queues!
+      pauser = Sidekiq::Throttled::QueuesPauser.instance
+      queues.each { |queue| pauser.pause!(queue) }
+    end
+
+    def resume_queues!
+      pauser = Sidekiq::Throttled::QueuesPauser.instance
+      queues.each { |queue| pauser.resume!(queue) }
+    end
+
+    def with_paused_queues(&block)
+      pause_queues!
+      yield
+    ensure
+      resume_queues!
+    end
+
+    def queues
+      Configuration::Sidekiq.queues
+    end
+  end
+end

data/lib/workarea/version.rb

@@ -2,7 +2,7 @@ module Workarea
   module VERSION
     MAJOR = 3
     MINOR = 5
-    PATCH = 9
+    PATCH = 14
     PRE   = nil
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join('.')
 

data/lib/workarea/visit.rb

@@ -38,7 +38,10 @@ module Workarea
     end
 
     def current_email
-      cookies.signed[:email]
+      # For performance, prefer to use the cookie. The fallback to looking it up
+      # by user is a failsafe against a blank email cookie (e.g. from a raised
+      # error or poor application coding).
+      cookies.signed[:email].presence || (email_from_user_id if logged_in?)
     end
 
     def metrics
@@ -91,5 +94,9 @@ module Workarea
     def blank_metrics
       @blank_metrics ||= Metrics::User.new
     end
+
+    def email_from_user_id
+      User.find(session[:user_id]).email rescue nil
+    end
   end
 end

data/lib/workarea/warnings.rb

@@ -51,13 +51,12 @@ db.getSiblingDB("admin").runCommand( { setParameter: 1, notablescan: 0 } )
 **************************************************
 ⛔️ WARNING: Dragonfly is configured to use the filesystem.
 
-This means all dragonfly assets (assets, product images, etc.) will be stored
+This means all Dragonfly assets (assets, product images, etc.) will be stored
 locally and not accessible to all servers within your environment.
 
 We recommend using S3 when running in a live environment by setting
-WORKAREA_S3_REGION and WORKAREA_S3_BUCKET_NAME in your environment variables.
-Workarea will automatically configure Dragonfly to use S3 if those values
-are present.
+WORKAREA_S3_REGION and WORKAREA_S3_BUCKET_NAME in your environment variables,
+and setting `Workarea.config.asset_store = :s3` in an initializer.
 **************************************************
         eos
       end

data/test/models/workarea/releasable_test.rb

@@ -375,6 +375,19 @@ module Workarea
       in_release = model.in_release(nil)
       assert_equal('Foo', in_release.name)
       refute_equal(in_release.object_id, model.object_id)
+
+      Mongoid::QueryCache.cache do
+        cached = Foo.find(model.id) # a find to ensure it's in the cache table
+        cached.name = 'Bar' # so the cache table's instance has a change
+
+        in_release = model.in_release(nil)
+        assert_equal('Foo', in_release.name)
+        refute_equal(in_release.object_id, model.object_id)
+        refute_equal(cached.object_id, model.object_id)
+      end
+
+    ensure
+      Mongoid::QueryCache.clear_cache
     end
 
     def test_skip_changeset

data/test/models/workarea/search/storefront/category_query_test.rb

@@ -75,6 +75,17 @@ module Workarea
             assert_equal([@category.id.to_s], CategoryQuery.find_by_product(@product))
           end
         end
+
+        def test_deleted_releases
+          release = create_release
+          release.as_current do
+            @category.product_rules.first.update!(value: 'bar')
+          end
+
+          release.destroy
+          CategoryQuery.new(@category).update
+          assert_equal([@category.id.to_s], CategoryQuery.find_by_product(@product))
+        end
       end
     end
   end

data/test/models/workarea/search/storefront/product_releases_test.rb

@@ -0,0 +1,60 @@
+require 'test_helper'
+
+module Workarea
+  module Search
+    class Storefront
+      class ProductReleasesTest < TestCase
+        def test_product_changes
+          product = create_product(name: 'Foo')
+          release_one = create_release
+          release_one.as_current { product.update!(name: 'Bar') }
+
+          assert_equal([release_one], Product.new(product).releases)
+
+          release_one.update!(publish_at: 1.day.from_now)
+          release_two = create_release(publish_at: 3.days.from_now)
+          assert_equal([release_one, release_two], Product.new(product).releases)
+        end
+
+        def test_featured_product_changes
+          product = create_product
+          category = create_category
+
+          release_one = create_release
+          release_one.as_current { category.update!(product_ids: [product.id]) }
+          assert_equal([release_one], Product.new(product).releases)
+
+          release_one.update!(publish_at: 1.day.from_now)
+          release_two = create_release(publish_at: 3.days.from_now)
+          assert_equal([release_one, release_two], Product.new(product).releases)
+        end
+
+        def test_variant_changes
+          product = create_product(variants: [{ sku: 'SKU' }])
+          release = create_release
+          release.as_current { product.variants.first.update!(details: { color: 'Red' }) }
+          assert_equal([release], Product.new(product).releases)
+        end
+
+        def test_pricing_changes
+          product = create_product(variants: [{ sku: 'SKU' }])
+          pricing = Pricing::Sku.find('SKU')
+
+          release = create_release
+          release.as_current { pricing.prices.first.update!(regular: 10_000) }
+          assert_equal([release], Product.new(product).releases)
+        end
+
+        def test_changesets_with_missing_releases
+          product = create_product(name: 'Foo')
+          release = create_release
+          release.as_current { product.update!(name: 'Bar') }
+          release.delete
+
+          assert_nil(product.reload.changesets.first.release)
+          assert_equal([], Product.new(product).releases)
+        end
+      end
+    end
+  end
+end

data/test/models/workarea/search/storefront_test.rb

@@ -25,6 +25,19 @@ module Workarea
         release.as_current { category.product_rules.first.update!(value: 'bar') }
         assert_equal(2, Storefront.new(category).changesets.size)
       end
+
+      def test_releases
+        category = create_category(name: 'Foo')
+        assert_empty(Storefront.new(category).as_document[:changeset_release_ids])
+
+        a = create_release(publish_at: 1.week.from_now)
+        a.as_current { category.update!(name: 'Bar') }
+        assert_equal([a.id], Storefront.new(category).as_document[:changeset_release_ids])
+
+        b = create_release(publish_at: 2.weeks.from_now)
+        assert_includes(Storefront.new(category).as_document[:changeset_release_ids], a.id)
+        assert_includes(Storefront.new(category).as_document[:changeset_release_ids], b.id)
+      end
     end
   end
 end

data/test/queries/workarea/search/category_browse_test.rb

@@ -382,6 +382,29 @@ module Workarea
           refute_includes(result_ids, product_five.id)
         end
       end
+
+      def test_featured_product_changes_in_a_release
+        one = create_product
+        two = create_product
+        three = create_product(name: 'Foo', active: false)
+        category = create_category(product_ids: [one.id, two.id], product_rules: [])
+        release = create_release(publish_at: 1.week.from_now)
+
+        release.as_current do
+          three.update!(name: 'Bar', active: true, default_category_id: category.id)
+          category.update!(product_ids: [three.id, one.id, two.id])
+          search = CategoryBrowse.new(sort: %w(featured), category_ids: [category.id])
+          sorts = search.results.pluck(:raw).pluck('_source').pluck('sorts').pluck(category.id.to_s)
+          assert_equal([0, 1, 2], sorts)
+        end
+
+        release.as_current do
+          category.update!(product_ids: [one.id, two.id, three.id])
+          search = CategoryBrowse.new(sort: %w(featured), category_ids: [category.id])
+          sorts = search.results.pluck(:raw).pluck('_source').pluck('sorts').pluck(category.id.to_s)
+          assert_equal([0, 1, 2], sorts)
+        end
+      end
     end
   end
 end

data/test/queries/workarea/search/pagination_test.rb

@@ -19,6 +19,15 @@ module Workarea
         assert_equal(1, Paginate.new(page: 'asdf').page)
       end
 
+      def test_per_page
+        assert_equal(Workarea.config.per_page, Paginate.new.per_page)
+        assert_equal(2, Paginate.new(per_page: 2).per_page)
+        assert_equal(Workarea.config.per_page, Paginate.new(per_page: -1).per_page)
+        assert_equal(Workarea.config.per_page, Paginate.new(per_page: 0).per_page)
+        assert_equal(3, Paginate.new(per_page: '3').per_page)
+        assert_equal(Workarea.config.per_page, Paginate.new(per_page: 'asdf').per_page)
+      end
+
       def test_from
         Workarea.config.per_page = 30
         assert_equal(0, Paginate.new(page: 1).from)

data/test/queries/workarea/search/product_search_test.rb

@@ -427,6 +427,9 @@ module Workarea
       end
 
       def test_locale
+        # No simple way to run this test without fallbacks or localized fields
+        return unless Workarea.config.localized_active_fields
+
         set_locales(available: [:en, :es], default: :en, current: :en)
         Search::Storefront.reset_indexes!
 

data/test/services/workarea/direct_upload_test.rb

@@ -108,11 +108,28 @@ module Workarea
       ).returns(true)
 
       assert(DirectUpload.ensure_cors!('http://test.host/admin/content_assets'))
-      assert_equal('true', Workarea.redis.get('cors_http_test_host'))
       assert(DirectUpload.ensure_cors!('http://localhost:3000/admin/content_assets'))
-      assert_equal('true', Workarea.redis.get('cors_http_localhost_3000'))
       assert(DirectUpload.ensure_cors!('https://example.com/admin/direct_uploads'))
-      assert_equal('true', Workarea.redis.get('cors_https_example_com'))
+    end
+
+    def test_ensure_cors_with_no_existing_configuration
+      Workarea.s3.expects(:get_bucket_cors)
+                 .raises(Excon::Errors::NotFound.new('CORS configuration does not exist'))
+
+
+      Workarea.s3.expects(:put_bucket_cors).with(
+        Configuration::S3.bucket,
+        'CORSConfiguration' => [
+          {
+            'ID' => "direct_upload_http://test.host",
+            'AllowedMethod' => 'PUT',
+            'AllowedOrigin' => 'http://test.host',
+            'AllowedHeader' => '*'
+          }
+        ]
+      ).returns(true)
+
+      assert(DirectUpload.ensure_cors!('http://test.host/admin/content_assets'))
     end
 
     private

data/test/services/workarea/hash_update_test.rb

@@ -2,23 +2,23 @@ require 'test_helper'
 
 module Workarea
   class HashUpdateTest < TestCase
-    def test_apply
-      hash = { 'foo' => 'bar' }
+    def test_result
+      original = { 'foo' => 'bar' }
 
-      HashUpdate.new(adds: %w(key value)).apply(hash)
-      assert_equal(%w(value), hash['key'])
+      result = HashUpdate.new(original: original, adds: %w(key value)).result
+      assert_equal(%w(value), result['key'])
 
-      HashUpdate.new(updates: %w(foo baz)).apply(hash)
-      assert_equal(%w(baz), hash['foo'])
+      result = HashUpdate.new(original: original, updates: %w(foo baz)).result
+      assert_equal(%w(baz), result['foo'])
 
-      HashUpdate.new(removes: %w(foo)).apply(hash)
-      refute_includes(hash.keys, 'foo')
+      result = HashUpdate.new(original: original, removes: %w(foo)).result
+      refute_includes(result.keys, 'foo')
 
-      HashUpdate.new(adds: ['key', 'one, two ']).apply(hash)
-      assert_equal(%w(one two), hash['key'])
+      result = HashUpdate.new(original: original, adds: ['key', 'one, two ']).result
+      assert_equal(%w(one two), result['key'])
 
-      HashUpdate.new(updates: ['key', 'one,  two, three ']).apply(hash)
-      assert_equal(%w(one two three), hash['key'])
+      result = HashUpdate.new(original: original, updates: ['key', 'one,  two, three ']).result
+      assert_equal(%w(one two three), result['key'])
     end
   end
 end

data/test/services/workarea/index_release_schedule_previews_test.rb

@@ -0,0 +1,28 @@
+require 'test_helper'
+
+module Workarea
+  class IndexReleaseSchedulePreviewsTest < TestCase
+    def test_affected_releases
+      release = create_release
+      results = IndexReleaseSchedulePreviews.new(release: release).affected_releases
+      assert_equal([release], results)
+
+      a = create_release(publish_at: 1.week.from_now)
+      b = create_release(publish_at: 2.weeks.from_now)
+      c = create_release(publish_at: 4.weeks.from_now)
+      assert_equal([a, b, c], IndexReleaseSchedulePreviews.new.affected_releases)
+
+      results = IndexReleaseSchedulePreviews
+        .new(starts_at: 3.days.from_now, ends_at: 17.days.from_now)
+        .affected_releases
+
+      assert_equal([a, b], results)
+
+      results = IndexReleaseSchedulePreviews
+        .new(release: release, starts_at: 3.days.from_now, ends_at: 10.days.from_now)
+        .affected_releases
+
+      assert_equal([a, release], results)
+    end
+  end
+end

data/test/workers/workarea/index_release_schedule_change_test.rb

@@ -0,0 +1,107 @@
+require 'test_helper'
+
+module Workarea
+  class IndexReleaseScheduleChangeTest < TestCase
+    include TestCase::SearchIndexing
+
+    setup :set_product
+
+    def set_product
+      @product = create_product(name: 'Foo')
+    end
+
+    def test_reschedule
+      a = create_release(name: 'A', publish_at: 1.week.from_now)
+      b = create_release(name: 'B', publish_at: 2.weeks.from_now)
+      c = create_release(name: 'C', publish_at: 4.weeks.from_now)
+
+      b.as_current { @product.update!(name: 'Bar') }
+      IndexProduct.perform(@product)
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+
+      # Changing publish_at via `update` causes the release to publish due to Sidekiq inline
+      previous_publish_at = b.publish_at
+      b.set(publish_at: 5.weeks.from_now)
+
+      Sidekiq::Callbacks.enable(IndexProduct) do
+        IndexReleaseScheduleChange.new.perform(b.id, previous_publish_at, b.publish_at)
+      end
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+    end
+
+    def test_removing_from_schedule
+      a = create_release(name: 'A', publish_at: 1.week.from_now)
+      b = create_release(name: 'B', publish_at: 2.weeks.from_now)
+      c = create_release(name: 'C', publish_at: 4.weeks.from_now)
+
+      b.as_current { @product.update!(name: 'Bar') }
+      IndexProduct.perform(@product)
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+
+      # Changing publish_at via `update` causes the release to publish due to Sidekiq inline
+      previous_publish_at = b.publish_at
+      b.set(publish_at: nil)
+
+      Sidekiq::Callbacks.enable(IndexProduct) do
+        IndexReleaseScheduleChange.new.perform(b.id, previous_publish_at, nil)
+      end
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+    end
+
+    def test_adding_to_schedule
+      a = create_release(name: 'A', publish_at: 1.week.from_now)
+      b = create_release(name: 'B')
+      c = create_release(name: 'C', publish_at: 4.weeks.from_now)
+
+      b.as_current { @product.update!(name: 'Bar') }
+      IndexProduct.perform(@product)
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+
+      # Changing publish_at via `update` causes the release to publish due to Sidekiq inline
+      b.set(publish_at: 2.weeks.from_now)
+
+      Sidekiq::Callbacks.enable(IndexProduct) do
+        IndexReleaseScheduleChange.new.perform(b.id, nil, b.publish_at)
+      end
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+    end
+
+    def test_destroyed
+      a = create_release(name: 'A', publish_at: 1.week.from_now)
+      b = create_release(name: 'B', publish_at: 2.weeks.from_now)
+      c = create_release(name: 'C', publish_at: 4.weeks.from_now)
+
+      b.as_current { @product.update!(name: 'Bar') }
+      IndexProduct.perform(@product)
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_equal([@product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+
+      Sidekiq::Callbacks.enable(IndexReleaseScheduleChange, IndexProduct) do
+        b.destroy
+      end
+
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+    end
+  end
+end

data/test/workers/workarea/process_import_test.rb

@@ -53,5 +53,11 @@ module Workarea
         t('workarea.admin.data_file_mailer.import_failure.errors')
       )
     end
+
+    def test_perform_with_missing_import
+      assert_raises Mongoid::Errors::DocumentNotFound do
+        ProcessImport.new.perform('foo')
+      end
+    end
   end
 end

data/test/workers/workarea/publish_release_test.rb

@@ -2,6 +2,8 @@ require 'test_helper'
 
 module Workarea
   class PublishReleaseTest < TestCase
+    include TestCase::SearchIndexing
+
     def test_publishes_the_release
       release = create_release
       PublishRelease.new.perform(release.id)
@@ -16,5 +18,27 @@ module Workarea
       assert_equal(1, Mongoid::AuditLog::Entry.count)
       assert(Mongoid::AuditLog::Entry.first.modifier.system?)
     end
+
+    def test_reindexes_release_schedule
+      product = create_product(name: 'Foo')
+
+      a = create_release(publish_at: 1.week.from_now)
+      b = create_release(publish_at: 2.weeks.from_now)
+      c = create_release(publish_at: 4.weeks.from_now)
+
+      b.as_current { product.update!(name: 'Bar') }
+      IndexProduct.perform(product)
+
+      assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model))
+      a.as_current { assert_empty(Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      b.as_current { assert_equal([product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_equal([product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+
+      Sidekiq::Callbacks.enable(IndexProduct) { PublishRelease.new.perform(b.id) }
+
+      assert_equal([product], Search::ProductSearch.new(q: 'bar').results.pluck(:model))
+      a.as_current { assert_equal([product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+      c.as_current { assert_equal([product], Search::ProductSearch.new(q: 'bar').results.pluck(:model)) }
+    end
   end
 end

data/workarea-core.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'mongoid-sample', '~> 0.1.0'
   s.add_dependency 'mongoid-encrypted', '~> 1.0.0'
   s.add_dependency 'elasticsearch', '~> 5.0.1'
-  s.add_dependency 'kaminari', '~> 0.17.0'
+  s.add_dependency 'kaminari', '~> 1.2.1'
   s.add_dependency 'kaminari-mongoid', '~> 0.1.2'
   s.add_dependency 'activemerchant', '~> 1.52'
   s.add_dependency 'dragonfly', '~> 1.1.2'
@@ -33,7 +33,8 @@ Gem::Specification.new do |s|
   s.add_dependency 'sidekiq-cron', '~> 0.6.3'
   s.add_dependency 'sidekiq-unique-jobs', '~> 6.0.6'
   s.add_dependency 'sidekiq-throttled', '~> 0.8.2'
-  s.add_dependency 'geocoder', '~> 1.4.4'
+  s.add_dependency 'geocoder', '~> 1.6.3'
+  s.add_dependency 'redis-rails', '~> 5.0.0'
   s.add_dependency 'redis-rack-cache', '~> 2.2.0'
   s.add_dependency 'easymon', '~> 1.4.0'
   s.add_dependency 'image_optim', '~> 0.26.0'
@@ -65,7 +66,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'chart-horizontalbar-rails', '~> 1.0.4' # TODO remove v4
   s.add_dependency 'select2-rails', '~> 4.0.3'
   s.add_dependency 'wysihtml-rails', '~> 0.6.0.beta2'
-  s.add_dependency 'rack-attack', '~> 5.0.1'
+  s.add_dependency 'rack-attack', '~> 6.3.1'
   s.add_dependency 'jquery-livetype-rails', '~> 0.1.0' # TODO remove v4
   s.add_dependency 'redcarpet', '~> 3.4.0'
   s.add_dependency 'jquery-unique-clone-rails', '~> 1.0.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workarea-core
 version: !ruby/object:Gem::Version
-  version: 3.5.9
+  version: 3.5.14
 platform: ruby
 authors:
 - Ben Crouse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-15 00:00:00.000000000 Z
+date: 2020-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -170,14 +170,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 1.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 1.2.1
 - !ruby/object:Gem::Dependency
   name: kaminari-mongoid
   requirement: !ruby/object:Gem::Requirement
@@ -282,14 +282,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.4
+        version: 1.6.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.4
+        version: 1.6.3
+- !ruby/object:Gem::Dependency
+  name: redis-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: redis-rack-cache
   requirement: !ruby/object:Gem::Requirement
@@ -730,14 +744,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.1
+        version: 6.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.1
+        version: 6.3.1
 - !ruby/object:Gem::Dependency
   name: jquery-livetype-rails
   requirement: !ruby/object:Gem::Requirement
@@ -1720,6 +1734,7 @@ files:
 - app/services/workarea/direct_upload/product_image.rb
 - app/services/workarea/export_report.rb
 - app/services/workarea/hash_update.rb
+- app/services/workarea/index_release_schedule_previews.rb
 - app/services/workarea/inventory_adjustment.rb
 - app/services/workarea/login.rb
 - app/services/workarea/new_discount.rb
@@ -1757,6 +1772,7 @@ files:
 - app/workers/workarea/index_product.rb
 - app/workers/workarea/index_product_children.rb
 - app/workers/workarea/index_product_rule.rb
+- app/workers/workarea/index_release_schedule_change.rb
 - app/workers/workarea/index_search_customizations.rb
 - app/workers/workarea/index_skus.rb
 - app/workers/workarea/keep_product_index_fresh.rb
@@ -1919,6 +1935,7 @@ files:
 - lib/workarea/ext/freedom_patches/dragonfly_job_fetch_url.rb
 - lib/workarea/ext/freedom_patches/float.rb
 - lib/workarea/ext/freedom_patches/global_id.rb
+- lib/workarea/ext/freedom_patches/i18n_js.rb
 - lib/workarea/ext/freedom_patches/money.rb
 - lib/workarea/ext/freedom_patches/mongoid_localized_defaults.rb
 - lib/workarea/ext/freedom_patches/mongoid_simple_tags.rb
@@ -1963,6 +1980,7 @@ files:
 - lib/workarea/ping_home_base.rb
 - lib/workarea/plugin.rb
 - lib/workarea/plugin/asset_appends_helper.rb
+- lib/workarea/queues_pauser.rb
 - lib/workarea/routes_constraints/redirect.rb
 - lib/workarea/routes_constraints/super_admin.rb
 - lib/workarea/scheduled_jobs.rb
@@ -2313,6 +2331,7 @@ files:
 - test/models/workarea/search/storefront/product/inventory_test.rb
 - test/models/workarea/search/storefront/product/pricing_test.rb
 - test/models/workarea/search/storefront/product/text_test.rb
+- test/models/workarea/search/storefront/product_releases_test.rb
 - test/models/workarea/search/storefront/product_test.rb
 - test/models/workarea/search/storefront_test.rb
 - test/models/workarea/segment/life_cycle_test.rb
@@ -2364,7 +2383,6 @@ files:
 - test/queries/workarea/pricing_override_params_test.rb
 - test/queries/workarea/product_primary_image_url_test.rb
 - test/queries/workarea/product_primary_navigation_test.rb
-- test/queries/workarea/product_releases_test.rb
 - test/queries/workarea/recommendation/order_based_test.rb
 - test/queries/workarea/recommendation/product_based_test.rb
 - test/queries/workarea/recommendation/searches_test.rb
@@ -2425,6 +2443,7 @@ files:
 - test/services/workarea/direct_upload_test.rb
 - test/services/workarea/export_report_test.rb
 - test/services/workarea/hash_update_test.rb
+- test/services/workarea/index_release_schedule_previews_test.rb
 - test/services/workarea/inventory_adjustment_test.rb
 - test/services/workarea/login_test.rb
 - test/services/workarea/order_merge_test.rb
@@ -2457,6 +2476,7 @@ files:
 - test/workers/workarea/index_payment_transactions_test.rb
 - test/workers/workarea/index_product_rule_test.rb
 - test/workers/workarea/index_product_test.rb
+- test/workers/workarea/index_release_schedule_change_test.rb
 - test/workers/workarea/index_skus_test.rb
 - test/workers/workarea/keep_product_index_fresh_test.rb
 - test/workers/workarea/mark_discounts_as_redeemed_test.rb

data/test/queries/workarea/product_releases_test.rb

@@ -1,56 +0,0 @@
-require 'test_helper'
-
-module Workarea
-  class ProductReleasesTest < TestCase
-    def test_product_changes
-      product = create_product(name: 'Foo')
-      release_one = create_release
-      release_one.as_current { product.update!(name: 'Bar') }
-
-      assert_equal([release_one], ProductReleases.new(product).releases)
-
-      release_one.update!(publish_at: 1.day.from_now)
-      release_two = create_release(publish_at: 3.days.from_now)
-      assert_equal([release_one, release_two], ProductReleases.new(product).releases)
-    end
-
-    def test_featured_product_changes
-      product = create_product
-      category = create_category
-
-      release_one = create_release
-      release_one.as_current { category.update!(product_ids: [product.id]) }
-      assert_equal([release_one], ProductReleases.new(product).releases)
-
-      release_one.update!(publish_at: 1.day.from_now)
-      release_two = create_release(publish_at: 3.days.from_now)
-      assert_equal([release_one, release_two], ProductReleases.new(product).releases)
-    end
-
-    def test_variant_changes
-      product = create_product(variants: [{ sku: 'SKU' }])
-      release = create_release
-      release.as_current { product.variants.first.update!(details: { color: 'Red' }) }
-      assert_equal([release], ProductReleases.new(product).releases)
-    end
-
-    def test_pricing_changes
-      product = create_product(variants: [{ sku: 'SKU' }])
-      pricing = Pricing::Sku.find('SKU')
-
-      release = create_release
-      release.as_current { pricing.prices.first.update!(regular: 10_000) }
-      assert_equal([release], ProductReleases.new(product).releases)
-    end
-
-    def test_changesets_with_missing_releases
-      product = create_product(name: 'Foo')
-      release = create_release
-      release.as_current { product.update!(name: 'Bar') }
-      release.delete
-
-      assert_nil(product.reload.changesets.first.release)
-      assert_equal([], ProductReleases.new(product).releases)
-    end
-  end
-end