workarea-basic_auth 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5dfc7106939adadfdd9a68402ab718b4402f58397fde56961b2829dc8ba3b931
-  data.tar.gz: 2950c86db45d8df08937d1def0256112e4ba696cd57ae4a6d9f26637fd4a62e8
+  metadata.gz: 3327a98acb6ee3bc11f51399de7d3c2351444bc9a8623d34b7eb543c4166f502
+  data.tar.gz: b8dd4dde7239e58edaed513f69266f81e5423a8ca2fc2a6829ad12aca18e1835
 SHA512:
-  metadata.gz: c0e4d294f866d66ed4a5f00f367d0ad7ca916ea5ea39008baad5f302fad4880793fc269058247d6c61bc049d1b42fa065c8cd7dddbfd1aa3176ae8a25a83c64d
-  data.tar.gz: 76fb28edc042898fb752d34aa18af184c081f8e2751d9ec67ba9f6864381eb0b8dc4cc59997534045e1ef7d2d7210f32b8fe0414734678a1bd46d34625cbc1cc
+  metadata.gz: 4c0b0dd04ae486fe1661dad7970ca91e3ad7219d167b46d65cfae78ff0bf24f688e03027ef6d72e53828f52ed8e81a40d4e9a7ceb6d5a949c839d89356d802d0
+  data.tar.gz: ae09651da39fd61d5c704f76ca22f874248ba3dd42a603fb45539aac1e84ab3fd8e3805af269f97c8d5afd14cf463c32eb964d81ae003672e08938b7335a0892

data/.eslintrc.json

@@ -0,0 +1,35 @@
+{
+    "extends": "eslint:recommended",
+    "rules": {
+      "semi": ["error", "always"],
+      "eqeqeq": ["error", "always"]
+    },
+    "globals": {
+      "window": true,
+      "document": true,
+      "WORKAREA": true,
+      "$": true,
+      "jQuery": true,
+      "_": true,
+      "feature": true,
+      "JST": true,
+      "Turbolinks": true,
+      "I18n": true,
+      "Chart": true,
+      "Dropzone": true,
+      "strftime": true,
+      "Waypoint": true,
+      "wysihtml": true,
+      "LocalTime": true,
+      "describe": true,
+      "after": true,
+      "afterEach": true,
+      "before": true,
+      "beforeEach": true,
+      "it": true,
+      "expect": true,
+      "sinon": true,
+      "fixture": true,
+      "chai": true
+    }
+}

data/.github/workflows/ci.yml

@@ -0,0 +1,57 @@
+name: CI
+on: [push]
+
+jobs:
+  static_analysis:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: workarea-commerce/ci/bundler-audit@v1
+    - uses: workarea-commerce/ci/rubocop@v1
+    - uses: workarea-commerce/ci/eslint@v1
+      with:
+        args: '**/*.js'
+
+  admin_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:admin
+
+  core_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:core
+
+  storefront_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:storefront
+
+  plugins_tests:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - uses: workarea-commerce/ci/test@v1
+      with:
+        command: bin/rails app:workarea:test:plugins

data/.rubocop.yml

@@ -0,0 +1,3 @@
+inherit_from:
+  - https://raw.githubusercontent.com/workarea-commerce/workarea/master/.rubocop.yml
+

data/.stylelintrc.json

@@ -0,0 +1,8 @@
+{
+  "extends": "stylelint-config-recommended-scss",
+  "rules": {
+    "block-no-empty": null,
+    "no-descending-specificity": null,
+    "property-no-unknown": [true, { "ignoreProperties": ["mso-hide"] }]
+  }
+}

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+Workarea Basic Auth 1.1.2 (2019-09-17)
+--------------------------------------------------------------------------------
+
+*   Fix for whitelisted IPs being blank
+
+*   Fix Error on App Initialization
+
+    This plugin causes an error on init with the latest Workarea version
+    because the `Rack::Attack::ALERT_LOGIC_IP_ADDRESSES` constant was
+    replaced with the more generic `Rack::Attack::IGNORED_IP_ADDRESSES`,
+    when it is defined. Since Basic Auth uses this constant for its own
+    whitelist, app initialization errors out.
+
+
 Workarea Basic Auth 1.1.1 (2019-08-21)
 --------------------------------------------------------------------------------
 

data/config/initializers/access_control.rb

@@ -15,7 +15,9 @@ Workarea.configure do |config|
   basic_auth.exclude_routes.add("/media/*")
   basic_auth.exclude_routes.add("/product_images/*")
 
-  basic_auth.whitelisted_ips = Rack::Attack::ALERT_LOGIC_IP_ADDRESSES
+  if Rack::Attack.const_defined? :IGNORED_IP_ADDRESSES
+    basic_auth.whitelisted_ips = Rack::Attack::IGNORED_IP_ADDRESSES
+  end
 
   Workarea.config.basic_auth = basic_auth
 

data/lib/workarea/basic_auth/middleware.rb

@@ -74,7 +74,7 @@ module Workarea
             end
 
             def whitelisted_ips
-              Workarea.config.basic_auth.whitelisted_ips
+              Array.wrap(Workarea.config.basic_auth.whitelisted_ips)
             end
         end
     end

data/lib/workarea/basic_auth/version.rb

@@ -1,5 +1,5 @@
 module Workarea
   module BasicAuth
-    VERSION = '1.1.1'.freeze
+    VERSION = '1.1.2'.freeze
   end
 end

data/test/lib/workarea/basic_auth/middleware_test.rb

@@ -41,11 +41,13 @@ module Workarea
       end
 
       def test_unauthorized_users_returns_200_if_ip_is_whitelisted
-        ip_addr = Workarea.config.basic_auth.whitelisted_ips.first.to_s
-        env = Rack::MockRequest.env_for("/login", 'REMOTE_ADDR' => ip_addr)
-        get_login = Rack::Response.new(middleware.call(env))
+        Workarea.with_config do |config|
+          config.basic_auth.whitelisted_ips = ['192.168.0.1']
+          env = Rack::MockRequest.env_for("/login", 'REMOTE_ADDR' => '192.168.0.1')
+          get_login = Rack::Response.new(middleware.call(env))
 
-        assert_equal(200, get_login.status)
+          assert_equal(200, get_login.status)
+        end
       end
 
       def test_unathorized_users_returns_401_for_all_http_methods_on_a_path_by_default

data/workarea-basic_auth.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.description = "HTTP basic authentication Rack middleware for the Workarea Commerce Platform"
   s.files       = `git ls-files`.split("\n")
   s.license = 'Business Software License'
-  s.test_files  = Dir["test/**/*"]
+  s.test_files = Dir["test/**/*"]
 
   s.required_ruby_version = ">= 2.0.0"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: workarea-basic_auth
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Thomas Vendetta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-21 00:00:00.000000000 Z
+date: 2019-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: workarea
@@ -52,10 +52,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".editorconfig"
+- ".eslintrc.json"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/documentation-request.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/ci.yml"
 - ".gitignore"
+- ".rubocop.yml"
+- ".stylelintrc.json"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
@@ -120,12 +124,6 @@ files:
 - test/dummy/lib/assets/.keep
 - test/dummy/log/.keep
 - test/dummy/log/sidekiq.log
-- test/dummy/public/404.html
-- test/dummy/public/422.html
-- test/dummy/public/500.html
-- test/dummy/public/apple-touch-icon-precomposed.png
-- test/dummy/public/apple-touch-icon.png
-- test/dummy/public/favicon.ico
 - test/factories/workarea/testing/basic_auth_helper.rb
 - test/lib/workarea/basic_auth/middleware_test.rb
 - test/lib/workarea/basic_auth/path_test.rb
@@ -165,18 +163,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: HTTP basic authentication Rack middleware for the Workarea Commerce Platform
 test_files:
 - test/test_helper.rb
-- test/dummy/public/apple-touch-icon-precomposed.png
-- test/dummy/public/404.html
-- test/dummy/public/422.html
-- test/dummy/public/500.html
-- test/dummy/public/favicon.ico
-- test/dummy/public/apple-touch-icon.png
 - test/dummy/Rakefile
 - test/dummy/config/initializers/workarea.rb
 - test/dummy/config/initializers/assets.rb