wordmove 1.4.0.pre4 → 1.4.0.pre5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d69432988eb6f712da0942373acfbb632ddd397
-  data.tar.gz: ef78b4984a4d7b2e1dcf09acbc8de185347ee0c5
+  metadata.gz: 3539e79c18d048d429bbf8c74fe16062fea7b247
+  data.tar.gz: 1a342c75af3274424eda5e5d46691e1d8f0408bb
 SHA512:
-  metadata.gz: 280f669a1f395a128b1966cf764de60cd468cc5ab18cffff40c6a61e0481e77cdc3537b1435dc56483014d715db9568fc43ebf95afa4caa46ba14e0faf329d0f
-  data.tar.gz: fdb6637c7aeae8fc02a2741e44777fd5447c6d1738335de2da86690d9b9b69ad8a281c4397cf107a9ec9dc4594f9c14045a24bd3913567132a722e7609b459aa
+  metadata.gz: 205ec2101b5bbab623950ceee0644160ace684841c7f2c8bb79921b253e37f2063590444b165405fcbcf46744e23d36432f7dac441be9ec45da317bbeb9fdda0
+  data.tar.gz: 1132b2af445f8a3d0f932621e7d1b113f6cfd725a05513689036126454f8fb358013573d691789b178554cdd4a6aba3f90cb5be20ba8c9796d920e0ff74284e5

data/.rubocop.yml

@@ -1,12 +1,35 @@
+Rails:
+  Enabled: true
+
+Rails/Output:
+  Enabled: false
+
 AllCops:
-  RunRailsCops: true
+  TargetRubyVersion: 2.2
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+
   Exclude:
-    - 'db/**/*'
     - 'bin/*'
+
 Metrics/LineLength:
   Max: 100
+
+Metrics/MethodLength:
+  Max: 15
+
+Metrics/ClassLength:
+  Max: 200
+
 Style/StringLiterals:
   Enabled: false
   EnforcedStyle: double_quotes
+
 Style/Documentation:
   Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Metrics/AbcSize:
+  Max: 35

data/CHANGELOG.md

@@ -1,18 +1,11 @@
-# 1.4.0
-- Implemented compression of sql files before and after transfers
-- Implemented compression of sql backup files inside wp-content
-- Implemented support to mu-plugins directory. Thanks connormckelvey
-- Update `dump.php` library to support database VIEWS
-
-
 # 1.3.1
-- Fix typo in dump.php.erb
+- fix typo in dump.php.erb
 
 # 1.3.0
-- Fix UTF-8 encoding issue when `wordmove init` with a wrong .sample file
-- Fix problem with ftp password and special chars
-- Fix duplicated wordpress tree in languages folder (ftp only)
-- Update db import / export php libraries
-- Add `--version` option
-- Required ruby version ~> 2.0
-- Updated test suite with rspec 3.x
+- fix UTF-8 encoding issue when `wordmove init` with a wrong .sample file
+- fix problem with ftp password and special chars
+- fix duplicated wordpress tree in languages folder (ftp only)
+- update db import / export php libraries
+- add `--version` option
+- required ruby version ~> 2.0
+- updated test suite with rspec 3.x

data/README.mdown

@@ -2,20 +2,16 @@
 
 ![logo](https://raw.githubusercontent.com/welaika/wordmove/master/assets/images/wordmove.png)
 
-Wordmove is a nice little gem that lets you automatically mirror local Wordpress
+Wordmove is a gem that lets you automatically mirror local Wordpress
 installations and DB data back and forth from your local development machine to
-the remote staging server. SSH and FTP connections are both supported.
+the remote staging server.
+
+**SSH** connections are fully supported, while [FTP support is planned to be discontinued](https://github.com/welaika/wordmove/wiki/FTP-support-disclaimer) when new features will be introduced.
 
 Think of it like Capistrano for Wordpress, complete with push/pull capabilities.
 
 [![Build Status](https://travis-ci.org/welaika/wordmove.png?branch=master)](https://travis-ci.org/welaika/wordmove)
 
-## Screencasts
-
-* Push all WordPress, including database and uploads: http://vimeo.com/74648079
-* Pull database and uploads, adapting paths and urls: http://vimeo.com/74646861
-* Push only theme, transfer only modified files: http://vimeo.com/74647529
-
 ## Installation
 
 That's easy:
@@ -24,15 +20,6 @@ That's easy:
 gem install wordmove
 ```
 
-## Upgrading?
-
-Beware!
-
-From version 1.0 we have decided to change wordmove flags' behaviour: they used to tell
-wordmove which options to **skip**, now they tell instead which options to **include**.
-In the Movefile, we have also changed all "username" fields to be just "user".
-
-So please, be very careful when upgrading :heart:
 
 ## Usage
 
@@ -45,11 +32,21 @@ Tasks:
   wordmove push         # Pushes WP data from local machine to remote host
 ```
 
+Move inside the Wordpress folder and use `wordmove init` to generate a new `Movefile` and edit it with your settings. Read the next paragraph for more info.
+
+See the wiki article: [Usage and flags explained](https://github.com/welaika/wordmove/wiki/Usage-and-flags-explained) for more info.
+
+### Screencasts
+
+* Push all WordPress, including database and uploads: http://vimeo.com/74648079
+* Pull database and uploads, adapting paths and urls: http://vimeo.com/74646861
+* Push only theme, transfer only modified files: http://vimeo.com/74647529
+
 ## Movefile
 
-You can configure Wordmove creating a `Movefile`. That's just a YAML file with all the local and remote host infos:
+You can configure Wordmove creating a `Movefile`. That's just a YAML file with local and remote host infos:
 
-```yaml
+```
 local:
   vhost: "http://vhost.local"
   wordpress_path: "/home/john/sites/your_site" # use an absolute path here
@@ -70,7 +67,6 @@ production:
     password: "password"
     host: "host"
     # port: "3308" # Use just in case you have exotic server config
-    # mysqldump_options: "--max_allowed_packet=50MB" # Only available if using SSH
 
   exclude:
     - ".git/"
@@ -82,77 +78,35 @@ production:
     - "Movefile"
     - "wp-config.php"
     - "wp-content/*.sql"
-
-  # paths: # you can customize wordpress internal paths
-  #   wp_content: "wp-content"
-  #   uploads: "wp-content/uploads"
-  #   plugins: "wp-content/plugins"
-  #   mu_plugins: "wp-content/mu-plugins"
-  #   themes: "wp-content/themes"
-  #   languages: "wp-content/languages"
-  #   themes: "wp-content/themes"
-
-  # ssh:
-  #   host: "host"
-  #   user: "user"
-  #   password: "password" # password is optional, will use public keys if available.
-  #   port: 22 # Port is optional
-  #   rsync_options: "--verbose" # Additional rsync options, optional
-  #   gateway: # Gateway is optional
-  #     host: "host"
-  #     user: "user"
-  #     password: "password" # password is optional, will use public keys if available.
-
-  # ftp:
-  #   user: "user"
-  #   password: "password"
-  #   host: "host"
-  #   passive: true
-  #   scheme: "ftps" # default "ftp"
-
-# staging: # multiple environments can be specified
-#   [...]
 ```
 
-## SSH support
+We warmly **recommend** to read the wiki article [Multiple environments explained
+](https://github.com/welaika/wordmove/wiki/Multiple-environments-explained) if you need multi-stage support, and the wiki article [Movefile configurations explained](https://github.com/welaika/wordmove/wiki/Movefile-configurations-explained) to understand about the supported configurations.
 
-In order for wordmove to work with SSH, you need to install `rsync` on your
-machine.
+## Supports
+### OS
 
-### If you want to use your SSH public key for authentication
-Just delete the `remote.ssh.password` field in your `Movefile`. Easy peasy.
+OS X and Linux are fully supported.
 
-### If you want to specify SSH password on the Movefile
-Please take a look at the various gotchas of the underlying [`photocopier` gem](https://github.com/welaika/photocopier#password-gotchas).
+See the [Windows (un)support disclaimer](https://github.com/welaika/wordmove/wiki/Windows-(un)support-disclaimer)
 
-## FTP support
+### SSH
 
-In order for wordmove to work with FTP, you need to install `lftp` on your
-machine. Then in the remote host section in your Movefile:
+* You need `rsync` on your machine; as far as we know it's already installed on OS X and Linux.
+* if you want to use your SSH public key for authentication,just delete the `production.ssh.password` field in your `Movefile`. Easy peasy.
+* writing the password inside the move file was and is somewhat supported, but we discourage this practice in favor of password-less authentication with pub key. Read [here](https://github.com/welaika/wordmove/wiki/%5Bdeprecated%5D-SSH-password-inside-Movefile) for old informations.
 
-* Use the relative FTP path as `wordpress_path`
-* Use the absolute FTP path as `wordpress_absolute_path` (you may need to recover this from the `__FILE__` constant)
+### FTP
 
-### If you want to specify a passive FTP connection
-Add to the YAML config a `passive` flag set to `true`.
+* You need to install `lftp` on your machine. See community wiki article: [Install lftp on OSX yosemite](https://github.com/welaika/wordmove/wiki/Install-lftp-on-OSX-yosemite)).
+* Use the relative FTP path as `production.wordpress_path`
+* Use the absolute FTP path as `production.wordpress_absolute_path` (you may need to recover this from the `__FILE__` [magic constant](http://php.net/manual/en/language.constants.predefined.php)
+* if you want to specify a passive FTP connection add to the YAML config a `production.ftp.passive` flag and set it to `true`.
 
-### Problems with server's certificate
-If server's certificate is not signed by a known Certificate Authority, you can disable `lftp` check by adding
-`set ssl:verify-certificate no` to your `~/.lftprc` or `~/.lftp/rc`
+FTP support is [planned to be discontinued](https://github.com/welaika/wordmove/wiki/FTP-support-disclaimer) at some point of future development.
 
-If host name used to connect to the server does not corresponds to the host name in its certificate, you can disable
-`lftp` check by adding `set ssl:check-hostname no` to your `~/.lftprc` or `~/.lftp/rc`
+### Multistage
 
-More `lftp` [configuration flags here.](https://gist.github.com/gaubert/822090)
-
-### How the heck you are able to sync the DB via FTP?
-We're glad you asked! We basically upload via FTP a PHP script that performs the various
-import/export operations. This script then gets executed via HTTP. Don't worry
-too much about security though: the script is deleted just after the usage,
-and can only be executed by `wordmove`, as each time it requires a pre-shared
-one-time-password to be run.
-
-## Multi environment
 You can define multiple environments in your `Movefile`, such as production, staging, etc.
 Use `-e` with `pull` or `push` to run the command on the specified environment.
 
@@ -160,15 +114,27 @@ For example:
 ```
 wordmove push -e staging -d
 ```
-will push your local database to the staging environment only
+will push your local database to the staging environment only.
+
+We warmly **recommend** to read the wiki article: [Multiple environments explained
+](https://github.com/welaika/wordmove/wiki/Multiple-environments-explained)
+
+## Notes
+### How the heck you are able to sync the DB via FTP?
+
+We're glad you asked! We basically upload via FTP a PHP script that performs the various
+import/export operations. This script then gets executed via HTTP. Don't worry
+too much about security though: the script is deleted just after the usage,
+and can only be executed by `wordmove`, as each time it requires a pre-shared
+one-time-password to be run.
 
 ## Need more tools?
 Visit [Wordpress Tools](http://wptools.it).
 
 ## Credits
 
-* The dump script is the [`MYSQL-dump` PHP package](https://github.com/dg/MySQL-dump) by David Grudl;
-* The import script used is the [BigDump](http://www.ozerov.de/bigdump/) library;
+* The dump script is the [`MYSQL-dump` PHP package](https://github.com/dg/MySQL-dump) by David Grudl
+* The import script used is the [BigDump](http://www.ozerov.de/bigdump/) library
 
 ## Contribute
 
@@ -202,3 +168,4 @@ FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+

data/Rakefile

@@ -1,5 +1,8 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 task default: :spec
+RuboCop::RakeTask.new(:rubocop)
+task default: :rubocop

data/lib/wordmove.rb

@@ -1,3 +1,5 @@
+require 'English'
+
 require 'thor'
 require 'thor/group'
 require 'colorize'

data/lib/wordmove/assets/dump.php.erb

@@ -78,20 +78,14 @@ class MySQLDump
 			throw new Exception('Argument must be stream resource.');
 		}
 
-		$tables = $views = array();
+		$tables = array();
 
-		$res = $this->connection->query('SHOW FULL TABLES');
+		$res = $this->connection->query('SHOW TABLES');
 		while ($row = $res->fetch_row()) {
-			if ($row[1] === 'VIEW') {
-				$views[] = $row[0];
-			} else {
-				$tables[] = $row[0];
-			}
+			$tables[] = $row[0];
 		}
 		$res->close();
 
-		$tables = array_merge($tables, $views); // views must be last
-
 		$this->connection->query('LOCK TABLES `' . implode('` READ, `', $tables) . '` READ');
 
 		$db = $this->connection->query('SELECT DATABASE()')->fetch_row();
@@ -225,4 +219,6 @@ $db_name = '<%= escape_php db[:name] %>';
 
 $connection = new mysqli($db_host, $db_user, $db_password, $db_name, $db_port);
 $dump = new MySQLDump($connection);
-$dump->save('dump.mysql');
+$db_file = 'dump.mysql';
+$dump->save($db_file);
+readfile($db_file);

data/lib/wordmove/cli.rb

@@ -1,6 +1,6 @@
 module Wordmove
   class CLI < Thor
-    map %w[--version -v] => :__print_version
+    map %w(--version -v) => :__print_version
 
     desc "--version, -v", "Print the version"
     def __print_version
@@ -17,7 +17,6 @@ module Wordmove
       uploads:     { aliases: "-u", type: :boolean },
       themes:      { aliases: "-t", type: :boolean },
       plugins:     { aliases: "-p", type: :boolean },
-      mu_plugins:  { aliases: "-m", type: :boolean },
       languages:   { aliases: "-l", type: :boolean },
       db:          { aliases: "-d", type: :boolean },
 
@@ -32,20 +31,10 @@ module Wordmove
 
     no_tasks do
       def handle_options(options)
-        wordpress_options.each do |task|
-          yield task if options[task] || options["all"]
+        %w(wordpress uploads themes plugins languages db).map(&:to_sym).each do |task|
+          yield task if options[task] || options[:all]
         end
       end
-
-      def wordpress_options
-        %w(wordpress uploads themes plugins mu_plugins languages db)
-      end
-
-      def ensure_wordpress_options_presence!(options)
-        return if (options.keys & (wordpress_options + ["all"])).present?
-        puts "No options given. See wordmove --help"
-        exit 1
-      end
     end
 
     desc "pull", "Pulls WP data from remote host to the local machine"
@@ -53,7 +42,6 @@ module Wordmove
       method_option option, args
     end
     def pull
-      ensure_wordpress_options_presence!(options)
       deployer = Wordmove::Deployer::Base.deployer_for(options)
       handle_options(options) do |task|
         deployer.send("pull_#{task}")
@@ -65,12 +53,10 @@ module Wordmove
       method_option option, args
     end
     def push
-      ensure_wordpress_options_presence!(options)
       deployer = Wordmove::Deployer::Base.deployer_for(options)
       handle_options(options) do |task|
         deployer.send("push_#{task}")
       end
     end
-
   end
 end

data/lib/wordmove/deployer/base.rb

@@ -1,6 +1,5 @@
 module Wordmove
   module Deployer
-
     class Base
       attr_reader :options
       attr_reader :logger
@@ -13,21 +12,20 @@ module Wordmove
           options.merge!(cli_options).deep_symbolize_keys!
 
           if available_enviroments.size > 1 && options[:environment].nil?
-            raise UndefinedEnvironment, "You need to specify an environment with --environment parameter"
+            raise(
+              UndefinedEnvironment,
+              "You need to specify an environment with --environment parameter"
+            )
           end
           environment = (options[:environment] || available_enviroments.first).to_sym
 
-          if options[environment][:ftp]
-            FTP.new(environment, options)
-          elsif options[environment][:ssh]
-            SSH.new(environment, options)
-          else
-            raise NoAdapterFound, "No valid adapter found."
-          end
+          return FTP.new(environment, options) if options[environment][:ftp]
+          return SSH.new(environment, options) if options[environment][:ssh]
+          raise NoAdapterFound, "No valid adapter found."
         end
 
         def extract_available_envs(options)
-          options.keys.map(&:to_sym) - [ :local ]
+          options.keys.map(&:to_sym) - [:local]
         end
 
         def fetch_movefile(name = nil, start_dir = current_dir)
@@ -35,21 +33,13 @@ module Wordmove
           entries = Dir["#{File.join(start_dir, name)}*"]
 
           if entries.empty?
-            if last_dir?(start_dir)
-              raise MovefileNotFound, "Could not find a valid Movefile"
-            else
-              return fetch_movefile(name, upper_dir(start_dir))
-            end
+            raise MovefileNotFound, "Could not find a valid Movefile" if last_dir?(start_dir)
+            return fetch_movefile(name, upper_dir(start_dir))
           end
 
           found = entries.first
           logger.task("Using Movefile: #{found}")
-          begin
-            YAML::load(File.open(found))
-          rescue Psych::SyntaxError
-            puts "Your Movefile is not a valid YAML file. Please, check your Movefile with a YAML linter such as http://lmgtfy.com/?q=yaml+linter"
-            exit 1
-          end
+          YAML.load(ERB.new(File.read(found)).result)
         end
 
         def current_dir
@@ -57,7 +47,7 @@ module Wordmove
         end
 
         def last_dir?(directory)
-          directory == "/" || File.exists?(File.join(directory, 'wp-config.php'))
+          directory == "/" || File.exist?(File.join(directory, 'wp-config.php'))
         end
 
         def upper_dir(directory)
@@ -84,9 +74,10 @@ module Wordmove
       end
 
       def remote_get_directory(directory); end
+
       def remote_put_directory(directory); end
 
-      %w(uploads themes plugins mu_plugins languages).each do |task|
+      %w(uploads themes plugins languages).each do |task|
         define_method "push_#{task}" do
           logger.task "Pushing #{task.titleize}"
           local_path = send("local_#{task}_dir").path
@@ -131,14 +122,14 @@ module Wordmove
       protected
 
       def paths_to_exclude
-        remote_options[:exclude] || Array.new
+        remote_options[:exclude] || []
       end
 
       def run(command)
         logger.task_step true, command
         unless simulate?
           system(command)
-          raise ShellCommandError, "Return code reports an error" unless $?.success?
+          raise ShellCommandError, "Return code reports an error" unless $CHILD_STATUS.success?
         end
       end
 
@@ -155,14 +146,14 @@ module Wordmove
         options[:simulate]
       end
 
-      [ WordpressDirectory::PATH::WP_CONTENT,
+      [
+        WordpressDirectory::PATH::WP_CONTENT,
         WordpressDirectory::PATH::PLUGINS,
-        WordpressDirectory::PATH::MU_PLUGINS,
         WordpressDirectory::PATH::THEMES,
         WordpressDirectory::PATH::UPLOADS,
         WordpressDirectory::PATH::LANGUAGES
       ].each do |type|
-        [ :remote, :local ].each do |location|
+        [:remote, :local].each do |location|
           define_method "#{location}_#{type}_dir" do
             options = send("#{location}_options")
             WordpressDirectory.new(type, options)
@@ -173,9 +164,7 @@ module Wordmove
       def adapt_sql(save_to_path, local, remote)
         unless options[:no_adapt]
           logger.task_step true, "adapt dump"
-          unless simulate?
-            SqlAdapter.new(save_to_path, local, remote).adapt!
-          end
+          SqlAdapter.new(save_to_path, local, remote).adapt! unless simulate?
         end
       end
 
@@ -184,11 +173,14 @@ module Wordmove
         command << "--host=#{Shellwords.escape(options[:host])}" if options[:host].present?
         command << "--port=#{Shellwords.escape(options[:port])}" if options[:port].present?
         command << "--user=#{Shellwords.escape(options[:user])}" if options[:user].present?
-        command << "--password=#{Shellwords.escape(options[:password])}" if options[:password].present?
-        command << "--default-character-set=#{Shellwords.escape(options[:charset])}" if options[:charset].present?
-        command << "--result-file=#{Shellwords.escape(save_to_path)}"
-        command << Shellwords.split(options[:mysqldump_options]) if options[:mysqldump_options].present?
+        if options[:password].present?
+          command << "--password=#{Shellwords.escape(options[:password])}"
+        end
+        if options[:charset].present?
+          command << "--default-character-set=#{Shellwords.escape(options[:charset])}"
+        end
         command << Shellwords.escape(options[:name])
+        command << "--result-file=#{Shellwords.escape(save_to_path)}"
         puts command.join(" ")
         command.join(" ")
       end
@@ -198,29 +190,18 @@ module Wordmove
         command << "--host=#{Shellwords.escape(options[:host])}" if options[:host].present?
         command << "--port=#{Shellwords.escape(options[:port])}" if options[:port].present?
         command << "--user=#{Shellwords.escape(options[:user])}" if options[:user].present?
-        command << "--password=#{Shellwords.escape(options[:password])}" if options[:password].present?
-        command << "--default-character-set=#{Shellwords.escape(options[:charset])}" if options[:charset].present?
+        if options[:password].present?
+          command << "--password=#{Shellwords.escape(options[:password])}"
+        end
+        if options[:charset].present?
+          command << "--default-character-set=#{Shellwords.escape(options[:charset])}"
+        end
         command << "--database=#{Shellwords.escape(options[:name])}"
         command << "--execute=#{Shellwords.escape("SOURCE #{dump_path}")}"
         puts command.join(" ")
         command.join(" ")
       end
 
-      def compress_command(path)
-        command = ["gzip"]
-        command << "--best"
-        command << Shellwords.escape(path)
-        puts command.join(" ")
-        command.join(" ")
-      end
-
-      def uncompress_command(path)
-        command = ["gunzip"]
-        command << Shellwords.escape(path)
-        puts command.join(" ")
-        command.join(" ")
-      end
-
       def rm_command(path)
         "rm #{Shellwords.escape(path)}"
       end
@@ -238,6 +219,5 @@ module Wordmove
         options[:local].clone
       end
     end
-
   end
 end

data/lib/wordmove/deployer/ftp.rb

@@ -1,7 +1,6 @@
 module Wordmove
   module Deployer
     class FTP < Base
-
       def initialize(environment, options)
         super
         ftp_options = remote_options[:ftp]
@@ -52,22 +51,18 @@ module Wordmove
 
       %w(get get_directory put_directory delete).each do |command|
         define_method "remote_#{command}" do |*args|
-          logger.task_step false, "#{command}: #{args.join(" ")}"
-          unless simulate?
-            @copier.send(command, *args)
-          end
+          logger.task_step false, "#{command}: #{args.join(' ')}"
+          @copier.send(command, *args) unless simulate?
         end
       end
 
       def remote_put(thing, path)
-        if File.exists?(thing)
+        if File.exist?(thing)
           logger.task_step false, "copying #{thing} to #{path}"
         else
           logger.task_step false, "write #{path}"
         end
-        unless simulate?
-          @copier.put(thing, path)
-        end
+        @copier.put(thing, path) unless simulate?
       end
 
       def escape_php(string)
@@ -75,7 +70,7 @@ module Wordmove
 
         # replaces \ with \\
         # replaces ' with \'
-        string.gsub('\\','\\\\\\').gsub(/[']/, '\\\\\'')
+        string.gsub('\\', '\\\\\\').gsub(/[']/, '\\\\\'')
       end
 
       def generate_dump_script(db, password)
@@ -97,7 +92,7 @@ module Wordmove
         # upload the dump script
         remote_put(dump_script, remote_dump_script)
         # download the resulting dump (using the password)
-        dump_url = "#{remote_wp_content_dir.url("dump.php")}?shared_key=#{one_time_password}"
+        dump_url = "#{remote_wp_content_dir.url('dump.php')}?shared_key=#{one_time_password}"
         download(dump_url, local_dump_path)
         # remove it remotely
         remote_delete(remote_dump_script)
@@ -113,14 +108,16 @@ module Wordmove
         # upload import script
         remote_put(import_script, remote_import_script_path)
         # run import script
-        import_url = "#{remote_wp_content_dir.url("import.php")}?shared_key=#{one_time_password}&start=1&foffset=0&totalqueries=0&fn=dump.sql"
+        import_url = [
+          remote_wp_content_dir.url('import.php').to_s,
+          "?shared_key=#{one_time_password}",
+          "&start=1&foffset=0&totalqueries=0&fn=dump.sql"
+        ].join
         download(import_url, temp_path)
         run rm_command(temp_path)
         # remove script remotely
         remote_delete(remote_import_script_path)
       end
-
     end
   end
 end
-

data/lib/wordmove/deployer/ssh.rb

@@ -11,30 +11,23 @@ module Wordmove
         super
 
         local_dump_path = local_wp_content_dir.path("dump.sql")
-        local_gzipped_dump_path = local_dump_path + '.gz'
-        local_gizipped_backup_path = local_wp_content_dir.path("#{environment}-backup-#{Time.now.to_i}.sql.gz")
-
-        download_remote_db(local_gizipped_backup_path)
+        local_backup_path = local_wp_content_dir.path("#{environment}-backup-#{Time.now.to_i}.sql")
+        download_remote_db(local_backup_path)
 
         save_local_db(local_dump_path)
         adapt_sql(local_dump_path, local_options, remote_options)
-        run compress_command(local_dump_path)
-        import_remote_dump(local_gzipped_dump_path)
-        run rm_command(local_gzipped_dump_path)
+        import_remote_dump(local_dump_path)
+        run rm_command(local_dump_path)
       end
 
       def pull_db
         super
 
         local_dump_path = local_wp_content_dir.path("dump.sql")
-        local_gzipped_dump_path = local_dump_path + '.gz'
         local_backup_path = local_wp_content_dir.path("local-backup-#{Time.now.to_i}.sql")
-
         save_local_db(local_backup_path)
-        run compress_command(local_backup_path)
 
-        download_remote_db(local_gzipped_dump_path)
-        run uncompress_command(local_gzipped_dump_path)
+        download_remote_db(local_dump_path)
         adapt_sql(local_dump_path, remote_options, local_options)
         run mysql_import_command(local_dump_path, local_options[:database])
         run rm_command(local_dump_path)
@@ -44,38 +37,34 @@ module Wordmove
 
       %w(get put get_directory put_directory delete).each do |command|
         define_method "remote_#{command}" do |*args|
-          logger.task_step false, "#{command}: #{args.join(" ")}"
-          unless simulate?
-            @copier.send(command, *args)
-          end
+          logger.task_step false, "#{command}: #{args.join(' ')}"
+          @copier.send(command, *args) unless simulate?
         end
       end
 
       def remote_run(command)
         logger.task_step false, command
         unless simulate?
-          stdout, stderr, exit_code = @copier.exec! command
-          raise ShellCommandError, "Error code #{exit_code} returned by command \"#{command}\": #{stderr}" unless exit_code.zero?
+          _stdout, stderr, exit_code = @copier.exec! command
+          raise(
+            ShellCommandError,
+            "Error code #{exit_code} returned by command \"#{command}\": #{stderr}"
+          ) unless exit_code.zero?
         end
       end
 
-      def download_remote_db(local_gizipped_dump_path)
+      def download_remote_db(local_dump_path)
         remote_dump_path = remote_wp_content_dir.path("dump.sql")
         # dump remote db into file
         remote_run mysql_dump_command(remote_options[:database], remote_dump_path)
-        remote_run compress_command(remote_dump_path)
-        remote_dump_path += '.gz'
         # download remote dump
-        remote_get(remote_dump_path, local_gizipped_dump_path)
+        remote_get(remote_dump_path, local_dump_path)
         remote_delete(remote_dump_path)
       end
 
-      def import_remote_dump(local_gizipped_dump_path)
+      def import_remote_dump(local_dump_path)
         remote_dump_path = remote_wp_content_dir.path("dump.sql")
-        remote_gizipped_dump_path = remote_dump_path + '.gz'
-
-        remote_put(local_gizipped_dump_path, remote_gizipped_dump_path)
-        remote_run uncompress_command(remote_gizipped_dump_path)
+        remote_put(local_dump_path, remote_dump_path)
         remote_run mysql_import_command(remote_dump_path, remote_options[:database])
         remote_delete(remote_dump_path)
       end

data/lib/wordmove/generators/Movefile

@@ -18,7 +18,6 @@ production:
     password: "password"
     host: "host"
     # port: "3308" # Use just in case you have exotic server config
-    # mysqldump_options: "--max_allowed_packet=1G" # Only available if using SSH
 
   exclude:
     - ".git/"
@@ -36,10 +35,8 @@ production:
   #   wp_content: "wp-content"
   #   uploads: "wp-content/uploads"
   #   plugins: "wp-content/plugins"
-  #   mu_plugins: "wp-content/mu-plugins"
   #   themes: "wp-content/themes"
   #   languages: "wp-content/languages"
-  #   themes: "wp-content/themes"
 
   # ssh:
   #   host: "host"
@@ -61,3 +58,4 @@ production:
 
 # staging: # multiple environments can be specified
 #   [...]
+

data/lib/wordmove/generators/movefile.rb

@@ -11,8 +11,6 @@ module Wordmove
       def copy_movefile
         template "Movefile"
       end
-
     end
   end
 end
-

data/lib/wordmove/generators/movefile_adapter.rb

@@ -28,7 +28,7 @@ module Wordmove
       end
 
       def wp_config_exists?
-        File.exists?(WordpressDirectory.default_path_for(:wp_config))
+        File.exist?(WordpressDirectory.default_path_for(:wp_config))
       end
     end
 
@@ -78,8 +78,6 @@ module Wordmove
           end
         end
       end
-
     end
   end
 end
-

data/lib/wordmove/logger.rb

@@ -24,6 +24,5 @@ module Wordmove
       result = MAX_LINE - line.length
       result > 0 ? result : 0
     end
-
   end
 end

data/lib/wordmove/sql_adapter.rb

@@ -41,12 +41,12 @@ module Wordmove
     def serialized_replace!(source_field, dest_field)
       length_delta = source_field.length - dest_field.length
 
-      sql_content.gsub!(/s:(\d+):([\\]*['"])(.*?)\2;/) do |match|
-        length = $1.to_i
-        delimiter = $2
-        string = $3
+      sql_content.gsub!(/s:(\d+):([\\]*['"])(.*?)\2;/) do |_|
+        length = Regexp.last_match(1).to_i
+        delimiter = Regexp.last_match(2)
+        string = Regexp.last_match(3)
 
-        string.gsub!(/#{Regexp.escape(source_field)}/) do |match|
+        string.gsub!(/#{Regexp.escape(source_field)}/) do |_|
           length -= length_delta
           dest_field
         end
@@ -60,7 +60,7 @@ module Wordmove
     end
 
     def write_sql!
-      File.open(sql_path, 'w') {|f| f.write(sql_content) }
+      File.open(sql_path, 'w') { |f| f.write(sql_content) }
     end
   end
 end

data/lib/wordmove/version.rb

@@ -1,3 +1,3 @@
 module Wordmove
-  VERSION = "1.4.0.pre4"
+  VERSION = "1.4.0.pre5".freeze
 end

data/lib/wordmove/wordpress_directory.rb

@@ -1,10 +1,8 @@
-class WordpressDirectory < Struct.new(:type, :options)
-
+WordpressDirectory = Struct.new(:type, :options) do
   module PATH
     WP_CONTENT = :wp_content
     WP_CONFIG  = :wp_config
     PLUGINS    = :plugins
-    MU_PLUGINS = :mu_plugins
     THEMES     = :themes
     UPLOADS    = :uploads
     LANGUAGES  = :languages
@@ -14,11 +12,10 @@ class WordpressDirectory < Struct.new(:type, :options)
     PATH::WP_CONTENT => 'wp-content',
     PATH::WP_CONFIG  => 'wp-config.php',
     PATH::PLUGINS    => 'wp-content/plugins',
-    PATH::MU_PLUGINS => 'wp-content/mu-plugins',
     PATH::THEMES     => 'wp-content/themes',
     PATH::UPLOADS    => 'wp-content/uploads',
     PATH::LANGUAGES  => 'wp-content/languages'
-  }
+  }.freeze
 
   def self.default_path_for(sym)
     DEFAULT_PATHS[sym]
@@ -40,5 +37,4 @@ class WordpressDirectory < Struct.new(:type, :options)
            end
     File.join(path, *args)
   end
-
 end

data/wordmove.gemspec

@@ -7,14 +7,22 @@ Gem::Specification.new do |spec|
   spec.name          = "wordmove"
   spec.version       = Wordmove::VERSION
   spec.authors       = ["Stefano Verna", "Ju Liu", "Fabrizio Monti", "Alessandro Fazzi"]
-  spec.email         = ["stefano.verna@welaika.com", "ju.liu@welaika.com", "fabrizio.monti@welaika.com", "alessandro.fazzi@welaika.com"]
+  spec.email         = [
+    "stefano.verna@welaika.com",
+    "ju.liu@welaika.com",
+    "fabrizio.monti@welaika.com",
+    "alessandro.fazzi@welaika.com"
+  ]
 
-  spec.summary       = %q{Wordmove, Capistrano for Wordpress}
-  spec.description   = %q{Wordmove deploys your WordPress websites at the speed of light.}
+  spec.summary       = "Wordmove, Capistrano for Wordpress"
+  spec.description   = "Wordmove deploys your WordPress websites at the speed of light."
   spec.homepage      = "https://github.com/welaika/wordmove"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`
+                       .split("\x0")
+                       .reject { |f| f.match(%r{^(test|spec|features)/}) }
+
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
@@ -32,11 +40,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov", "~> 0.9"
   spec.add_development_dependency "pry-byebug", "~> 3.1"
   spec.add_development_dependency "priscilla", "~> 1.0"
-
-  spec.post_install_message = <<-RAINBOW
-    Starting from 1.4.0 Wordmove will compress SQL dumps both in remote and locale environments.
-    If something will broke, please check if gzip and gunzip executables are present locally and
-    remotely. We are considering obviuos they are installed in any web environment.
-    Open an issue on github at your needs.
-  RAINBOW
+  spec.add_development_dependency "rubocop", "~> 0.37.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wordmove
 version: !ruby/object:Gem::Version
-  version: 1.4.0.pre4
+  version: 1.4.0.pre5
 platform: ruby
 authors:
 - Stefano Verna
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-09-11 00:00:00.000000000 Z
+date: 2016-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -153,6 +153,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.37.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.37.0
 description: Wordmove deploys your WordPress websites at the speed of light.
 email:
 - stefano.verna@welaika.com
@@ -202,11 +216,7 @@ homepage: https://github.com/welaika/wordmove
 licenses:
 - MIT
 metadata: {}
-post_install_message: |2
-      Starting from 1.4.0 Wordmove will compress SQL dumps both in remote and locale environments.
-      If something will broke, please check if gzip and gunzip executables are present locally and
-      remotely. We are considering obviuos they are installed in any web environment.
-      Open an issue on github at your needs.
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -222,7 +232,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Wordmove, Capistrano for Wordpress