wor-simple_crud 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32e4043eb57f025e3a834a364be09cae1e35fa401bbf95bac88351272297d4f9
-  data.tar.gz: bb88b34edd232839b1b760a2bcb834bd25f8a244d3ad02c4a91097f14d85b377
+  metadata.gz: 31af4e1bcfb9f45e6bcbe33a2454c96b27b2adab13ff87674a9bde462d21d2f4
+  data.tar.gz: 7fadec0262d373a35c02cd015e566a97d312c5afb110abe34f58e3ca99d88d2e
 SHA512:
-  metadata.gz: e173f6052e2c1674896a08067369068d2ab9f3c50c082f4a52bf8f4d7db3a9e27f548df1a55fd12bc22e9cc4a360095033d4693ecd5b6957fae7c6b09bd24224
-  data.tar.gz: a1ffc6e33056614ff6806f2b15716d21e749777de66619f23ef0025b4e5561c60e89bbb2d0df27abc3817f248cf21aa8a6ed7cbcdcc0dad67a561411084ba2f0
+  metadata.gz: 56aa1239c57e89eaa7a3944bf2c6303033806815e9671357249958b0eb954b431a9798898fdffa4e8d70432ee650ecad9a3ab6888aff38f0398ea69454302cb3
+  data.tar.gz: 69f04e8600f4e4d10b7687c94a14a3f06b4434d12572ab969ce5f67bbb9b886e4e6ffe1d572e9a7e89f936fe999ffc435bbcc358eda12fefb0108d4f2756e67e

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 ## Change log
 
+### V0.8.0
+
+Shared examples:
+* New examples: `update with block`, `edit with finder` and `edit with block`.
+* `required_attribute: nil` skips the invalid-attribute cases in `create`, `update` and their block variants, for models with nothing to validate. `update with finder` and `owned resource` skip their `required_attribute` assertions as well.
+* `singular: true` covers singular resources. Requests carry no id, the "does not exist" examples are skipped, and the controller's own finder loads the record.
+* `index with scope` handles scopes that exclude nothing. With `other_scoped_attributes: nil` it asserts every scoped record comes back, and `scoped_order: ->(records) { ... }` asserts their order.
+* `create with block` and `destroy with block` accept a redirect or a 2xx render, so a block that redirects on success (the README's HTML example) passes. `edit` and `update with finder` accept the same when they use a block.
+* `new with build` and `create with build` assert ownership by the current user only when an `owner_association` is configured. For `parent:`-built records they check that the hook built the record.
+* `make_policies_succeed` takes `permissive: true`. The `show`, `new` and `edit` "with block" examples use it, so a block can ask the policy about other actions, such as `update?`, without failing the strict double.
+
 ### V0.7.0
 
 Serializer support:

data/README.md

@@ -511,11 +511,14 @@ The `create` and `update` examples cover the `422` response with validation erro
 ```ruby
 include_examples 'simple crud for new'                    # the :new action
 include_examples 'simple crud for edit'                   # the :edit action
+include_examples 'simple crud for edit with finder'      # finder on :edit
+include_examples 'simple crud for edit with block'       # render block on :edit
 include_examples 'simple crud for index with block'      # render block
 include_examples 'simple crud for index with scope'      # scope: ->(user) { ... }
 include_examples 'simple crud for show with block'       # render block on :show
 include_examples 'simple crud for new with block'        # render block on :new
 include_examples 'simple crud for create with block'     # render block on :create
+include_examples 'simple crud for update with block'     # render block on :update
 include_examples 'simple crud for destroy with block'    # render block on :destroy
 include_examples 'simple crud for show with finder'      # finder on :show
 include_examples 'simple crud for update with finder'    # finder on :update
@@ -524,6 +527,8 @@ include_examples 'simple crud for new with build'        # build: -> { ... } on
 include_examples 'simple crud for create with build'     # build: -> { ... } on :create
 ```
 
+The `create with block`, `destroy with block`, `edit` and `update with finder` examples accept a 2xx render or a redirect. The `show`, `new` and `edit` block examples let the block ask the policy about other actions, such as `update?`. `new with build` and `create with build` check ownership by the current user only when you configure an `owner_association`.
+
 It's not needed to specify paginate: true and such, since the shared examples will use the configuration that was originally passed to simple_crud_for
 
 #### Adopting the shared examples
@@ -548,7 +553,7 @@ SimpleCrud::RSpec.configure do |config|
   # override model_attributes directly for multi-key or non-user-owned models).
   config.owner_association = :owner
   config.model_attributes = -> { { owner: current_user } }
-  config.required_attribute = :title
+  config.required_attribute = :title # nil skips the invalid-attribute cases
   config.required_error = "Title can't be blank"
 
   # Redirect-based apps: unauthenticated requests get a redirect, not a 401.
@@ -587,7 +592,7 @@ SimpleCrud::RSpec.configure do |config|
 end
 ```
 
-Each setting has a sensible default, so you only override what differs. Callable settings (`current_user`, `authenticate`, `create_record`, `create_records`, `params_for`, `model_attributes`, `scoped_attributes`, `other_scoped_attributes`, `policy_class`, `serializer_class`) run in the example-group context, so they can call `request`, `create`, `current_user`, etc.; `created_record_check` receives the persisted record. The examples are controller-agnostic (they issue requests by action name, not hardcoded paths), so they work for namespaced and nested controllers alike. If you keep `assert_html_template` on (the default), add `gem 'rails-controller-testing'` for the `render_template` matcher.
+Each setting has a sensible default, so you only override what differs. Callable settings (`current_user`, `authenticate`, `create_record`, `create_records`, `params_for`, `model_attributes`, `scoped_attributes`, `other_scoped_attributes`, `policy_class`, `serializer_class`) run in the example-group context, so they can call `request`, `create`, `current_user`, etc.; `created_record_check` receives the persisted record and `scoped_order` the created records. The examples are controller-agnostic (they issue requests by action name, not hardcoded paths), so they work for namespaced and nested controllers alike. If you keep `assert_html_template` on (the default), add `gem 'rails-controller-testing'` for the `render_template` matcher.
 
 #### Per-controller overrides via metadata
 
@@ -606,6 +611,26 @@ end
 
 Callable settings resolve in the example context, so their lambdas can close over the spec's `let`s; that's how records land in the same project the route params point at.
 
+A scope that only orders excludes nothing. Set `other_scoped_attributes: nil` and `simple crud for index with scope` asserts that every scoped record comes back. `scoped_order` also asserts the order. It takes the created records and returns them in the expected order:
+
+```ruby
+RSpec.describe UsersController, type: :controller, simple_crud: {
+  other_scoped_attributes: nil,
+  scoped_order: ->(records) { records.sort_by(&:email) }
+} do
+  include_examples 'simple crud for index with scope'
+end
+```
+
+`singular: true` is a per-controller setting for singular resources (`resource :profile`). Requests carry no id, the "model does not exist" examples are skipped, and the controller's own finder, such as `finder: ->(_params) { current_user.profile }`, loads the record:
+
+```ruby
+RSpec.describe ProfilesController, type: :controller, simple_crud: { singular: true } do
+  include_examples 'simple crud for show'
+  include_examples 'simple crud for update'
+end
+```
+
 ## Contributing
 
 1. Fork it

data/lib/simple_crud/rspec/config.rb

@@ -43,6 +43,8 @@ module SimpleCrud
           owner_association ? attributes.merge(owner_association => other_user) : {}
         },
         required_attribute: :name,
+        singular: false,
+        scoped_order: nil,
         required_error: "Name can't be blank",
         finder_key: :slug,
         params_key: nil,

data/lib/simple_crud/rspec/helpers/policies.rb

@@ -15,9 +15,9 @@ module SimpleCrud
             .and_return(instance_double(policy_class_object, "#{method}?" => false))
         end
 
-        def make_policies_succeed(method)
-          allow(policy_class_object).to receive(:new)
-            .and_return(instance_double(policy_class_object, "#{method}?" => true))
+        def make_policies_succeed(method, permissive: false)
+          policy = instance_double(policy_class_object, "#{method}?" => true)
+          allow(policy_class_object).to receive(:new).and_return(permissive ? policy.as_null_object : policy)
         end
       end
     end

data/lib/simple_crud/rspec/helpers/requests.rb

@@ -29,8 +29,11 @@ module SimpleCrud
         end
 
         # The params that identify a record for the given action, using the
-        # configured finder_key when the action has a custom finder.
+        # configured finder_key when the action has a custom finder. A singular
+        # resource has no id, so it identifies nothing.
         def record_param(action, record, not_found: false)
+          return {} if singular
+
           key = check_finder(action) ? finder_key : :id
           value = not_found ? "nonexistent-#{key}" : record.public_send(key)
           { key => value }

data/lib/simple_crud/rspec/helpers/settings.rb

@@ -24,10 +24,19 @@ module SimpleCrud
         end
 
         %i[owner_association required_attribute required_error finder_key params_key invalid_status
-           unauthenticated_status assert_html_template scoped_attributes other_scoped_attributes].each do |name|
+           unauthenticated_status assert_html_template scoped_attributes other_scoped_attributes
+           singular].each do |name|
           define_method(name) { resolve(setting(name)) }
         end
 
+        def invalid_case?(action)
+          !required_attribute.nil? && !check_raise_on_invalid(action)
+        end
+
+        def scoped_order
+          setting(:scoped_order)
+        end
+
         def created_record_check
           setting(:created_record_check)
         end

data/lib/simple_crud/rspec.rb

@@ -11,6 +11,9 @@ require_relative '../spec/shared_examples/simple_crud_for_destroy'
 require_relative '../spec/shared_examples/simple_crud_for_create'
 require_relative '../spec/shared_examples/simple_crud_for_new'
 require_relative '../spec/shared_examples/simple_crud_for_edit'
+require_relative '../spec/shared_examples/simple_crud_for_edit_with_finder'
+require_relative '../spec/shared_examples/simple_crud_for_edit_with_block'
+require_relative '../spec/shared_examples/simple_crud_for_update_with_block'
 require_relative '../spec/shared_examples/unauthorized_when_not_logged_in'
 require_relative '../spec/shared_examples/simple_crud_renders_template'
 require_relative '../spec/shared_examples/simple_crud_without_authenticated_user'
@@ -31,6 +34,7 @@ require_relative '../spec/shared_examples/simple_crud_for_owned_resource'
 require_relative '../spec/shared_examples/simple_crud_for_nested_resource'
 require_relative '../spec/shared_examples/authorization_adapter_authorize'
 require_relative '../spec/matchers/have_been_serialized_with'
+require_relative '../spec/matchers/render_or_redirect'
 
 module SimpleCrud
   # Opt-in wiring for the shared examples: see .install!

data/lib/simple_crud/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SimpleCrud
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 end

data/lib/spec/matchers/render_or_redirect.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec::Matchers.define :render_or_redirect do
+  match { |response| response.successful? || response.redirect? }
+
+  failure_message { |response| "expected a 2xx render or a redirect, got #{response.status}" }
+end

data/lib/spec/shared_examples/simple_crud_for_create.rb

@@ -53,7 +53,7 @@ RSpec.shared_examples 'simple crud for create' do
       end
     end
 
-    unless check_raise_on_invalid(:create)
+    if invalid_case?(:create)
       context 'when creating with invalid attributes' do
         include_context 'with authenticated user' if check_authenticate(:create)
 

data/lib/spec/shared_examples/simple_crud_for_create_with_block.rb

@@ -11,7 +11,7 @@ RSpec.shared_examples 'simple crud for create with block' do
       end
 
       it 'passes the saved record to the block' do
-        expect(response).to be_successful
+        expect(response).to render_or_redirect
       end
 
       it 'creates the record' do
@@ -19,7 +19,7 @@ RSpec.shared_examples 'simple crud for create with block' do
       end
     end
 
-    unless check_raise_on_invalid(:create)
+    if invalid_case?(:create)
       context 'when creating with invalid attributes' do
         include_context 'with authenticated user' if check_authenticate(:create)
 

data/lib/spec/shared_examples/simple_crud_for_create_with_build.rb

@@ -8,8 +8,14 @@ RSpec.shared_examples 'simple crud for create with build' do
       post :create, params: with_route_params(body_params(params_for(model_class))), format: format_param(:create)
     end
 
-    it 'creates the record owned by the current user' do
-      expect(model_class_object.last.public_send(owner_association)).to eq(current_user)
+    if owner_association
+      it 'creates the record owned by the current user' do
+        expect(model_class_object.last.public_send(owner_association)).to eq(current_user)
+      end
+    else
+      it 'creates the record through the hook' do
+        expect(model_class_object.count).to eq(1)
+      end
     end
   end
 end

data/lib/spec/shared_examples/simple_crud_for_destroy.rb

@@ -71,17 +71,19 @@ RSpec.shared_examples 'simple crud for destroy' do
       end
     end
 
-    context 'when ID is invalid' do
-      include_context 'with authenticated user' if check_authenticate(:destroy)
+    unless singular
+      context 'when ID is invalid' do
+        include_context 'with authenticated user' if check_authenticate(:destroy)
 
-      before do
-        model
-        delete :destroy, params: with_route_params(record_param(:destroy, nil, not_found: true)),
-                         format: format_param(:destroy)
-      end
+        before do
+          model
+          delete :destroy, params: with_route_params(record_param(:destroy, nil, not_found: true)),
+                           format: format_param(:destroy)
+        end
 
-      it 'responds with not found status' do
-        expect(response).to have_http_status(:not_found)
+        it 'responds with not found status' do
+          expect(response).to have_http_status(:not_found)
+        end
       end
     end
 

data/lib/spec/shared_examples/simple_crud_for_destroy_with_block.rb

@@ -11,7 +11,7 @@ RSpec.shared_examples 'simple crud for destroy with block' do
     end
 
     it 'passes the destroyed record to the block' do
-      expect(response).to be_successful
+      expect(response).to render_or_redirect
     end
 
     it 'destroys the record' do

data/lib/spec/shared_examples/simple_crud_for_edit.rb

@@ -41,38 +41,40 @@ RSpec.shared_examples 'simple crud for edit' do
 
       before do
         model
-        make_policies_succeed(:edit) if check_authorize(:edit)
+        make_policies_succeed(:edit, permissive: check_block(:edit)) if check_authorize(:edit)
         edit_request
       end
 
-      it 'responds with ok status' do
-        expect(response).to have_http_status(:ok)
-      end
-
       if check_block(:edit)
         it 'renders the asked model through the block' do
-          expect(response).to be_successful
+          expect(response).to render_or_redirect
         end
       elsif check_html(:edit)
         include_examples 'simple crud renders template', :edit
       else
+        it 'responds with ok status' do
+          expect(response).to have_http_status(:ok)
+        end
+
         it 'returns the asked model' do
           expect(response_body['id']).to eq(model.id)
         end
       end
     end
 
-    context 'when the model does not exist' do
-      include_context 'with authenticated user'
+    unless singular
+      context 'when the model does not exist' do
+        include_context 'with authenticated user'
 
-      let(:edit_params) { record_param(:edit, nil, not_found: true) }
+        let(:edit_params) { record_param(:edit, nil, not_found: true) }
 
-      before do
-        edit_request
-      end
+        before do
+          edit_request
+        end
 
-      it 'responds with not found status' do
-        expect(response).to have_http_status(:not_found)
+        it 'responds with not found status' do
+          expect(response).to have_http_status(:not_found)
+        end
       end
     end
   end

data/lib/spec/shared_examples/simple_crud_for_edit_with_block.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'simple crud for edit with block' do
+  describe 'GET #edit with a render block' do
+    include_context 'with authenticated user' if check_authenticate(:edit)
+
+    let!(:record) { model }
+
+    before do
+      make_policies_succeed(:edit, permissive: true) if check_authorize(:edit)
+      get :edit, params: with_route_params(record_param(:edit, record)), format: format_param(:edit)
+    end
+
+    if check_html(:edit)
+      include_examples 'simple crud renders template', :edit
+    else
+      it 'renders the record through the block' do
+        expect(response).to render_or_redirect
+      end
+    end
+  end
+end

data/lib/spec/shared_examples/simple_crud_for_edit_with_finder.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'simple crud for edit with finder' do
+  describe 'GET #edit with a custom finder' do
+    include_context 'with authenticated user' if check_authenticate(:edit)
+
+    context 'when the model exists' do
+      before do
+        model
+        make_policies_succeed(:edit, permissive: check_block(:edit)) if check_authorize(:edit)
+        get :edit, params: with_route_params(finder_key => model.public_send(finder_key)),
+                   format: format_param(:edit)
+      end
+
+      if check_block(:edit)
+        it 'finds the asked model' do
+          expect(rendered_record.id).to eq(model.id)
+        end
+      elsif check_html(:edit)
+        include_examples 'simple crud renders template', :edit
+      else
+        it 'responds with ok status' do
+          expect(response).to have_http_status(:ok)
+        end
+
+        it 'returns the asked model' do
+          expect(response_body['id']).to eq(model.id)
+        end
+      end
+    end
+
+    include_examples 'simple crud not found with finder', :get, :edit
+  end
+end

data/lib/spec/shared_examples/simple_crud_for_index_with_scope.rb

@@ -3,7 +3,14 @@
 RSpec.shared_examples 'simple crud for index with scope' do
   let(:request_params) { {} }
   let(:my_models) { create_records(model_class, 2, scoped_attributes) }
-  let(:other_models) { create_records(model_class, 3, other_scoped_attributes) }
+  let(:other_models) { create_records(model_class, 3, other_scoped_attributes) if other_scoped_attributes }
+  let(:listed_ids) do
+    if check_html(:index)
+      rendered_records.map(&:id)
+    else
+      (check_paginate(:index) ? response_body['page'] : response_body).map { |m| m['id'] }
+    end
+  end
 
   # Hooks stay inside this context so co-including the example never
   # authenticates or stubs policies for sibling examples.
@@ -16,17 +23,13 @@ RSpec.shared_examples 'simple crud for index with scope' do
       get :index, params: with_route_params(request_params), format: format_param(:index)
     end
 
-    if check_html(:index)
-      it 'returns only the assigned scoped records' do
-        expect(rendered_records.map(&:id)).to match_array(my_models.map(&:id))
-      end
-    elsif check_paginate(:index)
-      it 'returns only the paginated scoped records' do
-        expect(response_body['page'].map { |m| m['id'] }).to match_array(my_models.map(&:id))
-      end
-    else
-      it 'returns only the unpaginated scoped records' do
-        expect(response_body.map { |m| m['id'] }).to match_array(my_models.map(&:id))
+    it 'returns the scoped records' do
+      expect(listed_ids).to match_array(my_models.map(&:id))
+    end
+
+    if scoped_order
+      it 'returns the scoped records in order' do
+        expect(listed_ids).to eq(instance_exec(my_models, &scoped_order).map(&:id))
       end
     end
   end

data/lib/spec/shared_examples/simple_crud_for_new_with_block.rb

@@ -5,7 +5,7 @@ RSpec.shared_examples 'simple crud for new with block' do
     include_context 'with authenticated user' if check_authenticate(:new)
 
     before do
-      make_policies_succeed(:new) if check_authorize(:new)
+      make_policies_succeed(:new, permissive: true) if check_authorize(:new)
       get :new, params: with_route_params({}), format: format_param(:new)
     end
 

data/lib/spec/shared_examples/simple_crud_for_new_with_build.rb

@@ -8,11 +8,17 @@ RSpec.shared_examples 'simple crud for new with build' do
       get :new, params: with_route_params({}), format: format_param(:new)
     end
 
-    it 'builds the record owned by the current user', :aggregate_failures do
-      if check_html(:new) || check_block(:new)
-        expect(rendered_record.public_send(owner_foreign_key)).to eq(current_user.id)
-      else
-        expect(response_body[owner_foreign_key.to_s]).to eq(current_user.id)
+    if owner_association
+      it 'builds the record owned by the current user', :aggregate_failures do
+        if check_html(:new) || check_block(:new)
+          expect(rendered_record.public_send(owner_foreign_key)).to eq(current_user.id)
+        else
+          expect(response_body[owner_foreign_key.to_s]).to eq(current_user.id)
+        end
+      end
+    else
+      it 'builds the record through the hook' do
+        expect(response).to be_successful
       end
     end
   end

data/lib/spec/shared_examples/simple_crud_for_owned_resource.rb

@@ -15,13 +15,23 @@ RSpec.shared_examples 'simple crud for owned resource' do
       expect(response).to have_http_status(:not_found)
     end
 
-    it 'ignores an attempt to update a record owned by another user', :aggregate_failures do
-      params = with_route_params(record_param(:update, someone_elses_model)).merge(body_params(model_params))
-      patch :update, params: params, format: format_param(:update)
-
-      expect(response).to have_http_status(:not_found)
-      expect(someone_elses_model.reload.public_send(required_attribute))
-        .not_to eq(model_params[required_attribute])
+    context 'when updating a record owned by another user' do
+      let!(:original_value) { required_attribute && someone_elses_model.public_send(required_attribute) }
+
+      before do
+        params = with_route_params(record_param(:update, someone_elses_model)).merge(body_params(model_params))
+        patch :update, params: params, format: format_param(:update)
+      end
+
+      it 'responds with not found' do
+        expect(response).to have_http_status(:not_found)
+      end
+
+      if required_attribute
+        it 'leaves the record untouched' do
+          expect(someone_elses_model.reload.public_send(required_attribute)).to eq(original_value)
+        end
+      end
     end
 
     it 'attributes a created record to the current user regardless of the request', :aggregate_failures do

data/lib/spec/shared_examples/simple_crud_for_show.rb

@@ -39,16 +39,18 @@ RSpec.shared_examples 'simple crud for show' do
       end
     end
 
-    describe 'when the model does not exist' do
-      include_context 'with authenticated user'
-      let(:show_params) { record_param(:show, nil, not_found: true) }
+    unless singular
+      describe 'when the model does not exist' do
+        include_context 'with authenticated user'
+        let(:show_params) { record_param(:show, nil, not_found: true) }
 
-      before do
-        show_request
-      end
+        before do
+          show_request
+        end
 
-      it 'responds with not found status' do
-        expect(response).to have_http_status(:not_found)
+        it 'responds with not found status' do
+          expect(response).to have_http_status(:not_found)
+        end
       end
     end
   end

data/lib/spec/shared_examples/simple_crud_for_show_with_block.rb

@@ -7,7 +7,7 @@ RSpec.shared_examples 'simple crud for show with block' do
     let!(:record) { model }
 
     before do
-      make_policies_succeed(:show) if check_authorize(:show)
+      make_policies_succeed(:show, permissive: true) if check_authorize(:show)
       get :show, params: with_route_params(record_param(:show, record)), format: format_param(:show)
     end
 

data/lib/spec/shared_examples/simple_crud_for_update.rb

@@ -61,24 +61,26 @@ RSpec.shared_examples 'simple crud for update' do
       end
     end
 
-    context 'when updating a model that doesn\'t exist' do
-      include_context 'with authenticated user'
+    unless singular
+      context 'when updating a model that doesn\'t exist' do
+        include_context 'with authenticated user'
 
-      before do
-        put :update, params: with_route_params(record_param(:update, nil, not_found: true)),
-                     format: format_param(:update)
-      end
+        before do
+          put :update, params: with_route_params(record_param(:update, nil, not_found: true)),
+                       format: format_param(:update)
+        end
 
-      it 'response with 404 status code' do
-        expect(response).to have_http_status(:not_found)
-      end
+        it 'response with 404 status code' do
+          expect(response).to have_http_status(:not_found)
+        end
 
-      it 'doesn\'t create an model' do
-        expect(model_class_object.count).to be 0
+        it 'doesn\'t create an model' do
+          expect(model_class_object.count).to be 0
+        end
       end
     end
 
-    unless check_raise_on_invalid(:update)
+    if invalid_case?(:update)
       context 'when updating with invalid attributes' do
         include_context 'with authenticated user' if check_authenticate(:update)
 

data/lib/spec/shared_examples/simple_crud_for_update_with_block.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'simple crud for update with block' do
+  describe 'PUT #update with a render block' do
+    include_context 'with authenticated user' if check_authenticate(:update)
+
+    let!(:record) { model }
+
+    context 'when successfully updating a record' do
+      before do
+        make_policies_succeed(:update, permissive: true) if check_authorize(:update)
+        put :update, params: with_route_params(body_params(model_params).merge(record_param(:update, record))),
+                     format: format_param(:update)
+      end
+
+      it 'passes the saved record to the block' do
+        expect(response).to render_or_redirect
+      end
+
+      it 'updates the record' do
+        expect(record.reload).to have_attributes(model_params)
+      end
+    end
+
+    if invalid_case?(:update)
+      context 'when updating with invalid attributes' do
+        before do
+          make_policies_succeed(:update, permissive: true) if check_authorize(:update)
+          put :update, params: with_route_params(body_params({ required_attribute => nil }.merge(owner_params))
+                                                         .merge(record_param(:update, record))),
+                       format: format_param(:update)
+        end
+
+        it 'does not change the record' do
+          expect(record.reload.public_send(required_attribute)).not_to be_nil
+        end
+      end
+    end
+  end
+end

data/lib/spec/shared_examples/simple_crud_for_update_with_finder.rb

@@ -5,8 +5,9 @@ RSpec.shared_examples 'simple crud for update with finder' do
     include_context 'with authenticated user' if check_authenticate(:update)
 
     context 'when successfully updating a model' do
+      let(:updated_attributes) { required_attribute ? { required_attribute => 'Updated' } : model_params }
       let(:update_params) do
-        with_route_params(body_params(required_attribute => 'Updated').merge(owner_params))
+        with_route_params(body_params(updated_attributes).merge(owner_params))
           .merge(finder_key => model.public_send(finder_key))
       end
 
@@ -15,13 +16,15 @@ RSpec.shared_examples 'simple crud for update with finder' do
         put :update, params: update_params, format: format_param(:update)
       end
 
-      it 'updates the model' do
-        expect(model.reload.public_send(required_attribute)).to eq('Updated')
+      if required_attribute
+        it 'updates the model' do
+          expect(model.reload.public_send(required_attribute)).to eq('Updated')
+        end
       end
 
       if check_block(:update)
         it 'passes the updated model to the block' do
-          expect(rendered_record.id).to eq(model.id)
+          expect(response).to render_or_redirect
         end
       elsif check_html(:update)
         it 'redirects to the updated record' do

data/lib/spec/shared_examples/simple_crud_not_found_with_finder.rb

@@ -1,14 +1,16 @@
 # frozen_string_literal: true
 
 RSpec.shared_examples 'simple crud not found with finder' do |http_method, action|
-  context 'when the model does not exist' do
-    before do
-      send(http_method, action, params: with_route_params(finder_key => "nonexistent-#{finder_key}"),
-                                format: format_param(action))
-    end
+  unless singular
+    context 'when the model does not exist' do
+      before do
+        send(http_method, action, params: with_route_params(finder_key => "nonexistent-#{finder_key}"),
+                                  format: format_param(action))
+      end
 
-    it 'responds with not found status' do
-      expect(response).to have_http_status(:not_found)
+      it 'responds with not found status' do
+        expect(response).to have_http_status(:not_found)
+      end
     end
   end
 end

data/spec/block_create_redirect/dummy_models_controller_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe BlockCreateRedirect::DummyModelsController, type: :controller do
+  include_examples 'simple crud for create with block'
+
+  describe 'without a validated attribute', simple_crud: { required_attribute: nil } do
+    include_examples 'simple crud for create with block'
+  end
+end

data/spec/block_edit/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe BlockEdit::DummyModelsController, type: :controller do
+  include_examples 'simple crud for edit with block'
+end

data/spec/block_finder/dummy_models_controller_spec.rb

@@ -4,6 +4,8 @@ require 'spec_helper'
 
 describe BlockFinder::DummyModelsController, type: :controller do
   include_examples 'simple crud for edit'
+  include_examples 'simple crud for edit with finder'
+  include_examples 'simple crud for edit with block'
   include_examples 'simple crud for show with finder'
   include_examples 'simple crud for update with finder'
   include_examples 'simple crud for destroy with finder'

data/spec/block_policy_show/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe BlockPolicyShow::DummyModelsController, type: :controller do
+  include_examples 'simple crud for show with block'
+end

data/spec/block_redirect/dummy_models_controller_spec.rb

@@ -4,4 +4,5 @@ require 'spec_helper'
 
 describe BlockRedirect::DummyModelsController, type: :controller do
   include_examples 'simple crud for destroy'
+  include_examples 'simple crud for destroy with block'
 end

data/spec/block_update/dummy_models_controller_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe BlockUpdate::DummyModelsController, type: :controller do
+  include_examples 'simple crud for update with block'
+
+  describe 'without a validated attribute', simple_crud: { required_attribute: nil } do
+    include_examples 'simple crud for update with block'
+  end
+end

data/spec/dummy/app/controllers/block_create_redirect/dummy_models_controller.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module BlockCreateRedirect
+  class DummyModelsController < HtmlModes::BaseController
+    simple_crud_for :create, html: true, authenticate: false, authorize: false do |record, saved|
+      if saved
+        redirect_to action: :show, id: record.id
+      else
+        render json: { errors: record.errors.full_messages }, status: :unprocessable_entity
+      end
+    end
+  end
+end

data/spec/dummy/app/controllers/block_edit/dummy_models_controller.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module BlockEdit
+  class DummyModelsController < BlockModes::BaseController
+    simple_crud_for :edit, html: true, authenticate: false, authorize: false do |record|
+      render_model(record, :edit)
+    end
+  end
+end

data/spec/dummy/app/controllers/block_policy_show/dummy_models_controller.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module BlockPolicyShow
+  # The block consults the policy again (as an app picking a page by role would).
+  class DummyModelsController < BlockModes::BaseController
+    include Pundit::Authorization
+
+    simple_crud_for :show, html: true, authenticate: false do |record|
+      render_model(record, :show) if policy(record).update?
+    end
+  end
+end

data/spec/dummy/app/controllers/block_update/dummy_models_controller.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module BlockUpdate
+  class DummyModelsController < HtmlModes::BaseController
+    simple_crud_for :update, html: false, authenticate: false, authorize: false do |_record, saved|
+      render json: { updated: saved }
+    end
+  end
+end

data/spec/dummy/app/controllers/parented/dummy_models_controller.rb

@@ -15,6 +15,7 @@ module Parented
 
     simple_crud_defaults parent: :owner, authorize: false
     simple_crud_for :index
+    simple_crud_for :new
     simple_crud_for :show
     simple_crud_for :create
     simple_crud_for :update

data/spec/dummy/app/controllers/scoped_order/dummy_models_controller.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module ScopedOrder
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    simple_crud_for :index, scope: ->(_user) { DummyModel.order(:name, :id) }, authorize: false
+  end
+end

data/spec/dummy/app/controllers/singular/dummy_models_controller.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Singular
+  class DummyModelsController < HtmlModes::BaseController
+    FIRST_RECORD = ->(_params) { DummyModel.first! }
+
+    simple_crud_for :show, html: false, authenticate: false, authorize: false, finder: FIRST_RECORD
+    simple_crud_for :edit, html: false, authenticate: false, authorize: false, finder: FIRST_RECORD
+    simple_crud_for :update, html: false, authenticate: false, authorize: false, finder: FIRST_RECORD
+    simple_crud_for :destroy, html: false, authenticate: false, authorize: false, finder: FIRST_RECORD
+  end
+end

data/spec/dummy/app/views/block_edit/dummy_models/edit.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= model.name %></span>

data/spec/dummy/app/views/block_policy_show/dummy_models/show.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= model.name %></span>

data/spec/dummy/config/routes.rb

@@ -36,6 +36,18 @@ Rails.application.routes.draw do
     resources :dummy_models, only: %i[show edit update destroy], param: :slug
   end
 
+  namespace :block_update do
+    resources :dummy_models, only: :update
+  end
+
+  namespace :singular do
+    resource :dummy_model, only: %i[show edit update destroy]
+  end
+
+  namespace :scoped_order do
+    resources :dummy_models, only: :index
+  end
+
   namespace :scoped do
     resources :dummy_models, only: :index
   end
@@ -64,10 +76,22 @@ Rails.application.routes.draw do
     resources :dummy_models, only: :show
   end
 
+  namespace :block_edit do
+    resources :dummy_models, only: :edit
+  end
+
   namespace :block_show do
     resources :dummy_models, only: :show
   end
 
+  namespace :block_policy_show do
+    resources :dummy_models, only: :show
+  end
+
+  namespace :block_create_redirect do
+    resources :dummy_models, only: %i[show create]
+  end
+
   namespace :html_new do
     resources :dummy_models, only: :new
   end

data/spec/finder/dummy_models_controller_spec.rb

@@ -4,10 +4,16 @@ require 'spec_helper'
 
 describe Finder::DummyModelsController, type: :controller do
   include_examples 'simple crud for edit'
+  include_examples 'simple crud for edit with finder'
   include_examples 'simple crud for show with finder'
   include_examples 'simple crud for update with finder'
   include_examples 'simple crud for destroy with finder'
   include_examples 'simple crud for show'
   include_examples 'simple crud for update'
   include_examples 'simple crud for destroy'
+
+  describe 'without a validated attribute', simple_crud: { required_attribute: nil } do
+    include_examples 'simple crud for update'
+    include_examples 'simple crud for update with finder'
+  end
 end

data/spec/html_finder/dummy_models_controller_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 describe HtmlFinder::DummyModelsController, type: :controller do
   include_examples 'simple crud for edit'
+  include_examples 'simple crud for edit with finder'
   include_examples 'simple crud for show with finder'
   include_examples 'simple crud for update with finder'
   include_examples 'simple crud for destroy with finder'

data/spec/parented/dummy_models_controller_spec.rb

@@ -19,6 +19,16 @@ describe Parented::DummyModelsController, simple_crud: {
     end
   end
 
+  describe 'new with a build hook and no owner association',
+           simple_crud: { owner_association: nil, route_params: -> { { owner_id: current_user.id } } } do
+    include_examples 'simple crud for new with build'
+  end
+
+  describe 'create with a build hook and no owner association',
+           simple_crud: { owner_association: nil, route_params: -> { { owner_id: current_user.id } } } do
+    include_examples 'simple crud for create with build'
+  end
+
   describe 'POST #create with parent: and owned_by: together' do
     it 'raises, they are the same relation source' do
       expect do

data/spec/scoped_order/dummy_models_controller_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe ScopedOrder::DummyModelsController, simple_crud: {
+  other_scoped_attributes: nil,
+  scoped_order: ->(records) { records.sort_by { |r| [r.name, r.id] } }
+}, type: :controller do
+  include_examples 'simple crud for index with scope'
+end

data/spec/singular/dummy_models_controller_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Singular::DummyModelsController, simple_crud: { singular: true }, type: :controller do
+  include_examples 'simple crud for show'
+  include_examples 'simple crud for edit'
+  include_examples 'simple crud for update'
+  include_examples 'simple crud for destroy'
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: wor-simple_crud
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - icoluccio
 bindir: bin
 cert_chain: []
-date: 2026-09-18 00:00:00.000000000 Z
+date: 2026-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -83,6 +83,7 @@ files:
 - lib/simple_crud/update_context.rb
 - lib/simple_crud/version.rb
 - lib/spec/matchers/have_been_serialized_with.rb
+- lib/spec/matchers/render_or_redirect.rb
 - lib/spec/response_helper.rb
 - lib/spec/shared_contexts/authenticate_user.rb
 - lib/spec/shared_examples/authorization_adapter_authorize.rb
@@ -93,6 +94,8 @@ files:
 - lib/spec/shared_examples/simple_crud_for_destroy_with_block.rb
 - lib/spec/shared_examples/simple_crud_for_destroy_with_finder.rb
 - lib/spec/shared_examples/simple_crud_for_edit.rb
+- lib/spec/shared_examples/simple_crud_for_edit_with_block.rb
+- lib/spec/shared_examples/simple_crud_for_edit_with_finder.rb
 - lib/spec/shared_examples/simple_crud_for_index.rb
 - lib/spec/shared_examples/simple_crud_for_index_with_block.rb
 - lib/spec/shared_examples/simple_crud_for_index_with_scope.rb
@@ -105,6 +108,7 @@ files:
 - lib/spec/shared_examples/simple_crud_for_show_with_block.rb
 - lib/spec/shared_examples/simple_crud_for_show_with_finder.rb
 - lib/spec/shared_examples/simple_crud_for_update.rb
+- lib/spec/shared_examples/simple_crud_for_update_with_block.rb
 - lib/spec/shared_examples/simple_crud_for_update_with_finder.rb
 - lib/spec/shared_examples/simple_crud_not_found_with_finder.rb
 - lib/spec/shared_examples/simple_crud_renders_template.rb
@@ -114,12 +118,16 @@ files:
 - pull_request_template.md
 - spec/block/dummy_models_controller_spec.rb
 - spec/block_create/dummy_models_controller_spec.rb
+- spec/block_create_redirect/dummy_models_controller_spec.rb
 - spec/block_destroy/dummy_models_controller_spec.rb
+- spec/block_edit/dummy_models_controller_spec.rb
 - spec/block_finder/dummy_models_controller_spec.rb
 - spec/block_json/dummy_models_controller_spec.rb
 - spec/block_new/dummy_models_controller_spec.rb
+- spec/block_policy_show/dummy_models_controller_spec.rb
 - spec/block_redirect/dummy_models_controller_spec.rb
 - spec/block_show/dummy_models_controller_spec.rb
+- spec/block_update/dummy_models_controller_spec.rb
 - spec/blueprint/dummy_models_controller_spec.rb
 - spec/blueprint_unpaginated/dummy_models_controller_spec.rb
 - spec/built/dummy_models_controller_spec.rb
@@ -131,13 +139,17 @@ files:
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/block/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_create/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_create_redirect/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_destroy/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_edit/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_finder/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_json/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_modes/base_controller.rb
 - spec/dummy/app/controllers/block_new/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_policy_show/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_redirect/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_show/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_update/dummy_models_controller.rb
 - spec/dummy/app/controllers/blueprint/dummy_models_controller.rb
 - spec/dummy/app/controllers/blueprint_unpaginated/dummy_models_controller.rb
 - spec/dummy/app/controllers/built/dummy_models_controller.rb
@@ -163,8 +175,10 @@ files:
 - spec/dummy/app/controllers/redirect/dummy_models_controller.rb
 - spec/dummy/app/controllers/redirect_auth/dummy_models_controller.rb
 - spec/dummy/app/controllers/scoped/dummy_models_controller.rb
+- spec/dummy/app/controllers/scoped_order/dummy_models_controller.rb
 - spec/dummy/app/controllers/scoped_params/dummy_models_controller.rb
 - spec/dummy/app/controllers/scoped_symbol/dummy_models_controller.rb
+- spec/dummy/app/controllers/singular/dummy_models_controller.rb
 - spec/dummy/app/controllers/strict/dummy_models_controller.rb
 - spec/dummy/app/controllers/unpaginated_scoped/dummy_models_controller.rb
 - spec/dummy/app/controllers/without_pagination/dummy_models_controller.rb
@@ -176,7 +190,9 @@ files:
 - spec/dummy/app/serializers/dummy_model_plain_serializer.rb
 - spec/dummy/app/serializers/dummy_model_serializer.rb
 - spec/dummy/app/views/block/dummy_models/index.html.erb
+- spec/dummy/app/views/block_edit/dummy_models/edit.html.erb
 - spec/dummy/app/views/block_new/dummy_models/new.html.erb
+- spec/dummy/app/views/block_policy_show/dummy_models/show.html.erb
 - spec/dummy/app/views/block_show/dummy_models/show.html.erb
 - spec/dummy/app/views/html/dummy_models/index.html.erb
 - spec/dummy/app/views/html_create/dummy_models/new.html.erb
@@ -242,6 +258,7 @@ files:
 - spec/redirect/dummy_models_controller_spec.rb
 - spec/redirect_auth/dummy_models_controller_spec.rb
 - spec/scoped/dummy_models_controller_spec.rb
+- spec/scoped_order/dummy_models_controller_spec.rb
 - spec/scoped_params/dummy_models_controller_spec.rb
 - spec/scoped_symbol/dummy_models_controller_spec.rb
 - spec/simple_crud/action_context_spec.rb
@@ -256,6 +273,7 @@ files:
 - spec/simple_crud/show_context_spec.rb
 - spec/simple_crud_configuration_spec.rb
 - spec/simple_crud_controller_spec.rb
+- spec/singular/dummy_models_controller_spec.rb
 - spec/spec_helper.rb
 - spec/spy.rb
 - spec/strict/dummy_models_controller_spec.rb