wor-simple_crud 0.3.0 → 0.4.0

data/spec/dummy/app/controllers/finder/dummy_models_controller.rb

@@ -6,11 +6,6 @@ module Finder
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     def dummy_model_params
       params.permit(:name, :something, :user_id)
     end
@@ -18,5 +13,6 @@ module Finder
     simple_crud_for :show, finder: ->(params) { DummyModel.find_by!(slug: params[:slug]) }
     simple_crud_for :update, finder: :find_by_slug
     simple_crud_for :destroy, finder: ->(params) { DummyModel.find_by!(slug: params[:slug]) }
+    simple_crud_for :edit, finder: ->(params) { DummyModel.find_by!(slug: params[:slug]) }
   end
 end

data/spec/dummy/app/controllers/html_finder/dummy_models_controller.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module HtmlFinder
+  class DummyModelsController < HtmlModes::BaseController
+    include Pundit::Authorization
+
+    simple_crud_for :show, html: true, authenticate: false, authorize: false,
+                           finder: ->(params) { DummyModel.find_by!(slug: params[:slug]) }
+    simple_crud_for :update, html: true, authenticate: false, authorize: false,
+                             finder: :find_by_slug
+    simple_crud_for :destroy, html: true, authenticate: false, authorize: false,
+                              finder: ->(params) { DummyModel.find_by!(slug: params[:slug]) }
+    simple_crud_for :new, html: true, build: -> { current_user.dummy_models.build }
+    simple_crud_for :edit, html: true, authenticate: false, authorize: false,
+                           finder: ->(params) { DummyModel.find_by!(slug: params[:slug]) }
+  end
+end

data/spec/dummy/app/controllers/html_modes/base_controller.rb

@@ -5,11 +5,6 @@ module HtmlModes
     include Wor::Paginate
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     def dummy_model_params
       params.permit(:name, :something, :user_id, :slug)
     end

data/spec/dummy/app/controllers/html_scoped/dummy_models_controller.rb

@@ -3,6 +3,6 @@
 module HtmlScoped
   class DummyModelsController < HtmlModes::BaseController
     simple_crud_for :index, html: true, scope: ->(user) { DummyModel.where(user: user) },
-                            authenticate: false, authorize: false
+                            authorize: false
   end
 end

data/spec/dummy/app/controllers/invalid_status/dummy_models_controller.rb

@@ -2,7 +2,7 @@
 
 module InvalidStatus
   class DummyModelsController < HtmlModes::BaseController
-    simple_crud_for :create, authenticate: false, authorize: false do |record, saved|
+    simple_crud_for :create, html: true, authenticate: false, authorize: false do |record, saved|
       if saved
         redirect_to(record)
       else

data/spec/dummy/app/controllers/nested/dummy_models_controller.rb

@@ -6,11 +6,6 @@ module Nested
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     def dummy_model_params
       params.require(:dummy_model).permit(:name, :something, :user_id, :slug)
     end

data/spec/dummy/app/controllers/nested_route/dummy_models_controller.rb

@@ -6,11 +6,6 @@ module NestedRoute
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     def dummy_model_params
       params.require(:dummy_model).permit(:name, :something, :user_id, :slug, :classroom_slug)
     end

data/spec/dummy/app/controllers/redirect_auth/dummy_models_controller.rb

@@ -10,11 +10,6 @@ module RedirectAuth
 
     rescue_from UnauthenticatedError, with: :redirect_to_login
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     def authenticate_user!
       raise UnauthenticatedError unless current_user
     end

data/spec/dummy/app/controllers/scoped/dummy_models_controller.rb

@@ -6,11 +6,6 @@ module Scoped
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     simple_crud_for :index, scope: ->(user) { DummyModel.where(user: user) }
   end
 end

data/spec/dummy/app/controllers/scoped_params/dummy_models_controller.rb

@@ -6,11 +6,6 @@ module ScopedParams
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     simple_crud_for :index, scope: ->(user, params) { DummyModel.where(user: user, something: params[:something]) }
   end
 end

data/spec/dummy/app/controllers/strict/dummy_models_controller.rb

@@ -6,11 +6,6 @@ module Strict
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     def dummy_model_params
       params.permit(:name, :something, :user_id, :slug)
     end

data/spec/dummy/app/controllers/unpaginated_scoped/dummy_models_controller.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module UnpaginatedScoped
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    simple_crud_for :index, paginate: false, scope: ->(user) { DummyModel.where(user: user) }
+  end
+end

data/spec/dummy/app/controllers/without_pagination/dummy_models_controller.rb

@@ -5,11 +5,6 @@ module WithoutPagination
     include Pundit::Authorization
     extend SimpleCrudController
 
-    before_action :set_params
-    def set_params
-      SimpleCrudController.params = params
-    end
-
     simple_crud_for :index, paginate: false
   end
 end

data/spec/dummy/app/models/dummy_model_policy.rb

@@ -20,6 +20,10 @@ class DummyModelPolicy
     check_user
   end
 
+  def edit?
+    update?
+  end
+
   def create?
     check_user
   end
@@ -33,6 +37,6 @@ class DummyModelPolicy
   end
 
   def index?
-    check_user
+    user.present?
   end
 end

data/spec/dummy/app/views/html_finder/dummy_models/edit.html.erb

@@ -0,0 +1 @@
+<h1>Edit dummy model</h1>

data/spec/dummy/app/views/html_finder/dummy_models/new.html.erb

@@ -0,0 +1 @@
+<h1>New dummy model</h1>

data/spec/dummy/app/views/html_finder/dummy_models/show.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= @record.name %></span>

data/spec/dummy/config/routes.rb

@@ -17,13 +17,25 @@ Rails.application.routes.draw do
   end
 
   namespace :finder do
-    resources :dummy_models, only: %i[show update destroy], param: :slug
+    resources :dummy_models, only: %i[show edit update destroy], param: :slug
+  end
+
+  namespace :html_finder do
+    resources :dummy_models, only: %i[new show edit update destroy], param: :slug
+  end
+
+  namespace :block_finder do
+    resources :dummy_models, only: %i[show edit update destroy], param: :slug
   end
 
   namespace :scoped do
     resources :dummy_models, only: :index
   end
 
+  namespace :unpaginated_scoped do
+    resources :dummy_models, only: :index
+  end
+
   namespace :scoped_params do
     resources :dummy_models, only: :index
   end
@@ -72,6 +84,14 @@ Rails.application.routes.draw do
     resources :dummy_models, only: :destroy
   end
 
+  namespace :block_redirect do
+    resources :dummy_models, only: %i[show destroy]
+  end
+
+  namespace :block_json do
+    resources :dummy_models, only: %i[index show new]
+  end
+
   namespace :built do
     resources :dummy_models, only: %i[new create]
   end

data/spec/dummy_model_policy_spec.rb

@@ -7,15 +7,25 @@ describe DummyModelPolicy do
   let(:other_user) { create(:user) }
   let(:dummy_model) { create(:dummy_model, user: user) }
 
-  %i[destroy? index?].each do |policy_method|
-    describe "##{policy_method}" do
-      it 'allows the owning user' do
-        expect(described_class.new(user, dummy_model).public_send(policy_method)).to be true
-      end
+  describe '#destroy?' do
+    it 'allows the owning user' do
+      expect(described_class.new(user, dummy_model).destroy?).to be true
+    end
+
+    it 'denies a different user' do
+      expect(described_class.new(other_user, dummy_model).destroy?).to be false
+    end
+  end
+
+  # :index authorizes the model class, not an instance, so the policy can
+  # only reason about the user.
+  describe '#index?' do
+    it 'allows any signed-in user' do
+      expect(described_class.new(other_user, dummy_model).index?).to be true
+    end
 
-      it 'denies a different user' do
-        expect(described_class.new(other_user, dummy_model).public_send(policy_method)).to be false
-      end
+    it 'denies an anonymous user' do
+      expect(described_class.new(nil, dummy_model).index?).to be false
     end
   end
 end

data/spec/finder/dummy_models_controller_spec.rb

@@ -3,6 +3,7 @@
 require 'spec_helper'
 
 describe Finder::DummyModelsController, type: :controller do
+  include_examples 'simple crud for edit'
   include_examples 'simple crud for show with finder'
   include_examples 'simple crud for update with finder'
   include_examples 'simple crud for destroy with finder'

data/spec/html_finder/dummy_models_controller_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlFinder::DummyModelsController, type: :controller do
+  include_examples 'simple crud for edit'
+  include_examples 'simple crud for show with finder'
+  include_examples 'simple crud for update with finder'
+  include_examples 'simple crud for destroy with finder'
+  include_examples 'simple crud for new with build'
+end

data/spec/html_scoped/dummy_models_controller_spec.rb

@@ -3,5 +3,5 @@
 require 'spec_helper'
 
 describe HtmlScoped::DummyModelsController, type: :controller do
-  include_examples 'simple crud for index'
+  include_examples 'simple crud for index with scope'
 end

data/spec/scoped_params/dummy_models_controller_spec.rb

@@ -2,10 +2,11 @@
 
 require 'spec_helper'
 
-describe ScopedParams::DummyModelsController, type: :controller do
+describe ScopedParams::DummyModelsController, simple_crud: {
+  scoped_attributes: -> { { user: current_user, something: 42 } },
+  other_scoped_attributes: -> { { user: other_user, something: 7 } }
+}, type: :controller do
   include_examples 'simple crud for index with scope' do
-    let(:my_models) { create_list(:dummy_model, 2, user: user, something: 42) }
-    let(:other_models) { create_list(:dummy_model, 1, user: user, something: 7) }
     let(:request_params) { { something: 42 } }
   end
 end

data/spec/simple_crud/rspec_config_spec.rb

@@ -39,6 +39,16 @@ describe SimpleCrud::RSpec do
       end
     end
 
+    it 'derives other_scoped_attributes from model_attributes and the other user' do
+      expect(other_scoped_attributes).to eq(user: other_user)
+    end
+
+    it 'requires a Hash model_attributes before deriving other_scoped_attributes' do
+      with_config_override(:model_attributes, -> { 'not-a-hash' }) do
+        expect { other_scoped_attributes }.to raise_error(ArgumentError, /override other_scoped_attributes instead/)
+      end
+    end
+
     it 'lets settings be overridden and restored', :aggregate_failures do
       original = config.required_attribute
 
@@ -63,5 +73,34 @@ describe SimpleCrud::RSpec do
 
       SimpleCrud::RSpec.configure { |c| c.required_attribute = original }
     end
+
+    it 'falls back to global config when no metadata overrides' do
+      expect(setting(:finder_key)).to eq(:slug)
+    end
+
+    it 'defaults model_attributes to the owner association and current user' do
+      expect(model_attributes).to eq(user: current_user)
+    end
+
+    it 'raises a clear error when owner_association has no setter on the model' do
+      klass = Class.new { def self.column_names = [] }
+      allow(self).to receive_messages(owner_association: :nonexistent, model_class_object: klass)
+      expect { validate_owner_association! }.to raise_error(/owner_association is :nonexistent/)
+    end
+
+    describe 'with simple_crud metadata',
+             simple_crud: { finder_key: :token, model_attributes: -> { { overridden: true } } } do
+      it 'prefers metadata for overridden settings' do
+        expect(setting(:finder_key)).to eq(:token)
+      end
+
+      it 'still falls back to global config for the rest' do
+        expect(required_attribute).to eq(:name)
+      end
+
+      it 'resolves model_attributes from metadata in the example context' do
+        expect(model_attributes).to eq(overridden: true)
+      end
+    end
   end
 end

data/spec/simple_crud_controller_spec.rb

@@ -8,6 +8,14 @@ class UnpoliceableThingsController
   extend SimpleCrudController
 end
 
+class BaseWithDefaultsController
+  extend SimpleCrudController
+  simple_crud_defaults authorize: false, authenticate: false, authenticate_headers: true
+end
+
+class InheritingController < BaseWithDefaultsController
+end
+
 describe SimpleCrudController do
   describe '.check_policies' do
     it 'returns when a matching policy exists' do
@@ -21,6 +29,36 @@ describe SimpleCrudController do
     end
   end
 
+  describe '.simple_crud_defaults' do
+    it 'applies to parameters_with_defaults', :aggregate_failures do
+      params = BaseWithDefaultsController.parameters_with_defaults({})
+      expect(params[:authorize]).to be false
+      expect(params[:authenticate]).to be false
+      expect(params[:authenticate_headers]).to be true
+    end
+
+    it 'are inherited by subclasses', :aggregate_failures do
+      params = InheritingController.parameters_with_defaults({})
+      expect(params[:authorize]).to be false
+      expect(params[:authenticate]).to be false
+      expect(params[:authenticate_headers]).to be true
+    end
+
+    it 'can be overridden per action', :aggregate_failures do
+      params = InheritingController.parameters_with_defaults(authorize: true)
+      expect(params[:authorize]).to be true
+      expect(params[:authenticate]).to be false
+      expect(params[:authenticate_headers]).to be true
+    end
+
+    it 'does not affect unrelated controllers', :aggregate_failures do
+      params = DummyModelsController.parameters_with_defaults({})
+      expect(params[:authorize]).to be true
+      expect(params[:authenticate]).to be true
+      expect(params[:authenticate_headers]).to be true
+    end
+  end
+
   describe '.check_serializer' do
     it 'returns when the serializer option is blank' do
       expect { DummyModelsController.check_serializer({}) }.not_to raise_error

data/spec/unpaginated_scoped/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe UnpaginatedScoped::DummyModelsController, type: :controller do
+  include_examples 'simple crud for index with scope'
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: wor-simple_crud
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - icoluccio
 bindir: bin
 cert_chain: []
-date: 2026-08-21 00:00:00.000000000 Z
+date: 2026-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -48,6 +48,7 @@ files:
 - README.md
 - Rakefile
 - lib/simple_crud.rb
+- lib/simple_crud/action_lambdas.rb
 - lib/simple_crud/authorization/action_policy_adapter.rb
 - lib/simple_crud/authorization/adapter.rb
 - lib/simple_crud/authorization/can_can_can_adapter.rb
@@ -62,6 +63,12 @@ files:
 - lib/simple_crud/rspec.rb
 - lib/simple_crud/rspec/config.rb
 - lib/simple_crud/rspec/helpers.rb
+- lib/simple_crud/rspec/helpers/authentication.rb
+- lib/simple_crud/rspec/helpers/controller_options.rb
+- lib/simple_crud/rspec/helpers/models.rb
+- lib/simple_crud/rspec/helpers/policies.rb
+- lib/simple_crud/rspec/helpers/requests.rb
+- lib/simple_crud/rspec/helpers/settings.rb
 - lib/simple_crud/simple_crud_controller.rb
 - lib/simple_crud/version.rb
 - lib/spec/matchers/have_been_serialized_with.rb
@@ -74,6 +81,7 @@ files:
 - lib/spec/shared_examples/simple_crud_for_destroy.rb
 - lib/spec/shared_examples/simple_crud_for_destroy_with_block.rb
 - lib/spec/shared_examples/simple_crud_for_destroy_with_finder.rb
+- lib/spec/shared_examples/simple_crud_for_edit.rb
 - lib/spec/shared_examples/simple_crud_for_index.rb
 - lib/spec/shared_examples/simple_crud_for_index_with_block.rb
 - lib/spec/shared_examples/simple_crud_for_index_with_scope.rb
@@ -94,7 +102,10 @@ files:
 - spec/block/dummy_models_controller_spec.rb
 - spec/block_create/dummy_models_controller_spec.rb
 - spec/block_destroy/dummy_models_controller_spec.rb
+- spec/block_finder/dummy_models_controller_spec.rb
+- spec/block_json/dummy_models_controller_spec.rb
 - spec/block_new/dummy_models_controller_spec.rb
+- spec/block_redirect/dummy_models_controller_spec.rb
 - spec/block_show/dummy_models_controller_spec.rb
 - spec/built/dummy_models_controller_spec.rb
 - spec/dummy/Rakefile
@@ -103,8 +114,11 @@ files:
 - spec/dummy/app/controllers/block/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_create/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_destroy/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_finder/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_json/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_modes/base_controller.rb
 - spec/dummy/app/controllers/block_new/dummy_models_controller.rb
+- spec/dummy/app/controllers/block_redirect/dummy_models_controller.rb
 - spec/dummy/app/controllers/block_show/dummy_models_controller.rb
 - spec/dummy/app/controllers/built/dummy_models_controller.rb
 - spec/dummy/app/controllers/dummy_models_controller.rb
@@ -112,6 +126,7 @@ files:
 - spec/dummy/app/controllers/html/dummy_models_controller.rb
 - spec/dummy/app/controllers/html_create/dummy_models_controller.rb
 - spec/dummy/app/controllers/html_destroy/dummy_models_controller.rb
+- spec/dummy/app/controllers/html_finder/dummy_models_controller.rb
 - spec/dummy/app/controllers/html_modes/base_controller.rb
 - spec/dummy/app/controllers/html_new/dummy_models_controller.rb
 - spec/dummy/app/controllers/html_scoped/dummy_models_controller.rb
@@ -125,6 +140,7 @@ files:
 - spec/dummy/app/controllers/scoped/dummy_models_controller.rb
 - spec/dummy/app/controllers/scoped_params/dummy_models_controller.rb
 - spec/dummy/app/controllers/strict/dummy_models_controller.rb
+- spec/dummy/app/controllers/unpaginated_scoped/dummy_models_controller.rb
 - spec/dummy/app/controllers/without_pagination/dummy_models_controller.rb
 - spec/dummy/app/models/application_record.rb
 - spec/dummy/app/models/concerns/.keep
@@ -138,6 +154,9 @@ files:
 - spec/dummy/app/views/html/dummy_models/index.html.erb
 - spec/dummy/app/views/html_create/dummy_models/new.html.erb
 - spec/dummy/app/views/html_destroy/dummy_models/show.html.erb
+- spec/dummy/app/views/html_finder/dummy_models/edit.html.erb
+- spec/dummy/app/views/html_finder/dummy_models/new.html.erb
+- spec/dummy/app/views/html_finder/dummy_models/show.html.erb
 - spec/dummy/app/views/html_new/dummy_models/new.html.erb
 - spec/dummy/app/views/html_scoped/dummy_models/index.html.erb
 - spec/dummy/app/views/html_show/dummy_models/show.html.erb
@@ -180,6 +199,7 @@ files:
 - spec/html/dummy_models_controller_spec.rb
 - spec/html_create/dummy_models_controller_spec.rb
 - spec/html_destroy/dummy_models_controller_spec.rb
+- spec/html_finder/dummy_models_controller_spec.rb
 - spec/html_new/dummy_models_controller_spec.rb
 - spec/html_scoped/dummy_models_controller_spec.rb
 - spec/html_show/dummy_models_controller_spec.rb
@@ -202,6 +222,7 @@ files:
 - spec/spec_helper.rb
 - spec/spy.rb
 - spec/strict/dummy_models_controller_spec.rb
+- spec/unpaginated_scoped/dummy_models_controller_spec.rb
 - spec/without_pagination/dummy_models_controller_spec.rb
 - wor-simple_crud.gemspec
 homepage: https://github.com/icoluccio/simple-crud