wor-simple_crud 0.2.1 → 0.3.1

data/spec/dummy/app/controllers/nested_route/dummy_models_controller.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module NestedRoute
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    before_action :set_params
+    def set_params
+      SimpleCrudController.params = params
+    end
+
+    def dummy_model_params
+      params.require(:dummy_model).permit(:name, :something, :user_id, :slug, :classroom_slug)
+    end
+
+    NESTED_FINDER = lambda do |params|
+      DummyModel.find_by!(classroom_slug: params[:classroom_slug], slug: params[:slug])
+    end
+
+    simple_crud_for :show, finder: NESTED_FINDER
+    simple_crud_for :destroy, finder: NESTED_FINDER
+    simple_crud_for :create
+  end
+end

data/spec/dummy/app/controllers/redirect/dummy_models_controller.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module Redirect
+  class DummyModelsController < HtmlModes::BaseController
+    simple_crud_for :create, html: true, authenticate: false, authorize: false,
+                             redirect: ->(_record) { dummy_models_path }
+    simple_crud_for :destroy, html: true, authenticate: false, authorize: false,
+                              redirect: '/block_new/dummy_models/new'
+  end
+end

data/spec/dummy/app/controllers/redirect_auth/dummy_models_controller.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module RedirectAuth
+  class UnauthenticatedError < StandardError; end
+
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    rescue_from UnauthenticatedError, with: :redirect_to_login
+
+    before_action :set_params
+    def set_params
+      SimpleCrudController.params = params
+    end
+
+    def authenticate_user!
+      raise UnauthenticatedError unless current_user
+    end
+
+    def redirect_to_login(_exception)
+      redirect_to '/login'
+    end
+
+    simple_crud_for :index, authorize: false
+  end
+end

data/spec/dummy/app/controllers/scoped/dummy_models_controller.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Scoped
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    before_action :set_params
+    def set_params
+      SimpleCrudController.params = params
+    end
+
+    simple_crud_for :index, scope: ->(user) { DummyModel.where(user: user) }
+  end
+end

data/spec/dummy/app/controllers/scoped_params/dummy_models_controller.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module ScopedParams
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    before_action :set_params
+    def set_params
+      SimpleCrudController.params = params
+    end
+
+    simple_crud_for :index, scope: ->(user, params) { DummyModel.where(user: user, something: params[:something]) }
+  end
+end

data/spec/dummy/app/controllers/strict/dummy_models_controller.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Strict
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    before_action :set_params
+    def set_params
+      SimpleCrudController.params = params
+    end
+
+    def dummy_model_params
+      params.permit(:name, :something, :user_id, :slug)
+    end
+
+    simple_crud_for :create, raise_on_invalid: true
+    simple_crud_for :update, raise_on_invalid: true
+  end
+end

data/spec/dummy/app/controllers/unpaginated_scoped/dummy_models_controller.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module UnpaginatedScoped
+  class DummyModelsController < ApplicationController
+    include Wor::Paginate
+    include Pundit::Authorization
+    extend SimpleCrudController
+
+    before_action :set_params
+    def set_params
+      SimpleCrudController.params = params
+    end
+
+    simple_crud_for :index, paginate: false, scope: ->(user) { DummyModel.where(user: user) }
+  end
+end

data/spec/dummy/app/models/dummy_model.rb

@@ -4,4 +4,8 @@ require_relative 'dummy_model_policy'
 class DummyModel < ApplicationRecord
   belongs_to :user
   validates :name, presence: true
+
+  def self.find_by_slug(params)
+    find_by!(slug: params[:slug])
+  end
 end

data/spec/dummy/app/models/dummy_model_policy.rb

@@ -20,15 +20,23 @@ class DummyModelPolicy
     check_user
   end
 
+  def edit?
+    update?
+  end
+
   def create?
     check_user
   end
 
+  def new?
+    check_user
+  end
+
   def destroy?
     check_user
   end
 
   def index?
-    check_user
+    user.present?
   end
 end

data/spec/dummy/app/views/block/dummy_models/index.html.erb

@@ -0,0 +1,3 @@
+<% models.each do |model| %>
+  <span class="model"><%= model.name %></span>
+<% end %>

data/spec/dummy/app/views/block_new/dummy_models/new.html.erb

@@ -0,0 +1 @@
+<span class="record">new <%= model.new_record? %></span>

data/spec/dummy/app/views/block_show/dummy_models/show.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= model.name %></span>

data/spec/dummy/app/views/html/dummy_models/index.html.erb

@@ -0,0 +1,3 @@
+<% @records.each do |record| %>
+  <span class="record"><%= record.name %></span>
+<% end %>

data/spec/dummy/app/views/html_create/dummy_models/new.html.erb

@@ -0,0 +1 @@
+<span class="record">errors: <%= @record.errors.full_messages.join(',') %></span>

data/spec/dummy/app/views/html_destroy/dummy_models/show.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= @record.name %></span>

data/spec/dummy/app/views/html_finder/dummy_models/edit.html.erb

@@ -0,0 +1 @@
+<h1>Edit dummy model</h1>

data/spec/dummy/app/views/html_finder/dummy_models/new.html.erb

@@ -0,0 +1 @@
+<h1>New dummy model</h1>

data/spec/dummy/app/views/html_finder/dummy_models/show.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= @record.name %></span>

data/spec/dummy/app/views/html_new/dummy_models/new.html.erb

@@ -0,0 +1 @@
+<span class="record">new <%= @record.new_record? %></span>

data/spec/dummy/app/views/html_scoped/dummy_models/index.html.erb

@@ -0,0 +1,3 @@
+<% @records.each do |record| %>
+  <span class="record"><%= record.name %></span>
+<% end %>

data/spec/dummy/app/views/html_show/dummy_models/show.html.erb

@@ -0,0 +1 @@
+<span class="record"><%= @record.name %></span>

data/spec/dummy/app/views/html_update/dummy_models/edit.html.erb

@@ -0,0 +1 @@
+<span class="record">errors: <%= @record.errors.full_messages.join(',') %></span>

data/spec/dummy/app/views/invalid_status/dummy_models/new.html.erb

@@ -0,0 +1 @@
+<span class="record">errors: <%= @record.errors.full_messages.join(',') %></span>

data/spec/dummy/app/views/layouts/application.html.erb

@@ -0,0 +1,4 @@
+<!DOCTYPE html>
+<html>
+  <body><%= yield %></body>
+</html>

data/spec/dummy/app/views/redirect/dummy_models/new.html.erb

@@ -0,0 +1 @@
+New

data/spec/dummy/config/routes.rb

@@ -7,4 +7,114 @@ Rails.application.routes.draw do
   namespace :without_pagination do
     resources :dummy_models, only: :index
   end
+
+  namespace :html do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :block do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :finder do
+    resources :dummy_models, only: %i[show edit update destroy], param: :slug
+  end
+
+  namespace :html_finder do
+    resources :dummy_models, only: %i[new show edit update destroy], param: :slug
+  end
+
+  namespace :block_finder do
+    resources :dummy_models, only: %i[show edit update destroy], param: :slug
+  end
+
+  namespace :scoped do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :unpaginated_scoped do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :scoped_params do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :strict do
+    resources :dummy_models, only: %i[create update]
+  end
+
+  namespace :html_show do
+    resources :dummy_models, only: :show
+  end
+
+  namespace :block_show do
+    resources :dummy_models, only: :show
+  end
+
+  namespace :html_new do
+    resources :dummy_models, only: :new
+  end
+
+  namespace :block_new do
+    resources :dummy_models, only: :new
+  end
+
+  namespace :html_create do
+    resources :dummy_models, only: :create
+  end
+
+  namespace :redirect do
+    resources :dummy_models, only: %i[create destroy]
+  end
+
+  namespace :block_create do
+    resources :dummy_models, only: :create
+  end
+
+  namespace :html_update do
+    resources :dummy_models, only: :update
+  end
+
+  namespace :html_destroy do
+    resources :dummy_models, only: :destroy
+  end
+
+  namespace :block_destroy do
+    resources :dummy_models, only: :destroy
+  end
+
+  namespace :block_redirect do
+    resources :dummy_models, only: %i[show destroy]
+  end
+
+  namespace :block_json do
+    resources :dummy_models, only: %i[index show new]
+  end
+
+  namespace :built do
+    resources :dummy_models, only: %i[new create]
+  end
+
+  namespace :redirect_auth do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :html_scoped do
+    resources :dummy_models, only: :index
+  end
+
+  namespace :nested do
+    resources :dummy_models, only: %i[create update]
+  end
+
+  namespace :invalid_status do
+    resources :dummy_models, only: :create
+  end
+
+  namespace :nested_route do
+    resources :classrooms, only: [], param: :slug do
+      resources :dummy_models, param: :slug, only: %i[show create destroy]
+    end
+  end
 end

data/spec/dummy/db/migrate/20260806000000_add_slug_to_dummy_models.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddSlugToDummyModels < ActiveRecord::Migration[6.0]
+  def change
+    add_column :dummy_models, :slug, :string
+  end
+end

data/spec/dummy/db/migrate/20260807000000_add_classroom_slug_to_dummy_models.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddClassroomSlugToDummyModels < ActiveRecord::Migration[6.0]
+  def change
+    add_column :dummy_models, :classroom_slug, :string
+  end
+end

data/spec/dummy/db/schema.rb

@@ -12,9 +12,11 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20_200_120_165_657) do
+ActiveRecord::Schema.define(version: 20_260_807_000_000) do
   create_table 'dummy_models', force: :cascade do |t|
     t.string 'name'
+    t.string 'slug'
+    t.string 'classroom_slug'
     t.integer 'something'
     t.integer 'user_id'
     t.index ['user_id'], name: 'index_dummy_models_on_user_id'

data/spec/dummy/spec/factories/dummy_models.rb

@@ -4,6 +4,7 @@ FactoryBot.define do
   factory :dummy_model do
     name { rand(36 * 4).to_s(36) }
     something { rand(100) }
+    slug { "slug-#{rand(36 * 6).to_s(36)}" }
     user
   end
 end

data/spec/dummy_controller_spec.rb

@@ -7,6 +7,7 @@ describe DummyModelsController, type: :controller do
   include_examples 'simple crud for create'
   include_examples 'simple crud for index'
   include_examples 'simple crud for destroy'
+  include_examples 'simple crud for new'
 
   describe 'POST #create with invalid attributes' do
     include_context 'with authenticated user'

data/spec/dummy_model_policy_spec.rb

@@ -17,13 +17,15 @@ describe DummyModelPolicy do
     end
   end
 
+  # :index authorizes the model class, not an instance, so the policy can
+  # only reason about the user.
   describe '#index?' do
-    it 'allows the owning user' do
-      expect(described_class.new(user, dummy_model).index?).to be true
+    it 'allows any signed-in user' do
+      expect(described_class.new(other_user, dummy_model).index?).to be true
     end
 
-    it 'denies a different user' do
-      expect(described_class.new(other_user, dummy_model).index?).to be false
+    it 'denies an anonymous user' do
+      expect(described_class.new(nil, dummy_model).index?).to be false
     end
   end
 end

data/spec/finder/dummy_models_controller_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Finder::DummyModelsController, type: :controller do
+  include_examples 'simple crud for edit'
+  include_examples 'simple crud for show with finder'
+  include_examples 'simple crud for update with finder'
+  include_examples 'simple crud for destroy with finder'
+  include_examples 'simple crud for show'
+  include_examples 'simple crud for update'
+  include_examples 'simple crud for destroy'
+end

data/spec/html/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Html::DummyModelsController, type: :controller do
+  include_examples 'simple crud for index'
+end

data/spec/html_create/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlCreate::DummyModelsController, type: :controller do
+  include_examples 'simple crud for create'
+end

data/spec/html_destroy/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlDestroy::DummyModelsController, type: :controller do
+  include_examples 'simple crud for destroy'
+end

data/spec/html_finder/dummy_models_controller_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlFinder::DummyModelsController, type: :controller do
+  include_examples 'simple crud for edit'
+  include_examples 'simple crud for show with finder'
+  include_examples 'simple crud for update with finder'
+  include_examples 'simple crud for destroy with finder'
+  include_examples 'simple crud for new with build'
+end

data/spec/html_new/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlNew::DummyModelsController, type: :controller do
+  include_examples 'simple crud for new'
+end

data/spec/html_scoped/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlScoped::DummyModelsController, type: :controller do
+  include_examples 'simple crud for index with scope'
+end

data/spec/html_show/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlShow::DummyModelsController, type: :controller do
+  include_examples 'simple crud for show'
+end

data/spec/html_update/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HtmlUpdate::DummyModelsController, type: :controller do
+  include_examples 'simple crud for update'
+end

data/spec/invalid_status/dummy_models_controller_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe InvalidStatus::DummyModelsController, type: :controller do
+  before { SimpleCrud::RSpec.configure { |c| c.invalid_status = 422 } }
+  after { SimpleCrud::RSpec.configure { |c| c.invalid_status = :ok } }
+
+  include_examples 'simple crud for create'
+end

data/spec/nested/dummy_models_controller_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Nested::DummyModelsController, type: :controller do
+  around do |example|
+    with_config_override(:params_key, :dummy_model) { example.run }
+  end
+
+  include_examples 'simple crud for create'
+  include_examples 'simple crud for update'
+end

data/spec/nested_route/dummy_models_controller_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe NestedRoute::DummyModelsController, type: :controller do
+  let(:model_attributes) { { classroom_slug: 'room-1', user: current_user } }
+
+  around do |example|
+    with_config_override(:route_params, -> { { classroom_slug: 'room-1' } }) do
+      with_config_override(:params_key, :dummy_model) do
+        example.run
+      end
+    end
+  end
+
+  include_examples 'simple crud for show'
+  include_examples 'simple crud for create'
+  include_examples 'simple crud for destroy'
+end

data/spec/redirect/dummy_models_controller_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Redirect::DummyModelsController, type: :controller do
+  describe 'POST #create' do
+    it 'redirects to the target resolved from the redirect proc' do
+      post :create, params: attributes_for(:dummy_model).merge(user_id: create(:user).id), format: :html
+
+      expect(response).to redirect_to(dummy_models_path)
+    end
+  end
+
+  describe 'DELETE #destroy' do
+    it 'redirects to the literal redirect path' do
+      record = create(:dummy_model)
+
+      delete :destroy, params: { id: record.id }, format: :html
+
+      expect(response).to redirect_to('/block_new/dummy_models/new')
+    end
+  end
+end

data/spec/redirect_auth/dummy_models_controller_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe RedirectAuth::DummyModelsController, type: :controller do
+  around do |example|
+    with_config_override(:unauthenticated_status, :found) { example.run }
+  end
+
+  include_examples 'simple crud for index'
+end

data/spec/scoped/dummy_models_controller_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Scoped::DummyModelsController, type: :controller do
+  include_examples 'simple crud for index with scope'
+end

data/spec/scoped_params/dummy_models_controller_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe ScopedParams::DummyModelsController, simple_crud: {
+  scoped_attributes: -> { { user: current_user, something: 42 } },
+  other_scoped_attributes: -> { { user: other_user, something: 7 } }
+}, type: :controller do
+  include_examples 'simple crud for index with scope' do
+    let(:request_params) { { something: 42 } }
+  end
+end

data/spec/simple_crud/authorization/action_policy_adapter_spec.rb

@@ -35,15 +35,7 @@ describe SimpleCrud::Authorization::ActionPolicyAdapter do
   end
 
   describe '#authorize' do
-    it 'passes for a record the policy allows' do
-      expect { adapter.authorize(controller, ActionPolicyTestRecord.new(1)) }.not_to raise_error
-    end
-
-    it 'raises for a record the policy denies' do
-      expect do
-        adapter.authorize(controller, ActionPolicyTestRecord.new(2))
-      end.to raise_error(ActionPolicy::Unauthorized)
-    end
+    include_examples 'authorization adapter #authorize', ActionPolicyTestRecord, ActionPolicy::Unauthorized
   end
 
   describe '#policy_defined?' do

data/spec/simple_crud/authorization/can_can_can_adapter_spec.rb

@@ -36,13 +36,7 @@ describe SimpleCrud::Authorization::CanCanCanAdapter do
   end
 
   describe '#authorize' do
-    it 'passes for a record the ability grants' do
-      expect { adapter.authorize(controller, CanCanCanTestRecord.new(1)) }.not_to raise_error
-    end
-
-    it 'raises for a record the ability denies' do
-      expect { adapter.authorize(controller, CanCanCanTestRecord.new(2)) }.to raise_error(CanCan::AccessDenied)
-    end
+    include_examples 'authorization adapter #authorize', CanCanCanTestRecord, CanCan::AccessDenied
   end
 
   describe '#policy_defined?' do