woods 2.0.0.beta2 → 2.0.0.beta3

data/lib/woods/extractors/action_cable_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 
@@ -199,7 +201,7 @@ module Woods
       def log_extraction_error(name, error)
         return unless defined?(Rails) && Rails.respond_to?(:logger) && Rails.logger
 
-        Rails.logger.error("Failed to extract channel #{name}: #{error.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract channel #{name}: #{error.message}")
       end
     end
   end

data/lib/woods/extractors/behavioral_profile.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 module Woods
   module Extractors
     # BehavioralProfile introspects resolved Rails.application.config values
@@ -52,7 +54,7 @@ module Woods
 
         build_unit(profile)
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile extraction failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile extraction failed: #{e.message}")
         nil
       end
 
@@ -86,7 +88,7 @@ module Woods
 
         result
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile database section failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile database section failed: #{e.message}")
         {}
       end
 
@@ -102,7 +104,7 @@ module Woods
           Object.const_defined?(constant_name)
         end
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile frameworks section failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile frameworks section failed: #{e.message}")
         {}
       end
 
@@ -132,7 +134,7 @@ module Woods
 
         flags
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile behavior_flags section failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile behavior_flags section failed: #{e.message}")
         {}
       end
 
@@ -152,7 +154,7 @@ module Woods
 
         { adapter: aj.queue_adapter }
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile background section failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile background section failed: #{e.message}")
         {}
       end
 
@@ -172,7 +174,7 @@ module Woods
 
         { store: store }
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile caching section failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile caching section failed: #{e.message}")
         {}
       end
 
@@ -192,7 +194,7 @@ module Woods
 
         { delivery_method: am.delivery_method }
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile email section failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile email section failed: #{e.message}")
         {}
       end
 

data/lib/woods/extractors/caching_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 
@@ -98,7 +100,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract caching info from #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract caching info from #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/concern_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 require_relative 'source_nesting'
@@ -50,18 +52,20 @@ module Woods
       #
       # @return [Array<ExtractedUnit>] List of concern units
       def extract_all
-        find_files_in_directories(@directories).filter_map do |file|
-          extract_concern_file(file)
-        end
+        conventional = find_files_in_directories(@directories).filter_map { |file| extract_concern_file(file) }
+        conventional + runtime_model_mixins.keys.flat_map { |file| extract_model_mixin_file(file) }
       end
 
       # Extract a single concern file
       #
       # @param file_path [String] Path to the concern file
+      # @param module_name [String, nil] Runtime identity for a discovered model mixin
       # @return [ExtractedUnit, nil] The extracted unit or nil if not a concern
-      def extract_concern_file(file_path)
+      def extract_concern_file(file_path, module_name: nil)
         source = File.read(file_path)
-        module_name = extract_module_name(file_path, source)
+        # Runtime discovery supplies each included module's identity. Ordinary
+        # concern files retain their canonical identity, including nested helpers.
+        module_name ||= extract_module_name(file_path, source)
 
         return nil unless module_name
         return nil unless concern_module?(source)
@@ -79,12 +83,66 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract concern #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract concern #{file_path}: #{e.message}")
         nil
       end
 
+      # Extract a module outside concerns directories only when a live model
+      # includes it. Filenames alone cannot establish that a module is a mixin.
+      #
+      # @param file_path [String] Changed application source path
+      # @return [Array<ExtractedUnit>, nil]
+      def extract_model_mixin_file(file_path)
+        modules = model_mixin_paths[file_path.to_s]
+        return unless modules
+
+        modules.filter_map { |mod| extract_concern_file(file_path, module_name: mod.name) }
+      end
+
+      # Runtime mixins that have no conventional concern-directory discovery.
+      # @return [Hash<String, Array<Module>>] Source paths and their included modules
+      def runtime_model_mixins
+        model_mixin_paths.reject { |path, _mod| conventional_concern_path?(path) }
+      end
+
+      # @param path [String] Absolute source path
+      # @return [Boolean] Whether directory-based discovery owns this source
+      def conventional_concern_path?(path)
+        @directories.any? { |directory| path.to_s.start_with?("#{directory}/") }
+      end
+
       private
 
+      # Runtime ownership is authoritative; never import gem mixins even when
+      # the application adds methods to them.
+      # @return [Hash<String, Array<Module>>] App-owned included modules by source path
+      def model_mixin_paths
+        return {} unless defined?(ActiveRecord::Base)
+
+        @model_mixin_paths ||= discover_model_mixin_paths
+      end
+
+      # @return [Hash<String, Array<Module>>] Reflected module source locations
+      def discover_model_mixin_paths
+        models = ActiveRecord::Base.descendants.reject { |model| model.respond_to?(:abstract_class?) && model.abstract_class? }
+        models.flat_map(&:included_modules).uniq.each_with_object({}) do |mod, paths|
+          next unless mod.name
+
+          definition = begin
+            Object.const_source_location(mod.name)&.first
+          rescue NameError
+            # Removed/reloaded models can remain in descendants until GC.
+            next
+          end
+          next if definition && !app_source?(definition, "#{Rails.root}/")
+
+          path = resolve_source_location(mod, app_root: "#{Rails.root}/", fallback: nil)
+          next unless app_source?(path, "#{Rails.root}/") && File.file?(path)
+
+          (paths[path] ||= []) << mod
+        end
+      end
+
       # ──────────────────────────────────────────────────────────────────────
       # Module Discovery
       # ──────────────────────────────────────────────────────────────────────

data/lib/woods/extractors/configuration_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 require_relative 'behavioral_profile'
@@ -40,12 +42,14 @@ module Woods
           extract_configuration_file(file)
         end
 
-        profile = BehavioralProfile.new.extract
+        profiler = BehavioralProfile.new
+        profile = profiler.extract
+        SourceInputs::ConsumerErrors.record(self) if SourceInputs::ConsumerErrors.failed?(profiler)
         units << profile if profile
 
         units
       rescue StandardError => e
-        Rails.logger.error("BehavioralProfile integration failed: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "BehavioralProfile integration failed: #{e.message}")
         units || []
       end
 
@@ -71,7 +75,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract configuration #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract configuration #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/controller_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require 'digest'
 require_relative 'ast_source_extraction'
 require_relative 'shared_utility_methods'
@@ -120,8 +122,8 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("[Woods] Failed to extract controller #{controller.name}: #{e.class}: #{e.message}")
-        Rails.logger.error("[Woods]   #{e.backtrace&.first(5)&.join("\n  ")}")
+        SourceInputs::ConsumerErrors.log(self, "[Woods] Failed to extract controller #{controller.name}: #{e.class}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "[Woods]   #{e.backtrace&.first(5)&.join("\n  ")}")
         nil
       end
 
@@ -253,6 +255,7 @@ module Woods
           opts << "only: [#{f[:only].map { |a| ":#{a}" }.join(', ')}]" if f[:only]&.any?
           opts << "except: [#{f[:except].map { |a| ":#{a}" }.join(', ')}]" if f[:except]&.any?
           opts << "if: #{f[:if]}" if f[:if]
+          opts << "unless: #{f[:unless]}" if f[:unless]
 
           opts_str = opts.any? ? " (#{opts.join('; ')})" : ''
           "  #{f[:kind].to_s.ljust(8)} :#{f[:filter]}#{opts_str}"
@@ -272,7 +275,7 @@ module Woods
         controller._process_action_callbacks.map do |callback|
           only, except, if_conds, unless_conds = extract_callback_conditions(callback)
 
-          result = { kind: callback.kind, filter: callback.filter }
+          result = { kind: callback.kind, filter: callback_filter(callback) }
           result[:only] = only if only.any?
           result[:except] = except if except.any?
           result[:if] = if_conds.join(', ') if if_conds.any?
@@ -281,6 +284,12 @@ module Woods
         end
       end
 
+      # Override only controller Proc conditions; the shared model/mailer
+      # condition format is a separate extraction contract.
+      def condition_label(condition)
+        condition.is_a?(Proc) ? stable_filter(condition) : super
+      end
+
       # ──────────────────────────────────────────────────────────────────────
       # Concern Detection & Inlining
       # ──────────────────────────────────────────────────────────────────────
@@ -734,7 +743,7 @@ module Woods
         applicable = controller._process_action_callbacks.select do |cb|
           callback_applies_to_action?(cb, action_name)
         end
-        applicable.map { |cb| { kind: cb.kind, filter: cb.filter } }
+        applicable.map { |cb| { kind: cb.kind, filter: callback_filter(cb) } }
       end
 
       # Determine if a callback applies to a given action name.

data/lib/woods/extractors/database_view_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 
@@ -85,7 +87,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract database view #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract database view #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/decorator_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 
@@ -78,7 +80,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract decorator #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract decorator #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/engine_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 
 module Woods
@@ -184,7 +186,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract engine #{engine.name}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract engine #{engine.name}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/event_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 
@@ -59,14 +61,14 @@ module Woods
       def scan_file(file_path, event_map)
         source = cached_source(file_path)
         unless source
-          Rails.logger.error("Failed to scan #{file_path} for events: file unreadable")
+          SourceInputs::ConsumerErrors.log(self, "Failed to scan #{file_path} for events: file unreadable")
           return
         end
 
         scan_active_support_notifications(source, file_path, event_map)
         scan_wisper_patterns(source, file_path, event_map)
       rescue StandardError => e
-        Rails.logger.error("Failed to scan #{file_path} for events: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to scan #{file_path} for events: #{e.message}")
       end
 
       private

data/lib/woods/extractors/factory_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'line_neutralizer'
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
@@ -53,7 +55,7 @@ module Woods
 
         factories.map { |factory_data| build_unit(factory_data, file_path, source) }
       rescue StandardError => e
-        Rails.logger.error("Failed to extract factories from #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract factories from #{file_path}: #{e.message}")
         []
       end
 

data/lib/woods/extractors/graphql_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 require_relative 'source_nesting'
@@ -151,7 +153,9 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract GraphQL file #{file_path}: #{e.message}") if defined?(Rails)
+        if defined?(Rails)
+          SourceInputs::ConsumerErrors.log(self, "Failed to extract GraphQL file #{file_path}: #{e.message}")
+        end
         nil
       end
 
@@ -191,7 +195,9 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract GraphQL type #{type_class.name}: #{e.message}") if defined?(Rails)
+        if defined?(Rails)
+          SourceInputs::ConsumerErrors.log(self, "Failed to extract GraphQL type #{type_class.name}: #{e.message}")
+        end
         nil
       end
 

data/lib/woods/extractors/i18n_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require 'yaml'
 
 require_relative 'shared_utility_methods'
@@ -70,7 +72,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract i18n #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract i18n #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/job_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'reference_patterns'
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
@@ -107,7 +109,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract job #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract job #{file_path}: #{e.message}")
         nil
       end
 
@@ -134,7 +136,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract job #{job_class.name}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract job #{job_class.name}: #{e.message}")
         nil
       end
 
@@ -318,24 +320,9 @@ module Woods
       end
 
       def extract_perform_params(source)
-        return [] unless source =~ /def\s+perform\s*\(([^)]*)\)/
-
-        params_str = ::Regexp.last_match(1)
-        params = []
-
-        params_str.scan(/(\*?\*?\w+)(?:\s*=\s*([^,]+))?/) do |name, default|
-          params << {
-            name: name.gsub(/^\*+/, ''),
-            splat: if name.start_with?('**')
-                     :double
-                   else
-                     (name.start_with?('*') ? :single : nil)
-                   end,
-            has_default: !default.nil?
-          }
+        MethodParameters.extract(source, :perform).map do |parameter|
+          parameter.slice(:name, :splat, :has_default)
         end
-
-        params
       end
 
       def extract_discard_on(source)

data/lib/woods/extractors/lib_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 require_relative 'source_nesting'
@@ -85,7 +87,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract lib file #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract lib file #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/mailer_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require 'digest'
 require_relative 'ast_source_extraction'
 require_relative 'shared_utility_methods'
@@ -27,7 +29,9 @@ module Woods
       include RouteHelperResolver
 
       def initialize
-        @mailer_base = defined?(ApplicationMailer) ? ApplicationMailer : ActionMailer::Base
+        if defined?(ActionMailer::Base)
+          @mailer_base = defined?(ApplicationMailer) ? ApplicationMailer : ActionMailer::Base
+        end
         build_route_helper_map
       end
 
@@ -45,7 +49,9 @@ module Woods
       #
       # @return [Array<Class>]
       def discoverable_classes
-        @mailer_base.descendants
+        return [] unless @mailer_base
+
+        @mailer_base.descendants.select { |mailer| app_defined_mailer?(mailer) }
       end
 
       # Extract a single mailer
@@ -53,8 +59,7 @@ module Woods
       # @param mailer [Class] The mailer class
       # @return [ExtractedUnit] The extracted unit
       def extract_mailer(mailer)
-        return nil if mailer.name.nil?
-        return nil if mailer == ActionMailer::Base
+        return nil unless app_defined_mailer?(mailer)
 
         file_path = source_file_for(mailer)
 
@@ -76,12 +81,22 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract mailer #{mailer.name}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract mailer #{mailer.name}: #{e.message}")
         nil
       end
 
       private
 
+      # Discovery and direct incremental extraction must agree on ownership;
+      # otherwise a gem class with a fabricated path becomes a phantom unit.
+      def app_defined_mailer?(mailer)
+        return false unless @mailer_base && mailer.name
+        return false if mailer == ActionMailer::Base
+
+        path = source_file_for(mailer)
+        path && File.file?(path) && app_source?(path, Rails.root.to_s)
+      end
+
       # Locate the source file for a mailer class.
       #
       # Convention path first, then introspection via {#resolve_source_location}

data/lib/woods/extractors/manager_extractor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../source_inputs/consumer_errors'
+
 require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 
@@ -69,7 +71,7 @@ module Woods
 
         unit
       rescue StandardError => e
-        Rails.logger.error("Failed to extract manager #{file_path}: #{e.message}")
+        SourceInputs::ConsumerErrors.log(self, "Failed to extract manager #{file_path}: #{e.message}")
         nil
       end
 

data/lib/woods/extractors/method_parameters.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require 'prism'
+
+module Woods
+  module Extractors
+    # Syntactic method signatures only: never evaluate a default expression or
+    # mistake names inside one for additional parameters. Consumers retain their
+    # existing metadata shapes by selecting the fields they expose.
+    module MethodParameters
+      module_function
+
+      def extract(source, method_name)
+        parsed = Prism.parse(source)
+        return [] unless parsed.success?
+
+        method = find_method(parsed.value, method_name.to_sym)
+        return [] unless method&.parameters
+
+        method.parameters.compact_child_nodes.flat_map { |node| describe(node) }
+      end
+
+      def find_method(node, name)
+        return nil if node.is_a?(Prism::SingletonClassNode)
+        return node if node.is_a?(Prism::DefNode) && node.receiver.nil? && node.name == name
+
+        node.compact_child_nodes.each do |child|
+          found = find_method(child, name)
+          return found if found
+        end
+        nil
+      end
+
+      def describe(node)
+        # Destructured positional arguments contain declarations, while a
+        # default's subtree contains values and must never be walked.
+        return node.compact_child_nodes.flat_map { |child| describe(child) } if node.is_a?(Prism::MultiTargetNode)
+        return [] unless node.respond_to?(:name) && node.name
+
+        optional = node.is_a?(Prism::OptionalParameterNode) || node.is_a?(Prism::OptionalKeywordParameterNode)
+        keyword = node.is_a?(Prism::RequiredKeywordParameterNode) ||
+                  node.is_a?(Prism::OptionalKeywordParameterNode) || node.is_a?(Prism::KeywordRestParameterNode)
+        splat = if node.is_a?(Prism::KeywordRestParameterNode)
+                  :double
+                elsif node.is_a?(Prism::RestParameterNode)
+                  :single
+                end
+        [{ name: node.name.to_s, has_default: optional, keyword: keyword, splat: splat }]
+      end
+      private_class_method :find_method, :describe
+    end
+  end
+end