woocommerce_api 1.0.2 → 1.0.3

data/README.md

@@ -92,6 +92,7 @@ puts response.headers["x-wc-totalpages"] # Total of pages
 
 ## Release History
 
+- 2015-08-27 - 1.0.3 - Encode all % characters in query string for OAuth 1.0a.
 - 2015-08-12 - 1.0.2 - Fixed the release date.
 - 2015-08-12 - 1.0.1 - Escaped oauth_signature in url query string.
 - 2015-07-15 - 1.0.0 - Stable release.

data/lib/woocommerce_api/oauth.rb

@@ -55,13 +55,11 @@ module WooCommerce
       query_params = []
 
       params.sort.map do |key, value|
-        query_params.push(CGI::escape(key.to_s) + "%3D" + CGI::escape(value.to_s))
+        query_params.push(encode_param(key.to_s) + "%3D" + encode_param(value.to_s))
       end
 
       query_string = query_params
         .join("%26")
-        .gsub("%5B", "%255B")
-        .gsub("%5D", "%255D")
       string_to_sign = "#{@method}&#{base_request_uri}&#{query_string}"
 
       if @version == "v3"
@@ -72,5 +70,14 @@ module WooCommerce
 
       return Base64.strict_encode64(OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha256'), consumer_secret, string_to_sign))
     end
+
+    # Internal: Encode param
+    #
+    # text - A String to be encoded
+    #
+    # Returns the encoded String.
+    def encode_param(text)
+      CGI::escape(text).gsub('%', '%25')
+    end
   end
 end

data/lib/woocommerce_api/version.rb

@@ -1,3 +1,3 @@
 module WooCommerce
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: woocommerce_api
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-12 00:00:00.000000000 Z
+date: 2015-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty