wongi-engine 0.4.0.pre.alpha2 → 0.4.0.pre.alpha4

data/spec/{rule_specs/assign_spec.rb → assign_spec.rb}

@@ -4,7 +4,7 @@ describe "ASSIGN rule" do
   include Wongi::Engine::DSL
   let(:engine) { Wongi::Engine.create }
 
-  it "should assign simple expressions" do
+  it "assigns simple expressions" do
     production = engine << rule {
       forall {
         assign :X do
@@ -16,7 +16,7 @@ describe "ASSIGN rule" do
     expect(production.tokens.first[:X]).to eq(42)
   end
 
-  it 'should be available in the make section' do
+  it 'is available in the make section' do
     production = engine << rule {
       forall {
         has 1, 2, :X
@@ -32,7 +32,7 @@ describe "ASSIGN rule" do
     expect(production.tokens.first[:Y]).to be == 42
   end
 
-  it "should be able to access previous assignments" do
+  it "is able to access previous assignments" do
     production = engine << rule {
       forall {
         has 1, 2, :X
@@ -46,7 +46,7 @@ describe "ASSIGN rule" do
     expect(production.tokens.first[:Y]).to eq(10)
   end
 
-  it 'should be deactivatable' do
+  it 'is deactivatable' do
     prod = engine << rule {
       forall {
         has 1, 2, :X
@@ -62,7 +62,7 @@ describe "ASSIGN rule" do
     expect(prod).to have(0).tokens
   end
 
-  it 'should be evaluated once' do
+  it 'is evaluated once' do
     x = 0
     engine << rule {
       forall {
@@ -80,7 +80,7 @@ describe "ASSIGN rule" do
     expect(x).to be == 1
   end
 
-  it 'should handle booleans' do
+  it 'handles booleans' do
     engine << rule do
       forall {
         has :a, :b, :c

data/spec/{rule_specs/assuming_spec.rb → assuming_spec.rb}

@@ -4,7 +4,7 @@ describe Wongi::Engine::AssumingClause do
   include Wongi::Engine::DSL
   let(:engine) { Wongi::Engine.create }
 
-  it 'should include base rules' do
+  it 'includes base rules' do
     engine << rule(:base) {
       forall {
         has :x, :y, :Z
@@ -26,7 +26,7 @@ describe Wongi::Engine::AssumingClause do
     expect(result).to eq(1 => :a, 2 => :b)
   end
 
-  it 'should check for base rule\'s existence' do
+  it 'checks for base rule''s existence' do
     f = lambda {
       engine << rule {
         forall {
@@ -38,7 +38,7 @@ describe Wongi::Engine::AssumingClause do
     expect(&f).to raise_error Wongi::Engine::UndefinedBaseRule
   end
 
-  it 'should come first in a rule' do
+  it 'comes first in a rule' do
     f = lambda {
       engine << rule(:base) {
         forall {

data/spec/beta_node_spec.rb

@@ -6,7 +6,7 @@ describe Wongi::Engine::BetaNode do
   let(:engine) { Wongi::Engine.create }
 
   describe '#tokens' do
-    it 'should be enumerable' do
+    it 'is enumerable' do
       production = engine << rule {
         forall {
           has :x, :y, :Z

data/spec/bug_specs/issue_4_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe "issue 4" do
-  it "should correctly retract pre-added items from within a rule" do
+  it "correctlies retract pre-added items from within a rule" do
     engine = Wongi::Engine.create
 
     10.times { |i| engine << [i, :is_number, true] }
@@ -26,7 +26,7 @@ describe "issue 4" do
     expect(evens.size).to eq(10)
   end
 
-  it "should correctly retract post-added items from within a rule" do
+  it "correctlies retract post-added items from within a rule" do
     engine = Wongi::Engine.create
 
     engine.rule 'segregate' do
@@ -52,7 +52,7 @@ describe "issue 4" do
   end
 
   # cascaded processing affects this
-  it "should not retract later items from within a rule" do
+  it "does not retract later items from within a rule" do
     engine = Wongi::Engine.create
 
     10.times { |i| engine << [i, :is_number, true] }
@@ -85,7 +85,7 @@ describe "issue 4" do
     expect(odds.size).to eq(5)
   end
 
-  it "should not lose track when another rule affects a set" do
+  it "does not lose track when another rule affects a set" do
     engine = Wongi::Engine.create
 
     10.times { |i| engine << [i, :is_number, true] }

data/spec/dataset_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Wongi::Engine::Network do
   include Wongi::Engine::DSL
-  it 'should expose compiled productions' do
+  it 'exposes compiled productions' do
     ds = Wongi::Engine::Network.new
 
     ds << rule('test-rule') {

data/spec/generation_spec.rb

@@ -20,7 +20,7 @@ describe Wongi::Engine::DSL::Action::StatementGenerator do
   let(:production) { engine << transitive_rule }
 
   shared_examples 'generation' do
-    it 'should generate facts' do
+    it 'generates facts' do
       engine << %w[Alice relative Bob]
       engine << %w[Bob relative Dwight]
 
@@ -28,7 +28,7 @@ describe Wongi::Engine::DSL::Action::StatementGenerator do
       expect(engine.find(*%w[Alice relative Dwight])).not_to be_nil
     end
 
-    it 'should retrct generated facts' do
+    it 'retracts generated facts' do
       engine << %w[Alice relative Bob]
       engine << %w[Bob relative Dwight]
       engine.retract %w[Bob relative Dwight]
@@ -45,19 +45,19 @@ describe Wongi::Engine::DSL::Action::StatementGenerator do
         engine << %w[Claire relative Dwight]
       end
 
-      it 'should be created' do
+      it 'is created' do
         expect(production).to have(2).tokens
         expect(engine.find(*%w[Alice relative Dwight])).not_to be_nil
       end
 
-      it 'should remain after a single retraction' do
+      it 'remains after a single retraction' do
         engine.retract %w[Claire relative Dwight]
 
         expect(production).to have(1).token
         expect(engine.find(*%w[Alice relative Dwight])).not_to be_nil
       end
 
-      it 'should be destroyed after both retractions' do
+      it 'is destroyed after both retractions' do
         engine.retract %w[Claire relative Dwight]
         engine.retract %w[Alice relative Bob]
 
@@ -83,7 +83,7 @@ describe Wongi::Engine::DSL::Action::StatementGenerator do
 
     it_behaves_like 'generation'
 
-    it 'should not retract generated facts marked as manual', :wip do
+    it 'does not retract generated facts marked as manual', :wip do
       engine << %w[Alice relative Bob]
       engine << %w[Bob relative Dwight]
       engine << %w[Alice relative Dwight]
@@ -93,7 +93,7 @@ describe Wongi::Engine::DSL::Action::StatementGenerator do
       expect(engine.find(*%w[Alice relative Dwight])).not_to be_nil
     end
 
-    it 'should retract generated facts unmarked as manual', :wip do
+    it 'retracts generated facts unmarked as manual', :wip do
       engine << %w[Alice relative Bob]
       engine << %w[Bob relative Dwight]
       engine << %w[Alice relative Dwight]

data/spec/{filter_specs/greater_than_equality_test_spec.rb → greater_than_equality_test_spec.rb}

@@ -12,7 +12,7 @@ describe 'Greater Than Or Equal test' do
     @production = (engine << rule('test-rule', &block))
   end
 
-  it 'should interact with optional node correctly' do
+  it 'interacts with optional node correctly' do
     # before the fix, filters would try to piggy-back on optional templates
 
     test_rule do

data/spec/high_level_spec.rb

@@ -15,7 +15,7 @@ describe 'the engine' do
   let(:engine) { Wongi::Engine.create }
 
   context 'with a simple generative positive rule' do
-    it 'should generate wmes with an existing rule' do
+    it 'generates wmes with an existing rule' do
       engine << rule('symmetric') {
         forall {
           has :P, "symmetric", true
@@ -35,7 +35,7 @@ describe 'the engine' do
       expect(generated).to eq([Wongi::Engine::WME.new("Bob", "friend", "Alice")])
     end
 
-    it 'should generate wmes with an added rule' do
+    it 'generates wmes with an added rule' do
       engine << Wongi::Engine::WME.new("friend", "symmetric", true)
       engine << Wongi::Engine::WME.new("Alice", "friend", "Bob")
 
@@ -55,7 +55,7 @@ describe 'the engine' do
       expect(engine.facts.select { engine.current_overlay.manual?(_1) }.size).to eq(2)
     end
 
-    it 'should not get confused by recursive activations' do
+    it 'does not get confused by recursive activations' do
       engine << rule('reflexive') {
         forall {
           has :Predicate, "reflexive", true
@@ -76,7 +76,7 @@ describe 'the engine' do
     end
   end
 
-  it 'should check equality' do
+  it 'checks equality' do
     node = engine << rule('equality') {
       forall {
         fact :A, "same", :B
@@ -88,7 +88,7 @@ describe 'the engine' do
     expect(node.size).to eq(1)
   end
 
-  it 'should compare things' do
+  it 'compares things' do
     engine << rule('less') {
       forall {
         has :A, :age, :N1
@@ -121,7 +121,7 @@ describe 'the engine' do
     expect(items.size).to eq(1)
   end
 
-  it 'should use collectors' do
+  it 'uses collectors' do
     engine << rule('collector') {
       forall {
         has :X, :_, 42
@@ -139,7 +139,7 @@ describe 'the engine' do
     expect(collection.first).to eq("answer")
   end
 
-  it "should properly show error messages" do
+  it "properlies show error messages" do
     engine << rule("Error rule") {
       forall {
         has :_, :_, :TestNumber
@@ -156,7 +156,7 @@ describe 'the engine' do
     expect(error_messages).to eq(["An error has occurred"])
   end
 
-  it 'should use generic collectors' do
+  it 'uses generic collectors' do
     engine << rule('generic-collector') {
       forall {
         has :X, :_, 42
@@ -174,7 +174,7 @@ describe 'the engine' do
     expect(collection.first).to eq("answer")
   end
 
-  it 'should accept several rules' do
+  it 'accepts several rules' do
     expect {
       engine << rule('generic-collector') {
         forall {
@@ -196,7 +196,7 @@ describe 'the engine' do
     }.not_to raise_error
   end
 
-  it 'should process negative nodes' do
+  it 'processes negative nodes' do
     production = (engine << rule('negative') {
                     forall {
                       neg :_, :_, 42
@@ -220,14 +220,14 @@ describe 'the engine' do
       }
     end
 
-    it 'should run' do
+    it 'runs' do
       engine << ["answer", "is", 42]
       engine.execute "test-query", { X: "answer" }
       expect(engine.results["test-query"].size).to eq(1)
       expect(engine.results["test-query"].tokens.first[:Y]).to eq(42)
     end
 
-    it 'should run several times' do
+    it 'runs several times' do
       engine << ["answer", "is", 42]
       engine << %w[question is 6x9]
       engine.execute "test-query", { X: "answer" }

data/spec/{filter_specs/less_test_spec.rb → less_test_spec.rb}

@@ -10,7 +10,7 @@ describe "LESS test" do
     @production = (engine << rule('test-rule', &block))
   end
 
-  it "should interact with optional node correctly" do
+  it "interacts with optional node correctly" do
     # before the fix, filters would try to piggy-back on optional templates
 
     test_rule {

data/spec/{filter_specs/less_than_equality_test_spec.rb → less_than_equality_test_spec.rb}

@@ -12,7 +12,7 @@ describe 'Less Than Or Equal test' do
     @production = (engine << rule('test-rule', &block))
   end
 
-  it 'should interact with optional node correctly' do
+  it 'interacts with optional node correctly' do
     # before the fix, filters would try to piggy-back on optional templates
 
     test_rule do

data/spec/{rule_specs/maybe_rule_spec.rb → maybe_rule_spec.rb}

@@ -12,7 +12,7 @@ describe "MAYBE rule" do
     }
   }
 
-  it "should pass with existing facts" do
+  it "passes with existing facts" do
     production = engine << maybe_rule
 
     engine << [1, 2, 3]
@@ -24,7 +24,7 @@ describe "MAYBE rule" do
     expect(production.tokens.first[:Y]).to eq(5)
   end
 
-  it "should pass with missing facts" do
+  it "passes with missing facts" do
     production = engine << maybe_rule
 
     engine << [1, 2, 3]
@@ -35,7 +35,7 @@ describe "MAYBE rule" do
     expect(production.tokens.first[:Y]).to be_nil
   end
 
-  it "should pass with pre-added missing facts" do
+  it "passes with pre-added missing facts" do
     engine << [1, 2, 3]
 
     production = engine << maybe_rule
@@ -46,7 +46,7 @@ describe "MAYBE rule" do
     expect(production.tokens.first[:Y]).to be_nil
   end
 
-  it 'should pass with retracted facts' do
+  it 'passes with retracted facts' do
     prod = engine << maybe_rule
 
     engine << [1, 2, 3]
@@ -59,7 +59,7 @@ describe "MAYBE rule" do
     expect(prod.tokens.first[:Y]).to be_nil
   end
 
-  it 'should work with repeated activations' do
+  it 'works with repeated activations' do
     prod = engine << maybe_rule
 
     engine << [1, 2, 3]
@@ -77,7 +77,7 @@ describe "MAYBE rule" do
     }
   end
 
-  it 'should work with with overlays' do
+  it 'works with with overlays' do
     prod = engine << maybe_rule
 
     engine << [1, 2, 3]
@@ -96,7 +96,7 @@ describe "MAYBE rule" do
     expect(prod.tokens.first[:Y]).to be == 5
   end
 
-  it 'should handle retracted parent tokens' do
+  it 'handles retracted parent tokens' do
     prod = engine << maybe_rule
 
     engine << [1, 2, 3]

data/spec/{rule_specs/ncc_spec.rb → ncc_spec.rb}

@@ -29,7 +29,7 @@ describe Wongi::Engine::NccNode do
     }
   end
 
-  it 'should pass with a mismatching subchain' do
+  it 'passes with a mismatching subchain' do
     engine << ncc_rule
     production = engine.productions['ncc']
 
@@ -46,7 +46,7 @@ describe Wongi::Engine::NccNode do
     expect(production).to have(0).token
   end
 
-  it 'should remain consistent after retraction' do
+  it 'remains consistent after retraction' do
     engine << ncc_rule
     production = engine.productions['ncc']
 
@@ -81,7 +81,7 @@ describe Wongi::Engine::NccNode do
     expect(production).to have(0).tokens
   end
 
-  it 'should clean up correctly' do
+  it 'cleans up correctly' do
     engine.rule :rule1 do
       forall {
         has :light_kitchen, :value, :on
@@ -135,7 +135,7 @@ describe Wongi::Engine::NccNode do
     expect(engine.select(:light_bathroom, :last_user, :_).to_a).to be == [Wongi::Engine::WME.new(:light_bathroom, :last_user, :god)]
   end
 
-  it 'should clean up correctly with a different activation order' do
+  it 'cleans up correctly with a different activation order' do
     engine.rule :rule1 do
       forall {
         has :light_kitchen, :value, :on
@@ -191,7 +191,7 @@ describe Wongi::Engine::NccNode do
     expect(engine.select(:light_bathroom, :last_user, :_).to_a).to be == [Wongi::Engine::WME.new(:light_bathroom, :last_user, :god)]
   end
 
-  it 'should ncc-deactivate without destroying tokens' do
+  it 'ncc-deactivates without destroying tokens' do
     engine << rule {
       forall {
         has :Student, :is_a, :student
@@ -254,6 +254,29 @@ describe Wongi::Engine::NccNode do
     expect(prod).to have(1).tokens
   end
 
+  # TODO: this is probably pretty hard to fix, but it's good to fixate the behaviour
+  it "causes infinite loops" do
+    counter = 0
+    exception = StandardError.new
+
+    looping_rule = rule {
+      forall {
+        none {
+          has :a, :b, :c
+        }
+      }
+      make {
+        action {
+          counter += 1
+          raise exception if counter > 1
+        }
+        gen :a, :b, :c
+      }
+    }
+
+    expect { engine << looping_rule }.to raise_exception(exception)
+  end
+
   context "with overlays" do
     context 'should pass with a mismatching subchain' do
       specify "variation 1" do

data/spec/{rule_specs/negative_rule_spec.rb → negative_rule_spec.rb}

@@ -20,7 +20,7 @@ describe "negative rule" do
     expect(prod).to have(0).tokens
   end
 
-  it "should not introduce variables" do
+  it "does not introduce variables" do
     proc = lambda {
       engine << rule('one-option') {
         forall {
@@ -68,7 +68,7 @@ describe "negative rule" do
     expect(prod).to have(1).tokens
   end
 
-  it "should not create infinite feedback loops by default" do
+  it "does not create self-negating facts" do
     engine << rule('feedback') {
       forall {
         neg :a, :b, :_
@@ -78,28 +78,6 @@ describe "negative rule" do
       }
     }
 
-    engine.should have(1).facts
-  end
-
-  it "should create infinite feedback loops with unsafe option" do
-    counter = 0
-    exception = Class.new(StandardError)
-
-    proc = lambda {
-      engine << rule('feedback') {
-        forall {
-          neg :a, :b, :_, unsafe: true
-        }
-        make {
-          action {
-            counter += 1
-            raise exception if counter > 5
-          }
-          gen :a, :b, :c
-        }
-      }
-    }
-
-    expect(&proc).to raise_error(exception)
+    expect(engine).to have(0).facts
   end
 end

data/spec/network_spec.rb

@@ -3,15 +3,16 @@ require 'spec_helper'
 describe Wongi::Engine::Network do
   include Wongi::Engine::DSL
 
-  let(:engine) { Wongi::Engine.create }
   subject { engine }
 
-  it 'should assert facts' do
+  let(:engine) { Wongi::Engine.create }
+
+  it 'asserts facts' do
     subject << [1, 2, 3]
     expect(subject.select(:_, 2, :_)).to have(1).item
   end
 
-  it 'should retract facts' do
+  it 'retracts facts' do
     subject << [1, 2, 3]
     subject.retract [1, 2, 3]
     expect(subject.select(:_, 2, :_).count).to eq(0)

data/spec/overlay_spec.rb

@@ -102,6 +102,7 @@ describe Wongi::Engine::Overlay do
       allow(engine).to receive(:real_assert)
       allow(engine).to receive(:real_retract)
     end
+
     it "maintains visibility on each layer" do
       child1 = overlay.new_child
       child2 = child1.new_child
@@ -145,7 +146,7 @@ describe Wongi::Engine::Overlay do
     end
   end
 
-  it 'should be disposable' do
+  it 'is disposable' do
     production = engine << rule {
       forall {
         has 1, 2, :X
@@ -177,7 +178,7 @@ describe Wongi::Engine::Overlay do
     expect(production).to have(1).token
   end
 
-  it 'should generate into correct overlays' do
+  it 'generates into correct overlays' do
     production = engine << rule {
       forall {
         has 1, 2, :X

data/spec/ruleset_spec.rb

@@ -6,37 +6,37 @@ describe Wongi::Engine::Ruleset do
   end
 
   context 'initially' do
-    it 'should have no rules' do
+    it 'has no rules' do
       expect(Wongi::Engine::Ruleset.rulesets).to be_empty
     end
   end
 
   context 'when creating' do
-    it 'should not register itself when not given a name' do
+    it 'does not register itself when not given a name' do
       ruleset = Wongi::Engine::Ruleset.new
       expect(ruleset.name).to be_nil
       expect(Wongi::Engine::Ruleset.rulesets).to be_empty
     end
 
-    it 'should have a name' do
+    it 'has a name' do
       ruleset = Wongi::Engine::Ruleset.new 'testing-ruleset'
       expect(ruleset.name).to be == 'testing-ruleset'
     end
 
-    it 'should register itself when given a name' do
+    it 'registers itself when given a name' do
       ruleset = Wongi::Engine::Ruleset.new 'testing-ruleset'
       expect(Wongi::Engine::Ruleset.rulesets).not_to be_empty
       expect(Wongi::Engine::Ruleset[ruleset.name]).to be == ruleset
     end
   end
 
-  it 'should be able to clear registered rulesets' do
+  it 'is able to clear registered rulesets' do
     _ = Wongi::Engine::Ruleset.new 'testing-ruleset'
     Wongi::Engine::Ruleset.reset
     expect(Wongi::Engine::Ruleset.rulesets).to be_empty
   end
 
-  it 'should install creating rules into a rete' do
+  it 'installs creating rules into a rete' do
     rete = double 'rete'
 
     ruleset = Wongi::Engine::Ruleset.new

data/spec/simple_action_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Wongi::Engine::DSL::Action::SimpleAction do
   let(:engine) { Wongi::Engine.create }
 
-  it 'should work with blocks' do
+  it 'works with blocks' do
     count = 0
 
     engine.rule do

data/spec/wme_spec.rb

@@ -14,14 +14,14 @@ describe Wongi::Engine::WME do
   }
 
   context 'a new WME' do
-    it 'should initialize and expose members' do
+    it 'initializes and expose members' do
       expect(subject.subject).to be == "a"
       expect(subject.predicate).to be == "b"
       expect(subject.object).to be == "c"
     end
   end
 
-  it 'should compare instances' do
+  it 'compares instances' do
     wme1 = Wongi::Engine::WME.new "a", "b", "c"
     wme2 = Wongi::Engine::WME.new "a", "b", "c"
     wme3 = Wongi::Engine::WME.new "a", "b", "d"
@@ -30,11 +30,11 @@ describe Wongi::Engine::WME do
     expect(wme1).not_to be == wme3
   end
 
-  it 'should not match against non-templates' do
+  it 'does not match against non-templates' do
     expect { subject =~ [1, 2, 3] }.to raise_error(Wongi::Engine::Error)
   end
 
-  it 'should match against templates' do
+  it 'matches against templates' do
     t1 = Wongi::Engine::Template.new "a", :_, :_
     t2 = Wongi::Engine::Template.new "b", :_, :_